mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-10-01 03:32:09 +03:00
feat(tgbot): add /broadcast to relay an admin message to all clients (#6510)
* feat(tgbot): add /broadcast to relay an admin message to all clients Admins had no way to reach every client at once: notifications only cover exhausted quotas, so an operator had to copy a message to each client chat by hand. Add an admin-only /broadcast flow to the bot: - /broadcast asks for a message; any message the admin sends — text, rich text, photo, video, file, sticker or a whole album — becomes the broadcast by reference (admin chat + message ids), and a preview self-copy shows the admin exactly what recipients will get while rejecting content Telegram cannot copy before the run starts. - The draft references the original instead of parsing its content, so copyMessage/copyMessages deliver everything 1:1 on behalf of the bot with no forward header (the admin's identity stays private), no caption length pitfalls, and future Telegram message types work without new parsing. - A media group arrives as separate updates; its ids are buffered with a short debounce, sorted, and delivered as one copyMessages call so recipients see the original album. - Delivery runs in a background goroutine (common.GoRecover): sequential sends with a small pause, 429 retry_after honored per recipient, failures counted without stopping the run, progress edited into one card at most every 25 sends or 3 seconds, a cancel button checked between sends, and a final delivered/failed/skipped summary. The summary is edited into the card (only sent separately if the card is gone), so it is never duplicated. - Recipients repeat the notifyExhausted walk: clients with a linked tg_id, deduplicated, admins excluded — they already receive the reports. The message content is never logged. New i18n keys are added to all 13 locales. * fix(tgbot): harden broadcast composition per review - Key the composition per admin chat instead of one process-wide draft: two admins can now compose at once without dropping each other's drafts, and one admin's /broadcast no longer wipes another chat's half-collected album. - Bind each preview card to its own draft via a random token carried in the confirm callback, so a stale Send tap is answered with an error instead of delivering a newer, unapproved draft. - Ignore non-admin senders while a chat composes: the awaiting state is keyed by chat id, and in a group that chat is shared. - Check the cancel flag inside the flood-control retry loop, so a 429 with a long retry_after no longer holds the single broadcast slot after the admin cancelled. - Scale the per-recipient pause by the copied batch size, so an album keeps the same per-second ceiling as a single message. - Trim the comment blocks that exceeded the two-line cap. * fix(tgbot): reset broadcast state on stop and classify 403 as skipped - Clear compositions and cancel the active run from StopBot, next to the per-chat draft resets: an album debounce timer, a confirmable token or a held runner slot must not outlive the receiver that created them. - Sleep flood-control waits in 5 s slices and re-check cancel and bot state between them, so a minutes-long retry_after no longer parks the single-runner slot after the admin cancelled or the bot stopped. - Count Telegram 403 (the chat never started the bot, or blocked it) as skipped instead of failed, log it at debug rather than one warning per recipient, and append one line to the summary naming the reason. - Trim the remaining comment blocks over the two-line cap. * fix(tgbot): count unreachable recipients in broadcast progress throttle The progress card refresh was keyed on sent+failed, which a 403 does not advance since unreachable chats were split out of the failure count. A streak of unreachable recipients while that sum sat on a multiple of broadcastProgressEvery (0 included, so from the very first recipient) edited the card once per chat, doubling the request rate the send delay is sized for and defeating the throttle. Count processed recipients. * fix(tgbot): key broadcast compositions by admin, not chat After #6604 moved conversation state to the admin (chatUser), the broadcast draft map stayed keyed by chat. Two admins composing in one group then shared a slot: the second admin's message dropped the first admin's draft, whose Send tap answered "went wrong" while only the other draft could go out - the same class #6604 fixed for the add-client wizard. Drafts, album buffers and confirm tokens now live under the admin who ran /broadcast. The router now hands handleBroadcastInput only the admin whose own /broadcast is awaiting input, so its sender re-check and the test that fed it a non-admin message directly (an input no route can deliver) are removed. --------- Co-authored-by: MHSanaei <ho3ein.sanaei@gmail.com>
This commit is contained in:
DIMFLIX
@@ -408,6 +408,7 @@ func (t *Tgbot) trySetBotCommands(bot *telego.Bot) {
|
||||
{Command: "inbound", Description: t.I18nBot("tgbot.commands.inboundDesc")},
|
||||
{Command: "restart", Description: t.I18nBot("tgbot.commands.restartDesc")},
|
||||
{Command: "clearall", Description: t.I18nBot("tgbot.commands.clearallDesc")},
|
||||
{Command: "broadcast", Description: t.I18nBot("tgbot.commands.broadcastDesc")},
|
||||
},
|
||||
})
|
||||
if err != nil {
|
||||
@@ -542,6 +543,7 @@ func StopBot() {
|
||||
|
||||
userStateMgr.reset()
|
||||
addClientDrafts.resetAll()
|
||||
broadcastResetAll()
|
||||
|
||||
if handler != nil {
|
||||
_ = handler.Stop()
|
||||
|
||||
@@ -0,0 +1,525 @@
|
||||
package tgbot
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"slices"
|
||||
"strconv"
|
||||
"sync"
|
||||
"sync/atomic"
|
||||
"time"
|
||||
|
||||
telegoapi "github.com/mymmrac/telego/telegoapi"
|
||||
|
||||
"github.com/mhsanaei/3x-ui/v3/internal/logger"
|
||||
"github.com/mhsanaei/3x-ui/v3/internal/util/common"
|
||||
|
||||
"github.com/mymmrac/telego"
|
||||
tu "github.com/mymmrac/telego/telegoutil"
|
||||
)
|
||||
|
||||
const (
|
||||
broadcastAwaitingText = "awaiting_broadcast_text"
|
||||
|
||||
// Pause per recipient, scaled by the copied message count, keeps the run
|
||||
// around the bot-wide ~30 msg/s ceiling even for whole albums.
|
||||
broadcastSendDelay = 60 * time.Millisecond
|
||||
// Progress refreshes are throttled to keep the run under rate limits.
|
||||
broadcastProgressEvery = 25
|
||||
broadcastProgressInterval = 3 * time.Second
|
||||
broadcastFloodRetries = 5
|
||||
// A long retry_after is slept in slices so cancel and bot state stay checked.
|
||||
broadcastFloodWaitSlice = 5 * time.Second
|
||||
)
|
||||
|
||||
// broadcastDraft references the admin's original message: copyMessage relays
|
||||
// any message type 1:1 on behalf of the bot. An album lists its messages.
|
||||
type broadcastDraft struct {
|
||||
FromChatID int64
|
||||
MessageIDs []int
|
||||
}
|
||||
|
||||
// broadcastResult is the end-of-run statistics shown to the admin.
|
||||
type broadcastResult struct {
|
||||
Total int
|
||||
Delivered int
|
||||
Failed int
|
||||
Skipped int
|
||||
Unreachable int
|
||||
Canceled bool
|
||||
Elapsed time.Duration
|
||||
}
|
||||
|
||||
// broadcastRunner tracks the single in-flight broadcast: where to report
|
||||
// progress and whether the admin asked to stop it.
|
||||
type broadcastRunner struct {
|
||||
chatID int64
|
||||
messageID int
|
||||
cancel atomic.Bool
|
||||
|
||||
mu sync.Mutex
|
||||
result broadcastResult
|
||||
}
|
||||
|
||||
func (r *broadcastRunner) setResult(res broadcastResult) {
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
r.result = res
|
||||
}
|
||||
|
||||
func (r *broadcastRunner) getResult() broadcastResult {
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
return r.result
|
||||
}
|
||||
|
||||
// broadcastCompose is one admin's composition: collected message ids, the
|
||||
// album group still arriving, and the token binding the preview to its card.
|
||||
type broadcastCompose struct {
|
||||
messageIDs []int
|
||||
groupID string
|
||||
token string
|
||||
timer *time.Timer
|
||||
}
|
||||
|
||||
var (
|
||||
broadcastMu sync.Mutex
|
||||
broadcastComposes = make(map[chatUser]*broadcastCompose)
|
||||
broadcastActive *broadcastRunner
|
||||
)
|
||||
|
||||
// broadcastAlbumDebounce waits out Telegram's stream of one media group: an
|
||||
// album reaches the bot as separate messages sharing a media_group_id.
|
||||
var broadcastAlbumDebounce = 900 * time.Millisecond
|
||||
|
||||
// errBroadcastAborted reports a recipient abandoned because the run was
|
||||
// cancelled or the bot stopped, which is not a delivery failure.
|
||||
var errBroadcastAborted = errors.New("broadcast aborted")
|
||||
|
||||
// broadcastResetAll drops every composition and cancels the active run; the
|
||||
// bot calls it on stop so no timer, token or runner slot outlives the receiver.
|
||||
func broadcastResetAll() {
|
||||
broadcastMu.Lock()
|
||||
defer broadcastMu.Unlock()
|
||||
for _, c := range broadcastComposes {
|
||||
if c.timer != nil {
|
||||
c.timer.Stop()
|
||||
}
|
||||
}
|
||||
broadcastComposes = make(map[chatUser]*broadcastCompose)
|
||||
if broadcastActive != nil {
|
||||
broadcastActive.cancel.Store(true)
|
||||
broadcastActive = nil
|
||||
}
|
||||
}
|
||||
|
||||
func broadcastDropCompose(actor chatUser) {
|
||||
broadcastMu.Lock()
|
||||
defer broadcastMu.Unlock()
|
||||
if c := broadcastComposes[actor]; c != nil && c.timer != nil {
|
||||
c.timer.Stop()
|
||||
}
|
||||
delete(broadcastComposes, actor)
|
||||
}
|
||||
|
||||
// broadcastPendingDraft reports the ids awaiting an admin's confirmation;
|
||||
// ok is false while an album is still being collected.
|
||||
func broadcastPendingDraft(actor chatUser) ([]int, string, bool) {
|
||||
broadcastMu.Lock()
|
||||
defer broadcastMu.Unlock()
|
||||
c := broadcastComposes[actor]
|
||||
if c == nil || c.groupID != "" || c.token == "" {
|
||||
return nil, "", false
|
||||
}
|
||||
return append([]int(nil), c.messageIDs...), c.token, true
|
||||
}
|
||||
|
||||
// broadcastTakePending removes the pending draft only when its card token
|
||||
// matches; ok is false for stale taps or admins with no pending draft.
|
||||
func broadcastTakePending(actor chatUser, token string) ([]int, bool) {
|
||||
broadcastMu.Lock()
|
||||
defer broadcastMu.Unlock()
|
||||
c := broadcastComposes[actor]
|
||||
if c == nil || c.token == "" || c.token != token {
|
||||
return nil, false
|
||||
}
|
||||
delete(broadcastComposes, actor)
|
||||
return c.messageIDs, true
|
||||
}
|
||||
|
||||
// broadcastRegisterRunner claims the single broadcast slot; nil means one is
|
||||
// already running.
|
||||
func broadcastRegisterRunner(chatID int64) *broadcastRunner {
|
||||
broadcastMu.Lock()
|
||||
defer broadcastMu.Unlock()
|
||||
if broadcastActive != nil {
|
||||
return nil
|
||||
}
|
||||
broadcastActive = &broadcastRunner{chatID: chatID}
|
||||
return broadcastActive
|
||||
}
|
||||
|
||||
// broadcastUnregisterRunner releases the slot only if it is still ours, so a
|
||||
// stale runner cannot cancel a newer one's registration.
|
||||
func broadcastUnregisterRunner(runner *broadcastRunner) {
|
||||
broadcastMu.Lock()
|
||||
defer broadcastMu.Unlock()
|
||||
if broadcastActive == runner {
|
||||
broadcastActive = nil
|
||||
}
|
||||
}
|
||||
|
||||
func broadcastCurrentRunner() *broadcastRunner {
|
||||
broadcastMu.Lock()
|
||||
defer broadcastMu.Unlock()
|
||||
return broadcastActive
|
||||
}
|
||||
|
||||
// broadcastSender delivers one draft to one chat; swapped out in tests.
|
||||
var broadcastSender = deliverBroadcastCopy
|
||||
|
||||
// broadcastPause stands in for time.Sleep so tests don't wait real seconds.
|
||||
var broadcastPause = time.Sleep
|
||||
|
||||
// startBroadcast answers /broadcast: one broadcast at a time, so a second
|
||||
// command while one is running is refused instead of queued.
|
||||
func (t *Tgbot) startBroadcast(actor chatUser) {
|
||||
chatId := actor.chatID
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.SendMsgToTgbot(chatId, t.I18nBot("tgbot.messages.broadcastAlreadyRunning"))
|
||||
return
|
||||
}
|
||||
broadcastDropCompose(actor)
|
||||
userStateMgr.set(actor, broadcastAwaitingText)
|
||||
t.SendMsgToTgbot(chatId, t.I18nBot("tgbot.messages.broadcastAskText"), t.broadcastCancelKeyboard())
|
||||
}
|
||||
|
||||
// handleBroadcastInput references the message the admin sent and shows the
|
||||
// confirmation preview. The router hands over only the admin /broadcast awaits.
|
||||
func (t *Tgbot) handleBroadcastInput(message *telego.Message, actor chatUser) {
|
||||
logger.Debugf("broadcast: chat %d input (message_id=%d group=%q)", actor.chatID, message.MessageID, message.MediaGroupID)
|
||||
if message.MediaGroupID == "" {
|
||||
broadcastDropCompose(actor)
|
||||
t.acceptBroadcastDraft(actor, []int{message.MessageID})
|
||||
return
|
||||
}
|
||||
t.bufferBroadcastMedia(actor, message.MediaGroupID, message.MessageID)
|
||||
}
|
||||
|
||||
// acceptBroadcastDraft validates the draft with a self-copy — the admin sees
|
||||
// exactly what recipients will get — and shows the confirmation preview.
|
||||
func (t *Tgbot) acceptBroadcastDraft(actor chatUser, ids []int) {
|
||||
chatId := actor.chatID
|
||||
if err := broadcastSender(chatId, broadcastDraft{FromChatID: chatId, MessageIDs: ids}); err != nil {
|
||||
broadcastDropCompose(actor)
|
||||
userStateMgr.clear(actor)
|
||||
logger.Warningf("broadcast: chat %d message %v cannot be copied: %v", chatId, ids, err)
|
||||
t.SendMsgToTgbot(chatId, t.I18nBot("tgbot.messages.broadcastNotCopyable"))
|
||||
return
|
||||
}
|
||||
recipients := t.collectBroadcastRecipients()
|
||||
token := t.randomLowerAndNum(12)
|
||||
broadcastMu.Lock()
|
||||
broadcastComposes[actor] = &broadcastCompose{messageIDs: ids, token: token}
|
||||
broadcastMu.Unlock()
|
||||
userStateMgr.clear(actor)
|
||||
keyboard := tu.InlineKeyboard(tu.InlineKeyboardRow(
|
||||
tu.InlineKeyboardButton(t.I18nBot("tgbot.buttons.broadcastSend")).WithCallbackData("broadcast_confirm "+token),
|
||||
tu.InlineKeyboardButton(t.I18nBot("tgbot.buttons.cancel")).WithCallbackData("broadcast_cancel"),
|
||||
))
|
||||
t.SendMsgToTgbot(chatId, t.I18nBot("tgbot.messages.broadcastPreview", "Count=="+strconv.Itoa(len(recipients))), keyboard)
|
||||
}
|
||||
|
||||
// bufferBroadcastMedia appends an album item; the debounce timer fires the
|
||||
// preview once the group stops growing.
|
||||
func (t *Tgbot) bufferBroadcastMedia(actor chatUser, groupID string, messageID int) {
|
||||
broadcastMu.Lock()
|
||||
c := broadcastComposes[actor]
|
||||
if c == nil || c.groupID != groupID {
|
||||
if c != nil && c.timer != nil {
|
||||
c.timer.Stop()
|
||||
}
|
||||
c = &broadcastCompose{groupID: groupID}
|
||||
c.timer = time.AfterFunc(broadcastAlbumDebounce, func() {
|
||||
t.finalizeBroadcastAlbum(actor, groupID)
|
||||
})
|
||||
broadcastComposes[actor] = c
|
||||
}
|
||||
c.messageIDs = append(c.messageIDs, messageID)
|
||||
c.timer.Reset(broadcastAlbumDebounce)
|
||||
broadcastMu.Unlock()
|
||||
}
|
||||
|
||||
func (t *Tgbot) finalizeBroadcastAlbum(actor chatUser, groupID string) {
|
||||
broadcastMu.Lock()
|
||||
c := broadcastComposes[actor]
|
||||
if c == nil || c.groupID != groupID {
|
||||
broadcastMu.Unlock()
|
||||
return
|
||||
}
|
||||
// Album updates can arrive out of order, and copyMessages requires
|
||||
// strictly increasing ids.
|
||||
ids := append([]int(nil), c.messageIDs...)
|
||||
slices.Sort(ids)
|
||||
ids = slices.Compact(ids)
|
||||
delete(broadcastComposes, actor)
|
||||
broadcastMu.Unlock()
|
||||
|
||||
t.acceptBroadcastDraft(actor, ids)
|
||||
}
|
||||
|
||||
func (t *Tgbot) broadcastCancelKeyboard() *telego.InlineKeyboardMarkup {
|
||||
return tu.InlineKeyboard(tu.InlineKeyboardRow(
|
||||
tu.InlineKeyboardButton(t.I18nBot("tgbot.buttons.cancel")).WithCallbackData("broadcast_cancel"),
|
||||
))
|
||||
}
|
||||
|
||||
// confirmBroadcast turns the pending draft into a run: it claims the single
|
||||
// runner slot, replaces the preview with a progress card, and starts delivery.
|
||||
func (t *Tgbot) confirmBroadcast(actor chatUser, token string, messageID int, queryID string) {
|
||||
chatId := actor.chatID
|
||||
runner := broadcastRegisterRunner(chatId)
|
||||
if runner == nil {
|
||||
t.sendCallbackAnswerTgBot(queryID, t.I18nBot("tgbot.messages.broadcastAlreadyRunning"))
|
||||
return
|
||||
}
|
||||
ids, ok := broadcastTakePending(actor, token)
|
||||
if !ok {
|
||||
broadcastUnregisterRunner(runner)
|
||||
t.sendCallbackAnswerTgBot(queryID, t.I18nBot("tgbot.wentWrong"))
|
||||
return
|
||||
}
|
||||
draft := broadcastDraft{FromChatID: chatId, MessageIDs: ids}
|
||||
recipients := t.collectBroadcastRecipients()
|
||||
if len(recipients) == 0 {
|
||||
broadcastUnregisterRunner(runner)
|
||||
t.sendCallbackAnswerTgBot(queryID, t.I18nBot("tgbot.messages.broadcastNoRecipients"))
|
||||
t.deleteMessageTgBot(chatId, messageID)
|
||||
return
|
||||
}
|
||||
runner.messageID = messageID
|
||||
t.sendCallbackAnswerTgBot(queryID, t.I18nBot("tgbot.answers.broadcastStarted"))
|
||||
t.editMessageTgBot(chatId, messageID, t.broadcastProgressText(0, len(recipients), 0, 0), t.broadcastCancelKeyboard())
|
||||
common.GoRecover("tgbot-broadcast", func() {
|
||||
t.runBroadcast(runner, draft, recipients)
|
||||
})
|
||||
}
|
||||
|
||||
// runBroadcast walks the recipients sequentially, honoring rate limits, and
|
||||
// reports the final summary on the runner's card.
|
||||
func (t *Tgbot) runBroadcast(runner *broadcastRunner, draft broadcastDraft, recipients []int64) {
|
||||
defer broadcastUnregisterRunner(runner)
|
||||
start := time.Now()
|
||||
// One copyMessages call carries a whole album, so the pause scales with
|
||||
// the batch size to stay under the same per-second ceiling.
|
||||
pause := broadcastSendDelay * time.Duration(max(1, len(draft.MessageIDs)))
|
||||
aborted := func() bool { return runner.cancel.Load() || !t.IsRunning() }
|
||||
sent, failed, unreachable := 0, 0, 0
|
||||
lastProgress := time.Now()
|
||||
canceled := false
|
||||
|
||||
for i, chatID := range recipients {
|
||||
if aborted() {
|
||||
canceled = runner.cancel.Load()
|
||||
break
|
||||
}
|
||||
err := broadcastDeliverOne(chatID, draft, aborted)
|
||||
if errors.Is(err, errBroadcastAborted) {
|
||||
canceled = runner.cancel.Load()
|
||||
break
|
||||
}
|
||||
switch {
|
||||
case err == nil:
|
||||
sent++
|
||||
case broadcastChatUnreachable(err):
|
||||
// 403 means the chat never started the bot or blocked it; a long
|
||||
// recipient list would turn these into log spam at warning level.
|
||||
unreachable++
|
||||
logger.Debugf("broadcast: chat %d cannot receive bot messages: %v", chatID, err)
|
||||
default:
|
||||
failed++
|
||||
logger.Warningf("broadcast: chat %d not delivered: %v", chatID, err)
|
||||
}
|
||||
done := i + 1
|
||||
if done%broadcastProgressEvery == 0 || time.Since(lastProgress) >= broadcastProgressInterval {
|
||||
t.editMessageTgBot(runner.chatID, runner.messageID, t.broadcastProgressText(done, len(recipients), sent, failed), t.broadcastCancelKeyboard())
|
||||
lastProgress = time.Now()
|
||||
}
|
||||
if i < len(recipients)-1 {
|
||||
broadcastPause(pause)
|
||||
}
|
||||
}
|
||||
|
||||
result := broadcastResult{
|
||||
Total: len(recipients),
|
||||
Delivered: sent,
|
||||
Failed: failed,
|
||||
Skipped: len(recipients) - sent - failed,
|
||||
Unreachable: unreachable,
|
||||
Canceled: canceled,
|
||||
Elapsed: time.Since(start).Round(time.Second),
|
||||
}
|
||||
summary := t.broadcastSummaryText(result)
|
||||
if !t.finalizeBroadcastCard(runner, summary) {
|
||||
t.SendMsgToTgbot(runner.chatID, summary)
|
||||
}
|
||||
logger.Info("broadcast finished: delivered", sent, "failed", failed, "skipped", result.Skipped, "elapsed", result.Elapsed)
|
||||
runner.setResult(result)
|
||||
}
|
||||
|
||||
func (t *Tgbot) broadcastProgressText(done, total, sent, failed int) string {
|
||||
return t.I18nBot("tgbot.messages.broadcastProgress",
|
||||
"Done=="+strconv.Itoa(done),
|
||||
"Total=="+strconv.Itoa(total),
|
||||
"Sent=="+strconv.Itoa(sent),
|
||||
"Failed=="+strconv.Itoa(failed))
|
||||
}
|
||||
|
||||
func (t *Tgbot) broadcastSummaryText(result broadcastResult) string {
|
||||
params := []string{
|
||||
"Total==" + strconv.Itoa(result.Total),
|
||||
"Sent==" + strconv.Itoa(result.Delivered),
|
||||
"Failed==" + strconv.Itoa(result.Failed),
|
||||
"Skipped==" + strconv.Itoa(result.Skipped),
|
||||
"Time==" + result.Elapsed.String(),
|
||||
}
|
||||
summary := t.I18nBot("tgbot.messages.broadcastFinished", params...)
|
||||
if result.Canceled {
|
||||
summary = t.I18nBot("tgbot.messages.broadcastCanceled", params...)
|
||||
}
|
||||
if result.Unreachable > 0 {
|
||||
summary += t.I18nBot("tgbot.messages.broadcastUnreachable", "Count=="+strconv.Itoa(result.Unreachable))
|
||||
}
|
||||
return summary
|
||||
}
|
||||
|
||||
// finalizeBroadcastCard turns the progress card into the summary; false means
|
||||
// the card is gone and the summary needs its own message to be seen at all.
|
||||
func (t *Tgbot) finalizeBroadcastCard(runner *broadcastRunner, summary string) bool {
|
||||
params := telego.EditMessageTextParams{
|
||||
ChatID: tu.ID(runner.chatID),
|
||||
MessageID: runner.messageID,
|
||||
Text: summary,
|
||||
ParseMode: "HTML",
|
||||
ReplyMarkup: &telego.InlineKeyboardMarkup{InlineKeyboard: [][]telego.InlineKeyboardButton{}},
|
||||
}
|
||||
_, err := bot.EditMessageText(context.Background(), ¶ms)
|
||||
if err == nil || isTelegramNotModifiedError(err) {
|
||||
return true
|
||||
}
|
||||
logger.Warning("broadcast: progress card edit failed:", err)
|
||||
return false
|
||||
}
|
||||
|
||||
// cancelBroadcast handles the inline cancel button: while composing it drops
|
||||
// the draft, while running it stops the loop after the current recipient.
|
||||
func (t *Tgbot) cancelBroadcast(actor chatUser, messageID int, queryID string) {
|
||||
chatId := actor.chatID
|
||||
if runner := broadcastCurrentRunner(); runner != nil && runner.chatID == chatId {
|
||||
runner.cancel.Store(true)
|
||||
t.sendCallbackAnswerTgBot(queryID, t.I18nBot("tgbot.answers.broadcastCanceling"))
|
||||
return
|
||||
}
|
||||
broadcastDropCompose(actor)
|
||||
userStateMgr.clear(actor)
|
||||
t.deleteMessageTgBot(chatId, messageID)
|
||||
t.sendCallbackAnswerTgBot(queryID, t.I18nBot("tgbot.answers.broadcastCanceled"))
|
||||
}
|
||||
|
||||
// collectBroadcastRecipients returns the distinct client Telegram IDs to
|
||||
// deliver to: clients with a linked tg_id, admins excluded.
|
||||
func (t *Tgbot) collectBroadcastRecipients() []int64 {
|
||||
inbounds, err := t.inboundService.GetAllInbounds()
|
||||
if err != nil {
|
||||
logger.Warning("broadcast: unable to load inbounds:", err)
|
||||
return nil
|
||||
}
|
||||
seen := make(map[int64]bool)
|
||||
var recipients []int64
|
||||
for _, inbound := range inbounds {
|
||||
clients, err := t.inboundService.GetClients(inbound)
|
||||
if err != nil {
|
||||
continue
|
||||
}
|
||||
for _, client := range clients {
|
||||
if client.TgID == 0 || seen[client.TgID] || checkAdmin(client.TgID) {
|
||||
continue
|
||||
}
|
||||
seen[client.TgID] = true
|
||||
recipients = append(recipients, client.TgID)
|
||||
}
|
||||
}
|
||||
return recipients
|
||||
}
|
||||
|
||||
// broadcastDeliverOne retries a recipient through flood-control waits so a 429
|
||||
// never drops them; after broadcastFloodRetries waits it gives up on them.
|
||||
func broadcastDeliverOne(chatID int64, draft broadcastDraft, aborted func() bool) error {
|
||||
for attempt := 0; ; attempt++ {
|
||||
err := broadcastSender(chatID, draft)
|
||||
if err == nil {
|
||||
return nil
|
||||
}
|
||||
wait, flood := broadcastRetryAfter(err)
|
||||
if !flood || attempt >= broadcastFloodRetries {
|
||||
return err
|
||||
}
|
||||
logger.Warningf("broadcast: chat %d is flood-limited, retrying in %s", chatID, wait)
|
||||
if !broadcastFloodWait(wait, aborted) {
|
||||
return errBroadcastAborted
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// broadcastFloodWait sleeps out a flood-control delay in slices so a cancel or
|
||||
// a bot stop ends the wait instead of parking the runner slot for minutes.
|
||||
func broadcastFloodWait(wait time.Duration, aborted func() bool) bool {
|
||||
for remaining := wait; remaining > 0; remaining -= broadcastFloodWaitSlice {
|
||||
if aborted != nil && aborted() {
|
||||
return false
|
||||
}
|
||||
broadcastPause(min(broadcastFloodWaitSlice, remaining))
|
||||
}
|
||||
return aborted == nil || !aborted()
|
||||
}
|
||||
|
||||
// broadcastChatUnreachable reports a Telegram 403: the chat never started the
|
||||
// bot or has blocked it, which no retry can fix.
|
||||
func broadcastChatUnreachable(err error) bool {
|
||||
var apiErr *telegoapi.Error
|
||||
return errors.As(err, &apiErr) && apiErr.ErrorCode == 403
|
||||
}
|
||||
|
||||
// broadcastRetryAfter reports the flood-control wait a 429 response asks for.
|
||||
func broadcastRetryAfter(err error) (time.Duration, bool) {
|
||||
var apiErr *telegoapi.Error
|
||||
if !errors.As(err, &apiErr) || apiErr.ErrorCode != 429 {
|
||||
return 0, false
|
||||
}
|
||||
if apiErr.Parameters == nil || apiErr.Parameters.RetryAfter <= 0 {
|
||||
return time.Second, true
|
||||
}
|
||||
return time.Duration(apiErr.Parameters.RetryAfter) * time.Second, true
|
||||
}
|
||||
|
||||
// deliverBroadcastCopy copies the admin's message to one recipient chat; an
|
||||
// album rides one copyMessages call and arrives with no forward header.
|
||||
func deliverBroadcastCopy(chatID int64, draft broadcastDraft) error {
|
||||
from := tu.ID(draft.FromChatID)
|
||||
return callTelegramAPI(func(ctx context.Context) error {
|
||||
var err error
|
||||
switch {
|
||||
case len(draft.MessageIDs) > 1:
|
||||
_, err = bot.CopyMessages(ctx, &telego.CopyMessagesParams{ChatID: tu.ID(chatID), FromChatID: from, MessageIDs: draft.MessageIDs})
|
||||
case len(draft.MessageIDs) == 1:
|
||||
_, err = bot.CopyMessage(ctx, &telego.CopyMessageParams{ChatID: tu.ID(chatID), FromChatID: from, MessageID: draft.MessageIDs[0]})
|
||||
}
|
||||
return err
|
||||
})
|
||||
}
|
||||
|
||||
func callTelegramAPI(call func(ctx context.Context) error) error {
|
||||
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
||||
defer cancel()
|
||||
return call(ctx)
|
||||
}
|
||||
@@ -0,0 +1,941 @@
|
||||
package tgbot
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"slices"
|
||||
"strings"
|
||||
"sync"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/mhsanaei/3x-ui/v3/internal/database"
|
||||
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
|
||||
"github.com/mhsanaei/3x-ui/v3/internal/web/locale"
|
||||
|
||||
telegoapi "github.com/mymmrac/telego/telegoapi"
|
||||
|
||||
"github.com/mymmrac/telego"
|
||||
"github.com/nicksnyder/go-i18n/v2/i18n"
|
||||
"golang.org/x/text/language"
|
||||
)
|
||||
|
||||
// newBroadcastMock serves ok:true and records per-method call counts and
|
||||
// bodies; copyMessages answers with an array of ids, as the real API does.
|
||||
func newBroadcastMock(t *testing.T) (url string, calls func(string) int, bodies func(string) []map[string]any) {
|
||||
t.Helper()
|
||||
var mu sync.Mutex
|
||||
counts := map[string]int{}
|
||||
sent := map[string][]map[string]any{}
|
||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
raw, _ := io.ReadAll(r.Body)
|
||||
payload := map[string]any{}
|
||||
_ = json.Unmarshal(raw, &payload)
|
||||
method := strings.TrimPrefix(r.URL.Path, "/bot"+testBotToken+"/")
|
||||
message := map[string]any{"message_id": 7, "date": 0, "chat": map[string]any{"id": 1, "type": "private"}}
|
||||
result := any(message)
|
||||
if method == "copyMessages" {
|
||||
result = []any{message, message}
|
||||
}
|
||||
mu.Lock()
|
||||
counts[method]++
|
||||
sent[method] = append(sent[method], payload)
|
||||
mu.Unlock()
|
||||
w.Header().Set("Content-Type", "application/json")
|
||||
_ = json.NewEncoder(w).Encode(map[string]any{"ok": true, "result": result})
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
return srv.URL,
|
||||
func(method string) int {
|
||||
mu.Lock()
|
||||
defer mu.Unlock()
|
||||
return counts[method]
|
||||
},
|
||||
func(method string) []map[string]any {
|
||||
mu.Lock()
|
||||
defer mu.Unlock()
|
||||
return append([]map[string]any(nil), sent[method]...)
|
||||
}
|
||||
}
|
||||
|
||||
func setBroadcastAdmins(t *testing.T, ids []int64) {
|
||||
t.Helper()
|
||||
tgBotMutex.Lock()
|
||||
orig := adminIds
|
||||
adminIds = ids
|
||||
tgBotMutex.Unlock()
|
||||
t.Cleanup(func() {
|
||||
tgBotMutex.Lock()
|
||||
adminIds = orig
|
||||
tgBotMutex.Unlock()
|
||||
})
|
||||
}
|
||||
|
||||
func setBroadcastRunning(t *testing.T, running bool) {
|
||||
t.Helper()
|
||||
tgBotMutex.Lock()
|
||||
orig := isRunning
|
||||
isRunning = running
|
||||
tgBotMutex.Unlock()
|
||||
t.Cleanup(func() {
|
||||
tgBotMutex.Lock()
|
||||
isRunning = orig
|
||||
tgBotMutex.Unlock()
|
||||
})
|
||||
}
|
||||
|
||||
func swapBroadcastSender(t *testing.T, sender func(int64, broadcastDraft) error, pause func(time.Duration)) {
|
||||
t.Helper()
|
||||
origSend, origPause := broadcastSender, broadcastPause
|
||||
t.Cleanup(func() {
|
||||
broadcastSender, broadcastPause = origSend, origPause
|
||||
})
|
||||
broadcastSender = sender
|
||||
if pause != nil {
|
||||
broadcastPause = pause
|
||||
}
|
||||
}
|
||||
|
||||
// broadcastLocalizer renders the broadcast keys a test asserts on; without it
|
||||
// I18n returns the bare key instead of the template output.
|
||||
func broadcastLocalizer(t *testing.T) {
|
||||
t.Helper()
|
||||
bundle := i18n.NewBundle(language.MustParse("en-US"))
|
||||
bundle.RegisterUnmarshalFunc("json", json.Unmarshal)
|
||||
_ = bundle.AddMessages(language.MustParse("en-US"),
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastPreview", Other: "📤 This message will go to {{ .Count }} recipients. Send it?"},
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastNotCopyable", Other: "❗ This message can't be copied for broadcast."},
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastAskText", Other: "send the message"},
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastAlreadyRunning", Other: "already running"},
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastProgress", Other: "progress {{ .Sent }}/{{ .Total }} failed {{ .Failed }}"},
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastFinished", Other: "finished"},
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastCanceled", Other: "canceled"},
|
||||
&i18n.Message{ID: "tgbot.messages.broadcastUnreachable", Other: "ℹ️ {{ .Count }} recipients cannot be messaged — ask them to press Start."},
|
||||
)
|
||||
orig := locale.LocalizerBot
|
||||
t.Cleanup(func() { locale.LocalizerBot = orig })
|
||||
locale.LocalizerBot = i18n.NewLocalizer(bundle, "en-US")
|
||||
}
|
||||
|
||||
func createBroadcastInbound(t *testing.T, tag, settings string) {
|
||||
t.Helper()
|
||||
inbound := &model.Inbound{Tag: tag, Settings: settings, Enable: true}
|
||||
if err := database.GetDB().Create(inbound).Error; err != nil {
|
||||
t.Fatalf("create inbound %s: %v", tag, err)
|
||||
}
|
||||
}
|
||||
|
||||
// broadcastClientsJSON renders an inbound settings blob with the given tgIds.
|
||||
func broadcastClientsJSON(t *testing.T, tgIDs ...int64) string {
|
||||
t.Helper()
|
||||
clients := make([]string, 0, len(tgIDs))
|
||||
for i, tgID := range tgIDs {
|
||||
clients = append(clients, fmt.Sprintf(`{"email":"user%d@x","tgId":%d}`, i, tgID))
|
||||
}
|
||||
return `{"clients":[` + strings.Join(clients, ",") + `]}`
|
||||
}
|
||||
|
||||
// resetBroadcastState clears the shared broadcast globals before a test
|
||||
// asserts on them: shuffled tests may inherit state from an earlier test.
|
||||
func resetBroadcastState(t *testing.T) {
|
||||
t.Helper()
|
||||
broadcastResetAll()
|
||||
userStateMgr.reset()
|
||||
}
|
||||
|
||||
// composeBroadcast hands a message to the composition step the way the router
|
||||
// does: keyed by its sender, who is awaiting broadcast input.
|
||||
func composeBroadcast(tb *Tgbot, message telego.Message) {
|
||||
actor := messageActor(message)
|
||||
userStateMgr.set(actor, broadcastAwaitingText)
|
||||
tb.handleBroadcastInput(&message, actor)
|
||||
}
|
||||
|
||||
func swapAlbumDebounce(t *testing.T, d time.Duration) {
|
||||
t.Helper()
|
||||
orig := broadcastAlbumDebounce
|
||||
t.Cleanup(func() { broadcastAlbumDebounce = orig })
|
||||
broadcastAlbumDebounce = d
|
||||
}
|
||||
|
||||
// waitBroadcastPending polls until the debounce finalizer has stored a draft
|
||||
// and returns its ids and card token.
|
||||
func waitBroadcastPending(t *testing.T, actor chatUser) ([]int, string) {
|
||||
t.Helper()
|
||||
deadline := time.Now().Add(2 * time.Second)
|
||||
for time.Now().Before(deadline) {
|
||||
if ids, token, ok := broadcastPendingDraft(actor); ok {
|
||||
return ids, token
|
||||
}
|
||||
time.Sleep(2 * time.Millisecond)
|
||||
}
|
||||
t.Fatal("album draft was never finalized in time")
|
||||
return nil, ""
|
||||
}
|
||||
|
||||
func TestCollectBroadcastRecipients(t *testing.T) {
|
||||
tb := newStaleButtonTgbot(t)
|
||||
setBroadcastAdmins(t, []int64{222})
|
||||
|
||||
// 111 appears on both inbounds, 222 is an admin, 0 has no Telegram ID.
|
||||
createBroadcastInbound(t, "in-1", broadcastClientsJSON(t, 111, 111, 222))
|
||||
createBroadcastInbound(t, "in-2", broadcastClientsJSON(t, 111, 333, 0, 444))
|
||||
|
||||
got := tb.collectBroadcastRecipients()
|
||||
slices.Sort(got)
|
||||
if !slices.Equal(got, []int64{111, 333, 444}) {
|
||||
t.Fatalf("collectBroadcastRecipients() = %v, want [111 333 444]", got)
|
||||
}
|
||||
}
|
||||
|
||||
func assertBroadcastResult(t *testing.T, got, want broadcastResult) {
|
||||
t.Helper()
|
||||
got.Elapsed, want.Elapsed = 0, 0
|
||||
if got != want {
|
||||
t.Errorf("result = %+v, want %+v", got, want)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRunBroadcastCounters(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, _, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
blocked := &telegoapi.Error{ErrorCode: 403, Description: "Forbidden: bot was blocked by the user"}
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
recipients []int64
|
||||
outcomes map[int64]error
|
||||
delivered int
|
||||
failed int
|
||||
skipped int
|
||||
unreachable int
|
||||
}{
|
||||
{"all delivered", []int64{1, 2, 3}, map[int64]error{1: nil, 2: nil, 3: nil}, 3, 0, 0, 0},
|
||||
{
|
||||
"a blocked chat is skipped and a transient error fails",
|
||||
[]int64{1, 2, 3, 4},
|
||||
map[int64]error{1: nil, 2: blocked, 3: nil, 4: errors.New("connection reset")},
|
||||
2, 1, 1, 1,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
swapBroadcastSender(t, func(chatID int64, _ broadcastDraft) error {
|
||||
return tt.outcomes[chatID]
|
||||
}, func(time.Duration) {})
|
||||
|
||||
runner := &broadcastRunner{chatID: 100, messageID: 5}
|
||||
tb := &Tgbot{}
|
||||
tb.runBroadcast(runner, broadcastDraft{FromChatID: 100, MessageIDs: []int{7}}, tt.recipients)
|
||||
|
||||
assertBroadcastResult(t, runner.getResult(), broadcastResult{
|
||||
Total: len(tt.recipients),
|
||||
Delivered: tt.delivered,
|
||||
Failed: tt.failed,
|
||||
Skipped: tt.skipped,
|
||||
Unreachable: tt.unreachable,
|
||||
})
|
||||
summary := tb.broadcastSummaryText(runner.getResult())
|
||||
if tt.unreachable == 0 {
|
||||
if strings.Contains(summary, "press Start") {
|
||||
t.Errorf("summary = %q, want no unreachable note", summary)
|
||||
}
|
||||
} else if !strings.Contains(summary, "1 recipients cannot be messaged") {
|
||||
t.Errorf("summary = %q, want the unreachable note with the count", summary)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestRunBroadcastCancelsMidway(t *testing.T) {
|
||||
url, _, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
|
||||
runner := &broadcastRunner{chatID: 100, messageID: 5}
|
||||
swapBroadcastSender(t, func(chatID int64, _ broadcastDraft) error {
|
||||
if chatID == 1 {
|
||||
runner.cancel.Store(true)
|
||||
}
|
||||
return nil
|
||||
}, func(time.Duration) {})
|
||||
|
||||
(&Tgbot{}).runBroadcast(runner, broadcastDraft{FromChatID: 100, MessageIDs: []int{7}}, []int64{1, 2, 3, 4, 5})
|
||||
|
||||
assertBroadcastResult(t, runner.getResult(), broadcastResult{
|
||||
Total: 5,
|
||||
Delivered: 1,
|
||||
Failed: 0,
|
||||
Skipped: 4,
|
||||
Canceled: true,
|
||||
})
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.Errorf("broadcast slot still registered after the run finished")
|
||||
}
|
||||
}
|
||||
|
||||
// Regression: a 403 left the progress counter where it was, so a streak of
|
||||
// unreachable chats at a multiple of broadcastProgressEvery edited the card per chat.
|
||||
func TestRunBroadcastUnreachableKeepsProgressThrottled(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, calls, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
blocked := &telegoapi.Error{ErrorCode: 403, Description: "Forbidden: bot can't initiate conversation with a user"}
|
||||
swapBroadcastSender(t, func(int64, broadcastDraft) error { return blocked }, func(time.Duration) {})
|
||||
|
||||
runner := &broadcastRunner{chatID: 100, messageID: 5}
|
||||
(&Tgbot{}).runBroadcast(runner, broadcastDraft{FromChatID: 100, MessageIDs: []int{7}}, []int64{1, 2, 3, 4, 5})
|
||||
|
||||
// Five recipients sit under both throttle thresholds: only the summary edits the card.
|
||||
if got := calls("editMessageText"); got != 1 {
|
||||
t.Errorf("editMessageText calls = %d, want 1 (the summary alone)", got)
|
||||
}
|
||||
}
|
||||
|
||||
// A long retry_after must not park the runner slot: the wait is slept in
|
||||
// slices and an abort between them ends the recipient immediately.
|
||||
func TestBroadcastFloodWaitSlicesLongWaits(t *testing.T) {
|
||||
flood := &telegoapi.Error{
|
||||
ErrorCode: 429,
|
||||
Description: "Too Many Requests: retry after 30",
|
||||
Parameters: &telegoapi.ResponseParameters{RetryAfter: 30},
|
||||
}
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
abortAfter int // abort checks answered false before aborting; -1 never aborts
|
||||
wantPauses int
|
||||
wantErr string
|
||||
}{
|
||||
{"a 30 s wait becomes six 5 s slices", -1, 30, `429 "Too Many Requests: retry after 30", migrate to chat ID: 0, retry after: 30`},
|
||||
{"an abort between slices ends the wait", 1, 1, errBroadcastAborted.Error()},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
var mu sync.Mutex
|
||||
var pauses []time.Duration
|
||||
swapBroadcastSender(t, func(int64, broadcastDraft) error { return flood }, func(d time.Duration) {
|
||||
mu.Lock()
|
||||
defer mu.Unlock()
|
||||
pauses = append(pauses, d)
|
||||
})
|
||||
checks := 0
|
||||
aborted := func() bool {
|
||||
if tt.abortAfter < 0 {
|
||||
return false
|
||||
}
|
||||
checks++
|
||||
return checks > tt.abortAfter
|
||||
}
|
||||
|
||||
err := broadcastDeliverOne(9, broadcastDraft{FromChatID: 100, MessageIDs: []int{7}}, aborted)
|
||||
|
||||
mu.Lock()
|
||||
defer mu.Unlock()
|
||||
if err == nil || err.Error() != tt.wantErr {
|
||||
t.Errorf("broadcastDeliverOne() error = %v, want %q", err, tt.wantErr)
|
||||
}
|
||||
if len(pauses) != tt.wantPauses {
|
||||
t.Fatalf("pauses = %d slices, want %d", len(pauses), tt.wantPauses)
|
||||
}
|
||||
for i, p := range pauses {
|
||||
if p != broadcastFloodWaitSlice {
|
||||
t.Errorf("pauses[%d] = %v, want %v", i, p, broadcastFloodWaitSlice)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// Regression: broadcast state used to survive a stop, leaving an armed album
|
||||
// timer, a confirmable token and a held runner slot behind.
|
||||
func TestStopBotResetsBroadcastState(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, calls, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
swapAlbumDebounce(t, 20*time.Millisecond)
|
||||
setBroadcastAdmins(t, []int64{5000})
|
||||
|
||||
const chatID = int64(9116)
|
||||
resetBroadcastState(t)
|
||||
origRunning := isRunning
|
||||
t.Cleanup(func() {
|
||||
tgBotMutex.Lock()
|
||||
isRunning = origRunning
|
||||
tgBotMutex.Unlock()
|
||||
})
|
||||
|
||||
composeBroadcast(&Tgbot{}, telego.Message{
|
||||
Chat: telego.Chat{ID: chatID},
|
||||
From: &telego.User{ID: 5000},
|
||||
MessageID: 1,
|
||||
MediaGroupID: "grpR",
|
||||
})
|
||||
runner := broadcastRegisterRunner(chatID)
|
||||
if runner == nil {
|
||||
t.Fatal("broadcastRegisterRunner() = nil before the stop")
|
||||
}
|
||||
|
||||
StopBot()
|
||||
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.Errorf("broadcast slot survived StopBot")
|
||||
}
|
||||
if !runner.cancel.Load() {
|
||||
t.Errorf("the active run was not cancelled on stop")
|
||||
}
|
||||
if _, _, ok := broadcastPendingDraft(chatUser{chatID: chatID, userID: 5000}); ok {
|
||||
t.Errorf("a composition survived StopBot")
|
||||
}
|
||||
time.Sleep(60 * time.Millisecond)
|
||||
if got := calls("copyMessage") + calls("sendMessage"); got != 0 {
|
||||
t.Errorf("an armed album timer fired after StopBot (%d calls)", got)
|
||||
}
|
||||
}
|
||||
|
||||
// The per-recipient pause scales with the copied batch size so an album does
|
||||
// not multiply the messages per second on the wire.
|
||||
func TestRunBroadcastAlbumPacing(t *testing.T) {
|
||||
url, _, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
|
||||
var pauses []time.Duration
|
||||
swapBroadcastSender(t, func(int64, broadcastDraft) error { return nil }, func(d time.Duration) {
|
||||
pauses = append(pauses, d)
|
||||
})
|
||||
|
||||
runner := &broadcastRunner{chatID: 100, messageID: 5}
|
||||
(&Tgbot{}).runBroadcast(runner, broadcastDraft{FromChatID: 100, MessageIDs: []int{1, 2, 3}}, []int64{1, 2})
|
||||
|
||||
if len(pauses) != 1 || pauses[0] != 3*broadcastSendDelay {
|
||||
t.Errorf("pauses = %v, want one pause of %v for a three-message album", pauses, 3*broadcastSendDelay)
|
||||
}
|
||||
}
|
||||
|
||||
func TestBroadcastDeliverOneRetries429(t *testing.T) {
|
||||
flood := func(after int) error {
|
||||
return &telegoapi.Error{
|
||||
ErrorCode: 429,
|
||||
Description: "Too Many Requests: retry after " + fmt.Sprint(after),
|
||||
Parameters: &telegoapi.ResponseParameters{RetryAfter: after},
|
||||
}
|
||||
}
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
responses []error
|
||||
canceled bool
|
||||
wantErr string
|
||||
wantCalls int
|
||||
wantPauses []time.Duration
|
||||
}{
|
||||
{
|
||||
name: "flood control waits and retries the same recipient",
|
||||
responses: []error{flood(2), nil},
|
||||
wantCalls: 2,
|
||||
wantPauses: []time.Duration{2 * time.Second},
|
||||
},
|
||||
{
|
||||
name: "gives up after the retry budget",
|
||||
responses: []error{flood(1), flood(1), flood(1), flood(1), flood(1), flood(1), nil},
|
||||
wantErr: `429 "Too Many Requests: retry after 1", migrate to chat ID: 0, retry after: 1`,
|
||||
wantCalls: 6,
|
||||
wantPauses: []time.Duration{time.Second, time.Second, time.Second, time.Second, time.Second},
|
||||
},
|
||||
{
|
||||
name: "non-429 errors are returned without retrying",
|
||||
responses: []error{errors.New("connection reset")},
|
||||
wantErr: "connection reset",
|
||||
wantCalls: 1,
|
||||
},
|
||||
{
|
||||
name: "a cancel during a flood wait abandons the recipient",
|
||||
responses: []error{flood(2), nil},
|
||||
canceled: true,
|
||||
wantErr: errBroadcastAborted.Error(),
|
||||
wantCalls: 1,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
var mu sync.Mutex
|
||||
callNum := 0
|
||||
var pauses []time.Duration
|
||||
swapBroadcastSender(t, func(int64, broadcastDraft) error {
|
||||
mu.Lock()
|
||||
defer mu.Unlock()
|
||||
callNum++
|
||||
if callNum > len(tt.responses) {
|
||||
return nil
|
||||
}
|
||||
return tt.responses[callNum-1]
|
||||
}, func(d time.Duration) {
|
||||
mu.Lock()
|
||||
defer mu.Unlock()
|
||||
pauses = append(pauses, d)
|
||||
})
|
||||
canceled := func() bool { return tt.canceled }
|
||||
|
||||
err := broadcastDeliverOne(9, broadcastDraft{FromChatID: 100, MessageIDs: []int{7}}, canceled)
|
||||
|
||||
mu.Lock()
|
||||
defer mu.Unlock()
|
||||
if tt.wantErr != "" {
|
||||
if err == nil || err.Error() != tt.wantErr {
|
||||
t.Errorf("broadcastDeliverOne() error = %v, want %q", err, tt.wantErr)
|
||||
}
|
||||
} else if err != nil {
|
||||
t.Errorf("broadcastDeliverOne() error = %v, want nil", err)
|
||||
}
|
||||
if callNum != tt.wantCalls {
|
||||
t.Errorf("sender calls = %d, want %d", callNum, tt.wantCalls)
|
||||
}
|
||||
if len(pauses) != len(tt.wantPauses) {
|
||||
t.Fatalf("pauses = %v, want %v", pauses, tt.wantPauses)
|
||||
}
|
||||
for i, p := range tt.wantPauses {
|
||||
if pauses[i] != p {
|
||||
t.Errorf("pauses[%d] = %v, want %v", i, pauses[i], p)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestBroadcastRegisterRunnerSingleSlot(t *testing.T) {
|
||||
first := broadcastRegisterRunner(1)
|
||||
if first == nil {
|
||||
t.Fatal("broadcastRegisterRunner() = nil for an idle bot")
|
||||
}
|
||||
t.Cleanup(func() { broadcastUnregisterRunner(first) })
|
||||
|
||||
if second := broadcastRegisterRunner(2); second != nil {
|
||||
t.Fatalf("broadcastRegisterRunner() = %v while a broadcast is running, want nil", second)
|
||||
}
|
||||
|
||||
broadcastUnregisterRunner(first)
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.Fatalf("slot still registered after unregister")
|
||||
}
|
||||
}
|
||||
|
||||
func TestStartBroadcastRefusesWhileRunning(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
const chatID = int64(9102)
|
||||
resetBroadcastState(t)
|
||||
|
||||
runner := broadcastRegisterRunner(chatID)
|
||||
t.Cleanup(func() {
|
||||
broadcastUnregisterRunner(runner)
|
||||
})
|
||||
admin := chatUser{chatID: chatID, userID: chatID}
|
||||
|
||||
(&Tgbot{}).startBroadcast(admin)
|
||||
|
||||
if state, ok := userStateMgr.get(admin); ok {
|
||||
t.Fatalf("state = %q while a broadcast is running, want none", state)
|
||||
}
|
||||
}
|
||||
|
||||
func TestBroadcastCommandRequiresAdmin(t *testing.T) {
|
||||
const chatID = int64(9101)
|
||||
resetBroadcastState(t)
|
||||
|
||||
message := &telego.Message{Chat: telego.Chat{ID: chatID}, From: &telego.User{ID: chatID}, Text: "/broadcast"}
|
||||
(&Tgbot{}).answerCommand(message, chatID, false)
|
||||
|
||||
if state, ok := userStateMgr.get(messageActor(*message)); ok {
|
||||
t.Fatalf("non-admin /broadcast set state %q", state)
|
||||
}
|
||||
if _, _, ok := broadcastPendingDraft(messageActor(*message)); ok {
|
||||
t.Fatalf("non-admin /broadcast produced a draft")
|
||||
}
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.Fatalf("non-admin /broadcast started a runner")
|
||||
}
|
||||
}
|
||||
|
||||
func TestBroadcastStartCommandSetsState(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
const chatID = int64(9103)
|
||||
resetBroadcastState(t)
|
||||
defer func() {
|
||||
userStateMgr.reset()
|
||||
broadcastResetAll()
|
||||
}()
|
||||
|
||||
(&Tgbot{}).answerCommand(&telego.Message{Chat: telego.Chat{ID: chatID}, From: &telego.User{ID: chatID}, Text: "/broadcast"}, chatID, true)
|
||||
|
||||
state, ok := userStateMgr.get(chatUser{chatID: chatID, userID: chatID})
|
||||
if !ok || state != broadcastAwaitingText {
|
||||
t.Fatalf("state = %q (ok=%v), want %q", state, ok, broadcastAwaitingText)
|
||||
}
|
||||
}
|
||||
|
||||
func TestDeliverBroadcastCopy(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
draft broadcastDraft
|
||||
wantMethods map[string]int
|
||||
check func(t *testing.T, bodies func(string) []map[string]any)
|
||||
}{
|
||||
{
|
||||
name: "a single message rides copyMessage",
|
||||
draft: broadcastDraft{FromChatID: 55, MessageIDs: []int{7}},
|
||||
wantMethods: map[string]int{"copyMessage": 1},
|
||||
check: func(t *testing.T, bodies func(string) []map[string]any) {
|
||||
body := bodies("copyMessage")[0]
|
||||
if fmt.Sprint(body["from_chat_id"]) != "55" || fmt.Sprint(body["message_id"]) != "7" {
|
||||
t.Errorf("copy body = %v, want from 55 message 7", body)
|
||||
}
|
||||
},
|
||||
},
|
||||
{
|
||||
name: "an album rides one copyMessages call",
|
||||
draft: broadcastDraft{FromChatID: 55, MessageIDs: []int{1, 2, 3}},
|
||||
wantMethods: map[string]int{"copyMessages": 1, "copyMessage": 0},
|
||||
check: func(t *testing.T, bodies func(string) []map[string]any) {
|
||||
if fmt.Sprint(bodies("copyMessages")[0]["message_ids"]) != "[1 2 3]" {
|
||||
t.Errorf("message_ids = %v, want [1 2 3]", bodies("copyMessages")[0]["message_ids"])
|
||||
}
|
||||
},
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
// A fresh mock per case keeps the per-method counts independent.
|
||||
url, calls, bodies := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
|
||||
if err := deliverBroadcastCopy(66, tt.draft); err != nil {
|
||||
t.Fatalf("deliverBroadcastCopy() error = %v", err)
|
||||
}
|
||||
for method, want := range tt.wantMethods {
|
||||
if got := calls(method); got != want {
|
||||
t.Errorf("%s calls = %d, want %d", method, got, want)
|
||||
}
|
||||
}
|
||||
if tt.check != nil {
|
||||
tt.check(t, bodies)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// Regression: a media group used to produce one draft per photo, so three
|
||||
// photos meant three previews and only the last tapped one was delivered.
|
||||
func TestHandleBroadcastInputMediaGroup(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, calls, bodies := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
swapAlbumDebounce(t, 20*time.Millisecond)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
setBroadcastAdmins(t, []int64{5000})
|
||||
|
||||
const chatID = int64(9109)
|
||||
resetBroadcastState(t)
|
||||
createBroadcastInbound(t, "in-1", broadcastClientsJSON(t, 601))
|
||||
|
||||
// Updates of one album arrive out of order and copyMessages demands
|
||||
// strictly increasing ids, so the draft must sort them.
|
||||
for _, id := range []int{103, 101, 102} {
|
||||
composeBroadcast(tb, telego.Message{
|
||||
Chat: telego.Chat{ID: chatID},
|
||||
From: &telego.User{ID: 5000},
|
||||
MessageID: id,
|
||||
MediaGroupID: "grp9",
|
||||
Photo: []telego.PhotoSize{{FileID: "unused"}},
|
||||
})
|
||||
}
|
||||
|
||||
ids, token := waitBroadcastPending(t, chatUser{chatID: chatID, userID: 5000})
|
||||
if !slices.Equal(ids, []int{101, 102, 103}) {
|
||||
t.Fatalf("album draft ids = %v, want [101 102 103]", ids)
|
||||
}
|
||||
if token == "" {
|
||||
t.Fatalf("album draft has no confirmation token")
|
||||
}
|
||||
if state, ok := userStateMgr.get(chatUser{chatID: chatID, userID: 5000}); ok {
|
||||
t.Errorf("state = %q after the album was accepted, want cleared", state)
|
||||
}
|
||||
if got := calls("copyMessages"); got != 1 {
|
||||
t.Errorf("copyMessages calls = %d, want 1 self-copy of the whole album", got)
|
||||
}
|
||||
// copyMessages rejects ids that are not strictly increasing.
|
||||
if got := fmt.Sprint(bodies("copyMessages")[0]["message_ids"]); got != "[101 102 103]" {
|
||||
t.Errorf("self-copy message_ids = %v, want [101 102 103]", got)
|
||||
}
|
||||
deadline := time.Now().Add(2 * time.Second)
|
||||
for time.Now().Before(deadline) && calls("sendMessage") == 0 {
|
||||
time.Sleep(2 * time.Millisecond)
|
||||
}
|
||||
if calls("sendMessage") != 1 {
|
||||
t.Errorf("sendMessage calls = %d, want 1 confirmation card", calls("sendMessage"))
|
||||
}
|
||||
}
|
||||
|
||||
func TestHandleBroadcastInputSingleMessage(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, calls, bodies := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
setBroadcastAdmins(t, []int64{5000})
|
||||
|
||||
const chatID = int64(9104)
|
||||
resetBroadcastState(t)
|
||||
createBroadcastInbound(t, "in-1", broadcastClientsJSON(t, 602))
|
||||
|
||||
composeBroadcast(tb, telego.Message{
|
||||
Chat: telego.Chat{ID: chatID},
|
||||
From: &telego.User{ID: 5000},
|
||||
MessageID: 42,
|
||||
Text: "hello all",
|
||||
})
|
||||
|
||||
ids, token := waitBroadcastPending(t, chatUser{chatID: chatID, userID: 5000})
|
||||
if !slices.Equal(ids, []int{42}) {
|
||||
t.Fatalf("draft ids = %v, want a reference to message 42", ids)
|
||||
}
|
||||
if got := calls("copyMessage"); got != 1 {
|
||||
t.Errorf("copyMessage calls = %d, want 1 self-copy preview", got)
|
||||
}
|
||||
card := bodies("sendMessage")[0]
|
||||
confirmData := card["reply_markup"].(map[string]any)["inline_keyboard"].([]any)[0].([]any)[0].(map[string]any)["callback_data"]
|
||||
if confirmData != "broadcast_confirm "+token {
|
||||
t.Errorf("card button = %v, want a confirm bound to the pending token %q", confirmData, token)
|
||||
}
|
||||
}
|
||||
|
||||
// Regression: tapping Send on a superseded preview card delivered whatever
|
||||
// draft happened to be pending instead of the card's own composition.
|
||||
func TestBroadcastConfirmStaleTokenRejected(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, calls, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
setBroadcastAdmins(t, []int64{5000})
|
||||
|
||||
const chatID = int64(9112)
|
||||
resetBroadcastState(t)
|
||||
createBroadcastInbound(t, "in-1", broadcastClientsJSON(t, 603))
|
||||
|
||||
composeBroadcast(tb, telego.Message{Chat: telego.Chat{ID: chatID}, From: &telego.User{ID: 5000}, MessageID: 11, Text: "first"})
|
||||
_, staleToken := waitBroadcastPending(t, chatUser{chatID: chatID, userID: 5000})
|
||||
|
||||
// A second composition replaces the first, so the first card goes stale.
|
||||
composeBroadcast(tb, telego.Message{Chat: telego.Chat{ID: chatID}, From: &telego.User{ID: 5000}, MessageID: 12, Text: "second"})
|
||||
ids, liveToken := waitBroadcastPending(t, chatUser{chatID: chatID, userID: 5000})
|
||||
if !slices.Equal(ids, []int{12}) {
|
||||
t.Fatalf("draft ids = %v, want only the second message", ids)
|
||||
}
|
||||
previewCopies := calls("copyMessage")
|
||||
|
||||
tb.answerCallback(&telego.CallbackQuery{
|
||||
ID: "stale",
|
||||
From: telego.User{ID: 5000},
|
||||
Data: "broadcast_confirm " + staleToken,
|
||||
Message: &telego.Message{Chat: telego.Chat{ID: chatID}, MessageID: 5},
|
||||
}, true)
|
||||
if calls("copyMessage") != previewCopies {
|
||||
t.Fatalf("a stale token started deliveries")
|
||||
}
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.Fatalf("a stale token started a runner")
|
||||
}
|
||||
|
||||
tb.answerCallback(&telego.CallbackQuery{
|
||||
ID: "live",
|
||||
From: telego.User{ID: 5000},
|
||||
Data: "broadcast_confirm " + liveToken,
|
||||
Message: &telego.Message{Chat: telego.Chat{ID: chatID}, MessageID: 6},
|
||||
}, true)
|
||||
waitBroadcastFinished(t)
|
||||
if calls("copyMessage") != previewCopies+1 {
|
||||
t.Errorf("copyMessage calls = %d, want %d (the live draft delivered once)", calls("copyMessage"), previewCopies+1)
|
||||
}
|
||||
}
|
||||
|
||||
// Regression: composition stayed keyed by chat after the state moved to the
|
||||
// admin, so a second admin's draft in a group dropped the first admin's.
|
||||
func TestBroadcastComposesArePerAdmin(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, _, bodies := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
const groupChat, adminA, adminB = int64(-1009113), int64(5000), int64(5001)
|
||||
setBroadcastAdmins(t, []int64{adminA, adminB})
|
||||
resetBroadcastState(t)
|
||||
createBroadcastInbound(t, "in-1", broadcastClientsJSON(t, 604))
|
||||
|
||||
composeBroadcast(tb, telego.Message{Chat: telego.Chat{ID: groupChat}, From: &telego.User{ID: adminA}, MessageID: 21, Text: "from A"})
|
||||
composeBroadcast(tb, telego.Message{Chat: telego.Chat{ID: groupChat}, From: &telego.User{ID: adminB}, MessageID: 22, Text: "from B"})
|
||||
cards := bodies("sendMessage")
|
||||
if len(cards) != 2 {
|
||||
t.Fatalf("sendMessage calls = %d, want one preview card per admin", len(cards))
|
||||
}
|
||||
|
||||
// Each admin confirms their own card, A first; each run must deliver its own draft.
|
||||
for i, admin := range []int64{adminA, adminB} {
|
||||
confirm := cards[i]["reply_markup"].(map[string]any)["inline_keyboard"].([]any)[0].([]any)[0].(map[string]any)["callback_data"].(string)
|
||||
tb.answerCallback(&telego.CallbackQuery{
|
||||
ID: "q",
|
||||
From: telego.User{ID: admin},
|
||||
Data: confirm,
|
||||
Message: &telego.Message{Chat: telego.Chat{ID: groupChat}, MessageID: 30 + i},
|
||||
}, true)
|
||||
waitBroadcastFinished(t)
|
||||
}
|
||||
|
||||
var delivered []string
|
||||
for _, body := range bodies("copyMessage") {
|
||||
if fmt.Sprint(body["chat_id"]) == "604" {
|
||||
delivered = append(delivered, fmt.Sprint(body["message_id"]))
|
||||
}
|
||||
}
|
||||
if !slices.Equal(delivered, []string{"21", "22"}) {
|
||||
t.Errorf("messages delivered to the client = %v, want [21 22]: each admin's own draft", delivered)
|
||||
}
|
||||
}
|
||||
|
||||
func waitBroadcastFinished(t *testing.T) {
|
||||
t.Helper()
|
||||
deadline := time.Now().Add(2 * time.Second)
|
||||
for time.Now().Before(deadline) {
|
||||
if broadcastCurrentRunner() == nil {
|
||||
return
|
||||
}
|
||||
time.Sleep(2 * time.Millisecond)
|
||||
}
|
||||
t.Fatal("broadcast did not finish in time")
|
||||
}
|
||||
|
||||
func TestConfirmBroadcastEndToEnd(t *testing.T) {
|
||||
broadcastLocalizer(t)
|
||||
url, calls, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
setBroadcastRunning(t, true)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
setBroadcastAdmins(t, []int64{5000})
|
||||
|
||||
const chatID = int64(9105)
|
||||
resetBroadcastState(t)
|
||||
|
||||
createBroadcastInbound(t, "in-1", broadcastClientsJSON(t, 501, 502))
|
||||
composeBroadcast(tb, telego.Message{Chat: telego.Chat{ID: chatID}, From: &telego.User{ID: 5000}, MessageID: 9, Text: "hi"})
|
||||
_, token := waitBroadcastPending(t, chatUser{chatID: chatID, userID: 5000})
|
||||
|
||||
tb.answerCallback(&telego.CallbackQuery{
|
||||
ID: "q1",
|
||||
From: telego.User{ID: 5000},
|
||||
Data: "broadcast_confirm " + token,
|
||||
Message: &telego.Message{Chat: telego.Chat{ID: chatID}, MessageID: 5},
|
||||
}, true)
|
||||
|
||||
waitBroadcastFinished(t)
|
||||
|
||||
// One preview self-copy plus two deliveries; the card is edited into the
|
||||
// progress card and then into the summary, so nothing is sent twice.
|
||||
if got := calls("copyMessage"); got != 3 {
|
||||
t.Errorf("copyMessage calls = %d, want 3 (preview + 2 deliveries)", got)
|
||||
}
|
||||
if got := calls("sendMessage"); got != 1 {
|
||||
t.Errorf("sendMessage calls = %d, want 1 confirmation card", got)
|
||||
}
|
||||
if got := calls("editMessageText"); got != 2 {
|
||||
t.Errorf("editMessageText calls = %d, want 2 (progress + summary)", got)
|
||||
}
|
||||
if got := calls("answerCallbackQuery"); got != 1 {
|
||||
t.Errorf("answerCallbackQuery calls = %d, want 1", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestConfirmBroadcastWithoutDraftAnswersError(t *testing.T) {
|
||||
url, calls, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
const chatID = int64(9106)
|
||||
resetBroadcastState(t)
|
||||
|
||||
tb.answerCallback(&telego.CallbackQuery{
|
||||
ID: "q1",
|
||||
From: telego.User{ID: chatID},
|
||||
Data: "broadcast_confirm sometoken",
|
||||
Message: &telego.Message{Chat: telego.Chat{ID: chatID}, MessageID: 5},
|
||||
}, true)
|
||||
|
||||
if calls("answerCallbackQuery") != 1 {
|
||||
t.Errorf("answerCallbackQuery calls = %d, want 1 error answer", calls("answerCallbackQuery"))
|
||||
}
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.Errorf("a confirm without a draft must not start a broadcast")
|
||||
}
|
||||
}
|
||||
|
||||
func TestBroadcastCancelCallbackClearsDraft(t *testing.T) {
|
||||
url, calls, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
|
||||
const chatID = int64(9107)
|
||||
resetBroadcastState(t)
|
||||
|
||||
admin := chatUser{chatID: chatID, userID: chatID}
|
||||
userStateMgr.set(admin, broadcastAwaitingText)
|
||||
broadcastComposes[admin] = &broadcastCompose{messageIDs: []int{9}, token: "tok9"}
|
||||
|
||||
tb.answerCallback(&telego.CallbackQuery{
|
||||
ID: "q1",
|
||||
From: telego.User{ID: chatID},
|
||||
Data: "broadcast_cancel",
|
||||
Message: &telego.Message{Chat: telego.Chat{ID: chatID}, MessageID: 9},
|
||||
}, true)
|
||||
|
||||
if _, ok := userStateMgr.get(admin); ok {
|
||||
t.Errorf("state survived the cancel tap")
|
||||
}
|
||||
if _, _, ok := broadcastPendingDraft(admin); ok {
|
||||
t.Errorf("draft survived the cancel tap")
|
||||
}
|
||||
if got := calls("deleteMessage"); got != 1 {
|
||||
t.Errorf("deleteMessage calls = %d, want 1", got)
|
||||
}
|
||||
if got := calls("answerCallbackQuery"); got != 1 {
|
||||
t.Errorf("answerCallbackQuery calls = %d, want 1", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestBroadcastCallbacksDeniedToNonAdmin(t *testing.T) {
|
||||
url, calls, _ := newBroadcastMock(t)
|
||||
swapTestBot(t, url)
|
||||
tb := newStaleButtonTgbot(t)
|
||||
|
||||
const chatID = int64(9108)
|
||||
resetBroadcastState(t)
|
||||
|
||||
for _, data := range []string{"broadcast_confirm sometoken", "broadcast_cancel"} {
|
||||
tb.answerCallback(&telego.CallbackQuery{
|
||||
ID: "q1",
|
||||
From: telego.User{ID: 999999},
|
||||
Data: data,
|
||||
Message: &telego.Message{Chat: telego.Chat{ID: chatID}, MessageID: 5},
|
||||
}, false)
|
||||
if calls("answerCallbackQuery") != 0 {
|
||||
t.Fatalf("%s answered a non-admin callback", data)
|
||||
}
|
||||
if broadcastCurrentRunner() != nil {
|
||||
t.Fatalf("%s started a broadcast for a non-admin", data)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -115,6 +115,10 @@ func (t *Tgbot) OnReceive() {
|
||||
userStateMgr.maybePrune(time.Hour)
|
||||
actor := messageActor(message)
|
||||
if userState, exists := userStateMgr.get(actor); exists {
|
||||
if userState == broadcastAwaitingText {
|
||||
t.handleBroadcastInput(&message, actor)
|
||||
return nil
|
||||
}
|
||||
// Only a wizard step touches the draft, so only it takes the lock.
|
||||
draft := addClientDrafts.forActor(actor)
|
||||
draft.Lock()
|
||||
@@ -288,6 +292,13 @@ func (t *Tgbot) answerCommand(message *telego.Message, chatId int64, isAdmin boo
|
||||
} else {
|
||||
handleUnknownCommand()
|
||||
}
|
||||
case "broadcast":
|
||||
onlyMessage = true
|
||||
if isAdmin {
|
||||
t.startBroadcast(messageActor(*message))
|
||||
} else {
|
||||
handleUnknownCommand()
|
||||
}
|
||||
default:
|
||||
handleUnknownCommand()
|
||||
}
|
||||
@@ -342,6 +353,8 @@ func (t *Tgbot) answerCallback(callbackQuery *telego.CallbackQuery, isAdmin bool
|
||||
if len(dataArray) >= 2 && len(dataArray[1]) > 0 {
|
||||
email := dataArray[1]
|
||||
switch dataArray[0] {
|
||||
case "broadcast_confirm":
|
||||
t.confirmBroadcast(actor, dataArray[1], callbackQuery.Message.GetMessageID(), callbackQuery.ID)
|
||||
case "get_clients_for_sub":
|
||||
inboundIdInt, err := strconv.Atoi(dataArray[1])
|
||||
if err != nil {
|
||||
@@ -901,6 +914,9 @@ func (t *Tgbot) answerCallback(callbackQuery *telego.CallbackQuery, isAdmin bool
|
||||
return
|
||||
} else {
|
||||
switch callbackQuery.Data {
|
||||
case "broadcast_cancel":
|
||||
t.cancelBroadcast(actor, callbackQuery.Message.GetMessageID(), callbackQuery.ID)
|
||||
return
|
||||
case "get_inbounds":
|
||||
inbounds, err := t.getInbounds()
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user