fix(clients): bound the auto-renew interval at a century

An interval renewal turned the client's reset days into milliseconds
with no bound, so a value that wraps int64 (a node reports it unchecked)
sent the catch-up loop stepping through time for seconds per client
while the traffic writer held the database. Intervals above 36500 days
no longer renew, and every client write refuses them.
This commit is contained in:
MHSanaei
2026-10-31 14:32:31 +01:00
parent 47e9ef1a07
commit 351a01ff0c
4 changed files with 29 additions and 0 deletions
@@ -76,3 +76,21 @@ func TestWeeklyRenewalSearchFailsClosed(t *testing.T) {
})
}
}
// A node reports the renewal interval unchecked; one that wraps int64 when turned into
// milliseconds made the catch-up loop step through time for seconds per client.
func TestCatchUpClientRenewalRefusesAnOversizedInterval(t *testing.T) {
now := time.Now().UnixMilli()
for _, reset := range []int{106751991167, maxClientResetDays + 1} {
traffic := &xray.ClientTraffic{Email: "c", Reset: reset, ExpiryTime: now - 86400000}
start := time.Now()
expiry, renewals := catchUpClientRenewal(traffic, now, time.UTC)
if expiry != traffic.ExpiryTime || renewals != 0 || time.Since(start) > 100*time.Millisecond {
t.Fatalf("reset %d: expiry %d, renewals %d after %v; want no renewal", reset, expiry, renewals, time.Since(start))
}
}
traffic := &xray.ClientTraffic{Email: "c", Reset: maxClientResetDays, ExpiryTime: now - 86400000}
if _, renewals := catchUpClientRenewal(traffic, now, time.UTC); renewals != 1 {
t.Fatalf("a %d-day interval renewed %d times, want once", maxClientResetDays, renewals)
}
}