fix(tgbot): read the admin list and running flag under their mutex (#6491)

Start and Stop replace adminIds under tgBotMutex, but the report cron, the
backup job and every incoming callback (checkAdmin) read it unlocked. A
concurrent read of a slice header being replaced is not a benign race: it can
observe a torn header and iterate past the backing array. The readers now take
a snapshot under the same lock, and SendMsgToTgbot uses the existing IsRunning
accessor instead of reading the flag directly.
This commit is contained in:
BlindMaster24
2026-09-13 12:46:36 +03:00
committed by GitHub
parent 7ac5277c4f
commit 615876b2eb
5 changed files with 90 additions and 7 deletions
+4 -3
View File
@@ -121,7 +121,7 @@ func splitMessageLines(block string, limit int) []string {
// SendMsgToTgbot sends a message to the Telegram bot with optional reply markup.
func (t *Tgbot) SendMsgToTgbot(chatId int64, msg string, replyMarkup ...telego.ReplyMarkup) {
if !isRunning {
if !t.IsRunning() {
return
}
@@ -180,12 +180,13 @@ func (t *Tgbot) SendMsgToTgbot(chatId int64, msg string, replyMarkup ...telego.R
// SendMsgToTgbotAdmins sends a message to all admin Telegram chats.
func (t *Tgbot) SendMsgToTgbotAdmins(msg string, replyMarkup ...telego.ReplyMarkup) {
admins := adminSnapshot()
if len(replyMarkup) > 0 {
for _, adminId := range adminIds {
for _, adminId := range admins {
t.SendMsgToTgbot(adminId, msg, replyMarkup[0])
}
} else {
for _, adminId := range adminIds {
for _, adminId := range admins {
t.SendMsgToTgbot(adminId, msg)
}
}