mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-11-14 00:55:01 +03:00
chore(frontend): update dependencies and adapt to oxlint 1.79
npm install was failing with ERESOLVE: the lockfile pinned storybook 10.5.7 and vitest 4.1.10 as peers while package.json asked for ^10.5.9 and ^4.1.11, and npm would not move either. Neither npm update, a targeted install, nor --package-lock-only broke the cycle, so node_modules and package-lock.json were regenerated from scratch (601 packages, 0 vulnerabilities). oxlint 1.79.0 then promoted five React Compiler rules into the correctness category, flagging 101 pre-existing sites. 1.78.0 exits 0 on the same tree, so nothing in our code changed - the rule set grew. They are fixed rather than suppressed: - refs (31): latest-value ref writes moved out of render into an effect. onlineClientsRef turned out to be write-only and is gone; expireDiffRef and trafficDiffRef were replaced by reading the values directly. - set-state-in-effect (55): reset-on-open modals now adjust state during render; where an effect mixed a synchronous reset with an async fetch, the reset moved to render and the effect kept only the request. useMediaQuery became useSyncExternalStore. - preserve-manual-memoization (11): optional-chained deps the compiler cannot match, hoisted to locals or dropped where the memo wrapped a string concat. - purity (3): Date.now() in render replaced by a state-backed clock, which also refreshes the expiry tag every 60s instead of freezing it until the next unrelated re-render. - immutability (1): applyClientStatsEvent merged websocket traffic into DBInbound rows in place; it now rebuilds only the rows it touches. Two things fell out of that. clientCount is derived with useMemo instead of an imperative rebuildClientCount() called from five sites, which also fixes a staleness bug where changing the expiry or traffic threshold left the counts alone until some later rebuild. statsVersion existed only to force a re-render after an in-place mutation, is meaningless now that rows are replaced, and nothing read it, so it is removed. Also adds a lint:fix script - oxlint --fix was previously only reachable through the lint-staged hook.
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { useEffect, useMemo, useState } from 'react';
|
||||
import { useMemo, useState } from 'react';
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { Collapse, Modal } from 'antd';
|
||||
import type { CollapseProps } from 'antd';
|
||||
@@ -54,8 +54,24 @@ export default function QrCodeModal({
|
||||
const [subJsonLink, setSubJsonLink] = useState('');
|
||||
const [activeKey, setActiveKey] = useState<string[]>([]);
|
||||
|
||||
useEffect(() => {
|
||||
if (!open || !dbInbound) return;
|
||||
// Building the links is a pure function of the props, so it runs during
|
||||
// render; an effect would paint the previous inbound's QR first.
|
||||
const [syncedProps, setSyncedProps] = useState<{
|
||||
dbInbound: typeof dbInbound;
|
||||
client: typeof client;
|
||||
nodeAddress: typeof nodeAddress;
|
||||
subSettings: typeof subSettings;
|
||||
} | null>(null);
|
||||
if (
|
||||
open &&
|
||||
dbInbound &&
|
||||
(syncedProps === null ||
|
||||
syncedProps.dbInbound !== dbInbound ||
|
||||
syncedProps.client !== client ||
|
||||
syncedProps.nodeAddress !== nodeAddress ||
|
||||
syncedProps.subSettings !== subSettings)
|
||||
) {
|
||||
setSyncedProps({ dbInbound, client, nodeAddress, subSettings });
|
||||
const inbound = inboundFromDb(dbInbound);
|
||||
const fallbackHostname = preferPublicHost(
|
||||
window.location.hostname,
|
||||
@@ -105,7 +121,7 @@ export default function QrCodeModal({
|
||||
}
|
||||
setSubLink(nextSub);
|
||||
setSubJsonLink(nextSubJson);
|
||||
}, [open, dbInbound, client, nodeAddress, subSettings]);
|
||||
}
|
||||
|
||||
const qrItems = useMemo<QrItem[]>(() => {
|
||||
const items: QrItem[] = [];
|
||||
@@ -158,13 +174,12 @@ export default function QrCodeModal({
|
||||
[qrItems],
|
||||
);
|
||||
|
||||
useEffect(() => {
|
||||
if (!open) {
|
||||
setActiveKey([]);
|
||||
return;
|
||||
}
|
||||
setActiveKey(qrItems.length > 0 ? [qrItems[0].key] : []);
|
||||
}, [open, qrItems]);
|
||||
const firstKey = open && qrItems.length > 0 ? qrItems[0].key : null;
|
||||
const [syncedFirstKey, setSyncedFirstKey] = useState<string | null>(null);
|
||||
if (firstKey !== syncedFirstKey) {
|
||||
setSyncedFirstKey(firstKey);
|
||||
setActiveKey(firstKey ? [firstKey] : []);
|
||||
}
|
||||
|
||||
return (
|
||||
<Modal
|
||||
|
||||
Reference in New Issue
Block a user