From eef1c1eb6a27e3636cc15c0382e500d27c3c63ca Mon Sep 17 00:00:00 2001 From: MHSanaei Date: Fri, 2 Oct 2026 14:36:47 +0200 Subject: [PATCH] fix(maskcompat): size xdns domain list from domains alone CodeQL (go/allocation-size-overflow, alerts #115/#116) flagged the len(rawDomains)+len(rawResolvers) capacity hint. The sum cannot overflow in practice, but the hint bought nothing: resolver-derived domains are deduplicated and append grows the slice as needed. --- internal/util/maskcompat/xdns.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/util/maskcompat/xdns.go b/internal/util/maskcompat/xdns.go index 7c50c9ceb..6a2091e51 100644 --- a/internal/util/maskcompat/xdns.go +++ b/internal/util/maskcompat/xdns.go @@ -34,7 +34,7 @@ func upgradeLegacyXdnsSettings(settings map[string]any) bool { if !hasLegacyXdnsEntry(rawDomains) && !hasLegacyXdnsEntry(rawResolvers) { return false } - domains := make([]any, 0, len(rawDomains)+len(rawResolvers)) + domains := make([]any, 0, len(rawDomains)) listed := map[string]bool{} addDomain := func(domain map[string]any) { key, _ := domain["name"].(string)