mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-10-13 09:25:14 +03:00
fix(inbounds): refuse 2022-blake3-chacha20-poly1305 on shadowsocks inbounds
xray-core builds a Shadowsocks-2022 inbound with users only for the AES methods: the multi-user identity header is AES-only, so the config builder and the multi-user server both reject chacha20. Every panel inbound carries clients, so picking 2022-blake3-chacha20-poly1305 in the inbound form kept the whole core from starting; its links also failed on the client with "multi-key is not supported". The inbound form no longer offers the method and AddInbound/UpdateInbound reject it. Startup moves stored inbounds to 2022-blake3-aes-256-gcm, which takes the same 32-byte keys, so every stored key stays valid. Outbounds keep the method, since a single-key outbound to such a server works. The share-link generator drops the single-user branch that only this method reached.
This commit is contained in:
@@ -181,6 +181,9 @@ func initModels() error {
|
||||
if err := migrateShadowsocksRemovedCiphers(); err != nil {
|
||||
return err
|
||||
}
|
||||
if err := migrateShadowsocks2022ChachaInbounds(); err != nil {
|
||||
return err
|
||||
}
|
||||
if err := repairShadowsocks2022ServerKeys(); err != nil {
|
||||
return err
|
||||
}
|
||||
@@ -990,6 +993,36 @@ func migrateShadowsocksRemovedCiphers() error {
|
||||
return nil
|
||||
}
|
||||
|
||||
// migrateShadowsocks2022ChachaInbounds moves 2022-chacha20 inbounds, which the core
|
||||
// refuses with users, to aes-256-gcm: same 32-byte keys, so all keys stay valid.
|
||||
func migrateShadowsocks2022ChachaInbounds() error {
|
||||
var inbounds []model.Inbound
|
||||
if err := db.Where("protocol = ?", model.Shadowsocks).Find(&inbounds).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
for _, inbound := range inbounds {
|
||||
var settings map[string]any
|
||||
if json.Unmarshal([]byte(inbound.Settings), &settings) != nil {
|
||||
continue
|
||||
}
|
||||
method, _ := settings["method"].(string)
|
||||
if !xray.Shadowsocks2022NoMultiUser(method) {
|
||||
continue
|
||||
}
|
||||
settings["method"] = "2022-blake3-aes-256-gcm"
|
||||
newSettings, err := json.MarshalIndent(settings, "", " ")
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if err := db.Model(&model.Inbound{}).Where("id = ?", inbound.Id).
|
||||
Update("settings", string(newSettings)).Error; err != nil {
|
||||
return err
|
||||
}
|
||||
log.Printf("Inbound %q: switched %s to 2022-blake3-aes-256-gcm; its share links changed", inbound.Tag, method)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// repairShadowsocks2022ServerKeys replaces a stored server key xray-core cannot
|
||||
// parse; that inbound never worked, as the core refuses to start with it.
|
||||
func repairShadowsocks2022ServerKeys() error {
|
||||
|
||||
@@ -67,3 +67,55 @@ func TestRepairShadowsocks2022ServerKeys(t *testing.T) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// A stored 2022-chacha20 inbound never let xray-core start; aes-256-gcm takes the
|
||||
// same 32-byte keys, so switching keeps every stored key valid.
|
||||
func TestMigrateShadowsocks2022ChachaInbounds(t *testing.T) {
|
||||
dbDir := t.TempDir()
|
||||
t.Setenv("XUI_DB_FOLDER", dbDir)
|
||||
if err := InitDB(filepath.Join(dbDir, "x-ui.db")); err != nil {
|
||||
t.Fatalf("InitDB: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { _ = CloseDB() })
|
||||
|
||||
key := base64.StdEncoding.EncodeToString([]byte("0123456789abcdef0123456789abcdef"))
|
||||
rows := map[string]struct{ settings, wantMethod string }{
|
||||
"chacha": {`{"method":"2022-blake3-chacha20-poly1305","password":"` + key + `","clients":[{"email":"c","password":"` + key + `"}]}`, "2022-blake3-aes-256-gcm"},
|
||||
"legacy chacha": {`{"method":"chacha20-ietf-poly1305","clients":[{"email":"l","password":"p"}]}`, "chacha20-ietf-poly1305"},
|
||||
}
|
||||
port := 31200
|
||||
for tag, r := range rows {
|
||||
port++
|
||||
ib := model.Inbound{UserId: 1, Port: port, Protocol: model.Shadowsocks, Tag: tag, Settings: r.settings}
|
||||
if err := GetDB().Create(&ib).Error; err != nil {
|
||||
t.Fatalf("create %s: %v", tag, err)
|
||||
}
|
||||
}
|
||||
|
||||
if err := migrateShadowsocks2022ChachaInbounds(); err != nil {
|
||||
t.Fatalf("migrateShadowsocks2022ChachaInbounds: %v", err)
|
||||
}
|
||||
|
||||
for tag, r := range rows {
|
||||
var ib model.Inbound
|
||||
if err := GetDB().Where("tag = ?", tag).First(&ib).Error; err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
var got struct {
|
||||
Method string `json:"method"`
|
||||
Password string `json:"password"`
|
||||
Clients []struct {
|
||||
Password string `json:"password"`
|
||||
} `json:"clients"`
|
||||
}
|
||||
if err := json.Unmarshal([]byte(ib.Settings), &got); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got.Method != r.wantMethod {
|
||||
t.Errorf("%s: method %q, want %q", tag, got.Method, r.wantMethod)
|
||||
}
|
||||
if tag == "chacha" && (got.Password != key || got.Clients[0].Password != key) {
|
||||
t.Errorf("%s: keys changed to server=%q client=%q, want both kept", tag, got.Password, got.Clients[0].Password)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user