Files
3x-ui/internal/amneziawgnet/relay.go
T
MHSanaei ac896a9f95 fix(amneziawg): drop a removed client's flows before its address is reused
Removing or re-keying a client reconfigured the device in place but left
its TCP and UDP flows standing, and withdrawing a port forward stopped
only new connections. The next client given the same tunnel address
inherited those flows: it could read what outside hosts sent to the
former client and write back into those connections.

After an in-place reconfigure, every stack endpoint and UDP relay
session pinned to an address whose peer was removed or changed is
aborted, and closing a port forward cuts the connections it is relaying.
2026-10-31 15:10:32 +01:00

481 lines
17 KiB
Go

// Phase 2: relaying a recovered tunnel connection into Xray's own,
// completely stock SOCKS5 inbound -- authenticating as the owning peer's
// email -- is what gives every embedded AmneziaWG connection real, native
// Xray stats/routing/sniffing with no Xray-core fork at all (Finding 3 of
// the migration plan: a stock SOCKS5 inbound sets its per-connection stats
// identity directly from the SOCKS5 auth username).
package amneziawgnet
import (
"context"
"encoding/binary"
"encoding/json"
"fmt"
"io"
"net"
"net/netip"
"sync"
"sync/atomic"
"time"
"golang.org/x/net/proxy"
"gvisor.dev/gvisor/pkg/tcpip/adapters/gonet"
"gvisor.dev/gvisor/pkg/tcpip/stack"
"github.com/mhsanaei/3x-ui/v3/internal/logger"
)
// SocksRelay describes the loopback SOCKS5 inbound decapsulated AmneziaWG
// traffic gets relayed into.
type SocksRelay struct {
// Addr is the SOCKS5 inbound's own address, e.g. "127.0.0.1:11500".
Addr string
// Password is shared across every account. This traffic never leaves
// loopback, so the password is not a real secrecy boundary -- it only
// needs to satisfy Xray's SOCKS5 inbound requiring *some* username/
// password auth before it will accept a connection and use the
// username as the stats identity. Document this reasoning wherever a
// caller generates or displays it, so it's never mistaken later for a
// real credential.
Password string
}
// SocksInboundSettings builds the JSON `settings` block for a stock Xray
// SOCKS5 inbound with one username/password account per email, all sharing
// password (see SocksRelay's doc comment). udp:true is required: RelayUDP
// depends on the inbound accepting UDP ASSOCIATE, not just CONNECT.
func SocksInboundSettings(emails []string, password string) ([]byte, error) {
type account struct {
User string `json:"user"`
Pass string `json:"pass"`
}
settings := struct {
Auth string `json:"auth"`
UDP bool `json:"udp"`
Accounts []account `json:"accounts"`
}{Auth: "password", UDP: true}
for _, email := range emails {
settings.Accounts = append(settings.Accounts, account{User: email, Pass: password})
}
return json.Marshal(settings)
}
// RelayTCP dials r.Addr, authenticates as email, issues a SOCKS5 CONNECT to
// dest, and pipes bytes both ways until both directions end.
// Blocks until the relay ends; meant to be called from (or as) an
// AttachTCPForwarder handler, which already runs each connection on its own
// goroutine.
func (r SocksRelay) RelayTCP(conn *gonet.TCPConn, email string, dest netip.AddrPort) {
defer conn.Close()
auth := &proxy.Auth{User: email, Password: r.Password}
dialer, err := proxy.SOCKS5("tcp", r.Addr, auth, proxy.Direct)
if err != nil {
logger.Warningf("amneziawgnet: RelayTCP: build SOCKS5 dialer: %v", err)
return
}
upstream, err := dialer.Dial("tcp", dest.String())
if err != nil {
logger.Warningf("amneziawgnet: RelayTCP: SOCKS5 CONNECT to %s as %q: %v", dest, email, err)
return
}
defer upstream.Close()
pipeBothWays(conn, upstream)
}
// halfCloseIdle bounds how long the surviving direction of a half-closed pair
// may sit idle, so a peer that vanished mid-transfer cannot pin it forever.
const halfCloseIdle = 2 * time.Minute
// closeWriter is the half-close half of *net.TCPConn and *gonet.TCPConn.
type closeWriter interface{ CloseWrite() error }
// guardedReader reads one side of a relayed pair, re-arming its read deadline
// on every read once armed, so the bound is an idle window, not a total one.
type guardedReader struct {
conn net.Conn
armed atomic.Bool
}
func (r *guardedReader) Read(p []byte) (int, error) {
if r.armed.Load() {
_ = r.conn.SetReadDeadline(time.Now().Add(halfCloseIdle))
}
return r.conn.Read(p)
}
// arm bounds this side's remaining reads, including one already in flight.
func (r *guardedReader) arm() {
r.armed.Store(true)
_ = r.conn.SetReadDeadline(time.Now().Add(halfCloseIdle))
}
// pipeBothWays copies a and b into each other until BOTH directions end,
// half-closing each far side in turn so a half-closed peer still gets its reply.
func pipeBothWays(a, b net.Conn) {
ga, gb := &guardedReader{conn: a}, &guardedReader{conn: b}
var wg sync.WaitGroup
wg.Add(2)
// Arming dst bounds the direction still reading from it -- the one this
// copy just signalled EOF to.
pipe := func(dst, src *guardedReader) {
defer wg.Done()
_, _ = io.Copy(dst.conn, src)
if cw, ok := dst.conn.(closeWriter); ok {
_ = cw.CloseWrite()
} else {
_ = dst.conn.Close()
}
dst.arm()
}
go pipe(gb, ga)
go pipe(ga, gb)
wg.Wait()
}
// socks5UDPSession is one established SOCKS5 UDP ASSOCIATE session: udpConn
// is the actual socket packets are sent to (and replies read from); ctrl is
// the TCP control connection that must stay open for the session's
// lifetime -- per RFC 1928, closing it tears the association down.
type socks5UDPSession struct {
ctrl net.Conn
udpConn *net.UDPConn
}
// Bounds dial plus the greeting/auth/associate reads: an accepted-but-silent
// server otherwise parks Handle, and with it the tunnel's delivery path.
var socks5AssociateTimeout = 5 * time.Second
// newSocks5UDPSession performs the SOCKS5 greeting, username/password auth,
// and UDP ASSOCIATE request/reply by hand: golang.org/x/net/proxy's SOCKS5
// client (used by RelayTCP above) only implements CONNECT, and xray-core's
// own proxy/socks/client.go is written against its internal transport
// types, not reusable as a standalone dialer -- so this is a small, direct,
// from-the-RFC implementation rather than an existing library call.
func newSocks5UDPSession(addr, user, password string) (*socks5UDPSession, error) {
deadline := time.Now().Add(socks5AssociateTimeout)
dialer := net.Dialer{Deadline: deadline}
ctrl, err := dialer.DialContext(context.Background(), "tcp", addr)
if err != nil {
return nil, fmt.Errorf("amneziawgnet: dial SOCKS5 control connection: %w", err)
}
_ = ctrl.SetDeadline(deadline)
if err := socks5Handshake(ctrl, user, password); err != nil {
ctrl.Close()
return nil, err
}
// UDP ASSOCIATE, dst 0.0.0.0:0 ("I don't know my own source yet, and I
// don't need to specify one for a loopback relay").
if _, err := ctrl.Write([]byte{0x05, 0x03, 0x00, 0x01, 0, 0, 0, 0, 0, 0}); err != nil {
ctrl.Close()
return nil, fmt.Errorf("amneziawgnet: send UDP ASSOCIATE request: %w", err)
}
bind, err := readSocks5Reply(ctrl)
if err != nil {
ctrl.Close()
return nil, err
}
_ = ctrl.SetDeadline(time.Time{})
udpConn, err := net.DialUDP("udp", nil, net.UDPAddrFromAddrPort(bind))
if err != nil {
ctrl.Close()
return nil, fmt.Errorf("amneziawgnet: dial SOCKS5 UDP relay endpoint %s: %w", bind, err)
}
return &socks5UDPSession{ctrl: ctrl, udpConn: udpConn}, nil
}
// socks5Handshake performs the version greeting and (if the server
// requires it) username/password auth. Xray's SOCKS5 inbound with
// auth:"password" always requires it; the no-auth branch exists so this
// helper isn't silently wrong against a differently-configured server.
func socks5Handshake(conn net.Conn, user, password string) error {
if _, err := conn.Write([]byte{0x05, 0x02, 0x00, 0x02}); err != nil {
return fmt.Errorf("amneziawgnet: send SOCKS5 greeting: %w", err)
}
var resp [2]byte
if _, err := io.ReadFull(conn, resp[:]); err != nil {
return fmt.Errorf("amneziawgnet: read SOCKS5 greeting reply: %w", err)
}
if resp[0] != 0x05 {
return fmt.Errorf("amneziawgnet: unexpected SOCKS5 version %d", resp[0])
}
switch resp[1] {
case 0x00: // no auth required
return nil
case 0x02: // username/password
req := make([]byte, 0, 3+len(user)+len(password))
req = append(req, 0x01, byte(len(user)))
req = append(req, user...)
req = append(req, byte(len(password)))
req = append(req, password...)
if _, err := conn.Write(req); err != nil {
return fmt.Errorf("amneziawgnet: send SOCKS5 auth: %w", err)
}
var authResp [2]byte
if _, err := io.ReadFull(conn, authResp[:]); err != nil {
return fmt.Errorf("amneziawgnet: read SOCKS5 auth reply: %w", err)
}
if authResp[1] != 0x00 {
return fmt.Errorf("amneziawgnet: SOCKS5 auth rejected (status %d)", authResp[1])
}
return nil
default:
return fmt.Errorf("amneziawgnet: SOCKS5 server offered unsupported auth method %d", resp[1])
}
}
// readSocks5Reply reads a SOCKS5 reply (the common format shared by CONNECT
// and UDP ASSOCIATE replies) and returns its bound address.
func readSocks5Reply(r io.Reader) (netip.AddrPort, error) {
var hdr [4]byte
if _, err := io.ReadFull(r, hdr[:]); err != nil {
return netip.AddrPort{}, fmt.Errorf("amneziawgnet: read SOCKS5 reply header: %w", err)
}
if hdr[0] != 0x05 {
return netip.AddrPort{}, fmt.Errorf("amneziawgnet: unexpected SOCKS5 reply version %d", hdr[0])
}
if hdr[1] != 0x00 {
return netip.AddrPort{}, fmt.Errorf("amneziawgnet: SOCKS5 request failed (reply code %d)", hdr[1])
}
addr, err := readSocks5Addr(r, hdr[3])
if err != nil {
return netip.AddrPort{}, err
}
var portBytes [2]byte
if _, err := io.ReadFull(r, portBytes[:]); err != nil {
return netip.AddrPort{}, fmt.Errorf("amneziawgnet: read SOCKS5 reply port: %w", err)
}
return netip.AddrPortFrom(addr, binary.BigEndian.Uint16(portBytes[:])), nil
}
// readSocks5Addr reads the address portion of a SOCKS5 reply for the given
// address type (IPv4, IPv6, or domain -- resolved locally since a loopback
// Xray inbound is not expected to reply with one, but it's cheap to handle
// correctly rather than fail oddly if it ever does).
func readSocks5Addr(r io.Reader, atyp byte) (netip.Addr, error) {
switch atyp {
case 0x01:
var b [4]byte
if _, err := io.ReadFull(r, b[:]); err != nil {
return netip.Addr{}, err
}
return netip.AddrFrom4(b), nil
case 0x04:
var b [16]byte
if _, err := io.ReadFull(r, b[:]); err != nil {
return netip.Addr{}, err
}
return netip.AddrFrom16(b), nil
case 0x03:
var l [1]byte
if _, err := io.ReadFull(r, l[:]); err != nil {
return netip.Addr{}, err
}
name := make([]byte, l[0])
if _, err := io.ReadFull(r, name); err != nil {
return netip.Addr{}, err
}
resolved, err := net.ResolveIPAddr("ip", string(name))
if err != nil {
return netip.Addr{}, fmt.Errorf("amneziawgnet: resolve SOCKS5 domain reply %q: %w", name, err)
}
addr, ok := netip.AddrFromSlice(resolved.IP)
if !ok {
return netip.Addr{}, fmt.Errorf("amneziawgnet: unparseable resolved SOCKS5 domain reply address")
}
return addr, nil
default:
return netip.Addr{}, fmt.Errorf("amneziawgnet: unsupported SOCKS5 address type %d", atyp)
}
}
// Close ends the UDP ASSOCIATE session: closing ctrl tells the SOCKS5
// server to tear down its relay side too (RFC 1928).
func (s *socks5UDPSession) Close() error {
s.udpConn.Close()
return s.ctrl.Close()
}
// sendTo wraps payload in a SOCKS5 UDP request header addressed to dest and
// sends it to the session's relay endpoint.
func (s *socks5UDPSession) sendTo(dest netip.AddrPort, payload []byte) error {
hdr := make([]byte, 0, 3+1+16+2+len(payload))
hdr = append(hdr, 0x00, 0x00, 0x00) // RSV RSV FRAG(=0, no fragmentation)
if dest.Addr().Is4() {
b := dest.Addr().As4()
hdr = append(hdr, 0x01)
hdr = append(hdr, b[:]...)
} else {
b := dest.Addr().As16()
hdr = append(hdr, 0x04)
hdr = append(hdr, b[:]...)
}
var portBytes [2]byte
binary.BigEndian.PutUint16(portBytes[:], dest.Port())
hdr = append(hdr, portBytes[:]...)
hdr = append(hdr, payload...)
_, err := s.udpConn.Write(hdr)
return err
}
// receive reads one reply datagram into buf, returning the address the
// SOCKS5 server says it came from and the actual payload (a sub-slice of
// buf -- valid only until the next receive call).
func (s *socks5UDPSession) receive(buf []byte) (netip.AddrPort, []byte, error) {
n, err := s.udpConn.Read(buf)
if err != nil {
return netip.AddrPort{}, nil, err
}
data := buf[:n]
if len(data) < 4 {
return netip.AddrPort{}, nil, fmt.Errorf("amneziawgnet: short SOCKS5 UDP reply (%d bytes)", n)
}
addr, rest, err := splitSocks5Addr(data[4:], data[3])
if err != nil {
return netip.AddrPort{}, nil, err
}
if len(rest) < 2 {
return netip.AddrPort{}, nil, fmt.Errorf("amneziawgnet: truncated SOCKS5 UDP reply port")
}
return netip.AddrPortFrom(addr, binary.BigEndian.Uint16(rest[:2])), rest[2:], nil
}
// splitSocks5Addr decodes the address at the head of b for address type atyp
// and returns it with whatever follows, length-checked at every step.
func splitSocks5Addr(b []byte, atyp byte) (netip.Addr, []byte, error) {
switch atyp {
case 0x01:
if len(b) < 4 {
return netip.Addr{}, nil, fmt.Errorf("amneziawgnet: truncated SOCKS5 IPv4 reply address")
}
return netip.AddrFrom4([4]byte(b[:4])), b[4:], nil
case 0x04:
if len(b) < 16 {
return netip.Addr{}, nil, fmt.Errorf("amneziawgnet: truncated SOCKS5 IPv6 reply address")
}
return netip.AddrFrom16([16]byte(b[:16])), b[16:], nil
case 0x03:
// Resolving here would block the receive loop on DNS, and a datagram's
// own source is an address already -- so only a literal is accepted.
if len(b) < 1 || len(b) < 1+int(b[0]) {
return netip.Addr{}, nil, fmt.Errorf("amneziawgnet: truncated SOCKS5 domain reply address")
}
name := string(b[1 : 1+int(b[0])])
addr, err := netip.ParseAddr(name)
if err != nil {
return netip.Addr{}, nil, fmt.Errorf("amneziawgnet: SOCKS5 UDP reply from non-literal address %q", name)
}
return addr, b[1+int(b[0]):], nil
default:
return netip.Addr{}, nil, fmt.Errorf("amneziawgnet: unsupported SOCKS5 address type %d", atyp)
}
}
// UDPRelay tracks one SOCKS5 UDP ASSOCIATE session per source (tunnel-
// internal client) flow, relaying each into r's SOCKS5 inbound and writing
// replies back through gstack -- the UDP counterpart of RelayTCP, meant to
// be driven by an AttachUDPHandler callback (see udp.go).
type UDPRelay struct {
relay SocksRelay
gstack *stack.Stack
// Keyed by the comparable netip.AddrPort, like udpForwardListener's own
// session map: src.String() would allocate on every relayed datagram.
mu sync.Mutex
sessions map[netip.AddrPort]*socks5UDPSession
}
// NewUDPRelay creates a UDPRelay for one embedded AmneziaWG Device's stack.
func NewUDPRelay(relay SocksRelay, gstack *stack.Stack) *UDPRelay {
return &UDPRelay{relay: relay, gstack: gstack, sessions: map[netip.AddrPort]*socks5UDPSession{}}
}
// Handle relays one packet from src (the peer's tunnel-internal source) to
// dst (its real, recovered destination), opening a fresh SOCKS5 UDP
// ASSOCIATE session for src the first time it's seen (authenticating as
// email, so Xray attributes the whole flow's stats to the right peer) and
// reusing it for subsequent packets from the same src.
func (u *UDPRelay) Handle(src, dst netip.AddrPort, email string, payload []byte) {
u.mu.Lock()
sess, ok := u.sessions[src]
u.mu.Unlock()
if !ok {
fresh, err := newSocks5UDPSession(u.relay.Addr, email, u.relay.Password)
if err != nil {
logger.Warningf("amneziawgnet: UDPRelay: SOCKS5 associate for %q: %v", email, err)
return
}
u.mu.Lock()
// Associating happens off-lock, so a concurrent Handle for the same src
// may already have published one; keep it, so the key has a single pump.
if existing, dup := u.sessions[src]; dup {
u.mu.Unlock()
fresh.Close()
sess = existing
} else {
u.sessions[src] = fresh
u.mu.Unlock()
sess = fresh
go u.pump(src, fresh)
}
}
if err := sess.sendTo(dst, payload); err != nil {
logger.Warningf("amneziawgnet: UDPRelay: send to %s: %v", dst, err)
}
}
// pump reads replies from sess and writes them back into the tunnel toward
// src until the session errors out or goes idle for 2 minutes, then tears
// it down -- both the map entry and the underlying SOCKS5 association.
func (u *UDPRelay) pump(src netip.AddrPort, sess *socks5UDPSession) {
defer func() {
u.mu.Lock()
// Only retire our own entry: a delete by key alone would evict whichever
// session currently holds src, orphaning a live one.
if u.sessions[src] == sess {
delete(u.sessions, src)
}
u.mu.Unlock()
sess.Close()
}()
buf := make([]byte, 65536)
for {
_ = sess.udpConn.SetReadDeadline(time.Now().Add(2 * time.Minute))
from, payload, err := sess.receive(buf)
if err != nil {
return
}
if err := WriteUDPReply(u.gstack, from, src, payload); err != nil {
logger.Warningf("amneziawgnet: UDPRelay: reply write: %v", err)
}
}
}
// CloseSessions tears down the sessions whose tunnel-internal source address
// matches; pump retires each one's goroutine on the resulting read error.
func (u *UDPRelay) CloseSessions(match func(netip.Addr) bool) {
u.mu.Lock()
defer u.mu.Unlock()
for k, s := range u.sessions {
if match(k.Addr()) {
s.Close()
delete(u.sessions, k)
}
}
}
// Close tears down every open session. Call when the owning Device is
// closed.
func (u *UDPRelay) Close() {
u.mu.Lock()
defer u.mu.Unlock()
for k, s := range u.sessions {
s.Close()
delete(u.sessions, k)
}
}