Files
3x-ui/internal/tuic/manager.go
T
Egor 207c705300 fix(tuic): preserve client identity for Xray user routing (#6875)
TUIC traffic reached Xray through a loopback SOCKS relay that took no login,
so Xray never learned which client a connection belonged to and user routing
rules never matched TUIC (#6874). The relay now carries one account per client
email, so per-user rules match on TCP and both UDP modes; admission stays with
the native TUIC server.

Adding, removing or renaming a TUIC client swaps only that inbound's relay
instead of restarting Xray: new sessions wait behind a bounded gate while live
streams and UDP associations continue, accounts are verified after the swap and
rolled back on failure, one failing relay no longer strands the others or blocks
unrelated live changes, and emails over SOCKS5's 255-byte limit are excluded
with a warning.
2026-10-24 06:20:39 +02:00

265 lines
6.1 KiB
Go

package tuic
import (
"fmt"
"sync"
"time"
"github.com/mhsanaei/3x-ui/v3/internal/logger"
)
type managed struct {
server *Server
tag string
structuralFP string
usersFP string
}
type Manager struct {
mu sync.Mutex
servers map[int]*managed
lastStartErr map[int]string
pendingTraffic map[string]ClientTrafficDelta
}
var (
managerInstance *Manager
managerOnce sync.Once
)
func GetManager() *Manager {
managerOnce.Do(func() {
managerInstance = &Manager{
servers: make(map[int]*managed),
lastStartErr: make(map[int]string),
pendingTraffic: make(map[string]ClientTrafficDelta),
}
})
return managerInstance
}
func (m *Manager) HasRunning() bool {
m.mu.Lock()
defer m.mu.Unlock()
for _, mg := range m.servers {
if mg.server != nil && mg.server.IsRunning() {
return true
}
}
return false
}
func (m *Manager) Ensure(inst Instance) error {
m.mu.Lock()
defer m.mu.Unlock()
return m.ensureLocked(inst)
}
func (m *Manager) ensureLocked(inst Instance) error {
if err := ValidateClients(inst.Clients); err != nil {
return err
}
if len(inst.Clients) == 0 {
m.removeLocked(inst.Id)
return nil
}
structuralFP := inst.StructuralFingerprint()
usersFP := inst.UsersFingerprint()
if existing, ok := m.servers[inst.Id]; ok && existing != nil {
if existing.server != nil && existing.server.IsRunning() && existing.structuralFP == structuralFP {
existing.tag = inst.Tag
existing.server.UpdateRuntimeSettings(inst.Tag, inst.CongestionControl, inst.LogLevel)
if existing.usersFP != usersFP {
existing.usersFP = usersFP
existing.server.UpdateUsers(inst.Clients)
}
return nil
}
m.stopAndDrainLocked(existing)
delete(m.servers, inst.Id)
}
server, err := m.startLocked(inst)
if err != nil {
if m.lastStartErr[inst.Id] != err.Error() {
m.lastStartErr[inst.Id] = err.Error()
if tuicLogWarn >= parseLogLevel(inst.LogLevel) {
logger.Warningf("tuic: inbound %d (%s): failed to start server: %v", inst.Id, inst.Tag, err)
}
}
return err
}
delete(m.lastStartErr, inst.Id)
m.servers[inst.Id] = &managed{
server: server,
tag: inst.Tag,
structuralFP: structuralFP,
usersFP: usersFP,
}
return nil
}
func (m *Manager) startLocked(inst Instance) (*Server, error) {
relay := &SocksRelay{
Gate: ManagedRelayGate(SOCKSPortForInbound(inst.Id)),
InboundID: inst.Id,
Addr: fmt.Sprintf("127.0.0.1:%d", SOCKSPortForInbound(inst.Id)),
Password: SocksPassword(),
}
server, err := NewServer(inst, relay)
if err != nil {
return nil, fmt.Errorf("tuic: init server for %d: %w", inst.Id, err)
}
if err := server.Start(); err != nil {
return nil, fmt.Errorf("tuic: start server on %s for %d: %w", inst.BindTo(), inst.Id, err)
}
return server, nil
}
func (m *Manager) stopAndDrainLocked(mg *managed) {
if mg == nil || mg.server == nil {
return
}
_ = mg.server.Close()
m.appendPendingTrafficLocked(mg.server.CollectClientTraffic())
}
func (m *Manager) appendPendingTrafficLocked(deltas []ClientTrafficDelta) {
if m.pendingTraffic == nil {
m.pendingTraffic = make(map[string]ClientTrafficDelta)
}
for _, delta := range deltas {
key := delta.Email
if delta.TrafficID > 0 {
key = fmt.Sprintf("traffic:%d", delta.TrafficID)
}
if delta.TrafficID == 0 && delta.InboundID > 0 && delta.UUID != "" {
key = fmt.Sprintf("%d:%s", delta.InboundID, delta.UUID)
}
current := m.pendingTraffic[key]
current.Email = delta.Email
current.UUID = delta.UUID
current.InboundID = delta.InboundID
current.TrafficID = delta.TrafficID
current.Up += delta.Up
current.Down += delta.Down
m.pendingTraffic[key] = current
}
}
func (m *Manager) RequeueClientTraffic(deltas []ClientTrafficDelta) {
m.mu.Lock()
defer m.mu.Unlock()
m.appendPendingTrafficLocked(deltas)
}
func (m *Manager) GetActiveClients(window time.Duration) ([]string, []string) {
m.mu.Lock()
defer m.mu.Unlock()
var emails []string
var tags []string
for _, mg := range m.servers {
if mg.server != nil && mg.server.IsRunning() {
active := mg.server.GetActiveEmails(window)
if len(active) > 0 {
emails = append(emails, active...)
tags = append(tags, mg.tag)
}
}
}
return emails, tags
}
type InboundTrafficDelta struct {
Tag string
Up int64
Down int64
}
func (m *Manager) CollectClientTraffic() []ClientTrafficDelta {
_, clients := m.CollectAllTraffic()
return clients
}
func (m *Manager) CollectAllTraffic() ([]InboundTrafficDelta, []ClientTrafficDelta) {
m.mu.Lock()
defer m.mu.Unlock()
var inbounds []InboundTrafficDelta
clients := make([]ClientTrafficDelta, 0, len(m.pendingTraffic))
for email, delta := range m.pendingTraffic {
clients = append(clients, delta)
delete(m.pendingTraffic, email)
}
for _, mg := range m.servers {
if mg.server != nil && mg.server.IsRunning() {
up, down, cDeltas := mg.server.CollectAllTraffic()
if up > 0 || down > 0 {
inbounds = append(inbounds, InboundTrafficDelta{
Tag: mg.tag,
Up: up,
Down: down,
})
}
clients = append(clients, cDeltas...)
}
}
return inbounds, clients
}
func (m *Manager) AddTestTraffic(id int, email string, up, down int64) bool {
m.mu.Lock()
defer m.mu.Unlock()
if mg, ok := m.servers[id]; ok && mg.server != nil {
return mg.server.AddTestTraffic(email, up, down)
}
return false
}
func (m *Manager) Remove(id int) {
m.mu.Lock()
defer m.mu.Unlock()
m.removeLocked(id)
}
func (m *Manager) removeLocked(id int) {
if existing, ok := m.servers[id]; ok && existing != nil {
m.stopAndDrainLocked(existing)
delete(m.servers, id)
delete(m.lastStartErr, id)
}
}
func (m *Manager) Reconcile(desired []Instance) {
m.mu.Lock()
defer m.mu.Unlock()
desiredMap := make(map[int]Instance, len(desired))
for _, inst := range desired {
desiredMap[inst.Id] = inst
}
for id := range m.servers {
if _, ok := desiredMap[id]; !ok {
m.removeLocked(id)
}
}
for _, inst := range desired {
_ = m.ensureLocked(inst)
}
}
func (m *Manager) StopAll() {
m.mu.Lock()
defer m.mu.Unlock()
for _, mg := range m.servers {
m.stopAndDrainLocked(mg)
}
m.servers = make(map[int]*managed)
}