Files
3x-ui/internal/web/service/node_reset_queue.go
T
MHSanaei 4210a50cb4 fix(traffic): make a client reset reach every counter enforcing its quota
Invariant: a client traffic reset zeroes every counter that enforces the
client's quota - the master's, each hosting node's, and the local MTProto
sidecar's. A node cuts a client on its own local counters, and the master
adopts that verdict when both judged the same limits (#4917).

Node counters: ResetClientTraffic tried the node once and dropped a
failure ("nothing replays a reset"); BulkResetTraffic,
ResetAllClientTraffics and ClientService.ResetAllTraffics never told the
node at all. The node kept its pre-reset usage, switched the client off
again on its next tick, and the master latched that - a client shown at
zero usage stayed disabled.

Every reset path now queues a node_pending_resets row per hosting node in
its own transaction. It is delivered right after commit (per-client
endpoint up to the push threshold, bulkResetTraffic above) and replayed by
the node sync ahead of its snapshot, and dropped only once the node
accepted it. While one is owed, the merge takes only that client's usage
from the node, not its enable or limits. Deliveries to a node are
serialized so a reset is not sent twice.

Sidecar quota: BulkResetTraffic, ClientService.ResetAllTraffics and
auto-renew zeroed the panel counters but not mtg's own quota counter, so
the sidecar kept refusing a renewed or reset MTProto client. They now
reset it too, scoped to the affected clients.
2026-09-28 02:56:53 +02:00

153 lines
4.6 KiB
Go

package service
import (
"context"
"sync"
"time"
"github.com/mhsanaei/3x-ui/v3/internal/database"
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
"github.com/mhsanaei/3x-ui/v3/internal/logger"
"github.com/mhsanaei/3x-ui/v3/internal/web/runtime"
"gorm.io/gorm"
"gorm.io/gorm/clause"
)
// nodeBulkResetter is a node runtime that can zero many clients in one call.
type nodeBulkResetter interface {
ResetClientTraffics(ctx context.Context, emails []string) error
}
type nodeEmail struct {
NodeId int `gorm:"column:node_id"`
Email string `gorm:"column:email"`
}
// queueNodeResets records a reset for every node hosting one of emails (all
// node-hosted clients when emails is nil) and returns the nodes involved.
func queueNodeResets(tx *gorm.DB, emails []string) ([]int, error) {
base := func() *gorm.DB {
return tx.Table("clients").
Select("DISTINCT inbounds.node_id AS node_id, clients.email AS email").
Joins("JOIN client_inbounds ON client_inbounds.client_id = clients.id").
Joins("JOIN inbounds ON inbounds.id = client_inbounds.inbound_id").
Where("inbounds.node_id IS NOT NULL")
}
var pairs []nodeEmail
if emails == nil {
if err := base().Scan(&pairs).Error; err != nil {
return nil, err
}
} else {
for _, batch := range chunkStrings(uniqueNonEmptyStrings(emails), sqlInChunk) {
var page []nodeEmail
if err := base().Where("clients.email IN ?", batch).Scan(&page).Error; err != nil {
return nil, err
}
pairs = append(pairs, page...)
}
}
if len(pairs) == 0 {
return nil, nil
}
now := time.Now().UnixNano()
rows := make([]model.NodePendingReset, 0, len(pairs))
nodes := make(map[int]struct{})
for _, p := range pairs {
rows = append(rows, model.NodePendingReset{NodeId: p.NodeId, Email: p.Email, QueuedAt: now})
nodes[p.NodeId] = struct{}{}
}
if err := tx.Clauses(clause.OnConflict{
Columns: []clause.Column{{Name: "node_id"}, {Name: "email"}},
DoUpdates: clause.AssignmentColumns([]string{"queued_at"}),
}).CreateInBatches(rows, 200).Error; err != nil {
return nil, err
}
ids := make([]int, 0, len(nodes))
for id := range nodes {
ids = append(ids, id)
}
return ids, nil
}
// pendingNodeResetEmails lists the clients whose reset the node still owes.
func pendingNodeResetEmails(tx *gorm.DB, nodeID int) (map[string]struct{}, error) {
var emails []string
if err := tx.Model(&model.NodePendingReset{}).Where("node_id = ?", nodeID).Pluck("email", &emails).Error; err != nil {
return nil, err
}
out := make(map[string]struct{}, len(emails))
for _, e := range emails {
out[e] = struct{}{}
}
return out, nil
}
var nodeResetDeliveryLocks sync.Map
// DeliverNodeResets sends the node every reset it has not confirmed. A row is
// dropped only after the node accepted it and only if nothing re-queued it since.
func (s *InboundService) DeliverNodeResets(ctx context.Context, nodeID int, rt runtime.Runtime) error {
lock, _ := nodeResetDeliveryLocks.LoadOrStore(nodeID, &sync.Mutex{})
lock.(*sync.Mutex).Lock()
defer lock.(*sync.Mutex).Unlock()
db := database.GetDB()
var rows []model.NodePendingReset
if err := db.Where("node_id = ?", nodeID).Order("id").Find(&rows).Error; err != nil {
return err
}
if len(rows) == 0 {
return nil
}
bulk, canBulk := rt.(nodeBulkResetter)
for start := 0; start < len(rows); start += sqlInChunk {
batch := rows[start:min(start+sqlInChunk, len(rows))]
emails := make([]string, len(batch))
for i := range batch {
emails[i] = batch[i].Email
}
var err error
if canBulk && len(batch) > nodeBulkPushThreshold {
err = bulk.ResetClientTraffics(ctx, emails)
} else {
for _, email := range emails {
if err = rt.ResetClientTraffic(ctx, nil, email); err != nil {
break
}
}
}
if err != nil {
return err
}
for i := range batch {
if err := db.Where("id = ? AND queued_at = ?", batch[i].Id, batch[i].QueuedAt).
Delete(&model.NodePendingReset{}).Error; err != nil {
return err
}
}
}
return nil
}
// deliverNodeResetsNow tries each node once right after a reset commits; what
// fails stays queued for the node sync job.
func (s *InboundService) deliverNodeResetsNow(nodeIDs []int) {
mgr := runtime.GetManager()
if mgr == nil || len(nodeIDs) == 0 {
return
}
fanoutInboundResults(nodeIDs, nodeFanoutConcurrency, func(i int) struct{} {
rt, err := mgr.RuntimeFor(&nodeIDs[i])
if err != nil {
return struct{}{}
}
ctx, cancel := nodePushContext()
defer cancel()
if err := s.DeliverNodeResets(ctx, nodeIDs[i], rt); err != nil {
logger.Warning("reset delivery to", rt.Name(), "deferred to the next sync:", err)
}
return struct{}{}
})
}