mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-08-03 13:52:12 +03:00
Three agent-facing rules, each written after the same mistake showed up in review. Comments were banned outright, which the codebase itself contradicts on almost every file — the ban pushed real invariants out of the code entirely. Allow them, but cap a block at 2 lines and spend those lines on the *why* a name cannot carry. Add a scope rule: the fix must be the smallest change that removes the root cause. A small bug does not earn new columns, jobs, abstractions or config; if it genuinely needs architecture, agree on that first instead of shipping it alongside the fix. Add two testing rules: a test must go red when its fix is reverted, and it must cover something that can actually break. A test that passes either way certifies nothing and is then cited as proof the fix works.
7.7 KiB
7.7 KiB
CLAUDE.md
Operational guide for AI agents working in this repo. Long-form human docs:
CONTRIBUTING.md (setup, testing philosophy) and frontend/README.md.
Read those before large changes. This file is the short, must-follow version.
For a deep navigation map (request lifecycle, cron-job table, symptom → file
index, layering rules), read docs/architecture.md on demand — do not guess
file locations when it can answer in one hop.
Stack
- Backend: Go 1.26 (
module github.com/mhsanaei/3x-ui/v3), Gin, GORM. Runs Xray-core as a managed child process (internal/xray/process.go) and importsgithub.com/xtls/xray-corefor config types + gRPC stats/handler/router API. MTProto inbounds run a second managed child — themtg-multibinary (github.com/mhsanaei/mtg-multi, a multi-secret fork built from source;internal/mtproto/) — outside Xray, one process per inbound serving each client's FakeTLS secret via the fork's[secrets]section (plus per-client ad-tags via[secret-ad-tags]and per-client data quota / expiry via[secret-limits], mapped from the client'stotalGB/expiryTime). Client, ad-tag and quota/expiry edits are hot-applied through the fork's management API (PUT /secrets, bearer-token guarded) so connections survive; the manager falls back to a process restart on older binaries. A client's panel-side traffic reset also callsPOST /secrets/{name}/reset-quotaso a renewed client is not re-blocked by the sidecar's quota counter. - Storage: SQLite by default (
/etc/x-ui/x-ui.dbon Linux; the executable dir on Windows), PostgreSQL optional (XUI_DB_TYPE/XUI_DB_DSN). The CGo SQLite driver (mattn/go-sqlite3) needs a C compiler —CGO_ENABLED=0builds fail. - Frontend: React 19 + Ant Design 6 + Vite 8 + TypeScript in
frontend/, built intointernal/web/dist/(gitignored) and embedded viaembed.FS.
Repo map
main.go— entry point +x-uiCLI (run, migrate, migrate-db, setting, cert).internal/config/— env parsing (XUI_DEBUG, XUI_LOG_LEVEL, XUI_LOG_FOLDER, XUI_BIN_FOLDER, XUI_SKIP_HSTS, XUI_PORT, XUI_DB_*).internal/database/+internal/database/model/— GORM schema (Inbound, Client, Setting, User), inbound Protocol enum, AutoMigrate + hand-written migrations indb.go.internal/xray/— Xray child-process lifecycle, config generation, gRPC API.internal/mtproto/— MTProto inbounds via the bundledmtg-multibinary.internal/sub/— subscription server (raw / JSON / Clash).internal/eventbus/— in-process pub/sub (outbound/node health, xray.crash, cpu.high, memory.high, login.attempt).internal/logger/,internal/util/(link, crypto, sys, ldap, …),internal/tunnelmonitor/— shared infrastructure.internal/web/— Gin server (embedsdist/+translation/).controller/— panel + REST API handlers; OpenAPI at /panel/api/openapi.json.service/— business logic (InboundService, SettingService, XrayService, node sync); subpackages tgbot/, email/, outbound/, panel/, integration/.job/— cron jobs (traffic, fail2ban IP-limit, node heartbeat/sync, LDAP).middleware/,entity/,global/,session/(CSRF),network/,runtime/(master/sub-node over mTLS),websocket/.locale/+translation/— i18n, 13 embedded locale JSON files.
frontend/— React + TS source (seefrontend/CLAUDE.md).tools/openapigen/— Go generator that emits frontend types + Zod/JSON schemas intofrontend/src/generated/from Go structs. The OpenAPI doc itself (frontend/public/openapi.json) is assembled from those +endpoints.tsbyfrontend/scripts/build-openapi.mjs.
Hard rules (non-negotiable)
- Fix size must match bug size. Find the root cause, then make the SMALLEST change that removes it — a one-line guard beats a new subsystem. A small bug does not earn new columns, jobs, abstractions, config knobs or helper layers. If a fix genuinely needs new architecture, say so and get agreement first; never ship it unasked next to the fix.
- Comments in committed Go/TS: 2 lines MAX per comment block. Make the name
carry the meaning first and rename rather than annotate; spend the 2 lines on
the why a name cannot hold — an invariant, an issue number, a non-obvious
constraint. Exempt:
//go:build,//go:generate, and other directives. HTML<!-- -->is fine. (A linter cannot enforce this — you must.) - New
g.POST/g.GETininternal/web/controller/REQUIRES a matching entry infrontend/src/pages/api-docs/endpoints.ts, thenmake gen(orcd frontend && npm run gen). It is a hand-maintained registry — nothing checks it against the Go routes, so an omitted route silently vanishes from the docs. - Response examples come from Go struct
example:tags viatools/openapigen— never hand-write them. A new struct must be added to openapigen'sStructAllowallowlist (tools/openapigen/main.go) or it is silently omitted from schemas/examples (andbuild-openapi.mjsthen fails on the missing schema). - A new English i18n key must be added to EVERY locale JSON in
internal/web/translation/(13 files). Missing keys fall back to en-US (or render the raw key if absent there too); nothing fails the build, so they are easy to miss. - DB / model changes require a migration in
internal/database/db.go. - Conventional-commit prefixes (
feat,fix,refactor,chore,docs,style):<area>: short imperative summary, then a body explaining the why.
Go conventions
- Stdlib
testingonly (no testify). Table-driven,t.Runsubtests,t.Helper()on helpers. Assert the exact value / typed error / emitted string, never justerr != nil. Prefer real deps over mocks: throwaway DB viadatabase.InitDB(filepath.Join(t.TempDir(), "x-ui.db"))+t.Cleanup(func() { _ = database.CloseDB() });httptestfor HTTP.internal/sub'sinitSubDB(t)is the template. - A test must fail without its fix. Write it, revert the fix, watch it go red, restore. A test that passes either way is worse than no test: it certifies nothing and then gets cited as proof the fix works.
- Test what can actually break. No test for a getter, a constant, a rename, a pure map lookup, or inputs the function can never receive. One real test that drives the bug through the actual code path beats five that restate the code.
- Code must pass
golangci-lint run(gofumpt + goimports formatting):make lint.
Frontend conventions (summary; full version in frontend/CLAUDE.md)
- Ant Design 6 only — no Tailwind/shadcn. Targeted tweaks, not rewrites.
- TS strict;
@typescript-eslint/no-explicit-anyis an error. Zod schemas insrc/schemas/are the source of truth; infer types withz.infer, never hand-write. Do not editsrc/generated/. - Editing
frontend/srcdoes NOT change what users see until the Vite build is regenerated intointernal/web/dist/. InXUI_DEBUG=true, HTML is served from the frozen embedded FS but JS/CSS off disk — afternpm run buildyou MUST restartgo run .or you get a blank page with 404s. - After touching share-link logic (
src/lib/xray/), runnpm run test(golden fixtures); regenerate snapshots (npx vitest run -u) only for intentional output changes, never to make a red test green.
Build, test, verify
Run make help for all targets. The full local gate that mirrors CI:
make verify
Common targets: make gen (regenerate Zod/OpenAPI), make lint (Go + frontend),
make test (Go -shuffle=on + frontend), make race, make build. See Makefile.
Definition of done (before opening a PR)
make genand confirmgit diffonfrontend/src/generated+frontend/public/openapi.jsonis clean.make verifypasses.- Diff is focused; refactors are separate from feature work.