Files
3x-ui/internal/web/job/ldap_sync_job_test.go
T
MHSanaei 12d51d7195 perf(tests): copy a migrated template DB instead of migrating per test
Most tests opened a throwaway panel DB with database.InitDB, which runs the
full AutoMigrate + seed on an empty file every time: ~230ms, and ~850ms under
-race because GORM's reflection-heavy migration is what the detector slows
most. internal/web/service does this in ~550 of its 830 tests, so the CI race
job spent ~10 of its ~14.6 minutes re-migrating empty databases.

internal/database/dbtest.InitDB migrates once per test process, then hands
each test its own copy of that file (~130ms under -race) and registers the
CloseDB cleanup. The copy then goes through InitDB like a panel restart, so
every test still starts from the state a fresh install has. Tests that reopen
an existing file, migrate a hand-built legacy DB or target Postgres keep
calling database.InitDB.

Locally under -race: internal/web/service 626s (last CI run) -> 114s,
internal/sub 246s -> 35s.
2026-09-27 03:04:50 +02:00

131 lines
4.1 KiB
Go

package job
import (
"path/filepath"
"testing"
"github.com/mhsanaei/3x-ui/v3/internal/database"
"github.com/mhsanaei/3x-ui/v3/internal/database/dbtest"
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
"github.com/mhsanaei/3x-ui/v3/internal/web/service"
)
func initLdapJobDB(t *testing.T) {
t.Helper()
dbDir := t.TempDir()
t.Setenv("XUI_DB_FOLDER", dbDir)
dbtest.InitDB(t, filepath.Join(dbDir, "x-ui.db"))
}
func TestBuildClient_ConvertsDefaultTotalGBToBytes(t *testing.T) {
j := NewLdapSyncJob()
c := j.buildClient("user@example.com", 10, 0, 0)
if want := int64(10) * 1024 * 1024 * 1024; c.TotalGB != want {
t.Errorf("TotalGB = %d, want %d", c.TotalGB, want)
}
}
func TestLdapCreateClients_AttachesToAllConfiguredInbounds(t *testing.T) {
initLdapJobDB(t)
db := database.GetDB()
tags := []string{"in-1080-tcp", "in-1081-tcp", "in-1082-tcp"}
protocols := []model.Protocol{model.VLESS, model.Trojan, model.VLESS}
inboundIds := make([]int, 0, len(tags))
for i, tag := range tags {
ib := &model.Inbound{
UserId: 1,
Tag: tag,
Enable: true,
Port: 42080 + i,
Protocol: protocols[i],
Settings: `{"clients": []}`,
StreamSettings: `{"network":"tcp","security":"none"}`,
}
if err := db.Create(ib).Error; err != nil {
t.Fatalf("create inbound %s: %v", tag, err)
}
inboundIds = append(inboundIds, ib.Id)
}
j := NewLdapSyncJob()
const email = "user@example.com"
j.createClients([]model.Client{j.buildClient(email, 0, 0, 0)}, inboundIds, tags)
rec := &model.ClientRecord{}
if err := db.Where("email = ?", email).First(rec).Error; err != nil {
t.Fatalf("client record for %s not created: %v", email, err)
}
if rec.SubID == "" {
t.Error("created LDAP client must carry a subId")
}
clientSvc := &service.ClientService{}
for i, id := range inboundIds {
clients, err := clientSvc.ListForInbound(nil, id)
if err != nil {
t.Fatalf("ListForInbound(%s): %v", tags[i], err)
}
if len(clients) != 1 || clients[0].Email != email {
t.Fatalf("inbound %s must carry exactly the LDAP client, got %d clients", tags[i], len(clients))
}
if clients[0].SubID != rec.SubID {
t.Errorf("inbound %s client subId = %q, want the shared %q", tags[i], clients[0].SubID, rec.SubID)
}
}
trojanClients, err := clientSvc.ListForInbound(nil, inboundIds[1])
if err != nil {
t.Fatalf("ListForInbound(trojan): %v", err)
}
if trojanClients[0].Password == "" {
t.Error("trojan inbound client must get a generated password")
}
vlessClients, err := clientSvc.ListForInbound(nil, inboundIds[0])
if err != nil {
t.Fatalf("ListForInbound(vless): %v", err)
}
if vlessClients[0].ID == "" {
t.Error("vless inbound client must get a generated uuid")
}
}
// TestLdapCreateClients_FlagsRestartWhenEveryClientPartlyApplies pins that the
// restart survives created == 0, the case a partly-applied batch always hits.
func TestLdapCreateClients_FlagsRestartWhenEveryClientPartlyApplies(t *testing.T) {
initLdapJobDB(t)
db := database.GetDB()
healthy := &model.Inbound{
UserId: 1, Tag: "in-42180-tcp", Enable: true, Port: 42180,
Protocol: model.VLESS, Settings: `{"clients": []}`,
StreamSettings: `{"network":"tcp","security":"none"}`,
}
broken := &model.Inbound{
UserId: 1, Tag: "in-42181-tcp", Enable: true, Port: 42181,
Protocol: model.VLESS, Settings: `{"clients":`,
StreamSettings: `{"network":"tcp","security":"none"}`,
}
for _, ib := range []*model.Inbound{healthy, broken} {
if err := db.Create(ib).Error; err != nil {
t.Fatalf("create inbound %s: %v", ib.Tag, err)
}
}
j := NewLdapSyncJob()
j.xrayService.IsNeedRestartAndSetFalse()
j.createClients([]model.Client{j.buildClient("partial@example.com", 0, 0, 0)},
[]int{healthy.Id, broken.Id}, []string{healthy.Tag, broken.Tag})
clients, err := (&service.ClientService{}).ListForInbound(nil, healthy.Id)
if err != nil {
t.Fatalf("ListForInbound(%s): %v", healthy.Tag, err)
}
if len(clients) != 1 {
t.Fatalf("healthy inbound holds %d clients, want the partly-applied 1", len(clients))
}
if !j.xrayService.IsNeedRestartAndSetFalse() {
t.Fatal("a partly-applied LDAP batch left Xray unflagged for restart")
}
}