Files
3x-ui/internal/web/job/node_down_threshold_test.go
T
Grigoriy 2f62dadd25 feat(notifications): add a failed-check threshold for node.down alerts (#6768)
One lost heartbeat on a lossy link flipped a node offline and sent node.down,
and the next probe sent node.up, so a flaky node flooded Telegram, email and
Discord with alert pairs.

A new nodeDownThreshold setting (default 1, today's behaviour) works like
outboundDownThreshold: node.down fires once the failed-check streak reaches it,
once per outage, and node.up only after a node.down was sent. The announcement
is persisted in nodes.down_notified, so a restart inside the threshold window
neither drops the outage's node.down nor re-announces nodes already reported
offline; nodes offline at upgrade are seeded as announced.
2026-10-24 04:26:13 +02:00

119 lines
3.6 KiB
Go

package job
import (
"fmt"
"net/http"
"net/http/httptest"
"path/filepath"
"strconv"
"strings"
"sync/atomic"
"testing"
"github.com/op/go-logging"
"github.com/mhsanaei/3x-ui/v3/internal/database"
"github.com/mhsanaei/3x-ui/v3/internal/database/dbtest"
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
xuilogger "github.com/mhsanaei/3x-ui/v3/internal/logger"
"github.com/mhsanaei/3x-ui/v3/internal/web/runtime"
"github.com/mhsanaei/3x-ui/v3/internal/web/service"
)
func switchableNode(t *testing.T) *atomic.Bool {
t.Helper()
xuilogger.InitLogger(logging.ERROR)
dbtest.InitDB(t, filepath.Join(t.TempDir(), "x-ui.db"))
runtime.SetManager(runtime.NewManager(runtime.LocalDeps{APIPort: func() int { return 0 }, SetNeedRestart: func() {}}))
t.Cleanup(func() { runtime.SetManager(nil) })
var up atomic.Bool
up.Store(true)
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if !up.Load() {
w.WriteHeader(http.StatusServiceUnavailable)
return
}
w.Header().Set("Content-Type", "application/json")
if strings.HasSuffix(r.URL.Path, "server/status") {
_, _ = w.Write([]byte(`{"success":true,"obj":{"panelGuid":"flaky-guid","xray":{"state":"running"}}}`))
return
}
_, _ = w.Write([]byte(`{"success":true,"obj":[]}`))
}))
t.Cleanup(srv.Close)
host, port, _ := strings.Cut(strings.TrimPrefix(srv.URL, "http://"), ":")
portNum, _ := strconv.Atoi(port)
node := &model.Node{
Name: "flaky", Scheme: "http", Address: host, Port: portNum, BasePath: "/", ApiToken: "tok",
Enable: true, Status: "online", AllowPrivateAddress: true, TlsVerifyMode: "verify",
}
if err := database.GetDB().Create(node).Error; err != nil {
t.Fatalf("create node: %v", err)
}
return &up
}
func TestHeartbeatHoldsNodeDownUntilThreshold(t *testing.T) {
cases := []struct {
name string
probes []bool
restartBefore int
want []string
}{
{
name: "flapping below threshold",
probes: []bool{false, true, false, false, true, false, true},
},
{
name: "outage reaching threshold",
probes: []bool{false, false, false, false, true},
want: []string{"probe 3: node.down", "probe 5: node.up"},
},
{
name: "restart mid-streak still announces the outage",
probes: []bool{false, false, false, false, true},
restartBefore: 2,
want: []string{"probe 4: node.down", "probe 5: node.up"},
},
{
name: "restart after announced outage does not repeat it",
probes: []bool{false, false, false, false, false, false, true},
restartBefore: 5,
want: []string{"probe 3: node.down", "probe 7: node.up"},
},
{
name: "restart after recovery announces the next outage",
probes: []bool{false, false, false, true, false, false, false, true},
restartBefore: 5,
want: []string{"probe 3: node.down", "probe 4: node.up", "probe 7: node.down", "probe 8: node.up"},
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
up := switchableNode(t)
if err := (&service.SettingService{}).SetNodeDownThreshold(3); err != nil {
t.Fatalf("SetNodeDownThreshold: %v", err)
}
events := collectNodeEvents(t)
job := NewNodeHeartbeatJob()
var got []string
for i, probeOK := range tc.probes {
if i+1 == tc.restartBefore {
job = NewNodeHeartbeatJob()
}
up.Store(probeOK)
job.Run()
for _, e := range events()[len(got):] {
got = append(got, fmt.Sprintf("probe %d: %s", i+1, e.Type))
}
}
if strings.Join(got, ", ") != strings.Join(tc.want, ", ") {
t.Fatalf("notifications = %q, want %q", got, tc.want)
}
})
}
}