Files
3x-ui/internal/web/service/xray_wireguard_config_test.go
T
MHSanaei f8b72de995 fix(node-sync): write only changed client rows in the node traffic merge
Every 5s node merge rewrote one client_traffics row and one
node_client_traffics baseline per (inbound, client) pair the node
reported, even when nothing had moved: a client is reported once per
inbound it is on, and idle clients every tick. On top of that each
inbound's SyncInbound wrote its own per-inbound values onto the shared
clients record, so a client on a flow and a non-flow inbound (or on a
WireGuard tunnel plus any other inbound) had its record flipped back
and forth twice per merge. With 7 nodes and ~20k client links that is
tens of thousands of statements per tick, all inside transactions on
the single serialized writer, holding row locks for seconds. A renew
of a client on 38 inbounds takes one writer turn per inbound, queued
behind those merges each time, and outlived the 30s HTTP write timeout
even though it committed; last_sub_fetch updates waited on the same
locks.

The merge now computes the row its UPDATE would leave, mirroring the
SQL merge expressions, and skips the write when nothing changes; the
baseline upsert is skipped when the node counter has not moved. The
record's per-inbound fields get one owner each, so repeated syncs
agree: flow is settled to the effective flow (lowest-id link carrying
one) for clients whose links changed, and WireGuard/AmneziaWG peer
fields come from the client's lowest-id tunnel. A repeated unchanged
snapshot now writes no client row; one active client writes two.

Verified beyond make verify: the CI Postgres lane, the merge and flow
tests run against PostgreSQL 16, and make node-e2e.

Closes #6815
2026-10-14 00:37:00 +02:00

307 lines
10 KiB
Go

package service
import (
"encoding/base64"
"encoding/json"
"testing"
"github.com/mhsanaei/3x-ui/v3/internal/database"
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
"github.com/mhsanaei/3x-ui/v3/internal/util/json_util"
)
func wgTestSecretKey() string {
return base64.StdEncoding.EncodeToString(make([]byte, 32))
}
func wgInboundEmittedSettings(t *testing.T, tag string) map[string]any {
t.Helper()
svc := &XrayService{}
cfg, err := svc.GetXrayConfig()
if err != nil {
t.Fatalf("GetXrayConfig: %v", err)
}
for i := range cfg.InboundConfigs {
ic := cfg.InboundConfigs[i]
if ic.Tag != tag {
continue
}
var s map[string]any
if err := json.Unmarshal([]byte(ic.Settings), &s); err != nil {
t.Fatalf("unmarshal emitted settings: %v", err)
}
return s
}
t.Fatalf("inbound %q not found in generated config", tag)
return nil
}
func seedWGInbound(t *testing.T, tag string, port int, clients []model.Client) {
t.Helper()
setupSettingTestDB(t)
db := database.GetDB()
in := &model.Inbound{
Tag: tag,
Enable: true,
Port: port,
Protocol: model.WireGuard,
Settings: `{"secretKey":"` + wgTestSecretKey() + `","mtu":1420}`,
}
if err := db.Create(in).Error; err != nil {
t.Fatalf("create wg inbound: %v", err)
}
svc := ClientService{}
if err := svc.SyncInbound(nil, in.Id, clients); err != nil {
t.Fatalf("SyncInbound: %v", err)
}
}
func seedDualTunnelClient(t *testing.T, enabled bool, wgKeepAlive *int) string {
t.Helper()
setupSettingTestDB(t)
db := database.GetDB()
const email = "dual@wg.test"
wgClient := model.Client{
Email: email,
Enable: true,
PublicKey: "pub-wg",
AllowedIPs: []string{"10.0.0.5/32"},
PreSharedKey: "wg-psk",
KeepAlive: wgKeepAlive,
}
awgClient := wgClient
awgClient.PublicKey = "pub-awg"
awgClient.AllowedIPs = []string{"10.8.1.5/32"}
awgClient.PreSharedKey = "awg-psk"
awgClient.KeepAlive = model.KeepAlivePtr(25)
wgSettings, err := json.Marshal(map[string]any{
"secretKey": wgTestSecretKey(),
"mtu": 1420,
"clients": []model.Client{wgClient},
})
if err != nil {
t.Fatalf("marshal wg settings: %v", err)
}
awgSettings, err := json.Marshal(map[string]any{
"server": map[string]any{"subnetIp": "10.8.1.0", "subnetCidr": 24},
"clients": []model.Client{awgClient},
})
if err != nil {
t.Fatalf("marshal awg settings: %v", err)
}
wgInbound := &model.Inbound{Tag: "wg-dual", Enable: true, Port: 51823, Protocol: model.WireGuard, Settings: string(wgSettings)}
awgInbound := &model.Inbound{Tag: "awg-dual", Enable: true, Port: 51824, Protocol: model.AmneziaWG, Settings: string(awgSettings)}
// The lower-id tunnel owns the shared record's peer fields: AmneziaWG first.
if err := db.Create(awgInbound).Error; err != nil {
t.Fatalf("create awg inbound: %v", err)
}
if err := db.Create(wgInbound).Error; err != nil {
t.Fatalf("create wg inbound: %v", err)
}
svc := ClientService{}
if err := svc.SyncInbound(nil, wgInbound.Id, []model.Client{wgClient}); err != nil {
t.Fatalf("SyncInbound(wg): %v", err)
}
awgClient.Enable = enabled
if err := svc.SyncInbound(nil, awgInbound.Id, []model.Client{awgClient}); err != nil {
t.Fatalf("SyncInbound(awg): %v", err)
}
return email
}
func wgPeerList(t *testing.T, settings map[string]any) []map[string]any {
t.Helper()
if _, ok := settings["clients"]; ok {
t.Fatalf("wireguard inbound must not emit a clients[] key: %v", settings["clients"])
}
rawPeers, ok := settings["peers"].([]any)
if !ok {
t.Fatalf("settings.peers is not an array: %T", settings["peers"])
}
out := make([]map[string]any, 0, len(rawPeers))
for _, p := range rawPeers {
m, ok := p.(map[string]any)
if !ok {
t.Fatalf("peer is not an object: %T", p)
}
out = append(out, m)
}
return out
}
func TestGetXrayConfigWireGuardPeers(t *testing.T) {
clients := []model.Client{
{Email: "alice@wg.test", Enable: true, PublicKey: "pub-alice", AllowedIPs: []string{"10.0.0.2/32"}, KeepAlive: model.KeepAlivePtr(25)},
{Email: "bob@wg.test", Enable: true, PublicKey: "pub-bob", AllowedIPs: []string{"10.0.0.3/32"}},
}
seedWGInbound(t, "wg-multi", 51820, clients)
settings := wgInboundEmittedSettings(t, "wg-multi")
if settings["secretKey"] != wgTestSecretKey() {
t.Errorf("secretKey not preserved: %v", settings["secretKey"])
}
if settings["mtu"] != float64(1420) {
t.Errorf("mtu not preserved: %v", settings["mtu"])
}
peers := wgPeerList(t, settings)
if len(peers) != 2 {
t.Fatalf("expected 2 peers, got %d: %v", len(peers), peers)
}
ips := map[string]bool{}
for _, p := range peers {
if p["email"] == nil || p["email"] == "" {
t.Errorf("peer missing email: %v", p)
}
if p["publicKey"] == nil || p["publicKey"] == "" {
t.Errorf("peer missing publicKey: %v", p)
}
if p["level"] != float64(0) {
t.Errorf("peer level = %v, want 0 (needed for per-user stats)", p["level"])
}
allowed, ok := p["allowedIPs"].([]any)
if !ok || len(allowed) == 0 {
t.Fatalf("peer missing allowedIPs: %v", p)
}
ips[allowed[0].(string)] = true
}
if len(ips) != 2 {
t.Errorf("peers must have distinct allowedIPs, got %v", ips)
}
}
func TestGetXrayConfigWireGuardDisabledClientExcluded(t *testing.T) {
clients := []model.Client{
{Email: "on@wg.test", Enable: true, PublicKey: "pub-on", AllowedIPs: []string{"10.0.0.2/32"}},
{Email: "off@wg.test", Enable: true, PublicKey: "pub-off", AllowedIPs: []string{"10.0.0.3/32"}},
}
seedWGInbound(t, "wg-disabled", 51821, clients)
if err := database.GetDB().Model(&model.ClientRecord{}).
Where("email = ?", "off@wg.test").Update("enable", false).Error; err != nil {
t.Fatalf("disable client: %v", err)
}
peers := wgPeerList(t, wgInboundEmittedSettings(t, "wg-disabled"))
if len(peers) != 1 {
t.Fatalf("expected 1 enabled peer, got %d: %v", len(peers), peers)
}
if peers[0]["email"] != "on@wg.test" {
t.Errorf("wrong peer kept: %v", peers[0])
}
}
func TestGetXrayConfigWireGuardUsesInboundLocalTunnelFields(t *testing.T) {
email := seedDualTunnelClient(t, true, model.KeepAlivePtr(15))
var shared model.ClientRecord
if err := database.GetDB().Where("email = ?", email).First(&shared).Error; err != nil {
t.Fatalf("read shared client: %v", err)
}
if shared.AllowedIPs != "10.8.1.5/32" || shared.PreSharedKey != "awg-psk" || shared.PublicKey != "pub-awg" || shared.KeepAlive != 25 {
t.Fatalf("test setup did not persist AmneziaWG identity: allowedIPs=%q preSharedKey=%q publicKey=%q keepAlive=%d", shared.AllowedIPs, shared.PreSharedKey, shared.PublicKey, shared.KeepAlive)
}
peers := wgPeerList(t, wgInboundEmittedSettings(t, "wg-dual"))
if len(peers) != 1 {
t.Fatalf("expected 1 peer, got %d: %v", len(peers), peers)
}
allowed, ok := peers[0]["allowedIPs"].([]any)
if !ok || len(allowed) != 1 || allowed[0] != "10.0.0.5/32" {
t.Fatalf("WireGuard peer allowedIPs = %v, want [10.0.0.5/32]", peers[0]["allowedIPs"])
}
if peers[0]["preSharedKey"] != "wg-psk" {
t.Fatalf("WireGuard peer preSharedKey = %v, want wg-psk", peers[0]["preSharedKey"])
}
if peers[0]["publicKey"] != "pub-wg" {
t.Fatalf("WireGuard peer publicKey = %v, want pub-wg", peers[0]["publicKey"])
}
if peers[0]["keepAlive"] != float64(15) {
t.Fatalf("WireGuard peer keepAlive = %v, want 15", peers[0]["keepAlive"])
}
}
func TestGetXrayConfigWireGuardOmitsKeepAliveAbsentFromSettings(t *testing.T) {
email := seedDualTunnelClient(t, true, nil)
var shared model.ClientRecord
if err := database.GetDB().Where("email = ?", email).First(&shared).Error; err != nil {
t.Fatalf("read shared client: %v", err)
}
if shared.PublicKey != "pub-awg" || shared.KeepAlive != 25 {
t.Fatalf("test setup did not persist AmneziaWG identity: publicKey=%q keepAlive=%d", shared.PublicKey, shared.KeepAlive)
}
peers := wgPeerList(t, wgInboundEmittedSettings(t, "wg-dual"))
if len(peers) != 1 {
t.Fatalf("expected 1 peer, got %d: %v", len(peers), peers)
}
if peers[0]["publicKey"] != "pub-wg" {
t.Fatalf("WireGuard peer publicKey = %v, want pub-wg", peers[0]["publicKey"])
}
if _, ok := peers[0]["keepAlive"]; ok {
t.Fatalf("WireGuard peer keepAlive = %v, want absent", peers[0]["keepAlive"])
}
}
func TestGetXrayConfigWireGuardDisabledDualProtocolClientExcluded(t *testing.T) {
seedDualTunnelClient(t, false, model.KeepAlivePtr(15))
peers := wgPeerList(t, wgInboundEmittedSettings(t, "wg-dual"))
if len(peers) != 0 {
t.Fatalf("expected disabled dual-protocol client to be excluded, got %v", peers)
}
}
func TestGetXrayConfigWireGuardNoClientsEmitsEmptyPeers(t *testing.T) {
seedWGInbound(t, "wg-empty", 51822, nil)
settings := wgInboundEmittedSettings(t, "wg-empty")
if _, ok := settings["clients"]; ok {
t.Fatalf("clients key must be absent")
}
peers, ok := settings["peers"].([]any)
if !ok {
t.Fatalf("peers must be an (empty) array, got %T", settings["peers"])
}
if len(peers) != 0 {
t.Fatalf("expected empty peers, got %v", peers)
}
}
// #6796: where the core would pick a kernel TUN it cannot set up (Docker, a sandboxed unit),
// one WireGuard outbound aborts the whole start unless it is moved to the userspace TUN.
func TestForceUserspaceWireGuardTun(t *testing.T) {
cases := []struct {
name, protocol, settings string
}{
{"kernel TUN requested", "wireguard", `{"noKernelTun":false,"mtu":1420}`},
{"kernel TUN by default, protocol cased like the core accepts", "WireGuard", `{"mtu":1420}`},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
raw := json_util.RawMessage(`[{"protocol":"freedom","tag":"direct","settings":{}},` +
`{"protocol":"` + tc.protocol + `","tag":"warp","settings":` + tc.settings + `}]`)
var outbounds []struct {
Settings map[string]any `json:"settings"`
}
if err := json.Unmarshal(forceUserspaceWireGuardTun(raw), &outbounds); err != nil {
t.Fatal(err)
}
if got := outbounds[1].Settings["noKernelTun"]; got != true {
t.Fatalf("wireguard noKernelTun = %v, want true", got)
}
if got := outbounds[1].Settings["mtu"]; got != float64(1420) {
t.Fatalf("wireguard mtu = %v, want the template's 1420 kept", got)
}
if _, ok := outbounds[0].Settings["noKernelTun"]; ok {
t.Fatalf("freedom outbound gained noKernelTun: %v", outbounds[0].Settings)
}
})
}
}