From 07f3b71fc9ac4f7dd29f26425cd3c4c53d140938 Mon Sep 17 00:00:00 2001 From: Mrinal Joshi Date: Sat, 16 May 2026 00:31:03 +0100 Subject: [PATCH] style(sse): condense flag-removal NOTE comment (review feedback) Compresses the explanatory NOTE in claudeCodeToolRemapper.ts from 6 lines to 4 while keeping the actionable why: the flag has no readers, would leak into the Anthropic request body causing HTTP 400 (Extra inputs are not permitted), and the response-side remap is unconditional. Addresses gemini-code-assist review feedback on PR #2290. --- open-sse/services/claudeCodeToolRemapper.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/open-sse/services/claudeCodeToolRemapper.ts b/open-sse/services/claudeCodeToolRemapper.ts index 8e8b457be5..db6f873cad 100644 --- a/open-sse/services/claudeCodeToolRemapper.ts +++ b/open-sse/services/claudeCodeToolRemapper.ts @@ -88,12 +88,10 @@ export function remapToolNamesInRequest(body: Record): boolean } } - // NOTE: previously set body._claudeCodeRequiresLowercaseToolNames = true here. - // Removed: the flag had no readers in the codebase and leaked into the - // outgoing Anthropic request body, causing HTTP 400 - // "_claudeCodeRequiresLowercaseToolNames: Extra inputs are not permitted". - // The response-side lowercase remap is unconditional anyway via - // remapToolNamesInResponse(text, forceLowercase=true). + // NOTE: do not set body._claudeCodeRequiresLowercaseToolNames here. + // The flag has no readers and would leak into the outgoing Anthropic + // request body, causing HTTP 400 (Extra inputs are not permitted). + // The response-side remap is unconditional via remapToolNamesInResponse. return hasLowercase && !hasTitleCase; }