pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-09-21 22:32:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): stamp BUILD_SHA before the release-green pack gate validates

Browse Source 
check:pack-artifact assembles dist/ through build:cli, which never writes
dist/BUILD_SHA (only build:release does). #12959 pointed the provenance ref at
HEAD, but the #10427 guard still stops at 'dist/BUILD_SHA is missing' before it
ever reaches the ancestry check — reproduced on tip + #13635 + #13436, the first
tree whose Turbopack build compiles.

ci.yml sequences build -> stamp -> validate; the validator now does the same in
both entry points, keeping PACK_GATE_ENV for the validate step. The guard is
unchanged: an unstamped dist/ or one built from another commit still fails.
On that tree the stamped gate passes: 'BUILD_SHA 5cb3ae5d9 is on the release line'.

Refs #12732
This commit is contained in:
diegosouzapw
2026-09-14 19:07:00 -03:00
parent 6b08790274
commit 2ef073f513
3 changed files with 64 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/unit/validate-release-green.test.ts
View File

@@ -277,6 +277,33 @@ test("pre-flight runs tarball boot only after the package artifact builder compl
);
});
test("pack gate builds, stamps dist/BUILD_SHA, then validates against the tree under test (#10427)", async () => {
const fs = await import("node:fs");
const src = fs.readFileSync(
new URL("../../scripts/quality/validate-release-green.mjs", import.meta.url),
"utf8"
);
const gate = src.slice(src.indexOf("async function runPackArtifactGate"));
assert.ok(gate.length > 0, "the pack gate runner must exist");
const buildAt = gate.indexOf('"build:cli"');
const stampAt = gate.indexOf("scripts/build/write-build-sha.mjs");
const checkAt = gate.indexOf('"check:pack-artifact"');
// `build:cli` never writes dist/BUILD_SHA, so a bare `check:pack-artifact` always failed
// the provenance guard with "dist/BUILD_SHA is missing" — the same trap ci.yml avoids.
assert.ok(buildAt >= 0 && stampAt > buildAt, "BUILD_SHA must be stamped after build:cli");
assert.ok(checkAt > stampAt, "the artifact must be validated only after it is stamped");
assert.match(
gate.slice(checkAt, checkAt + 200),
/env: PACK_GATE_ENV/,
"a release-branch tip is never an ancestor of origin/main mid-cycle"
);
assert.match(src, /const PACK_GATE_ENV = \{ OMNIROUTE_RELEASE_REF: "HEAD" \}/);
// Both entry points (the parallel wave and --with-build --quick) must use it.
assert.equal(src.match(/runPackArtifactGate\b/g)?.length, 3);
assert.doesNotMatch(src, /runAsync\(npmCmd, \["run", "check:pack-artifact"\]/);
assert.doesNotMatch(src, /id: "pack-artifact",[^}]*args:/);
});
// ─── --full-ci gate extraction (P0, v3.8.46 post-mortem) ─────────────────────
const CI_FIXTURE = `