pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-05 06:42:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): return 400 for missing/invalid messages before model resolution (#6402) (#6515)

Browse Source 
fix(api): return 400 for missing/invalid messages before model resolution (#6402). Integrated into release/v3.8.47. (thanks @chirag127)
This commit is contained in:
Chirag Singhal
2026-07-08 04:37:48 +05:30
committed by GitHub
parent 9450e03b1e
commit 3aeb87be7b
3 changed files with 151 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/sse/handlers/chat.ts
View File

@@ -240,18 +240,30 @@ export async function handleChat(
// reasoning_effort / reasoning / object-shaped thinking always wins (backward compatible).
body = normalizeReasoningRequest(body);
// Early guard: an explicitly empty `messages` array is invalid for every
// upstream (Anthropic/OpenAI both reject "at least one message is required").
// Forwarding it produced a confusing raw upstream 400/502; reject it here with
// a clear OmniRoute-level error before any routing or upstream call (#5110).
// Responses-API requests use `input` (not `messages`) so they are unaffected,
// and an absent `messages` field is left to downstream validation.
if (
Array.isArray((body as { messages?: unknown }).messages) &&
(body as { messages: unknown[] }).messages.length === 0
) {
log.warn("CHAT", "Rejecting request with empty messages array");
return errorResponse(HTTP_STATUS.BAD_REQUEST, "messages: at least one message is required");
// Early guard: an invalid `messages` field is rejected here with a clear
// OmniRoute-level 400 before any routing or upstream call (#5110, #6402).
// Without this guard, schema-invalid bodies fell through to model resolution
// and surfaced as a misleading 404 `model_not_found` from chatHelpers.ts (#6402).
// Cases covered:
// - present-but-non-array (null, number, string, object) → 400 (#6402)
// - empty array → 400 ("at least one message is required") (#5110)
// - missing entirely, when the Responses-API `input` discriminator is also
// absent → 400 (#6402). Responses-API requests use `input` (not `messages`)
// and are still unaffected.
{
const b = body as { messages?: unknown; input?: unknown };
if ("messages" in b && !Array.isArray(b.messages)) {
log.warn("CHAT", "Rejecting request with non-array messages");
return errorResponse(HTTP_STATUS.BAD_REQUEST, "messages: Expected array");
}
if (Array.isArray(b.messages) && b.messages.length === 0) {
log.warn("CHAT", "Rejecting request with empty messages array");
return errorResponse(HTTP_STATUS.BAD_REQUEST, "messages: at least one message is required");
}
if (!("messages" in b) && !("input" in b)) {
log.warn("CHAT", "Rejecting request with missing messages");
return errorResponse(HTTP_STATUS.BAD_REQUEST, "messages: Expected array, received undefined");
}
}
// Reject non-string `model` before it reaches downstream code that calls