mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-17 20:52:15 +03:00
fix(cli): fast-path --version to skip full CLI bootstrap
`omniroute --version` ran the entire CLI bootstrap before printing the version: the tsx/esm + polyfill imports, env-file loading, and Commander's ~70-command registration (importing DB, providers, OAuth, and other heavy modules). That took ~1.5s just to print a version string. Add isVersionFastPath() (bin/cli/utils/versionFastPath.mjs) and check it at the very top of bin/omniroute.mjs, before any of that work runs. It only trips for an unambiguous bare `--version`/`-V` invocation (no other args), so it never changes behavior for real commands or for `--help` (whose output is generated dynamically from every registered subcommand, so it still needs full registration and is deliberately not fast-pathed). `--version` now returns in ~0.3s instead of ~1.5s locally. Co-authored-by: Sutarto Jordan Chrisfivo <Jordannst@users.noreply.github.com> Inspired-by: https://github.com/decolua/9router/pull/2414
This commit is contained in:
25
bin/cli/utils/versionFastPath.mjs
Normal file
25
bin/cli/utils/versionFastPath.mjs
Normal file
@@ -0,0 +1,25 @@
|
||||
/**
|
||||
* Decide whether a CLI invocation is a bare `--version`/`-V` query that should
|
||||
* short-circuit BEFORE the runtime polyfill import, env-file loading, and
|
||||
* Commander's command registration (~70 command modules) are loaded.
|
||||
*
|
||||
* Scope is intentionally narrow — only a single, unambiguous `--version`/`-V`
|
||||
* argument fast-paths. Anything else (extra args, a subcommand, `--help`,
|
||||
* global options like `--lang`/`--output` alongside it) falls through to the
|
||||
* normal Commander flow. Unlike `--version`, OmniRoute's `--help` output is
|
||||
* generated dynamically from every registered subcommand, so skipping
|
||||
* registration would change (truncate) the help text — that flag is
|
||||
* deliberately NOT fast-pathed here.
|
||||
*
|
||||
* Mirrors the intent of upstream 9router PR #2414 (fast-path help/version
|
||||
* before expensive self-heal hooks), adapted to OmniRoute's Commander-based
|
||||
* CLI where the equivalent expensive work is eager command registration
|
||||
* rather than npm-install-based runtime self-healing.
|
||||
*
|
||||
* @param {string[]} argv - process.argv (node + script + args).
|
||||
* @returns {boolean}
|
||||
*/
|
||||
export function isVersionFastPath(argv) {
|
||||
const args = Array.isArray(argv) ? argv.slice(2) : [];
|
||||
return args.length === 1 && (args[0] === "--version" || args[0] === "-V");
|
||||
}
|
||||
Reference in New Issue
Block a user