fix(docker): warn when OMNIROUTE_MEMORY_MB disagrees with NODE_OPTIONS heap (#10818)

Merged — validated together with a batch of related RaviTharuma PRs in one combined worktree (typecheck:core clean, complexity/file-size/changelog gates green, focused tests passing). Thanks for the contribution!

scripts/dev/run-standalone.mjs

@@ -5,6 +5,8 @@ import {
   resolveRuntimePorts,
   withRuntimePortEnv,
   resolveMaxOldSpaceMb,
+  warnConflictingHeapLimits,
+  buildStandaloneNodeOptions,
   spawnWithForwardedSignals,
 } from "../build/runtime-env.mjs";
 import { bootstrapEnv } from "../build/bootstrap-env.mjs";
@@ -13,13 +15,13 @@ const env = bootstrapEnv();
 const runtimePorts = resolveRuntimePorts(env);
 const childEnv = withRuntimePortEnv(env, runtimePorts);
 
-// #2939: honor OMNIROUTE_MEMORY_MB (default 512), the same knob
-// `omniroute serve` uses, so Docker users can control the server heap under
-// load / large SQLite DBs. A trailing --max-old-space-size wins, so this
-// overrides the image fallback without clobbering any other NODE_OPTIONS flags.
+// #2939 / #10353: OMNIROUTE_MEMORY_MB is the Docker/standalone heap knob.
+// When it is set, we append --max-old-space-size last (V8 last-flag wins).
+// When it is unset and NODE_OPTIONS already pins the heap, keep NODE_OPTIONS
+// (#5238). Warn when both are set and the numbers disagree.
 const maxOldSpaceMb = resolveMaxOldSpaceMb(childEnv.OMNIROUTE_MEMORY_MB);
-childEnv.NODE_OPTIONS =
-  `${childEnv.NODE_OPTIONS || ""} --max-old-space-size=${maxOldSpaceMb}`.trim();
+warnConflictingHeapLimits(childEnv, maxOldSpaceMb);
+childEnv.NODE_OPTIONS = buildStandaloneNodeOptions(childEnv, maxOldSpaceMb);
 
 // Prefer the WS-aware wrapper (server-ws.mjs) over the bare Next standalone
 // server.js: it installs the trusted peer-IP stamp (scripts/dev/peer-stamp.mjs)