diff --git a/src/app/api/conductor/fleet/route.ts b/src/app/api/conductor/fleet/route.ts new file mode 100644 index 0000000000..d79abd5ad6 --- /dev/null +++ b/src/app/api/conductor/fleet/route.ts @@ -0,0 +1,17 @@ +/** + * GET /api/conductor/fleet — fleet snapshot for the Conductor dashboard panel + * (PRD Conductor RF3). Server-side proxy: the hub token lives only in env; the + * response is the whitelisted shape from hubProxy (degraded {offline:true} when + * the hub is unset/offline — never a 5xx for that). + */ + +import { NextResponse } from "next/server"; + +import { requireManagementAuth } from "@/lib/api/requireManagementAuth"; +import { getFleetSnapshot } from "@/lib/conductor/hubProxy"; + +export async function GET(request: Request) { + const authError = await requireManagementAuth(request); + if (authError) return authError; + return NextResponse.json(await getFleetSnapshot()); +} diff --git a/src/app/api/conductor/tasks/[id]/cancel/route.ts b/src/app/api/conductor/tasks/[id]/cancel/route.ts new file mode 100644 index 0000000000..5440a7ebf4 --- /dev/null +++ b/src/app/api/conductor/tasks/[id]/cancel/route.ts @@ -0,0 +1,26 @@ +/** + * POST /api/conductor/tasks/[id]/cancel — cancela a task no hub do Conductor. + * Ação destrutiva: auth de gerência + confirmação na UI (ConfirmModal). A + * recusa do hub volta só como status + mensagem sanitizada (nunca o corpo + * upstream — Hard Rule #12). + */ + +import { NextResponse } from "next/server"; + +import { createErrorResponse } from "@/lib/api/errorResponse"; +import { requireManagementAuth } from "@/lib/api/requireManagementAuth"; +import { cancelConductorTask } from "@/lib/conductor/hubProxy"; + +export async function POST(request: Request, ctx: { params: Promise<{ id: string }> }) { + const authError = await requireManagementAuth(request); + if (authError) return authError; + const { id } = await ctx.params; + const result = await cancelConductorTask(id); + if (!result.ok) { + return createErrorResponse({ + status: result.status, + message: `Conductor hub refused the cancellation (HTTP ${result.status})`, + }); + } + return NextResponse.json({ ok: true }); +} diff --git a/src/app/api/conductor/tasks/[id]/route.ts b/src/app/api/conductor/tasks/[id]/route.ts new file mode 100644 index 0000000000..379b78989f --- /dev/null +++ b/src/app/api/conductor/tasks/[id]/route.ts @@ -0,0 +1,22 @@ +/** + * GET /api/conductor/tasks/[id] — whitelisted task detail (manifest, prompt, + * council funnel) from the Conductor hub. 404 sanitizado quando o hub não + * conhece a task — o corpo do hub nunca é repassado. + */ + +import { NextResponse } from "next/server"; + +import { createErrorResponse } from "@/lib/api/errorResponse"; +import { requireManagementAuth } from "@/lib/api/requireManagementAuth"; +import { getConductorTaskDetail } from "@/lib/conductor/hubProxy"; + +export async function GET(request: Request, ctx: { params: Promise<{ id: string }> }) { + const authError = await requireManagementAuth(request); + if (authError) return authError; + const { id } = await ctx.params; + const detail = await getConductorTaskDetail(id); + if (!detail) { + return createErrorResponse({ status: 404, message: "Conductor task not found (or hub offline)" }); + } + return NextResponse.json(detail); +} diff --git a/tests/unit/conductor-fleet-route.test.ts b/tests/unit/conductor-fleet-route.test.ts new file mode 100644 index 0000000000..4fb4b88a2b --- /dev/null +++ b/tests/unit/conductor-fleet-route.test.ts @@ -0,0 +1,103 @@ +import test from "node:test"; +import assert from "node:assert/strict"; +import fs from "node:fs"; +import os from "node:os"; +import path from "node:path"; +import { createServer, type Server } from "node:http"; + +const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-conductor-route-")); +process.env.DATA_DIR = TEST_DATA_DIR; + +const core = await import("../../src/lib/db/core.ts"); +const fleetRoute = await import("../../src/app/api/conductor/fleet/route.ts"); +const detailRoute = await import("../../src/app/api/conductor/tasks/[id]/route.ts"); +const cancelRoute = await import("../../src/app/api/conductor/tasks/[id]/cancel/route.ts"); + +const servers: Server[] = []; + +function fakeHub(routes: Record): Promise { + const server = createServer((req, res) => { + const hit = Object.entries(routes).find(([p]) => (req.url ?? "").startsWith(p)); + res.writeHead(hit ? hit[1].status : 404, { "content-type": "application/json" }); + res.end(JSON.stringify(hit ? hit[1].body : { error: "hub: segredo interno que NÃO pode vazar" })); + }); + servers.push(server); + return new Promise((resolve) => { + server.listen(0, "127.0.0.1", () => { + const addr = server.address(); + resolve(`http://127.0.0.1:${typeof addr === "object" && addr ? addr.port : 0}`); + }); + }); +} + +test.beforeEach(() => { + core.resetDbInstance(); + fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true }); + fs.mkdirSync(TEST_DATA_DIR, { recursive: true }); + delete process.env.CONDUCTOR_HUB_URL; + delete process.env.CONDUCTOR_HUB_TOKEN; +}); + +test.after(async () => { + core.resetDbInstance(); + fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true }); + delete process.env.CONDUCTOR_HUB_URL; + while (servers.length > 0) { + const s = servers.pop(); + await new Promise((resolve) => s?.close(resolve)); + } +}); + +test("GET /api/conductor/fleet devolve snapshot whitelisted; sem hub → degradado 200", async () => { + process.env.CONDUCTOR_HUB_URL = await fakeHub({ + "/v1/runners": { + status: 200, + body: [{ id: "r_1", token: "VAZOU?", online: true, capabilities: { name: "devbox", clis: [{ profile: "claude" }] } }], + }, + "/v1/tasks": { + status: 200, + body: [{ id: "t_1", status: "working", mode: "solo", repo: { url: "https://x/r" }, assigned_runner: "r_1" }], + }, + }); + process.env.CONDUCTOR_HUB_TOKEN = "tok"; + const res = await fleetRoute.GET(new Request("http://localhost/api/conductor/fleet")); + assert.equal(res.status, 200); + const body = await res.json(); + assert.equal(body.offline, false); + assert.equal(body.runners[0].name, "devbox"); + assert.equal(body.tasks[0].status, "working"); + assert.ok(!JSON.stringify(body).includes("VAZOU?"), "token de runner não vaza pela rota"); + + delete process.env.CONDUCTOR_HUB_URL; // sem hub: degradado, nunca 500 + const down = await fleetRoute.GET(new Request("http://localhost/api/conductor/fleet")); + assert.equal(down.status, 200); + assert.equal((await down.json()).offline, true); +}); + +test("GET /api/conductor/tasks/[id] → 404 sanitizado quando o hub não conhece a task", async () => { + process.env.CONDUCTOR_HUB_URL = await fakeHub({}); + const res = await detailRoute.GET(new Request("http://localhost/api/conductor/tasks/t_x"), { + params: Promise.resolve({ id: "t_x" }), + }); + assert.equal(res.status, 404); + const text = await res.text(); + assert.ok(!text.includes("segredo interno"), "corpo do hub NUNCA repassado"); +}); + +test("POST cancel repassa recusa do hub com status, sem corpo upstream", async () => { + process.env.CONDUCTOR_HUB_URL = await fakeHub({ + "/v1/tasks/t_done/cancel": { status: 409, body: { error: "segredo interno que NÃO pode vazar" } }, + "/v1/tasks/t_ok/cancel": { status: 200, body: { ok: true } }, + }); + const denied = await cancelRoute.POST(new Request("http://localhost/x", { method: "POST" }), { + params: Promise.resolve({ id: "t_done" }), + }); + assert.equal(denied.status, 409); + assert.ok(!(await denied.text()).includes("segredo interno")); + + const ok = await cancelRoute.POST(new Request("http://localhost/x", { method: "POST" }), { + params: Promise.resolve({ id: "t_ok" }), + }); + assert.equal(ok.status, 200); + assert.deepEqual(await ok.json(), { ok: true }); +}); diff --git a/tests/unit/conductor-routes-auth.test.ts b/tests/unit/conductor-routes-auth.test.ts new file mode 100644 index 0000000000..8c35f1f5a6 --- /dev/null +++ b/tests/unit/conductor-routes-auth.test.ts @@ -0,0 +1,23 @@ +import test from "node:test"; +import assert from "node:assert/strict"; +import fs from "node:fs"; +import path from "node:path"; + +// Padrão budget-route-auth: prova pelo fonte que o gate de auth vem ANTES de qualquer uso do proxy. +const ROUTES = [ + "src/app/api/conductor/fleet/route.ts", + "src/app/api/conductor/tasks/[id]/route.ts", + "src/app/api/conductor/tasks/[id]/cancel/route.ts", +]; + +for (const route of ROUTES) { + test(`${route}: requireManagementAuth antes do proxy ao hub`, () => { + const src = fs.readFileSync(path.join(process.cwd(), route), "utf8"); + const authAt = src.indexOf("requireManagementAuth("); + assert.ok(authAt > 0, "handler chama requireManagementAuth"); + assert.match(src, /if \(authError\) return authError;/, "curto-circuito no erro de auth"); + const proxyAt = src.search(/getFleetSnapshot\(|getConductorTaskDetail\(|cancelConductorTask\(/); + assert.ok(proxyAt > authAt, "proxy ao hub só depois do gate de auth"); + assert.ok(!src.includes("CONDUCTOR_HUB_TOKEN"), "token nunca manuseado na rota (vive no hubProxy)"); + }); +}