From 662b2ba84d63d588a5c56c33bb0af61a48c507cb Mon Sep 17 00:00:00 2001 From: Diego Rodrigues de Sa e Souza Date: Mon, 20 Jul 2026 07:26:40 -0300 Subject: [PATCH] fix(dashboard): clear the two ghe-copilot typecheck regressions from #7546 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AgentEmoji's AGENT_COLORS is a Record; #7546 widened AgentId with 'ghe-copilot' without adding the entry (TS2741). GheConfigStep typed its error prop as `unknown` and rendered it directly, which is not a ReactNode (TS2322). Both are counted by check:dashboard-typecheck, which was failing on the pure release tip (261 live vs 259 frozen) and reddening Fast Quality Gates for every open PR. Now back to the frozen 259. --- changelog.d/maintenance/ghe-copilot-registry-mirrors.md | 1 + .../tools/traffic-inspector/components/shared/AgentEmoji.tsx | 1 + src/shared/components/oauthModal/GheConfigStep.tsx | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changelog.d/maintenance/ghe-copilot-registry-mirrors.md b/changelog.d/maintenance/ghe-copilot-registry-mirrors.md index 1462537c32..dbcae31d38 100644 --- a/changelog.d/maintenance/ghe-copilot-registry-mirrors.md +++ b/changelog.d/maintenance/ghe-copilot-registry-mirrors.md @@ -1 +1,2 @@ - fix(oauth): register `ghe-copilot` in the OAuth provider id map and the client-safe MITM host mirror, which #7546 left out of both — the gap turned the whole release branch red on `oauth-providers-config` and `mitm-tool-hosts` +- fix(dashboard): add the ghe-copilot entry to the traffic-inspector agent map and type `GheConfigStep`'s `error` prop as a renderable string, clearing the two dashboard-typecheck regressions #7546 left behind diff --git a/src/app/(dashboard)/dashboard/tools/traffic-inspector/components/shared/AgentEmoji.tsx b/src/app/(dashboard)/dashboard/tools/traffic-inspector/components/shared/AgentEmoji.tsx index 8cadbfd3b1..cc7560c257 100644 --- a/src/app/(dashboard)/dashboard/tools/traffic-inspector/components/shared/AgentEmoji.tsx +++ b/src/app/(dashboard)/dashboard/tools/traffic-inspector/components/shared/AgentEmoji.tsx @@ -6,6 +6,7 @@ const AGENT_COLORS: Record void; - error: unknown; + /** Rendered inline below the form; `unknown` is not a valid ReactNode. */ + error?: string | null; setError: (value: string) => void; startOAuthFlow: () => void; };