From 71eeaf293cd1ae7215592de74e7854131664f8de Mon Sep 17 00:00:00 2001 From: Markus Hartung Date: Mon, 24 Aug 2026 12:32:09 -0300 Subject: [PATCH] fix(combo): reconcile #11360 retry-loop persisted-cooldown recheck return shape MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The retry-loop recheck returned a non-conforming {ok:false, reason} object that breaks typecheck against the established {ok, response?} contract used everywhere else in this function. Aligns with the pre-dispatch skip pattern (return null after fallbackCount++), matching the PR's own intent: skip this target and move to the next, not error the whole attempt. This is a live fix — the broken shape reached origin/release/v3.8.50 via #11360's own squash-merge and was breaking typecheck:core until now. --- open-sse/services/combo.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/open-sse/services/combo.ts b/open-sse/services/combo.ts index b06577af4a..894c79033c 100644 --- a/open-sse/services/combo.ts +++ b/open-sse/services/combo.ts @@ -1524,7 +1524,8 @@ async function handleComboChatInner({ ); if (persistedRetrySkip) { log.info("COMBO", persistedRetrySkip); - return { ok: false, reason: "persisted_cooldown" }; + if (i > 0) fallbackCount++; + return null; } }