From 7afacf6c218bc19e926ca600870847daa9d62082 Mon Sep 17 00:00:00 2001 From: Xiangzhe Date: Wed, 26 Aug 2026 01:17:16 -0300 Subject: [PATCH] chore(quality): refresh the combos-page eslint suppressions after the manual-model restore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two changes, both consequences of restoring the expert-mode manual model block: - no-unused-vars drops 9 -> 6. Three of those suppressions existed only because #8285 deleted the JSX that consumed manualModelInput / handleAddManualModel and left the state behind as dead code. With the block back they are live again, and a stale suppression makes eslint exit 2 — which is what actually turned the Lint job red, not the react-hooks errors below. - Freeze the 7 react-hooks/set-state-in-effect + 1 react-hooks/immutability errors in this file. They are pre-existing: overwriting the file with its 091e2ba4da content reproduces all 8. They surfaced only because touching the file evicted it from the persisted .eslintcache the Lint job restores; 223 errors across 127 tracked files are masked the same way repo-wide. Fixing seven effects inside a 4841-line page during a release is the wrong trade, so they are frozen here and tracked separately. --- config/quality/eslint-suppressions.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/config/quality/eslint-suppressions.json b/config/quality/eslint-suppressions.json index cca4a3fb1c..81dc80bdee 100644 --- a/config/quality/eslint-suppressions.json +++ b/config/quality/eslint-suppressions.json @@ -955,7 +955,13 @@ }, "src/app/(dashboard)/dashboard/combos/page.tsx": { "@typescript-eslint/no-unused-vars": { - "count": 9 + "count": 6 + }, + "react-hooks/immutability": { + "count": 1 + }, + "react-hooks/set-state-in-effect": { + "count": 7 } }, "src/app/(dashboard)/dashboard/costs/CostOverviewTab.tsx": {