+
+ {tc("loading")}
diff --git a/tests/unit/ui/api-manager-loading-status-12066.test.tsx b/tests/unit/ui/api-manager-loading-status-12066.test.tsx
new file mode 100644
index 0000000000..48e5e33901
--- /dev/null
+++ b/tests/unit/ui/api-manager-loading-status-12066.test.tsx
@@ -0,0 +1,76 @@
+// @vitest-environment jsdom
+
+import React, { act } from "react";
+import { createRoot } from "react-dom/client";
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+(
+ globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT?: boolean }
+).IS_REACT_ACT_ENVIRONMENT = true;
+
+const translate = (key: string) => key;
+vi.mock("next-intl", () => ({
+ useLocale: () => "en",
+ useTranslations: () => Object.assign(translate, { has: () => false, rich: translate }),
+}));
+
+const { default: ApiManagerPageClient } =
+ await import("@/app/(dashboard)/dashboard/api-manager/ApiManagerPageClient");
+
+const roots: Array<{ root: ReturnType
; container: HTMLDivElement }> = [];
+
+function mountPage() {
+ const container = document.createElement("div");
+ document.body.appendChild(container);
+ const root = createRoot(container);
+ roots.push({ root, container });
+ act(() => root.render());
+ return container;
+}
+
+afterEach(() => {
+ for (const { root, container } of roots.splice(0)) {
+ act(() => root.unmount());
+ container.remove();
+ }
+ vi.restoreAllMocks();
+ vi.unstubAllGlobals();
+});
+
+describe("API manager loading gate accessibility (#12066)", () => {
+ it("exposes a busy polite status while the initial /api/keys fetch is pending", () => {
+ // Never settles: the page stays on its skeleton gate for the whole test.
+ vi.stubGlobal(
+ "fetch",
+ vi.fn(() => new Promise(() => undefined))
+ );
+
+ const container = mountPage();
+ const status = container.querySelector('[role="status"]');
+
+ expect(status).not.toBeNull();
+ expect(status?.getAttribute("aria-live")).toBe("polite");
+ expect(status?.getAttribute("aria-busy")).toBe("true");
+ // The only text in the accessibility tree during the gate is the loading label.
+ expect(status?.textContent).toContain("loading");
+ // The skeleton cards themselves stay decorative.
+ expect(container.querySelectorAll('[aria-hidden="true"]').length).toBeGreaterThan(0);
+ });
+
+ it("drops the loading status once /api/keys has settled", async () => {
+ vi.stubGlobal(
+ "fetch",
+ vi.fn(async () => ({ ok: true, json: async () => ({}) }))
+ );
+
+ const container = mountPage();
+ for (let i = 0; i < 40 && container.querySelector('[role="status"]'); i++) {
+ await act(async () => {
+ await new Promise((resolve) => setTimeout(resolve, 10));
+ });
+ }
+
+ expect(container.querySelector('[role="status"]')).toBeNull();
+ expect(container.querySelector("h1")).not.toBeNull();
+ });
+});
From b23b0ca68ec22e7f813fa92740e30eee199fa0d9 Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 22:42:08 +0200
Subject: [PATCH 11/20] fix(gemini): strip prefixItems from Gemini tool schemas
(#12540)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
High-impact and precisely diagnosed: `prefixItems` missing from the strip-list rejected every tool-bearing Claude Code request routed to Gemini before generation, because Claude Code's built-in tools describe line ranges as tuples. All three tool shapes going through the same cleaner is what makes the one-key fix sufficient.
---
Validated in one consolidated worktree cut from `release/v3.8.51`, boarded with the rest of this batch — zero conflicts between the 19 PRs.
- `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, all within the frozen baseline); `check:changelog-integrity` OK
- complexity 2802 / baseline 3218 and cognitive-complexity 1267 / baseline 1437 — both under baseline
- 226 of 228 focused assertions green across the batch's 23 test files. The 2 remaining belong to #12551, which is held separately.
Two batch-owned defects were found and fixed in flight, both pure base drift: `173_xp_action_counts.sql` collided with `173_call_logs_video_content_removed.sql` (renumbered to 176 on #12651 — it aborted every DB open, which is what 53 of the first run's failures were), and the feature-flag catalog was missing the `SERVER_OWNED_TOOL_LOOP_ENABLED` row the base gained after #12552 was written.
⚠️ base-red inherited: #12732 — `Docs Gates`, `Merge integrity`, `No new ESLint warnings`, `Unit Tests fast-path` and `Fast Quality Gates` reproduce on the pure tip (provider count 356 vs the 358 the modules define, SKILL.md drift, and `open-sse/utils/stream.ts` at 3115 > frozen 3098, which this batch does not touch).
Thanks @pacocartones — the `file:line` citations and the explicit out-of-scope notes on every one of these made a 19-PR batch reviewable in one pass.
---
.../12540-gemini-strip-prefixitems-nested.md | 1 +
open-sse/translator/helpers/geminiHelper.ts | 6 +
tests/unit/12509-gemini-prefixitems.test.ts | 141 ++++++++++++++++++
3 files changed, 148 insertions(+)
create mode 100644 changelog.d/fixes/12540-gemini-strip-prefixitems-nested.md
create mode 100644 tests/unit/12509-gemini-prefixitems.test.ts
diff --git a/changelog.d/fixes/12540-gemini-strip-prefixitems-nested.md b/changelog.d/fixes/12540-gemini-strip-prefixitems-nested.md
new file mode 100644
index 0000000000..d1b24b21ab
--- /dev/null
+++ b/changelog.d/fixes/12540-gemini-strip-prefixitems-nested.md
@@ -0,0 +1 @@
+- **fix(gemini):** strip the JSON-Schema-2020-12 `prefixItems` keyword from Gemini tool schemas at every nesting level, so Claude Code tool definitions no longer fail with `400 Unknown name "prefixItems"` on Gemini models (#12540 — thanks @pacocartones)
diff --git a/open-sse/translator/helpers/geminiHelper.ts b/open-sse/translator/helpers/geminiHelper.ts
index 95fea6dcea..fefa882c35 100644
--- a/open-sse/translator/helpers/geminiHelper.ts
+++ b/open-sse/translator/helpers/geminiHelper.ts
@@ -63,6 +63,12 @@ export const GEMINI_UNSUPPORTED_SCHEMA_KEYS = new Set([
// it, rejecting the whole request with "Unknown name \"uniqueItems\"".
// Upstream 9router already strips it alongside `contains` for the same error.
"uniqueItems",
+ // #12509: JSON-Schema-2020-12 tuple keyword. Claude Code's built-in tools
+ // describe `[start_line, end_line]` ranges with it (nested under `items`),
+ // and Gemini's schema parser rejects the whole tool list with
+ // "Unknown name \"prefixItems\" ... Cannot find field". ensureArrayItems
+ // below still guarantees an `items` schema for the tuple-typed array.
+ "prefixItems",
// Complex schema keywords (handled by flattenAnyOfOneOf/mergeAllOf)
"anyOf",
"oneOf",
diff --git a/tests/unit/12509-gemini-prefixitems.test.ts b/tests/unit/12509-gemini-prefixitems.test.ts
new file mode 100644
index 0000000000..43ea7ab015
--- /dev/null
+++ b/tests/unit/12509-gemini-prefixitems.test.ts
@@ -0,0 +1,141 @@
+import assert from "node:assert/strict";
+import { test } from "node:test";
+
+import { buildGeminiTools } from "../../open-sse/translator/helpers/geminiToolsSanitizer.ts";
+import { GEMINI_UNSUPPORTED_SCHEMA_KEYS } from "../../open-sse/translator/helpers/geminiHelper.ts";
+
+// Issue #12509: Gemini rejects the JSON-Schema-2020-12 tuple keyword `prefixItems` in
+// function_declarations parameter schemas with HTTP 400
+// `Unknown name "prefixItems" at 'tools[0].function_declarations[1].parameters.properties[5]
+// .value.properties[0].value.items': Cannot find field.` — the same class of error already
+// fixed for `uniqueItems` (#9617), `multipleOf`, `strict` and `encrypted` in
+// GEMINI_UNSUPPORTED_SCHEMA_KEYS (open-sse/translator/helpers/geminiHelper.ts).
+
+type GeminiFunctionDeclaration = { name: string; parameters: Record };
+
+function declarationsOf(tools: unknown[]): GeminiFunctionDeclaration[] {
+ const geminiTools = buildGeminiTools(tools) as Array<{
+ functionDeclarations?: GeminiFunctionDeclaration[];
+ }> | null;
+ assert.ok(geminiTools, "expected buildGeminiTools to return a tools array");
+ return geminiTools.flatMap((tool) => tool.functionDeclarations ?? []);
+}
+
+function assertNoPrefixItems(tools: unknown[]): GeminiFunctionDeclaration[] {
+ const declarations = declarationsOf(tools);
+ const serialized = JSON.stringify(declarations);
+ assert.equal(
+ serialized.includes("prefixItems"),
+ false,
+ `prefixItems leaked into the Gemini payload (would trigger upstream 400 "Unknown name \\"prefixItems\\""): ${serialized}`
+ );
+ return declarations;
+}
+
+// The reporter's shape: a tuple nested under `items` — an array of `[start_line, end_line]`
+// ranges, i.e. `properties.ranges.items.prefixItems`.
+const nestedTupleParameters = {
+ type: "object",
+ properties: {
+ file_path: { type: "string" },
+ ranges: {
+ type: "array",
+ description: "Line ranges to read",
+ items: {
+ type: "array",
+ prefixItems: [{ type: "integer" }, { type: "integer" }],
+ items: false,
+ minItems: 2,
+ maxItems: 2,
+ },
+ },
+ },
+ required: ["file_path", "ranges"],
+};
+
+test("buildGeminiTools strips prefixItems nested under items (OpenAI tool shape, issue #12509)", () => {
+ const [declaration] = assertNoPrefixItems([
+ {
+ type: "function",
+ function: {
+ name: "read_ranges",
+ description: "tuple-typed array parameter nested under items",
+ parameters: nestedTupleParameters,
+ },
+ },
+ ]);
+
+ const ranges = (declaration.parameters.properties as Record>)
+ .ranges;
+ assert.equal(ranges.type, "array");
+ const inner = ranges.items as Record;
+ assert.equal(inner.type, "array");
+ assert.ok(inner.items && typeof inner.items === "object", "inner array keeps an items schema");
+});
+
+test("buildGeminiTools strips prefixItems from a Claude input_schema (issue #12509)", () => {
+ const [declaration] = assertNoPrefixItems([
+ {
+ name: "read_ranges",
+ description: "Claude Messages tool shape",
+ input_schema: nestedTupleParameters,
+ },
+ ]);
+ assert.equal(declaration.name, "read_ranges");
+});
+
+test("buildGeminiTools strips a top-level prefixItems tuple and keeps a usable items schema (issue #12509)", () => {
+ const [declaration] = assertNoPrefixItems([
+ {
+ type: "function",
+ function: {
+ name: "read_range",
+ description: "single [start_line, end_line] tuple",
+ parameters: {
+ type: "object",
+ properties: {
+ range: {
+ type: "array",
+ prefixItems: [{ type: "integer" }, { type: "integer" }],
+ },
+ },
+ required: ["range"],
+ },
+ },
+ },
+ ]);
+
+ const range = (declaration.parameters.properties as Record>)
+ .range;
+ assert.equal(range.type, "array");
+ assert.ok(range.items && typeof range.items === "object", "Gemini requires items on arrays");
+});
+
+test("buildGeminiTools strips prefixItems that sits next to a regular items schema (issue #12509)", () => {
+ const [declaration] = assertNoPrefixItems([
+ {
+ type: "function",
+ function: {
+ name: "pair",
+ description: "tuple keyword as a sibling of a regular items schema",
+ parameters: {
+ type: "object",
+ properties: {
+ pair: {
+ type: "array",
+ prefixItems: [{ type: "string" }],
+ items: { type: "string" },
+ },
+ },
+ },
+ },
+ },
+ ]);
+
+ const pair = (declaration.parameters.properties as Record>).pair;
+ assert.deepEqual(pair.items, { type: "string" });
+});
+
+test("prefixItems is registered in GEMINI_UNSUPPORTED_SCHEMA_KEYS (issue #12509)", () => {
+ assert.ok(GEMINI_UNSUPPORTED_SCHEMA_KEYS.has("prefixItems"));
+});
From 0831d487c0e5f84d8964c2bcf219c27ca5f461dd Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 22:42:12 +0200
Subject: [PATCH 12/20] fix(audio): resolve combo names on
/v1/audio/translations (#12536)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Translations was the one audio route the combo-resolution fixes never reached, so the same combo name worked on `/v1/audio/transcriptions` and failed here. Following the #9382 shape rather than inventing a new one is the right call.
---
Validated in one consolidated worktree cut from `release/v3.8.51`, boarded with the rest of this batch — zero conflicts between the 19 PRs.
- `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, all within the frozen baseline); `check:changelog-integrity` OK
- complexity 2802 / baseline 3218 and cognitive-complexity 1267 / baseline 1437 — both under baseline
- 226 of 228 focused assertions green across the batch's 23 test files. The 2 remaining belong to #12551, which is held separately.
Two batch-owned defects were found and fixed in flight, both pure base drift: `173_xp_action_counts.sql` collided with `173_call_logs_video_content_removed.sql` (renumbered to 176 on #12651 — it aborted every DB open, which is what 53 of the first run's failures were), and the feature-flag catalog was missing the `SERVER_OWNED_TOOL_LOOP_ENABLED` row the base gained after #12552 was written.
⚠️ base-red inherited: #12732 — `Docs Gates`, `Merge integrity`, `No new ESLint warnings`, `Unit Tests fast-path` and `Fast Quality Gates` reproduce on the pure tip (provider count 356 vs the 358 the modules define, SKILL.md drift, and `open-sse/utils/stream.ts` at 3115 > frozen 3098, which this batch does not touch).
Thanks @pacocartones — the `file:line` citations and the explicit out-of-scope notes on every one of these made a 19-PR batch reviewable in one pass.
---
...536-audio-translations-combo-resolution.md | 1 +
src/app/api/v1/audio/translations/route.ts | 122 ++++++++++++----
...udio-translations-combo-resolution.test.ts | 131 ++++++++++++++++++
3 files changed, 226 insertions(+), 28 deletions(-)
create mode 100644 changelog.d/fixes/12536-audio-translations-combo-resolution.md
create mode 100644 tests/unit/audio-translations-combo-resolution.test.ts
diff --git a/changelog.d/fixes/12536-audio-translations-combo-resolution.md b/changelog.d/fixes/12536-audio-translations-combo-resolution.md
new file mode 100644
index 0000000000..0f16b8f32e
--- /dev/null
+++ b/changelog.d/fixes/12536-audio-translations-combo-resolution.md
@@ -0,0 +1 @@
+- **fix(audio):** `/v1/audio/translations` now resolves combo names the way `/v1/audio/transcriptions` already does, so a combo that `GET /v1/models` advertises is fanned out to its targets instead of being rejected with `400 Invalid translation model: . Use format: provider/model`; literal `provider/model` ids and unknown bare names behave as before (#12536 — thanks @pacocartones)
diff --git a/src/app/api/v1/audio/translations/route.ts b/src/app/api/v1/audio/translations/route.ts
index f0c0acfa4e..65c45d0268 100644
--- a/src/app/api/v1/audio/translations/route.ts
+++ b/src/app/api/v1/audio/translations/route.ts
@@ -19,6 +19,25 @@ import {
} from "@/app/api/v1/_shared/rateLimit";
import { attachOmniRouteMetaToResponse } from "@/domain/omnirouteResponseMeta";
import { generateRequestId } from "@/shared/utils/requestId";
+import { getComboByName, getCombos } from "@/lib/db/combos";
+import { getDatabaseSettings } from "@/lib/db/databaseSettings";
+import { handleComboChat } from "@omniroute/open-sse/services/combo.ts";
+import { log } from "@omniroute/open-sse/utils/logger.ts";
+
+/**
+ * Copy a multipart body, swapping only the `model` field. Combo fan-out needs one
+ * body per target, and the uploaded file part is reused as-is (a Blob can be read
+ * more than once).
+ */
+function withModel(formData: FormData, modelStr: string): FormData {
+ const next = new FormData();
+ for (const [key, value] of formData.entries()) {
+ if (key === "model") continue;
+ next.append(key, value as string | Blob);
+ }
+ next.set("model", modelStr);
+ return next;
+}
/**
* Handle CORS preflight
@@ -33,30 +52,14 @@ export async function OPTIONS() {
}
/**
- * POST /v1/audio/translations — translate audio to English text
- * OpenAI Whisper API compatible (multipart/form-data). Unlike
- * /v1/audio/transcriptions, output is always English regardless of the
- * source audio language.
+ * Translate with one concrete `provider/model` string. Split out of POST so combo
+ * fan-out can invoke it once per target.
*/
-export async function POST(request) {
- let formData;
- try {
- formData = await request.formData();
- } catch {
- return errorResponse(HTTP_STATUS.BAD_REQUEST, "Invalid multipart form data");
- }
-
- const startTime = Date.now();
-
- const model = formData.get("model");
- if (!model) {
- return errorResponse(HTTP_STATUS.BAD_REQUEST, "Missing model");
- }
-
- // Enforce API key policies (model restrictions + budget limits)
- const policy = await enforceApiKeyPolicy(request, model as string);
- if (policy.rejection) return policy.rejection;
-
+async function translateWithModel(
+ formData: FormData,
+ modelStr: string,
+ startTime: number
+): Promise {
// Translation is served by the transcription-capable nodes (Whisper-style
// endpoints expose both), plus general chat/responses gateways. Remote hosts are
// opt-in (default OFF).
@@ -65,14 +68,11 @@ export async function POST(request) {
"audio-transcriptions"
);
- const { provider, model: resolvedModel } = parseTranslationModel(
- model as string,
- dynamicProviders
- );
+ const { provider, model: resolvedModel } = parseTranslationModel(modelStr, dynamicProviders);
if (!provider) {
return errorResponse(
HTTP_STATUS.BAD_REQUEST,
- `Invalid translation model: ${model}. Use format: provider/model`
+ `Invalid translation model: ${modelStr}. Use format: provider/model`
);
}
@@ -84,6 +84,8 @@ export async function POST(request) {
let credentials = null;
if (providerConfig && providerConfig.authType !== "none") {
const credentialKey = providerConfig.credentialProviderId || provider;
+ // NOTE: the 2nd arg of this helper is `excludeConnectionId`, not "use this
+ // connection" — a combo target's connectionId must never be passed here.
credentials = await getProviderCredentialsWithQuotaPreflight(credentialKey);
if (!credentials) {
return errorResponse(HTTP_STATUS.BAD_REQUEST, `No credentials for provider: ${provider}`);
@@ -113,3 +115,67 @@ export async function POST(request) {
}
return response;
}
+
+/**
+ * POST /v1/audio/translations — translate audio to English text
+ * OpenAI Whisper API compatible (multipart/form-data). Unlike
+ * /v1/audio/transcriptions, output is always English regardless of the
+ * source audio language.
+ */
+export async function POST(request) {
+ let formData;
+ try {
+ formData = await request.formData();
+ } catch {
+ return errorResponse(HTTP_STATUS.BAD_REQUEST, "Invalid multipart form data");
+ }
+
+ const startTime = Date.now();
+
+ const model = formData.get("model");
+ if (!model) {
+ return errorResponse(HTTP_STATUS.BAD_REQUEST, "Missing model");
+ }
+ const modelStr = String(model);
+
+ // Enforce API key policies (model restrictions + budget limits)
+ const policy = await enforceApiKeyPolicy(request, modelStr);
+ if (policy.rejection) return policy.rejection;
+
+ // A bare name (no "/") may be a combo. /v1/models advertises combos, and chat,
+ // embeddings and the sibling /v1/audio/transcriptions all resolve them —
+ // resolving here too keeps the catalog honest and frees callers from hardcoding
+ // a provider's internal model id.
+ if (!modelStr.includes("/")) {
+ try {
+ const combo = await getComboByName(modelStr);
+ if (combo) {
+ let allCombos: Awaited> = [];
+ try {
+ allCombos = await getCombos();
+ } catch {}
+ let settings = {};
+ try {
+ settings = getDatabaseSettings();
+ } catch {}
+
+ return handleComboChat({
+ body: { model: modelStr } as any,
+ combo: combo as any,
+ handleSingleModel: async (_reqBody: any, targetModelStr: string) =>
+ translateWithModel(withModel(formData, targetModelStr), targetModelStr, startTime),
+ isModelAvailable: undefined,
+ log,
+ settings,
+ allCombos: allCombos as any,
+ relayOptions: undefined,
+ signal: undefined,
+ } as any);
+ }
+ } catch (err) {
+ log.error("AUDIO", `Combo resolution failed for ${modelStr}: ${err}`);
+ }
+ }
+
+ return translateWithModel(formData, modelStr, startTime);
+}
diff --git a/tests/unit/audio-translations-combo-resolution.test.ts b/tests/unit/audio-translations-combo-resolution.test.ts
new file mode 100644
index 0000000000..aa4defe26a
--- /dev/null
+++ b/tests/unit/audio-translations-combo-resolution.test.ts
@@ -0,0 +1,131 @@
+// Regression test: /v1/audio/translations must resolve combo names.
+//
+// /v1/models advertises combos, and /v1/chat/completions, /v1/embeddings,
+// /v1/audio/transcriptions (#9134), /v1/audio/speech and /v1/videos/generations
+// (#10469) all resolve them — but the translation route still treated the model
+// string as a literal `provider/model` id only. A combo name therefore came back as
+// `400 Invalid translation model: . Use format: provider/model`, so any
+// client populating a model picker from /v1/models offered an option the endpoint
+// rejected, and callers had to hardcode the provider's internal model id.
+//
+// This asserts the combo is expanded to its target before dispatch (observed at the
+// upstream fetch: URL and multipart `model`), that a literal provider/model id still
+// dispatches directly, and that an unknown bare name keeps the format hint.
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+
+const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-audio-translations-combo-"));
+process.env.DATA_DIR = TEST_DATA_DIR;
+
+const core = await import("../../src/lib/db/core.ts");
+const { createCombo } = await import("../../src/lib/db/combos.ts");
+const { createProviderNode } = await import("../../src/lib/db/providers.ts");
+const route = await import("../../src/app/api/v1/audio/translations/route.ts");
+
+const originalFetch = globalThis.fetch;
+
+test.after(() => {
+ globalThis.fetch = originalFetch;
+ core.resetDbInstance();
+ fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
+});
+
+/** Minimal but structurally valid WAV so nothing rejects the upload shape. */
+function makeWav(): Blob {
+ const dataLen = 1600;
+ const b = Buffer.alloc(44 + dataLen);
+ b.write("RIFF", 0, "ascii");
+ b.writeUInt32LE(36 + dataLen, 4);
+ b.write("WAVE", 8, "ascii");
+ b.write("fmt ", 12, "ascii");
+ b.writeUInt32LE(16, 16);
+ b.writeUInt16LE(1, 20);
+ b.writeUInt16LE(1, 22);
+ b.writeUInt32LE(16000, 24);
+ b.writeUInt32LE(32000, 28);
+ b.writeUInt16LE(2, 32);
+ b.writeUInt16LE(16, 34);
+ b.write("data", 36, "ascii");
+ b.writeUInt32LE(dataLen, 40);
+ return new Blob([b], { type: "audio/wav" });
+}
+
+function translationRequest(model: string) {
+ const fd = new FormData();
+ fd.set("model", model);
+ fd.set("file", makeWav(), "t.wav");
+ return new Request("http://localhost/v1/audio/translations", { method: "POST", body: fd });
+}
+
+/** Capture every upstream call: URL plus the decoded multipart body the handler built. */
+function captureUpstream(): Array<{ url: string; body: string }> {
+ const calls: Array<{ url: string; body: string }> = [];
+ globalThis.fetch = (async (url: RequestInfo | URL, init: RequestInit = {}) => {
+ calls.push({
+ url: String(url),
+ body: new TextDecoder().decode(init.body as Uint8Array),
+ });
+ return new Response(JSON.stringify({ text: "ok" }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ });
+ }) as typeof fetch;
+ return calls;
+}
+
+test.before(async () => {
+ await createProviderNode({
+ id: "openai-compatible-audio-translations-test",
+ type: "openai-compatible",
+ name: "Local STT",
+ prefix: "localstt",
+ apiType: "audio-transcriptions",
+ baseUrl: "http://localhost:9000/v1",
+ } as Parameters[0]);
+
+ await createCombo({
+ name: "traducao",
+ strategy: "priority",
+ models: [{ provider: "localstt", model: "whisper-1" }],
+ } as Parameters[0]);
+});
+
+test("a combo name is expanded to its target instead of being rejected", async () => {
+ const calls = captureUpstream();
+
+ const res = await route.POST(translationRequest("traducao"));
+ const body = await res.text();
+
+ assert.equal(res.status, 200, `combo name must not be rejected — got: ${body}`);
+ assert.deepEqual(JSON.parse(body), { text: "ok" });
+ assert.equal(calls.length, 1, `expected exactly one upstream call, got ${calls.length}`);
+ assert.equal(calls[0].url, "http://localhost:9000/v1/audio/translations");
+ assert.match(calls[0].body, /name="model"\r\n\r\nwhisper-1\r\n/);
+ assert.doesNotMatch(calls[0].body, /name="model"\r\n\r\ntraducao\r\n/);
+});
+
+test("a literal provider/model id still dispatches directly", async () => {
+ const calls = captureUpstream();
+
+ const res = await route.POST(translationRequest("localstt/whisper-1"));
+
+ assert.equal(res.status, 200);
+ assert.equal(calls.length, 1);
+ assert.equal(calls[0].url, "http://localhost:9000/v1/audio/translations");
+ assert.match(calls[0].body, /name="model"\r\n\r\nwhisper-1\r\n/);
+});
+
+test("an unknown bare name is still rejected with the format hint", async () => {
+ const calls = captureUpstream();
+
+ const res = await route.POST(translationRequest("definitely-not-a-combo-or-model"));
+ const body = await res.text();
+
+ assert.equal(res.status, 400);
+ assert.match(body, /Invalid translation model/);
+ assert.equal(calls.length, 0);
+});
From e09cb5a76885d9198faf8ed34f6c757c4cc428c7 Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 22:42:16 +0200
Subject: [PATCH 13/20] chore(lifecycle): gate DEFAULT_DEGRADATION_MAP against
retired ids (#12535)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Third hand-maintained table naming model ids and the only one outside the retired-model gate — extending `check-model-lifecycle.mjs` to cover it is the durable fix, and the three retired rows it flushed out were already dead code behind the 410 `model_shutdown` answer.
---
Validated in one consolidated worktree cut from `release/v3.8.51`, boarded with the rest of this batch — zero conflicts between the 19 PRs.
- `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, all within the frozen baseline); `check:changelog-integrity` OK
- complexity 2802 / baseline 3218 and cognitive-complexity 1267 / baseline 1437 — both under baseline
- 226 of 228 focused assertions green across the batch's 23 test files. The 2 remaining belong to #12551, which is held separately.
Two batch-owned defects were found and fixed in flight, both pure base drift: `173_xp_action_counts.sql` collided with `173_call_logs_video_content_removed.sql` (renumbered to 176 on #12651 — it aborted every DB open, which is what 53 of the first run's failures were), and the feature-flag catalog was missing the `SERVER_OWNED_TOOL_LOOP_ENABLED` row the base gained after #12552 was written.
⚠️ base-red inherited: #12732 — `Docs Gates`, `Merge integrity`, `No new ESLint warnings`, `Unit Tests fast-path` and `Fast Quality Gates` reproduce on the pure tip (provider count 356 vs the 358 the modules define, SKILL.md drift, and `open-sse/utils/stream.ts` at 3115 > frozen 3098, which this batch does not touch).
Thanks @pacocartones — the `file:line` citations and the explicit out-of-scope notes on every one of these made a 19-PR batch reviewable in one pass.
---
.../12535-lifecycle-gate-degradation-map.md | 7 +++
docs/architecture/QUALITY_GATES.md | 56 +++++++++----------
open-sse/services/backgroundTaskDetector.ts | 8 ++-
scripts/check/check-model-lifecycle.mjs | 56 +++++++++++++++----
tests/unit/check-model-lifecycle-gate.test.ts | 32 ++++++++++-
.../model-lifecycle-degradation-map.test.ts | 56 +++++++++++++++++++
6 files changed, 173 insertions(+), 42 deletions(-)
create mode 100644 changelog.d/maintenance/12535-lifecycle-gate-degradation-map.md
create mode 100644 tests/unit/model-lifecycle-degradation-map.test.ts
diff --git a/changelog.d/maintenance/12535-lifecycle-gate-degradation-map.md b/changelog.d/maintenance/12535-lifecycle-gate-degradation-map.md
new file mode 100644
index 0000000000..f667999ac9
--- /dev/null
+++ b/changelog.d/maintenance/12535-lifecycle-gate-degradation-map.md
@@ -0,0 +1,7 @@
+- **chore(lifecycle):** `check:model-lifecycle` now also diffs `DEFAULT_DEGRADATION_MAP`
+ (the background-task redirect table) against the vendor lifecycle snapshot, refusing a
+ retired id as source or target, with a table-driven unit test beside it. Three rows
+ whose source the vendor had retired — `claude-sonnet-4-20250514`, `gemini-3-pro-preview`
+ and `gpt-5.1-codex` (whose target `gpt-5.1-codex-mini` is retired too) — were dead code,
+ since `checkLifecycle` answers 410 before the redirect runs; they are dropped
+ (#12535 — thanks @pacocartones)
diff --git a/docs/architecture/QUALITY_GATES.md b/docs/architecture/QUALITY_GATES.md
index 4b4315cc4d..feb11fad25 100644
--- a/docs/architecture/QUALITY_GATES.md
+++ b/docs/architecture/QUALITY_GATES.md
@@ -57,34 +57,34 @@ assertion weakening and other masking remain owned by the independently blocking
Runs on every PR to `main`. Blocks merge on failure.
-| Script (`npm run ...`) | Validates | Blocking |
-| --------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------- |
-| `check:node-runtime` | Node.js version is within the supported range | Yes |
-| `check:cycles` | Circular imports — all `src/` + `open-sse/` modules | Yes |
-| `check:route-validation:t06` | Zod schemas present on all routes (Tier 6 policy) | Yes |
-| `check:any-budget:t11` | `@ts-expect-error // any` count does not exceed budget (Tier 11 catraca) | Yes |
-| `check:provider-consistency` | Every provider in `providers.ts` has a matching entry in `providerRegistry.ts` (and vice-versa, within the allowlist) | Yes |
-| `check:model-lifecycle` | The two hand-maintained routing tables do not point at retired models (#11503): `FITNESS_TABLE` (`taskFitness.ts`) scores no routable retired id, every `BUILT_IN_ALIASES` target is a live catalog model, and every retired id the catalog still routes is either forwarded or listed in `allowedRetiredInCatalog`. Offline — compares against the vendor snapshot `config/quality/model-lifecycle.json`, refreshed by hand with `npm run quality:refresh-model-lifecycle` (network; not wired into CI). `allowedRetiredInCatalog` is a burn-down ratchet: add an entry only with a tracking issue. | Yes |
-| `check:fetch-targets` | Every `fetch("/api/...")` in client-side `src/` resolves to a real `route.ts` | Yes |
-| `check:deps` | All `npm install`-able deps across every `package.json` in the repo are in `dependency-allowlist.json`; new unpinned or slopsquatted packages flagged | Yes |
-| `audit:deps` | `npm audit` (root + electron) — no high/critical advisories (overlaps osv `check:vuln-ratchet`; see Rationalization Backlog) | Yes |
-| `check:lockfile` | `package-lock.json` integrity — https registry, integrity hashes, no host overrides | Yes |
-| `check:licenses` | SPDX license allowlist for production dependencies | Yes |
-| `check:tracked-artifacts` | No build artifacts / committed `node_modules` symlinks (also runs in husky pre-commit; pre-push is intentionally light — #6716) | Yes |
-| `check:file-size` | No source file exceeds the per-extension cap (ratchet: frozen large files in `frozen` list) | Yes |
-| `check:error-helper` | Error responses in executors/handlers use `buildErrorBody()` / `sanitizeErrorMessage()` (Hard Rule #12) | Yes |
-| `check:migration-numbering` | Migration SQL files are sequentially numbered, no gaps or duplicates | Yes |
-| `check:public-creds` | No literal OAuth `client_id`/`client_secret` or Firebase Web keys outside `publicCreds.ts` (Hard Rule #11) | Yes |
-| `check:db-rules` | No raw SQL outside `src/lib/db/` modules; no barrel-imports from `localDb.ts` (Hard Rules #2/#5) | Yes |
-| `check:known-symbols` | Provider executors, routing strategies, and translators registered in their dispatch tables match the files on disk — no orphaned or undeclared symbols | Yes |
-| `check:route-guard-membership` | Every route that spawns a child process is classified by `isLocalOnlyPath()` (Hard Rules #15/#17) | Yes |
-| `check:test-discovery` | Every `*.test.ts` / `*.spec.ts` file in the repo is collected by at least one test runner (ratchet: orphan list in `test-discovery-baseline.json` can only shrink) | Yes |
-| `check:agent-skills-sync` | Generated agent-skills artifacts match their source catalog (no drift) |
-| `check:provider-asset-provenance` | Provider logos/assets carry a recorded provenance entry |
-| `lint:json` | JSON config files parse and satisfy the repo lint rules |
-| `typecheck:core` | TypeScript compilation without errors (advisory warnings only) | Yes |
-| `typecheck:noimplicit:core` | Strict `noImplicitAny` — forward-looking; many pre-existing call sites still need annotations | **Advisory** (`continue-on-error: true`) |
-| `check:dashboard-typecheck` | `tsc` scoped to `src/app/(dashboard)/**` (#7033) — `typecheck:core`'s curated 27-file allowlist does not include any dashboard TSX, and `next build` never type-checks it either (`next.config.mjs` sets `ignoreBuildErrors: true`), so orphaned-identifier regressions there (#6625/#6909) were invisible to CI. Diffs against a frozen per-file/per-TS-code count baseline (`config/quality/dashboard-typecheck-baseline.json`, same stale-enforcement pattern as `check:known-symbols`) — only NEW errors beyond the baselined count fail the gate; ratchet down with `--update` when a pre-existing error is fixed. | Yes |
+| Script (`npm run ...`) | Validates | Blocking |
+| --------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------- |
+| `check:node-runtime` | Node.js version is within the supported range | Yes |
+| `check:cycles` | Circular imports — all `src/` + `open-sse/` modules | Yes |
+| `check:route-validation:t06` | Zod schemas present on all routes (Tier 6 policy) | Yes |
+| `check:any-budget:t11` | `@ts-expect-error // any` count does not exceed budget (Tier 11 catraca) | Yes |
+| `check:provider-consistency` | Every provider in `providers.ts` has a matching entry in `providerRegistry.ts` (and vice-versa, within the allowlist) | Yes |
+| `check:model-lifecycle` | The three hand-maintained routing tables stay consistent with the checked-in lifecycle snapshot (#11503): `FITNESS_TABLE` (`taskFitness.ts`) scores no retired id that `REGISTRY` can route; every `BUILT_IN_ALIASES` target is present in `REGISTRY` and absent from the retired-id snapshot; every retired id still in `REGISTRY` is forwarded or listed in `allowedRetiredInCatalog`; and no `DEFAULT_DEGRADATION_MAP` source or target appears retired in that snapshot. This does not prove that a model is currently served by a live upstream. Offline — compares against `config/quality/model-lifecycle.json`, refreshed by hand with `npm run quality:refresh-model-lifecycle` (network; not wired into CI). `allowedRetiredInCatalog` is a burn-down ratchet: add an entry only with a tracking issue. | Yes |
+| `check:fetch-targets` | Every `fetch("/api/...")` in client-side `src/` resolves to a real `route.ts` | Yes |
+| `check:deps` | All `npm install`-able deps across every `package.json` in the repo are in `dependency-allowlist.json`; new unpinned or slopsquatted packages flagged | Yes |
+| `audit:deps` | `npm audit` (root + electron) — no high/critical advisories (overlaps osv `check:vuln-ratchet`; see Rationalization Backlog) | Yes |
+| `check:lockfile` | `package-lock.json` integrity — https registry, integrity hashes, no host overrides | Yes |
+| `check:licenses` | SPDX license allowlist for production dependencies | Yes |
+| `check:tracked-artifacts` | No build artifacts / committed `node_modules` symlinks (also runs in husky pre-commit; pre-push is intentionally light — #6716) | Yes |
+| `check:file-size` | No source file exceeds the per-extension cap (ratchet: frozen large files in `frozen` list) | Yes |
+| `check:error-helper` | Error responses in executors/handlers use `buildErrorBody()` / `sanitizeErrorMessage()` (Hard Rule #12) | Yes |
+| `check:migration-numbering` | Migration SQL files are sequentially numbered, no gaps or duplicates | Yes |
+| `check:public-creds` | No literal OAuth `client_id`/`client_secret` or Firebase Web keys outside `publicCreds.ts` (Hard Rule #11) | Yes |
+| `check:db-rules` | No raw SQL outside `src/lib/db/` modules; no barrel-imports from `localDb.ts` (Hard Rules #2/#5) | Yes |
+| `check:known-symbols` | Provider executors, routing strategies, and translators registered in their dispatch tables match the files on disk — no orphaned or undeclared symbols | Yes |
+| `check:route-guard-membership` | Every route that spawns a child process is classified by `isLocalOnlyPath()` (Hard Rules #15/#17) | Yes |
+| `check:test-discovery` | Every `*.test.ts` / `*.spec.ts` file in the repo is collected by at least one test runner (ratchet: orphan list in `test-discovery-baseline.json` can only shrink) | Yes |
+| `check:agent-skills-sync` | Generated agent-skills artifacts match their source catalog (no drift) |
+| `check:provider-asset-provenance` | Provider logos/assets carry a recorded provenance entry |
+| `lint:json` | JSON config files parse and satisfy the repo lint rules |
+| `typecheck:core` | TypeScript compilation without errors (advisory warnings only) | Yes |
+| `typecheck:noimplicit:core` | Strict `noImplicitAny` — forward-looking; many pre-existing call sites still need annotations | **Advisory** (`continue-on-error: true`) |
+| `check:dashboard-typecheck` | `tsc` scoped to `src/app/(dashboard)/**` (#7033) — `typecheck:core`'s curated 27-file allowlist does not include any dashboard TSX, and `next build` never type-checks it either (`next.config.mjs` sets `ignoreBuildErrors: true`), so orphaned-identifier regressions there (#6625/#6909) were invisible to CI. Diffs against a frozen per-file/per-TS-code count baseline (`config/quality/dashboard-typecheck-baseline.json`, same stale-enforcement pattern as `check:known-symbols`) — only NEW errors beyond the baselined count fail the gate; ratchet down with `--update` when a pre-existing error is fixed. | Yes |
### Job: `quality-gate`
diff --git a/open-sse/services/backgroundTaskDetector.ts b/open-sse/services/backgroundTaskDetector.ts
index 8cbcbd3e9e..258500fbd9 100644
--- a/open-sse/services/backgroundTaskDetector.ts
+++ b/open-sse/services/backgroundTaskDetector.ts
@@ -45,22 +45,24 @@ const DEFAULT_DETECTION_PATTERNS = [
"label this",
];
+// Every source and target must be absent from the retired-id snapshot: a retired source is
+// a dead row (checkLifecycle answers 410 before the redirect runs), while a retired target
+// is normally rejected with 410 when lifecycle validation runs again after the redirect
+// (unless alias resolution maps it to an accepted id). `npm run check:model-lifecycle`
+// diffs this map against config/quality/model-lifecycle.json.
const DEFAULT_DEGRADATION_MAP: Record = {
// Premium → Cheap alternatives
"claude-opus-4-6": "gemini-3-flash",
"claude-opus-4-6-thinking": "gemini-3-flash",
"claude-opus-4-5-20251101": "gemini-3-flash",
"claude-sonnet-4-5-20250929": "gemini-3-flash",
- "claude-sonnet-4-20250514": "gemini-3-flash",
"claude-sonnet-4": "gemini-3-flash",
"gemini-3.1-pro": "gemini-3-flash",
"gemini-3.1-pro-high": "gemini-3-flash",
- "gemini-3-pro-preview": "gemini-3-flash-preview",
"gemini-2.5-pro": "gemini-3-flash",
"gpt-4o": "gpt-4o-mini",
"gpt-5": "gpt-5-mini",
"gpt-5.1": "gpt-5-mini",
- "gpt-5.1-codex": "gpt-5.1-codex-mini",
};
// ── State ───────────────────────────────────────────────────────────────────
diff --git a/scripts/check/check-model-lifecycle.mjs b/scripts/check/check-model-lifecycle.mjs
index 7bad03ec60..2e9c961ccd 100644
--- a/scripts/check/check-model-lifecycle.mjs
+++ b/scripts/check/check-model-lifecycle.mjs
@@ -1,19 +1,25 @@
#!/usr/bin/env node
// scripts/check/check-model-lifecycle.mjs
-// Gate anti-drift (#11503): as duas tabelas mantidas à mão que decidem roteamento —
+// Gate anti-drift (#11503): as três tabelas mantidas à mão que decidem roteamento —
// FITNESS_TABLE (open-sse/services/autoCombo/taskFitness.ts, camada 4 do task fitness) e
// BUILT_IN_ALIASES (open-sse/services/modelDeprecation.ts, reescreve `body.model` em toda
-// request) — apodrecem em silêncio quando o fornecedor aposenta um modelo. Em
+// request), além de DEFAULT_DEGRADATION_MAP (backgroundTaskDetector.ts) — apodrecem em
+// silêncio quando o fornecedor aposenta um modelo. Em
// release/v3.8.51 o resultado foi uma inversão de ranking (modelo morto 0.98 vs flagship
-// vivo 0.50) e aliases que garantiam 404. Este gate compara as duas contra o snapshot de
+// vivo 0.50) e aliases apontando para ids obsoletos. Este gate compara as três contra o snapshot de
// ciclo de vida em config/quality/model-lifecycle.json (sem rede; regenerar com
// `npm run quality:refresh-model-lifecycle`).
//
-// Três checagens, todas somadas antes do exit — nenhuma aborta as outras:
+// Quatro checagens, todas somadas antes do exit — nenhuma aborta as outras:
// (a) nenhum padrão do FITNESS_TABLE pontua um id aposentado que o catálogo roteia;
// (b) nenhum alvo de BUILT_IN_ALIASES está aposentado ou ausente do catálogo;
// (c) todo id aposentado ainda presente no REGISTRY tem encaminhamento em
-// BUILT_IN_ALIASES ou consta em `allowedRetiredInCatalog` (a catraca a queimar).
+// BUILT_IN_ALIASES ou consta em `allowedRetiredInCatalog` (a catraca a queimar);
+// (d) nenhuma linha de DEFAULT_DEGRADATION_MAP (open-sse/services/backgroundTaskDetector.ts)
+// tem origem ou destino aposentado. A origem aposentada é linha morta: checkLifecycle
+// devolve 410 antes de resolveBackgroundTaskRedirect rodar. O destino aposentado é o
+// normalmente rejeitado com 410 quando o ciclo de vida é validado novamente após o
+// redirecionamento; a resolução de alias ainda pode convertê-lo em um id aceito.
//
// (a) é deliberadamente restrita aos ids ROTEÁVEIS: linhas versionadas legítimas como
// `gpt-4o` também casam com ids aposentados que o catálogo nunca serviu
@@ -88,6 +94,22 @@ export function findUnforwardedRetiredIds(routableRetiredIds, aliases, allowlist
.map((id) => `${id} is retired but still routable with no BUILT_IN_ALIASES forward`);
}
+/** (d) Linhas de DEFAULT_DEGRADATION_MAP com origem ou destino aposentado. */
+export function findRetiredDegradationRows(degradationMap, retiredIds) {
+ const violations = [];
+ for (const [source, target] of Object.entries(degradationMap ?? {})) {
+ if (isRetiredId(source, retiredIds)) {
+ violations.push(
+ `${source} → ${target} (the vendor has retired the source id; checkLifecycle rejects it before the redirect runs)`
+ );
+ }
+ if (isRetiredId(target, retiredIds)) {
+ violations.push(`${source} → ${target} (the vendor has retired the target id)`);
+ }
+ }
+ return violations;
+}
+
export function readSnapshot(snapshotPath = SNAPSHOT_PATH) {
const snapshot = JSON.parse(fs.readFileSync(snapshotPath, "utf8"));
const retiredIds = new Set(
@@ -102,12 +124,18 @@ async function loadProductionTables() {
// Nenhum gate pode migrar o banco do operador: taskFitness.ts importa src/lib/db/core.ts,
// então DATA_DIR aponta para um diretório descartável ANTES do import dinâmico.
process.env.DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-lifecycle-gate-"));
- const [{ REGISTRY }, { getStaticFitnessTableScore }, { getBuiltInAliases }] = await Promise.all([
+ const [
+ { REGISTRY },
+ { getStaticFitnessTableScore },
+ { getBuiltInAliases },
+ { getDefaultDegradationMap },
+ ] = await Promise.all([
import(pathToFileURL(path.join(ROOT, "open-sse/config/providers/index.ts")).href),
import(pathToFileURL(path.join(ROOT, "open-sse/services/autoCombo/taskFitness.ts")).href),
import(pathToFileURL(path.join(ROOT, "open-sse/services/modelDeprecation.ts")).href),
+ import(pathToFileURL(path.join(ROOT, "open-sse/services/backgroundTaskDetector.ts")).href),
]);
- return { REGISTRY, getStaticFitnessTableScore, getBuiltInAliases };
+ return { REGISTRY, getStaticFitnessTableScore, getBuiltInAliases, getDefaultDegradationMap };
}
function report(label, violations, hint) {
@@ -125,11 +153,13 @@ function report(label, violations, hint) {
async function main() {
const { snapshot, retiredIds } = readSnapshot();
- const { REGISTRY, getStaticFitnessTableScore, getBuiltInAliases } = await loadProductionTables();
+ const { REGISTRY, getStaticFitnessTableScore, getBuiltInAliases, getDefaultDegradationMap } =
+ await loadProductionTables();
const catalogIds = collectCatalogIds(REGISTRY);
const routableRetired = catalogIds.filter((id) => isRetiredId(id, retiredIds)).sort();
const aliases = getBuiltInAliases();
+ const degradationMap = getDefaultDegradationMap();
let failures = 0;
failures += report(
@@ -138,7 +168,7 @@ async function main() {
"drop the row from FITNESS_TABLE in open-sse/services/autoCombo/taskFitness.ts, or replace it with the versioned id of the live successor."
);
failures += report(
- `all ${Object.keys(aliases).length} BUILT_IN_ALIASES targets are live catalog models`,
+ `all ${Object.keys(aliases).length} BUILT_IN_ALIASES targets are present in REGISTRY and absent from the retired-id snapshot`,
findBadAliasTargets(aliases, catalogIds, retiredIds),
"point the alias at the replacement the vendor publishes (see `sources` in config/quality/model-lifecycle.json). Never invent a target."
);
@@ -148,8 +178,14 @@ async function main() {
"add a BUILT_IN_ALIASES forward to the vendor's replacement, remove the model from the provider catalog, or (last resort) add the id to `allowedRetiredInCatalog` in config/quality/model-lifecycle.json with a tracking issue."
);
+ failures += report(
+ `none of the ${Object.keys(degradationMap).length} DEFAULT_DEGRADATION_MAP rows names a retired id`,
+ findRetiredDegradationRows(degradationMap, retiredIds),
+ "drop the row from DEFAULT_DEGRADATION_MAP in open-sse/services/backgroundTaskDetector.ts (a retired source can never reach the redirect), or point a retired target at the replacement the vendor publishes (see `sources` in config/quality/model-lifecycle.json)."
+ );
+
if (failures) {
- console.error(`[model-lifecycle] FAIL — ${failures} violation(s) across 3 check(s).`);
+ console.error(`[model-lifecycle] FAIL — ${failures} violation(s) across 4 check(s).`);
process.exit(1);
}
console.log(
diff --git a/tests/unit/check-model-lifecycle-gate.test.ts b/tests/unit/check-model-lifecycle-gate.test.ts
index d717ffabe4..3a9d649f7f 100644
--- a/tests/unit/check-model-lifecycle-gate.test.ts
+++ b/tests/unit/check-model-lifecycle-gate.test.ts
@@ -2,7 +2,7 @@
* Unit coverage for the #11503 drift gate (`scripts/check/check-model-lifecycle.mjs`).
*
* The gate's value is that it goes red when a hand-maintained routing table starts
- * pointing at a model the vendor retired, so each of its three checks is exercised here
+ * pointing at a model the vendor retired, so each of its four checks is exercised here
* against small fixtures rather than against the live catalog (which would make the test
* a duplicate of the gate run itself, and red for reasons unrelated to the logic).
*/
@@ -14,6 +14,7 @@ import {
findRetiredFitnessRows,
findBadAliasTargets,
findUnforwardedRetiredIds,
+ findRetiredDegradationRows,
} from "../../scripts/check/check-model-lifecycle.mjs";
const RETIRED = new Set(["dead-model-1", "dead-model-2", "gpt-5.2-codex"]);
@@ -93,3 +94,32 @@ describe("check-model-lifecycle: (c) routable retired ids", () => {
);
});
});
+
+describe("check-model-lifecycle: (d) DEFAULT_DEGRADATION_MAP rows", () => {
+ it("flags a retired source id as a dead row", () => {
+ const violations = findRetiredDegradationRows({ "dead-model-1": "live-1" }, RETIRED);
+ assert.equal(violations.length, 1);
+ assert.match(violations[0], /retired the source id; checkLifecycle rejects it/);
+ });
+
+ it("flags a retired target id", () => {
+ const violations = findRetiredDegradationRows({ "live-1": "dead-model-1" }, RETIRED);
+ assert.equal(violations.length, 1);
+ assert.match(violations[0], /retired the target id/);
+ });
+
+ it("reports both ends when source and target are retired", () => {
+ const violations = findRetiredDegradationRows({ "dead-model-1": "dead-model-2" }, RETIRED);
+ assert.equal(violations.length, 2);
+ });
+
+ it("treats a vendor-prefixed source as retired when its bare form is", () => {
+ const violations = findRetiredDegradationRows({ "openai/gpt-5.2-codex": "live-1" }, RETIRED);
+ assert.equal(violations.length, 1);
+ });
+
+ it("passes for a map of live ids", () => {
+ assert.deepEqual(findRetiredDegradationRows({ "live-1": "live-2" }, RETIRED), []);
+ assert.deepEqual(findRetiredDegradationRows({}, RETIRED), []);
+ });
+});
diff --git a/tests/unit/model-lifecycle-degradation-map.test.ts b/tests/unit/model-lifecycle-degradation-map.test.ts
new file mode 100644
index 0000000000..0b59ab732a
--- /dev/null
+++ b/tests/unit/model-lifecycle-degradation-map.test.ts
@@ -0,0 +1,56 @@
+/**
+ * Follow-up to #11503 / #11507: `DEFAULT_DEGRADATION_MAP` (backgroundTaskDetector.ts) is the
+ * third hand-maintained routing table that names model ids, and it was outside the
+ * retired-model gate. A retired *source* is a dead row — `checkLifecycle` answers 410
+ * `model_shutdown` before `resolveBackgroundTaskRedirect` runs — and a retired *target*
+ * is normally rejected with 410 when lifecycle validation runs again after the redirect,
+ * unless alias resolution maps it to an accepted id.
+ *
+ * Table-driven over the production default map and the checked-in lifecycle snapshot, mirroring
+ * `model-deprecation-aliases-11503.test.ts`, so a new dead row fails by name.
+ */
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync } from "node:fs";
+import { fileURLToPath } from "node:url";
+import { getDefaultDegradationMap } from "../../open-sse/services/backgroundTaskDetector.ts";
+import { isVendorRetiredId } from "../../open-sse/services/modelLifecycle.ts";
+
+const lifecycle = JSON.parse(
+ readFileSync(
+ fileURLToPath(new URL("../../config/quality/model-lifecycle.json", import.meta.url)),
+ "utf8"
+ )
+) as { retired: Record };
+
+const retiredIds = new Set(
+ Object.entries(lifecycle.retired)
+ .filter(([, entry]) => entry.status === "retired")
+ .map(([id]) => id.toLowerCase())
+);
+
+describe("DEFAULT_DEGRADATION_MAP names no retired model id", () => {
+ const rows = Object.entries(getDefaultDegradationMap());
+
+ it("has rows to check", () => {
+ assert.ok(rows.length > 0);
+ });
+
+ for (const [source, target] of rows) {
+ it(`degrades from ${source}, an id the vendor has not retired`, () => {
+ assert.ok(
+ !retiredIds.has(source.toLowerCase()),
+ `"${source}" → "${target}" is dead: the vendor has retired "${source}", so checkLifecycle rejects the request before the background redirect runs`
+ );
+ assert.equal(isVendorRetiredId(source), false);
+ });
+
+ it(`degrades ${source} to ${target}, an id the vendor has not retired`, () => {
+ assert.ok(
+ !retiredIds.has(target.toLowerCase()),
+ `"${source}" → "${target}" forwards background tasks to "${target}", which the vendor has retired`
+ );
+ assert.equal(isVendorRetiredId(target), false);
+ });
+ }
+});
From afd2d993e632637683ab62403f4c5e9b38e04ca5 Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 22:42:21 +0200
Subject: [PATCH 14/20] fix(rerank): clamp Voyage top_k and honor NVIDIA
return_documents (#12523)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Both defects are real adapter bugs: `top_k` computed from the unfiltered array after the adapter drops empty strings makes Voyage reject a request that is valid under the Cohere-style contract this endpoint exposes. Good that the NVIDIA `return_documents` half rides along rather than waiting.
---
Validated in one consolidated worktree cut from `release/v3.8.51`, boarded with the rest of this batch — zero conflicts between the 19 PRs.
- `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, all within the frozen baseline); `check:changelog-integrity` OK
- complexity 2802 / baseline 3218 and cognitive-complexity 1267 / baseline 1437 — both under baseline
- 226 of 228 focused assertions green across the batch's 23 test files. The 2 remaining belong to #12551, which is held separately.
Two batch-owned defects were found and fixed in flight, both pure base drift: `173_xp_action_counts.sql` collided with `173_call_logs_video_content_removed.sql` (renumbered to 176 on #12651 — it aborted every DB open, which is what 53 of the first run's failures were), and the feature-flag catalog was missing the `SERVER_OWNED_TOOL_LOOP_ENABLED` row the base gained after #12552 was written.
⚠️ base-red inherited: #12732 — `Docs Gates`, `Merge integrity`, `No new ESLint warnings`, `Unit Tests fast-path` and `Fast Quality Gates` reproduce on the pure tip (provider count 356 vs the 358 the modules define, SKILL.md drift, and `open-sse/utils/stream.ts` at 3115 > frozen 3098, which this batch does not touch).
Thanks @pacocartones — the `file:line` citations and the explicit out-of-scope notes on every one of these made a 19-PR batch reviewable in one pass.
---
.../12523-rerank-topk-and-return-documents.md | 1 +
open-sse/handlers/rerank.ts | 9 +++-
tests/unit/rerank-providers-5332.test.ts | 34 ++++++++++++++
tests/unit/rerank-voyage-7809.test.ts | 44 +++++++++++++++++++
4 files changed, 86 insertions(+), 2 deletions(-)
create mode 100644 changelog.d/fixes/12523-rerank-topk-and-return-documents.md
diff --git a/changelog.d/fixes/12523-rerank-topk-and-return-documents.md b/changelog.d/fixes/12523-rerank-topk-and-return-documents.md
new file mode 100644
index 0000000000..88b1a23726
--- /dev/null
+++ b/changelog.d/fixes/12523-rerank-topk-and-return-documents.md
@@ -0,0 +1 @@
+- **fix(rerank):** clamp Voyage `top_k` to the documents actually sent after empty-string filtering, and honor `return_documents: false` in the NVIDIA response adapter (#12523 — thanks @pacocartones)
diff --git a/open-sse/handlers/rerank.ts b/open-sse/handlers/rerank.ts
index 45ab3c2bee..3963f7d154 100644
--- a/open-sse/handlers/rerank.ts
+++ b/open-sse/handlers/rerank.ts
@@ -73,6 +73,10 @@ function buildAuthHeader(providerConfig, token) {
// strings (whitespace-only documents are accepted and ranked upstream). We
// filter out exact empty strings and track original indices implicitly via the
// response adapter, which reconstructs the map from options.documents (#7809).
+ // `top_k` is clamped to the number of documents actually sent: the handler
+ // defaults `top_n` to the caller's *unfiltered* document count, so dropping an
+ // empty string would otherwise ask Voyage to rank more documents than it got,
+ // and Voyage rejects `top_k > documents.length` with HTTP 400.
// `return_documents` is always forced off upstream: Voyage echoes documents as
// plain strings (not Cohere's {text}), so we never rely on the echo — document
// text is always synthesized locally from the caller's originals (#7811).
@@ -84,7 +88,7 @@ function buildAuthHeader(providerConfig, token) {
model: body.model,
query: body.query,
documents: docTexts,
- top_k: body.top_n || docTexts.length,
+ top_k: Math.min(body.top_n || docTexts.length, docTexts.length),
return_documents: false,
};
}
@@ -101,12 +105,13 @@ function buildAuthHeader(providerConfig, token) {
options: RerankResponseOptions = {}
) {
if (providerConfig.format === "nvidia") {
+ const returnDocuments = options.return_documents !== false;
return {
id: data.id != null ? String(data.id) : `rerank-${Date.now()}`,
results: (data.rankings || []).map((r) => ({
index: r.index,
relevance_score: r.logit || r.score || 0,
- document: { text: r.text || "" },
+ ...(returnDocuments ? { document: { text: r.text || "" } } : {}),
})),
meta: {
api_version: { version: "2" },
diff --git a/tests/unit/rerank-providers-5332.test.ts b/tests/unit/rerank-providers-5332.test.ts
index 20a0ad74ef..c7e39a1fb9 100644
--- a/tests/unit/rerank-providers-5332.test.ts
+++ b/tests/unit/rerank-providers-5332.test.ts
@@ -69,3 +69,37 @@ test("#5332 deepinfra response omits document text when return_documents=false",
assert.equal(out.results[0].document, undefined);
assert.equal(out.results[0].index, 1);
});
+
+// ─── NVIDIA must honor return_documents like its deepinfra/voyage siblings ──
+
+test("#5332 nvidia response omits document text when return_documents=false", () => {
+ const cfg = getRerankProvider("nvidia");
+ const out = transformResponseFromProvider(
+ cfg,
+ { id: "r1", rankings: [{ index: 0, logit: 0.8, text: "a" }] },
+ { documents: ["a"], return_documents: false }
+ );
+ assert.equal(out.results[0].document, undefined);
+ assert.equal(out.results[0].index, 0);
+ assert.equal(out.results[0].relevance_score, 0.8);
+});
+
+test("#5332 nvidia response includes document text when return_documents is true", () => {
+ const cfg = getRerankProvider("nvidia");
+ const out = transformResponseFromProvider(
+ cfg,
+ { id: "r1", rankings: [{ index: 1, logit: 0.4, text: "b" }] },
+ { documents: ["a", "b"], return_documents: true }
+ );
+ assert.equal(out.results[0].document.text, "b");
+});
+
+test("#5332 nvidia response includes document text when return_documents is omitted", () => {
+ const cfg = getRerankProvider("nvidia");
+ const out = transformResponseFromProvider(
+ cfg,
+ { id: "r1", rankings: [{ index: 0, logit: 0.9, text: "a" }] },
+ { documents: ["a"] }
+ );
+ assert.equal(out.results[0].document.text, "a");
+});
diff --git a/tests/unit/rerank-voyage-7809.test.ts b/tests/unit/rerank-voyage-7809.test.ts
index 208fad237c..059c964d25 100644
--- a/tests/unit/rerank-voyage-7809.test.ts
+++ b/tests/unit/rerank-voyage-7809.test.ts
@@ -223,3 +223,47 @@ test("#7809 voyage response adapter handles empty data array", () => {
const out = transformResponseFromProvider(cfg, { data: [] }, { documents: ["a", "b"] });
assert.deepEqual(out.results, []);
});
+
+// ─── top_k must never exceed the surviving document count ──────────────────
+// The handler normalizes `top_n: top_n || documents.length` BEFORE the adapter
+// runs, so a caller that omits top_n and sends an exact empty string yields
+// top_k > documents.length — which Voyage rejects with HTTP 400.
+
+test("#7809 voyage request adapter clamps top_k to the surviving document count", () => {
+ const cfg = getRerankProvider("voyage-ai");
+ const out = transformRequestForProvider(cfg, {
+ model: "rerank-2.5-lite",
+ query: "teste",
+ documents: ["a", "", "b"],
+ // Mirrors the handler's `top_n: top_n || documents.length` when the caller omits top_n.
+ top_n: 3,
+ return_documents: true,
+ });
+ assert.deepEqual(out.documents, ["a", "b"]);
+ assert.equal(out.top_k, 2, "top_k must not exceed the number of documents actually sent");
+});
+
+test("#7809 voyage request adapter clamps an explicit oversized top_n", () => {
+ const cfg = getRerankProvider("voyage-ai");
+ const out = transformRequestForProvider(cfg, {
+ model: "rerank-2.5-lite",
+ query: "teste",
+ documents: ["a", "", "", "b"],
+ top_n: 10,
+ return_documents: true,
+ });
+ assert.deepEqual(out.documents, ["a", "b"]);
+ assert.equal(out.top_k, 2);
+});
+
+test("#7809 voyage request adapter keeps a legitimate top_n below the document count", () => {
+ const cfg = getRerankProvider("voyage-ai");
+ const out = transformRequestForProvider(cfg, {
+ model: "rerank-2.5-lite",
+ query: "teste",
+ documents: ["a", "b", "c"],
+ top_n: 2,
+ return_documents: true,
+ });
+ assert.equal(out.top_k, 2);
+});
From 7cd2fab25393a18dcb33088e4fe54a88bbbdffab Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 22:42:25 +0200
Subject: [PATCH 15/20] fix(routing): honor edited custom-node API type
(#12358)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Forwarding only an explicit custom-model DB override as `modelInfo.targetFormat` is the key distinction — it lets chat core's credential-aware resolution pick the live connection setting instead of the format baked into the node id at creation, which is exactly what #11884 was about. I rebaselined the integration test file for the new case.
---
Validated in one consolidated worktree cut from `release/v3.8.51`, boarded with the rest of this batch — zero conflicts between the 19 PRs.
- `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, all within the frozen baseline); `check:changelog-integrity` OK
- complexity 2802 / baseline 3218 and cognitive-complexity 1267 / baseline 1437 — both under baseline
- 226 of 228 focused assertions green across the batch's 23 test files. The 2 remaining belong to #12551, which is held separately.
Two batch-owned defects were found and fixed in flight, both pure base drift: `173_xp_action_counts.sql` collided with `173_call_logs_video_content_removed.sql` (renumbered to 176 on #12651 — it aborted every DB open, which is what 53 of the first run's failures were), and the feature-flag catalog was missing the `SERVER_OWNED_TOOL_LOOP_ENABLED` row the base gained after #12552 was written.
⚠️ base-red inherited: #12732 — `Docs Gates`, `Merge integrity`, `No new ESLint warnings`, `Unit Tests fast-path` and `Fast Quality Gates` reproduce on the pure tip (provider count 356 vs the 358 the modules define, SKILL.md drift, and `open-sse/utils/stream.ts` at 3115 > frozen 3098, which this batch does not touch).
Thanks @pacocartones — the `file:line` citations and the explicit out-of-scope notes on every one of these made a 19-PR batch reviewable in one pass.
---
.../12358-custom-node-api-type-precedence.md | 1 +
config/quality/file-size-baseline.json | 3 +-
src/sse/handlers/chat.ts | 7 +-
src/sse/handlers/chatHelpers.ts | 10 ++-
tests/integration/chat-pipeline.test.ts | 88 +++++++++++++++++++
tests/unit/chat-helpers.test.ts | 56 ++++++++++++
6 files changed, 162 insertions(+), 3 deletions(-)
create mode 100644 changelog.d/fixes/12358-custom-node-api-type-precedence.md
diff --git a/changelog.d/fixes/12358-custom-node-api-type-precedence.md b/changelog.d/fixes/12358-custom-node-api-type-precedence.md
new file mode 100644
index 0000000000..739017ad26
--- /dev/null
+++ b/changelog.d/fixes/12358-custom-node-api-type-precedence.md
@@ -0,0 +1 @@
+- **fix(routing):** custom OpenAI-compatible nodes now honor the saved Chat/Responses API type after edits instead of letting the node's original ID prefix override the live connection setting ([#11884](https://github.com/diegosouzapw/OmniRoute/issues/11884)).
diff --git a/config/quality/file-size-baseline.json b/config/quality/file-size-baseline.json
index f855229516..0b46fbf4a6 100644
--- a/config/quality/file-size-baseline.json
+++ b/config/quality/file-size-baseline.json
@@ -1,4 +1,5 @@
{
+ "_rebaseline_2026_09_11_12358_chat_pipeline_custom_node": "PR #12358 own test growth: tests/integration/chat-pipeline.test.ts 1648->1736 (+88). One new integration case, \"#11884 chat pipeline sends a custom node's edited Chat API type upstream\": it seeds a custom OpenAI-compatible node with an edited Chat/Responses API type, stubs fetch, drives handleChatCore and asserts the upstream request carries the live connection setting rather than the format baked into the node id at creation. Irreducible at this layer — the point of the test is the full route-to-upstream path, which is what #11884 regressed. Nothing else in the file changed. Covered by the case itself plus tests/unit/chat-helpers.test.ts (28/28).",
"_rebaseline_2026_09_10_12975_rotation_correlation_id": "PR #12975 own growth: open-sse/executors/base.ts 1751->1753 (+2) and open-sse/handlers/chatCore.ts 6021->6024 (+3). The opencode rotation lines carry the request correlationId: one optional ExecuteInput field and one correlationId argument at each of the three executor.execute call sites in handleChatCore. Irreducible plumbing at existing call sites; the rotation logic itself lives in open-sse/executors/opencode.ts and the new leaf predicates (under cap). Covered by tests/unit/opencode-transient-rotation.test.ts and tests/unit/chat-correlation-id-exhaustion.test.ts.",
"_rebaseline_2026_09_11_mergebatch_v3851_maxmad_opencode": "/merge-batch 2026-09-11 (v3.8.51), PRs #13141, #13146 and #12975 by maxmad64bis. src/sse/services/auth.ts 3450->3488 (+38): #13146 adds the narrow ruleScope===model branch to markAccountUnavailable (gated on status 400; every other status keeps its path) plus the HONORS_RULE_LOCK_SCOPE_PROVIDERS opencode entry, taking it to 3464; #12975 then adds buildExhaustionOptions so the exhaustion log lines carry the request correlationId (+24). open-sse/services/accountFallback.ts 2467->2468 (+1): #13141 routes hasFutureRateLimitUntil through the tolerant epoch normalizer; #13146 is net zero there (+16/-16). open-sse/executors/base.ts 1751->1753 (+2): #12975 adds the optional ExecuteInput.correlationId field with its doc comment. src/sse/handlers/chat.ts is NOT rebaselined: #12975 threads correlationId through the three executor call sites (+2) but the file lands at 2452, still under its existing 2458 freeze. open-sse/utils/stream.ts is deliberately NOT rebaselined either: it is already 3115 > 3098 on the pure tip with zero contribution from this batch (base-red #12732, owned by /sweep-reds). No new branching beyond the two guarded branches named above. Covered by tests/unit/combo-predicates-epoch-cooldown.test.ts, opencode-400-model-unavailable.test.ts, agentrouter-error-rules.test.ts, opencode-transient-rotation.test.ts and chat-correlation-id-exhaustion.test.ts.",
"_rebaseline_2026_09_10_mergebatch_v3851_greenpt_eurouter": "/merge-batch 2026-09-10 (v3.8.51), PRs #13024 (GreenPT, closes #12986) and #13025 (EURouter, closes #12985) by ntdatt812: src/shared/constants/providers/apikey/gateways.ts 1462->1502 (+40 = two APIKEY_PROVIDERS_GATEWAYS catalog entries, declarative data only: id/alias/name/icon/color/website plus the hasFree=false rationale comments and the apiHint copy each PR verified). No logic and no new branching. Same god-file no-split rationale as every prior gateways.ts rebaseline (#11786 seekai, #10987 logfare, #10668 tabitoken, #10531 freebuff, #11631 1min.ai): the file header says it is pure data merged by apikey/index.ts via spread, and it is already split into 6 family files under apikey/, so splitting a catalog for two entries would violate the semantic-families rule rather than help. Both entries are deliberately conservative (models: [] with passthroughModels, no tool/vision capability declared, hasFree false), so the growth is the entry itself, not claims. EURouter is in AGGREGATOR_PROVIDER_IDS because it routes to third-party upstreams; GreenPT is not because it serves its own inference. Covered by tests/unit/greenpt-provider.test.ts and tests/unit/eurouter-provider.test.ts.",
@@ -220,7 +221,7 @@
"_rebaseline_2026_08_24_video_bridge_fu01_fu03_fu04_result_cache_tests": "PRs #11362 (FU-01 cache hardening) + #11382 (FU-03 visual dedup policy identity) + #11383 (FU-04 focused analysis mode) own test growth: videoBridgeResultCache.test.ts <1000->1040, +40 (sum of three stacked PRs boarded together in the same merge-batch, each adding its own cache-identity assertions on the shared result-cache seam). Owner pre-authorized rebaseline for legitimate PR growth (2026-08-19 directive).",
"_rebaseline_basered_codebuddy_cn": "Base-red fix (#4664 CodeBuddy CN): oauth-providers-config.test.ts 867->870 (+3) to align the EXPECTED provider list/config with the codebuddy-cn provider that #4664 added to the registry without updating this test (it asserts 'exactly once').",
"_rebaseline_pr4613_compatible_provider_groups": "Reconcile #4613 already-merged growth: providers-page-utils.test.ts 1004->1052 (+48, buildCompatibleProviderGroups partition unit test). Fast-gate PR->release does not run check:file-size, so this surfaced post-merge.",
- "tests/integration/chat-pipeline.test.ts": 1648,
+ "tests/integration/chat-pipeline.test.ts": 1736,
"tests/unit/account-fallback-service.test.ts": 2056,
"tests/unit/batch_api.test.ts": 1345,
"tests/unit/cc-compatible-provider.test.ts": 1225,
diff --git a/src/sse/handlers/chat.ts b/src/sse/handlers/chat.ts
index 0a5b3fafbe..fcd565133a 100644
--- a/src/sse/handlers/chat.ts
+++ b/src/sse/handlers/chat.ts
@@ -1489,6 +1489,7 @@ async function handleSingleModelChat(
model,
sourceFormat,
targetFormat,
+ customModelTargetFormat,
extendedContext,
apiFormat,
} = resolved;
@@ -1940,7 +1941,11 @@ async function handleSingleModelChat(
runtimeOptions.comboExecutionKey ?? runtimeOptions.comboStepId ?? null,
extendedContext,
modelApiFormat: apiFormat,
- modelTargetFormat: targetFormat,
+ // Only a model's explicit DB override may cross this boundary as
+ // modelInfo.targetFormat. The effective targetFormat above was
+ // resolved without credentials; forwarding it would let a stale
+ // provider-id fallback override the credential-aware resolution.
+ modelTargetFormat: customModelTargetFormat,
providerProfile,
cachedSettings: runtimeOptions.cachedSettings,
skipUpstreamRetry: runtimeOptions.skipUpstreamRetry ?? false,
diff --git a/src/sse/handlers/chatHelpers.ts b/src/sse/handlers/chatHelpers.ts
index 17e3a0f08a..c29300b30d 100644
--- a/src/sse/handlers/chatHelpers.ts
+++ b/src/sse/handlers/chatHelpers.ts
@@ -338,7 +338,15 @@ export async function resolveModelOrError(
log.info("ROUTING", `Provider: ${provider}, Model: ${model}${ctxTag}`);
}
- return { provider, model, sourceFormat, targetFormat, extendedContext, apiFormat };
+ return {
+ provider,
+ model,
+ sourceFormat,
+ targetFormat,
+ customModelTargetFormat,
+ extendedContext,
+ apiFormat,
+ };
}
export async function checkPipelineGates(
diff --git a/tests/integration/chat-pipeline.test.ts b/tests/integration/chat-pipeline.test.ts
index 191462d93c..e2303c86b9 100644
--- a/tests/integration/chat-pipeline.test.ts
+++ b/tests/integration/chat-pipeline.test.ts
@@ -21,6 +21,7 @@ const { skillRegistry } = await import("../../src/lib/skills/registry.ts");
const { skillExecutor } = await import("../../src/lib/skills/executor.ts");
const { encodeSkillToolName } = await import("../../src/lib/skills/injection.ts");
const { handleChat } = await import("../../src/sse/handlers/chat.ts");
+const providerNodeRoute = await import("../../src/app/api/provider-nodes/[id]/route.ts");
const { initTranslators } = await import("../../open-sse/translator/index.ts");
const { clearInflight } = await import("../../open-sse/services/requestDedup.ts");
const { setCliCompatProviders } = await import("../../open-sse/config/cliFingerprints.ts");
@@ -550,6 +551,93 @@ test("chat pipeline handles OpenAI passthrough with valid API key auth", async (
assert.equal(json.choices[0].message.content, "OpenAI passthrough");
});
+test("#11884 chat pipeline sends a custom node's edited Chat API type upstream", async () => {
+ // Mirror POST /api/provider-nodes: the generated node id embeds the API type chosen at
+ // creation time, so a node created as Responses keeps "responses" in its id forever.
+ const providerId = "openai-compatible-responses-11884";
+ const prefix = "edited-node-11884";
+ const baseUrl = "https://edited-node-11884.example.invalid/v1";
+ const nodeName = "Edited node 11884";
+ await providersDb.createProviderNode({
+ id: providerId,
+ type: "openai-compatible",
+ name: nodeName,
+ prefix,
+ apiType: "responses",
+ baseUrl,
+ });
+ await seedConnection(providerId, {
+ apiKey: "sk-edited-node-11884",
+ providerSpecificData: { baseUrl, apiType: "responses" },
+ });
+
+ // The operator edits the node from Responses to Chat through the real route, which also
+ // rewrites the connection's saved apiType.
+ const editResponse = await providerNodeRoute.PUT(
+ new Request(`http://localhost/api/provider-nodes/${providerId}`, {
+ method: "PUT",
+ headers: { "Content-Type": "application/json" },
+ body: JSON.stringify({ name: nodeName, prefix, apiType: "chat", baseUrl }),
+ }),
+ { params: Promise.resolve({ id: providerId }) }
+ );
+ assert.equal(editResponse.status, 200);
+ const [connection] = (await providersDb.getProviderConnections({
+ provider: providerId,
+ })) as Array<{
+ providerSpecificData?: { apiType?: unknown };
+ }>;
+ assert.equal(connection?.providerSpecificData?.apiType, "chat");
+
+ const apiKey = await seedApiKey();
+ const fetchCalls: FetchCall[] = [];
+ globalThis.fetch = async (url, init: RequestInit = {}) => {
+ const call: FetchCall = {
+ url: String(url),
+ method: init.method || "GET",
+ headers: toPlainHeaders(init.headers),
+ body: init.body ? JSON.parse(String(init.body)) : null,
+ };
+ fetchCalls.push(call);
+ if (!call.url.startsWith(baseUrl)) {
+ throw new Error(`unexpected upstream call: ${call.method} ${call.url}`);
+ }
+ return buildOpenAIResponse("Edited node reply", "edited-model");
+ };
+
+ const response = await handleChat(
+ buildRequest({
+ authKey: apiKey.key,
+ body: {
+ model: `${prefix}/edited-model`,
+ stream: false,
+ messages: [{ role: "user", content: "Hello edited node" }],
+ },
+ })
+ );
+
+ const json = (await response.json()) as { choices: Array<{ message: { content: string } }> };
+ assert.ok(fetchCalls.length >= 1, "expected an upstream request");
+ const upstream = fetchCalls[0];
+ assert.equal(upstream.method, "POST");
+ assert.equal(upstream.url, `${baseUrl}/chat/completions`);
+ assert.equal(upstream.headers.Authorization, "Bearer sk-edited-node-11884");
+ assert.deepEqual(
+ upstream.body.messages,
+ [{ role: "user", content: "Hello edited node" }],
+ "the saved Chat API type must produce a Chat Completions body"
+ );
+ assert.equal(
+ upstream.body.input,
+ undefined,
+ "the stale Responses API type from the node id must not shape the upstream body"
+ );
+ assert.equal(upstream.body.model, "edited-model");
+ assert.equal(fetchCalls.length, 1, "exactly one upstream request");
+ assert.equal(response.status, 200);
+ assert.equal(json.choices[0].message.content, "Edited node reply");
+});
+
test("chat pipeline persists Codex responses cache and reasoning tokens to call logs", async () => {
await seedConnection("codex", { apiKey: "sk-codex-primary" });
const fetchCalls = [];
diff --git a/tests/unit/chat-helpers.test.ts b/tests/unit/chat-helpers.test.ts
index 710bb6f21c..21ac50fa27 100644
--- a/tests/unit/chat-helpers.test.ts
+++ b/tests/unit/chat-helpers.test.ts
@@ -24,6 +24,9 @@ const { getCircuitBreaker, resetAllCircuitBreakers, STATE } =
await import("../../src/shared/utils/circuitBreaker.ts");
// DATA_DIR must be fixed before these modules load; keep this test seam dynamic.
const { setTlsClientForTest } = await import("../../open-sse/utils/proxyFetch.ts");
+const { resolveChatCoreTargetFormat } =
+ await import("../../open-sse/handlers/chatCore/targetFormat.ts");
+const { FORMATS } = await import("../../open-sse/translator/formats.ts");
type ApiErrorJson = {
error?: {
@@ -259,6 +262,59 @@ test("resolveModelOrError honors a custom-model targetFormat override even when
assert.equal(result.targetFormat, "claude");
});
+test("#11884 configured Chat API type wins after custom-node model resolution", async () => {
+ const provider = "openai-compatible-responses-11884";
+ const prefix = "custom-chat-11884";
+ const model = "chat-only-model";
+
+ await providersDb.createProviderNode({
+ id: provider,
+ type: "openai-compatible",
+ name: "Custom Chat 11884",
+ prefix,
+ apiType: "chat",
+ baseUrl: "https://chat-only.example.invalid/v1",
+ });
+ const connection = await seedConnection(provider, {
+ providerSpecificData: { apiType: "chat" },
+ });
+ const modelsDb = await import("../../src/lib/db/models.ts");
+ await modelsDb.addCustomModel(provider, model, "Chat-only model", "manual", "chat-completions", [
+ "chat",
+ ]);
+
+ const firstResolution = await resolveModelOrError(
+ `${prefix}/${model}`,
+ { model: `${prefix}/${model}`, messages: [{ role: "user", content: "hello" }] },
+ "/v1/chat/completions"
+ );
+ assert.equal(firstResolution.error, undefined);
+
+ // Before #11884's fix the resolver exposed only its credential-blind effective
+ // targetFormat, so the dispatcher necessarily forwarded that value as though it
+ // were a model override. The fixed contract exposes the explicit model override
+ // separately; keep the fallback here so this regression test still exercises the
+ // broken production path when run against the parent revision.
+ const forwardedModelOverride =
+ "customModelTargetFormat" in firstResolution
+ ? firstResolution.customModelTargetFormat
+ : firstResolution.targetFormat;
+ const finalResolution = resolveChatCoreTargetFormat({
+ provider: firstResolution.provider,
+ resolvedModel: firstResolution.model,
+ apiFormat: firstResolution.apiFormat,
+ sourceFormat: firstResolution.sourceFormat,
+ customModelTargetFormat: forwardedModelOverride,
+ providerSpecificData: connection.providerSpecificData,
+ });
+
+ assert.equal(
+ finalResolution.targetFormat,
+ FORMATS.OPENAI,
+ "the stored Chat API type must not be shadowed by a stale Responses fallback"
+ );
+});
+
test("checkPipelineGates blocks providers with an open circuit breaker", async () => {
const breaker = getCircuitBreaker("openai");
breaker.state = STATE.OPEN;
From 6caf836092d4b1e31c5bb3f926f084623e051eb5 Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 22:42:28 +0200
Subject: [PATCH 16/20] fix(providers): include Agnes model in video polling
(#12356)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Straightforward and complete: polling by `video_id` without `model_name` could not identify the job, and URL-encoding in the shared builder covers the custom-provider preset as well as the built-in.
---
Validated in one consolidated worktree cut from `release/v3.8.51`, boarded with the rest of this batch — zero conflicts between the 19 PRs.
- `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, all within the frozen baseline); `check:changelog-integrity` OK
- complexity 2802 / baseline 3218 and cognitive-complexity 1267 / baseline 1437 — both under baseline
- 226 of 228 focused assertions green across the batch's 23 test files. The 2 remaining belong to #12551, which is held separately.
Two batch-owned defects were found and fixed in flight, both pure base drift: `173_xp_action_counts.sql` collided with `173_call_logs_video_content_removed.sql` (renumbered to 176 on #12651 — it aborted every DB open, which is what 53 of the first run's failures were), and the feature-flag catalog was missing the `SERVER_OWNED_TOOL_LOOP_ENABLED` row the base gained after #12552 was written.
⚠️ base-red inherited: #12732 — `Docs Gates`, `Merge integrity`, `No new ESLint warnings`, `Unit Tests fast-path` and `Fast Quality Gates` reproduce on the pure tip (provider count 356 vs the 358 the modules define, SKILL.md drift, and `open-sse/utils/stream.ts` at 3115 > frozen 3098, which this batch does not touch).
Thanks @pacocartones — the `file:line` citations and the explicit out-of-scope notes on every one of these made a 19-PR batch reviewable in one pass.
---
changelog.d/fixes/12356-agnes-video-poll-model-name.md | 1 +
open-sse/handlers/videoGeneration/job.ts | 6 ++++--
tests/unit/agnes-provider.test.ts | 4 ++--
tests/unit/video-custom-provider-route.test.ts | 9 +++++++--
4 files changed, 14 insertions(+), 6 deletions(-)
create mode 100644 changelog.d/fixes/12356-agnes-video-poll-model-name.md
diff --git a/changelog.d/fixes/12356-agnes-video-poll-model-name.md b/changelog.d/fixes/12356-agnes-video-poll-model-name.md
new file mode 100644
index 0000000000..e756da7686
--- /dev/null
+++ b/changelog.d/fixes/12356-agnes-video-poll-model-name.md
@@ -0,0 +1 @@
+- **fix(providers):** include the submitted Agnes video model when polling by `video_id`
diff --git a/open-sse/handlers/videoGeneration/job.ts b/open-sse/handlers/videoGeneration/job.ts
index 030fe97a48..17308e77b8 100644
--- a/open-sse/handlers/videoGeneration/job.ts
+++ b/open-sse/handlers/videoGeneration/job.ts
@@ -121,7 +121,7 @@ const VIDEO_JOB_PRESETS: Record = {
}),
},
taskIdPath: "video_id",
- poll: { pathTemplate: "/agnesapi?video_id={taskId}" },
+ poll: { pathTemplate: "/agnesapi?video_id={taskId}&model_name={model}" },
statusPath: "status",
statusDone: ["completed"],
statusFailed: ["failed"],
@@ -273,7 +273,9 @@ export async function handleVideoJobGeneration({
for (let attempt = 1; attempt <= maxPolls; attempt += 1) {
await sleep(pollInterval);
- const pollUrl = `${baseUrl}${preset.poll.pathTemplate.replace("{taskId}", encodeURIComponent(taskId))}`;
+ const pollUrl = `${baseUrl}${preset.poll.pathTemplate
+ .replace("{taskId}", encodeURIComponent(taskId))
+ .replace("{model}", encodeURIComponent(model))}`;
const pollResult = await fetchJson(pollUrl, {
method: "GET",
headers: buildJobHeaders(preset, credentials),
diff --git a/tests/unit/agnes-provider.test.ts b/tests/unit/agnes-provider.test.ts
index bc15ab9e8c..2b0930eaa6 100644
--- a/tests/unit/agnes-provider.test.ts
+++ b/tests/unit/agnes-provider.test.ts
@@ -224,7 +224,7 @@ test("agnes registers Video V2.0 on the current video_id job contract", () => {
assert.ok(getAllVideoModels().some((model) => model.id === "agnes/agnes-video-v2.0"));
});
-test("agnes Video V2.0 submits with Bearer auth and polls by video_id", async () => {
+test("agnes Video V2.0 submits with Bearer auth and polls by video_id and model_name", async () => {
const originalFetch = globalThis.fetch;
const originalSetTimeout = globalThis.setTimeout;
const calls: Array<{
@@ -309,7 +309,7 @@ test("agnes Video V2.0 submits with Bearer auth and polls by video_id", async ()
},
});
assert.deepEqual(calls[1], {
- url: "https://apihub.agnes-ai.com/agnesapi?video_id=video-123",
+ url: "https://apihub.agnes-ai.com/agnesapi?video_id=video-123&model_name=agnes-video-v2.0",
method: "GET",
headers: {
"Content-Type": "application/json",
diff --git a/tests/unit/video-custom-provider-route.test.ts b/tests/unit/video-custom-provider-route.test.ts
index 9c10d6f2cb..a963b7710a 100644
--- a/tests/unit/video-custom-provider-route.test.ts
+++ b/tests/unit/video-custom-provider-route.test.ts
@@ -213,7 +213,9 @@ test("video route dispatches submit→poll job flow for custom model with agnes-
headers: { "content-type": "application/json" },
});
}
- if (stringUrl === "https://custom.example.com/agnesapi?video_id=video-123") {
+ if (
+ stringUrl === "https://custom.example.com/agnesapi?video_id=video-123&model_name=job-video-v1"
+ ) {
return createResponse(
JSON.stringify({
status: "completed",
@@ -256,7 +258,10 @@ test("video route dispatches submit→poll job flow for custom model with agnes-
prompt: "a cat playing piano",
});
assert.equal(calls[1].method, "GET");
- assert.equal(calls[1].url, "https://custom.example.com/agnesapi?video_id=video-123");
+ assert.equal(
+ calls[1].url,
+ "https://custom.example.com/agnesapi?video_id=video-123&model_name=job-video-v1"
+ );
});
test("video route returns 502 when job preset reports failed status", async () => {
From 16c68bad4957e880da951fcc7554e3cfb53a2ecf Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 22:42:32 +0200
Subject: [PATCH 17/20] feat(gamification): pay the documented streak and badge
XP rewards (#12522)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
`XP_REWARDS` documented `streak_bonus` and `badge_unlock` and the pipeline paid neither — closing that gap is right. The idempotency design carries it: `advanceStreak()` reporting `extended` only on the call that moves the record to today is what keeps a same-day repeat from paying twice.
---
Validated in one consolidated worktree cut from `release/v3.8.51`, boarded with the rest of this batch — zero conflicts between the 19 PRs.
- `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, all within the frozen baseline); `check:changelog-integrity` OK
- complexity 2802 / baseline 3218 and cognitive-complexity 1267 / baseline 1437 — both under baseline
- 226 of 228 focused assertions green across the batch's 23 test files. The 2 remaining belong to #12551, which is held separately.
Two batch-owned defects were found and fixed in flight, both pure base drift: `173_xp_action_counts.sql` collided with `173_call_logs_video_content_removed.sql` (renumbered to 176 on #12651 — it aborted every DB open, which is what 53 of the first run's failures were), and the feature-flag catalog was missing the `SERVER_OWNED_TOOL_LOOP_ENABLED` row the base gained after #12552 was written.
⚠️ base-red inherited: #12732 — `Docs Gates`, `Merge integrity`, `No new ESLint warnings`, `Unit Tests fast-path` and `Fast Quality Gates` reproduce on the pure tip (provider count 356 vs the 358 the modules define, SKILL.md drift, and `open-sse/utils/stream.ts` at 3115 > frozen 3098, which this batch does not touch).
Thanks @pacocartones — the `file:line` citations and the explicit out-of-scope notes on every one of these made a 19-PR batch reviewable in one pass.
---
.../12522-gamification-streak-badge-xp.md | 1 +
src/lib/db/gamification.ts | 29 ++-
src/lib/gamification/events.ts | 87 +++++--
src/lib/gamification/streaks.ts | 50 ++++-
tests/unit/gamification/events.test.ts | 6 +-
.../unit/gamification/streak-badge-xp.test.ts | 212 ++++++++++++++++++
6 files changed, 353 insertions(+), 32 deletions(-)
create mode 100644 changelog.d/features/12522-gamification-streak-badge-xp.md
create mode 100644 tests/unit/gamification/streak-badge-xp.test.ts
diff --git a/changelog.d/features/12522-gamification-streak-badge-xp.md b/changelog.d/features/12522-gamification-streak-badge-xp.md
new file mode 100644
index 0000000000..d13d0ad942
--- /dev/null
+++ b/changelog.d/features/12522-gamification-streak-badge-xp.md
@@ -0,0 +1 @@
+- **feat(gamification): pay the documented `streak_bonus` and `badge_unlock` XP rewards.** `XP_REWARDS` listed both rewards but the award pipeline never paid them: the private reward table in `events.ts` omitted them, `updateStreak()` did not report when a streak extended, and badge unlocks carried no XP. Every request that extends a daily streak now pays `streak_bonus × streak length` once per UTC day (guarded by a same-day `xp_audit_log` check), and every badge unlocked through the pipeline pays `badge_unlock` once per badge (guarded by the `user_badges` primary key; `unlockBadge()` now reports whether it inserted). Bonus XP flows through the same `addXp` + level sync + global/weekly/monthly leaderboard path as action XP, so level-ups and rankings include it. The Radar supporter recognition unlock stays XP-free. (#12522 — thanks @pacocartones)
diff --git a/src/lib/db/gamification.ts b/src/lib/db/gamification.ts
index df452271a6..12085a633a 100644
--- a/src/lib/db/gamification.ts
+++ b/src/lib/db/gamification.ts
@@ -222,10 +222,17 @@ export function updateLevel(apiKeyId: string, level: number): void {
// ──────────────── Badges ────────────────
-export function unlockBadge(apiKeyId: string, badgeId: string): void {
- db()
+/**
+ * Award a badge to an API key. Idempotent on the `(api_key_id, badge_id)` primary key.
+ *
+ * @returns `true` when this call inserted the badge, `false` when it was already earned.
+ * Callers that pay the `badge_unlock` XP reward key off this so a badge is paid once.
+ */
+export function unlockBadge(apiKeyId: string, badgeId: string): boolean {
+ const result = db()
.prepare(`INSERT OR IGNORE INTO user_badges (api_key_id, badge_id) VALUES (?, ?)`)
.run(apiKeyId, badgeId);
+ return result.changes > 0;
}
/**
@@ -243,6 +250,24 @@ export function hasBadge(apiKeyId: string, badgeId: string): boolean {
return !!row;
}
+/**
+ * Whether `xp_audit_log` already holds an entry for this action on the current UTC day.
+ *
+ * `created_at` is written by the table default `datetime('now')` as
+ * `"YYYY-MM-DD HH:MM:SS"` (UTC), so a lexical compare against `date('now')` selects
+ * today's rows. Used as the once-per-day guard for daily rewards such as `streak_bonus`.
+ */
+export function hasXpActionToday(apiKeyId: string, action: string): boolean {
+ const row = db()
+ .prepare(
+ `SELECT 1 FROM xp_audit_log
+ WHERE api_key_id = ? AND action = ? AND created_at >= date('now')
+ LIMIT 1`
+ )
+ .get(apiKeyId, action);
+ return !!row;
+}
+
export function getBadges(apiKeyId: string): UserBadge[] {
const rows = db()
.prepare(
diff --git a/src/lib/gamification/events.ts b/src/lib/gamification/events.ts
index 8c2ad62369..3560037a26 100644
--- a/src/lib/gamification/events.ts
+++ b/src/lib/gamification/events.ts
@@ -5,6 +5,7 @@
*/
import { logger } from "../../../open-sse/utils/logger.ts";
+import { calculateLevel, XP_REWARDS } from "./xp";
const log = logger("GAMIFICATION");
@@ -57,23 +58,19 @@ export async function emitGamificationEvent(params: {
const { addXp } = await import("../db/gamification");
addXp(apiKeyId, action, xpAmount, metadata ? JSON.stringify(metadata) : undefined);
- // Update level
- const { getXp, updateLevel } = await import("../db/gamification");
- const xp = getXp(apiKeyId);
- if (xp) {
- const { calculateLevel } = await import("./xp");
- const newLevel = calculateLevel(xp.totalXp);
- if (newLevel !== xp.currentLevel) {
- updateLevel(apiKeyId, newLevel);
- log.info("events.level_up", { apiKeyId, oldLevel: xp.currentLevel, newLevel });
- }
- }
+ await syncLevel(apiKeyId);
}
// 2. Update streak
if (action === "request") {
- const { updateStreak } = await import("./streaks");
- const streak = await updateStreak(apiKeyId);
+ const { advanceStreak } = await import("./streaks");
+ const { currentStreak: streak, extended } = await advanceStreak(apiKeyId);
+
+ // Pay the documented streak_bonus (XP_REWARDS: per consecutive streak day, multiplied
+ // by streak length) on the one request per UTC day that extends the streak.
+ if (extended) {
+ await awardStreakBonus(apiKeyId, streak);
+ }
// Check streak badges
if (streak >= 365) {
@@ -112,6 +109,54 @@ export async function emitGamificationEvent(params: {
}
}
+/**
+ * Recompute the level from total XP and persist it when it changed.
+ * Runs after every award so bonus XP (streaks, badges) also counts toward level-ups.
+ */
+async function syncLevel(apiKeyId: string): Promise {
+ const { getXp, updateLevel } = await import("../db/gamification");
+ const xp = getXp(apiKeyId);
+ if (!xp) return;
+ const newLevel = calculateLevel(xp.totalXp);
+ if (newLevel !== xp.currentLevel) {
+ updateLevel(apiKeyId, newLevel);
+ log.info("events.level_up", { apiKeyId, oldLevel: xp.currentLevel, newLevel });
+ }
+}
+
+/**
+ * Award a bonus reward (`streak_bonus`, `badge_unlock`) through the same path as action XP:
+ * `xp_audit_log` + `user_levels` via addXp, level sync, and the global/weekly/monthly
+ * leaderboard scopes. Idempotency is the caller's responsibility.
+ */
+async function awardBonusXp(
+ apiKeyId: string,
+ action: "streak_bonus" | "badge_unlock",
+ amount: number,
+ metadata: Record
+): Promise {
+ const { addXp } = await import("../db/gamification");
+ addXp(apiKeyId, action, amount, JSON.stringify(metadata));
+ await syncLevel(apiKeyId);
+
+ const { updateScore } = await import("./leaderboard");
+ await updateScore(apiKeyId, "global", amount);
+ await updateScore(apiKeyId, "weekly", amount);
+ await updateScore(apiKeyId, "monthly", amount);
+ log.info("events.bonus_awarded", { apiKeyId, action, amount, ...metadata });
+}
+
+/**
+ * Pay `streak_bonus × streak` once per UTC day. The `xp_audit_log` same-day check and the
+ * insert run synchronously with no await in between, so two requests racing at the day
+ * boundary cannot both pay.
+ */
+async function awardStreakBonus(apiKeyId: string, streak: number): Promise {
+ const { hasXpActionToday } = await import("../db/gamification");
+ if (hasXpActionToday(apiKeyId, "streak_bonus")) return;
+ await awardBonusXp(apiKeyId, "streak_bonus", XP_REWARDS.streak_bonus * streak, { streak });
+}
+
/**
* Get XP amount for an action.
*/
@@ -130,20 +175,28 @@ function getXpForAction(action: string): number {
}
/**
- * Check and unlock a specific badge.
+ * Check and unlock a specific badge, paying the documented `badge_unlock` XP once per badge.
+ *
+ * @param rewardable - `false` for recognition-only unlocks (Radar supporter): the caller
+ * supplies a one-way identity, so the unlock neither earns XP nor logs the identity.
*/
async function checkAndUnlockBadge(
apiKeyId: string,
badgeId: string,
- logIdentity = true
+ rewardable = true
): Promise {
const { unlockBadge, hasBadge } = await import("../db/gamification");
// #3472: dedup via user_badges directly. getBadges() INNER-JOINs badge_definitions, which is
// empty until seeded, so it falsely reported "not earned" and re-emitted the unlock event on
// every request.
if (!hasBadge(apiKeyId, badgeId)) {
- unlockBadge(apiKeyId, badgeId);
- log.info("events.badge_unlocked", logIdentity ? { apiKeyId, badgeId } : { badgeId });
+ // unlockBadge is INSERT OR IGNORE on the (api_key_id, badge_id) primary key; only the call
+ // that actually inserts the row pays, so concurrent unlocks cannot double-pay.
+ const inserted = unlockBadge(apiKeyId, badgeId);
+ log.info("events.badge_unlocked", rewardable ? { apiKeyId, badgeId } : { badgeId });
+ if (inserted && rewardable) {
+ await awardBonusXp(apiKeyId, "badge_unlock", XP_REWARDS.badge_unlock, { badgeId });
+ }
// Look up badge details from badge_definitions
const { getDbInstance } = await import("../db/core");
diff --git a/src/lib/gamification/streaks.ts b/src/lib/gamification/streaks.ts
index 4406375ac1..9c9303375c 100644
--- a/src/lib/gamification/streaks.ts
+++ b/src/lib/gamification/streaks.ts
@@ -157,7 +157,39 @@ export async function getAggregateStreak(): Promise<
* console.log(count); // 8
*/
export async function updateStreak(apiKeyId: string): Promise {
- if (isBuildPhase || isCloud) return 0;
+ const { currentStreak } = await advanceStreak(apiKeyId);
+ return currentStreak;
+}
+
+/**
+ * Result of {@link advanceStreak}.
+ */
+export interface StreakAdvance {
+ /** Current consecutive active days after this call */
+ currentStreak: number;
+ /**
+ * `true` only on the call that extended the streak onto a new consecutive day
+ * (yesterday was active, today was not yet counted). `false` when today was
+ * already counted, when a new streak starts at 1, or when streaks are disabled.
+ */
+ extended: boolean;
+}
+
+/**
+ * Same as {@link updateStreak}, but also reports whether this call extended the
+ * streak onto a new consecutive day. The award pipeline uses `extended` to pay
+ * the `streak_bonus` reward once per UTC day; repeated requests on the same day
+ * see `extended: false` because the record already carries today's date.
+ *
+ * @param apiKeyId - The API key identifier
+ * @returns The new streak count and whether it just extended
+ *
+ * @example
+ * const { currentStreak, extended } = await advanceStreak("key_abc123");
+ * if (extended) console.log(`day ${currentStreak} of the streak`);
+ */
+export async function advanceStreak(apiKeyId: string): Promise {
+ if (isBuildPhase || isCloud) return { currentStreak: 0, extended: false };
const db = getDbInstance() as unknown as DbLike;
const today = todayUtc();
@@ -165,19 +197,13 @@ export async function updateStreak(apiKeyId: string): Promise {
// Already counted today
if (streak.lastActiveDate === today) {
- return streak.currentStreak;
+ return { currentStreak: streak.currentStreak, extended: false };
}
const yesterday = yesterdayUtc();
- let newStreak: number;
-
- if (streak.lastActiveDate === yesterday) {
- // Consecutive day — extend streak
- newStreak = streak.currentStreak + 1;
- } else {
- // Streak broken or first activity — start fresh
- newStreak = 1;
- }
+ const extended = streak.lastActiveDate === yesterday;
+ // Consecutive day — extend streak; otherwise streak broken or first activity — start fresh
+ const newStreak = extended ? streak.currentStreak + 1 : 1;
const newData: StreakData = {
currentStreak: newStreak,
@@ -192,5 +218,5 @@ export async function updateStreak(apiKeyId: string): Promise {
JSON.stringify(newData)
);
- return newStreak;
+ return { currentStreak: newStreak, extended };
}
diff --git a/tests/unit/gamification/events.test.ts b/tests/unit/gamification/events.test.ts
index 0e2a9b6ed3..41a21b474e 100644
--- a/tests/unit/gamification/events.test.ts
+++ b/tests/unit/gamification/events.test.ts
@@ -1,6 +1,7 @@
import { describe, it } from "node:test";
import assert from "node:assert/strict";
import { emitGamificationEvent } from "../../../src/lib/gamification/events";
+import { XP_REWARDS } from "../../../src/lib/gamification/xp";
import { getDbInstance } from "../../../src/lib/db/core";
describe("Gamification Events", () => {
@@ -107,7 +108,10 @@ describe("Gamification Events", () => {
await emitGamificationEvent({ apiKeyId: key, action: "request" });
assert.equal(countRequestRows(key), 1);
- assert.equal(leaderboardScore(key), 1);
+ // The very first request also unlocks the "first-token" badge, and badge unlocks now
+ // pay XP_REWARDS.badge_unlock through the same leaderboard path. The gate only governs
+ // the action award, so the score is the 1 XP action plus the badge bonus.
+ assert.equal(leaderboardScore(key), 1 + XP_REWARDS.badge_unlock);
cleanup(key);
});
diff --git a/tests/unit/gamification/streak-badge-xp.test.ts b/tests/unit/gamification/streak-badge-xp.test.ts
new file mode 100644
index 0000000000..21eea0815d
--- /dev/null
+++ b/tests/unit/gamification/streak-badge-xp.test.ts
@@ -0,0 +1,212 @@
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { emitGamificationEvent } from "../../../src/lib/gamification/events";
+import { advanceStreak, getStreak } from "../../../src/lib/gamification/streaks";
+import { XP_REWARDS } from "../../../src/lib/gamification/xp";
+import { addXp, getXp, unlockBadge } from "../../../src/lib/db/gamification";
+import { getDbInstance } from "../../../src/lib/db/core";
+
+// `XP_REWARDS` documents `streak_bonus` ("per consecutive streak day, multiplied by streak
+// length") and `badge_unlock`, but the award pipeline never paid either: events.ts kept a
+// private reward table without them, updateStreak() did not report whether the streak had
+// just extended, and checkAndUnlockBadge() unlocked badges without XP. These tests pin the
+// documented rewards and their idempotency guards (once per UTC day, once per badge).
+
+const MS_PER_DAY = 86_400_000;
+const STREAK_NS = "gamification:streaks";
+
+function utcDate(offsetDays: number): string {
+ return new Date(Date.now() - offsetDays * MS_PER_DAY).toISOString().split("T")[0];
+}
+
+function seedStreak(apiKeyId: string, currentStreak: number, lastActiveDaysAgo: number): void {
+ const lastActiveDate = utcDate(lastActiveDaysAgo);
+ getDbInstance()
+ .prepare("INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES (?, ?, ?)")
+ .run(
+ STREAK_NS,
+ apiKeyId,
+ JSON.stringify({
+ currentStreak,
+ longestStreak: currentStreak,
+ lastActiveDate,
+ streakStartDate: utcDate(lastActiveDaysAgo + currentStreak - 1),
+ })
+ );
+}
+
+function auditRows(
+ apiKeyId: string,
+ action: string
+): Array<{ xp_earned: number; metadata: string | null }> {
+ return getDbInstance()
+ .prepare("SELECT xp_earned, metadata FROM xp_audit_log WHERE api_key_id = ? AND action = ?")
+ .all(apiKeyId, action) as Array<{ xp_earned: number; metadata: string | null }>;
+}
+
+function auditTotal(apiKeyId: string): number {
+ const row = getDbInstance()
+ .prepare("SELECT COALESCE(SUM(xp_earned), 0) AS total FROM xp_audit_log WHERE api_key_id = ?")
+ .get(apiKeyId) as { total: number };
+ return row.total;
+}
+
+function leaderboardScore(apiKeyId: string, scope: string): number {
+ const row = getDbInstance()
+ .prepare("SELECT score FROM leaderboard WHERE api_key_id = ? AND scope = ?")
+ .get(apiKeyId, scope) as { score: number } | undefined;
+ return row?.score ?? 0;
+}
+
+function cleanup(apiKeyId: string): void {
+ const db = getDbInstance();
+ db.prepare("DELETE FROM xp_audit_log WHERE api_key_id = ?").run(apiKeyId);
+ db.prepare("DELETE FROM user_levels WHERE api_key_id = ?").run(apiKeyId);
+ db.prepare("DELETE FROM user_badges WHERE api_key_id = ?").run(apiKeyId);
+ db.prepare("DELETE FROM leaderboard WHERE api_key_id = ?").run(apiKeyId);
+ db.prepare("DELETE FROM key_value WHERE namespace = ? AND key = ?").run(STREAK_NS, apiKeyId);
+}
+
+describe("streak bonus XP", () => {
+ it("advanceStreak reports whether the streak extended today", async () => {
+ const key = `sb-advance-${Date.now()}`;
+ try {
+ seedStreak(key, 1, 1);
+ const first = await advanceStreak(key);
+ assert.deepEqual(first, { currentStreak: 2, extended: true });
+ const second = await advanceStreak(key);
+ assert.deepEqual(second, { currentStreak: 2, extended: false }, "same day is a no-op");
+ } finally {
+ cleanup(key);
+ }
+ });
+
+ it("pays streak_bonus x streak length on the day the streak extends", async () => {
+ const key = `sb-pay-${Date.now()}`;
+ try {
+ seedStreak(key, 1, 1); // active yesterday → today's request extends to 2
+ await emitGamificationEvent({ apiKeyId: key, action: "request" });
+
+ const rows = auditRows(key, "streak_bonus");
+ assert.equal(rows.length, 1, "exactly one streak_bonus audit row");
+ assert.equal(rows[0].xp_earned, XP_REWARDS.streak_bonus * 2);
+ assert.deepEqual(JSON.parse(rows[0].metadata ?? "{}"), { streak: 2 });
+ assert.equal((await getStreak(key)).currentStreak, 2);
+
+ const total = auditTotal(key);
+ assert.equal(getXp(key)?.totalXp, total, "user_levels.total_xp matches the audit log");
+ assert.equal(leaderboardScore(key, "global"), total, "global leaderboard credits the bonus");
+ assert.equal(leaderboardScore(key, "weekly"), total);
+ assert.equal(leaderboardScore(key, "monthly"), total);
+ } finally {
+ cleanup(key);
+ }
+ });
+
+ it("pays the bonus once per UTC day even when requests repeat", async () => {
+ const key = `sb-once-${Date.now()}`;
+ try {
+ seedStreak(key, 4, 1);
+ await emitGamificationEvent({ apiKeyId: key, action: "request" });
+ await emitGamificationEvent({ apiKeyId: key, action: "request" });
+ await emitGamificationEvent({ apiKeyId: key, action: "request" });
+
+ const rows = auditRows(key, "streak_bonus");
+ assert.equal(rows.length, 1);
+ assert.equal(rows[0].xp_earned, XP_REWARDS.streak_bonus * 5);
+ } finally {
+ cleanup(key);
+ }
+ });
+
+ it("does not pay on the first day of a streak or after a broken streak", async () => {
+ const fresh = `sb-fresh-${Date.now()}`;
+ const broken = `sb-broken-${Date.now()}`;
+ try {
+ await emitGamificationEvent({ apiKeyId: fresh, action: "request" });
+ assert.equal(auditRows(fresh, "streak_bonus").length, 0, "day 1 is not a consecutive day");
+
+ seedStreak(broken, 6, 3); // last active three days ago → streak resets to 1
+ await emitGamificationEvent({ apiKeyId: broken, action: "request" });
+ assert.equal((await getStreak(broken)).currentStreak, 1);
+ assert.equal(auditRows(broken, "streak_bonus").length, 0);
+ } finally {
+ cleanup(fresh);
+ cleanup(broken);
+ }
+ });
+});
+
+describe("badge unlock XP", () => {
+ it("unlockBadge reports whether a new row was inserted", () => {
+ const key = `bu-insert-${Date.now()}`;
+ try {
+ assert.equal(unlockBadge(key, "first-token"), true);
+ assert.equal(unlockBadge(key, "first-token"), false, "INSERT OR IGNORE → no new row");
+ } finally {
+ cleanup(key);
+ }
+ });
+
+ it("pays badge_unlock once per badge when the pipeline unlocks it", async () => {
+ const key = `bu-pay-${Date.now()}`;
+ try {
+ await emitGamificationEvent({ apiKeyId: key, action: "request" }); // → first-token
+ await emitGamificationEvent({ apiKeyId: key, action: "request" }); // already earned
+
+ const rows = auditRows(key, "badge_unlock");
+ assert.equal(rows.length, 1, "exactly one badge_unlock audit row");
+ assert.equal(rows[0].xp_earned, XP_REWARDS.badge_unlock);
+ assert.deepEqual(JSON.parse(rows[0].metadata ?? "{}"), { badgeId: "first-token" });
+
+ const total = auditTotal(key);
+ assert.equal(total, 2 * XP_REWARDS.request + XP_REWARDS.badge_unlock);
+ assert.equal(getXp(key)?.totalXp, total);
+ assert.equal(leaderboardScore(key, "global"), total);
+ } finally {
+ cleanup(key);
+ }
+ });
+
+ it("pays the streak badge and the streak bonus from the same request", async () => {
+ const key = `bu-streak-${Date.now()}`;
+ try {
+ seedStreak(key, 2, 1); // → 3 today: daily-user badge + bonus
+ await emitGamificationEvent({ apiKeyId: key, action: "request" });
+
+ const badgeRows = auditRows(key, "badge_unlock");
+ const unlocked = badgeRows.map((r) => JSON.parse(r.metadata ?? "{}").badgeId).sort();
+ assert.deepEqual(unlocked, ["daily-user", "first-token"]);
+ assert.equal(auditRows(key, "streak_bonus")[0]?.xp_earned, XP_REWARDS.streak_bonus * 3);
+ } finally {
+ cleanup(key);
+ }
+ });
+
+ it("recomputes the level after bonus XP, not only after the action XP", async () => {
+ const key = `bu-level-${Date.now()}`;
+ try {
+ // Level 2 needs 282 XP. 280 + 1 (request) = 281 stays level 1; the first-token
+ // badge_unlock XP crosses the threshold, so the level must be synced after it.
+ addXp(key, "request", 280);
+ assert.equal(getXp(key)?.currentLevel, 1);
+ await emitGamificationEvent({ apiKeyId: key, action: "request" });
+ assert.equal(getXp(key)?.totalXp, 280 + XP_REWARDS.request + XP_REWARDS.badge_unlock);
+ assert.equal(getXp(key)?.currentLevel, 2);
+ } finally {
+ cleanup(key);
+ }
+ });
+
+ it("keeps the radar_supporter recognition path free of XP", async () => {
+ const identity = `bu-radar-${Date.now()}`;
+ try {
+ await emitGamificationEvent({ apiKeyId: identity, action: "radar_supporter" });
+ assert.equal(auditRows(identity, "badge_unlock").length, 0);
+ assert.equal(getXp(identity), null);
+ assert.equal(leaderboardScore(identity, "global"), 0);
+ } finally {
+ cleanup(identity);
+ }
+ });
+});
From 3f62e4369656b66913b2c72767597871fe2d4cb1 Mon Sep 17 00:00:00 2001
From: Diego Rodrigues de Sa e Souza
Date: Fri, 11 Sep 2026 17:46:22 -0300
Subject: [PATCH 18/20] test(compression): assert idle eviction terminates at
the resource level (#13371)
Merged as the credit vehicle for #12542. Reverse-TDD verified on the tip: 8/8 with the fix, 7/8 with `terminate()` disabled.
---
.../12542-compression-idle-terminate-test.md | 1 +
.../compression/compression-worker.test.ts | 35 +++++++++++++++++++
2 files changed, 36 insertions(+)
create mode 100644 changelog.d/maintenance/12542-compression-idle-terminate-test.md
diff --git a/changelog.d/maintenance/12542-compression-idle-terminate-test.md b/changelog.d/maintenance/12542-compression-idle-terminate-test.md
new file mode 100644
index 0000000000..744e38f854
--- /dev/null
+++ b/changelog.d/maintenance/12542-compression-idle-terminate-test.md
@@ -0,0 +1 @@
+- **test(compression):** cover idle worker eviction at the resource level — the pool must call `terminate()` and must not retain the worker's `MessagePort`, complementing the `exit`-event assertion added with the fix
diff --git a/tests/unit/compression/compression-worker.test.ts b/tests/unit/compression/compression-worker.test.ts
index 0ca4cbd453..93265c91e7 100644
--- a/tests/unit/compression/compression-worker.test.ts
+++ b/tests/unit/compression/compression-worker.test.ts
@@ -1,5 +1,6 @@
import assert from "node:assert/strict";
import { after, describe, it } from "node:test";
+import { Worker } from "node:worker_threads";
import {
isCompressionWorkerEligible,
isStrictlySerializable,
@@ -136,6 +137,40 @@ describe("compression worker execution", () => {
}
});
+ it("terminates an idle worker instead of only dropping it from the pool", async () => {
+ const spawned = new Set();
+ const terminated: Promise[] = [];
+ const originalPostMessage = Worker.prototype.postMessage;
+ const originalTerminate = Worker.prototype.terminate;
+ Worker.prototype.postMessage = function (this: Worker, ...args) {
+ spawned.add(this);
+ return originalPostMessage.apply(this, args);
+ };
+ Worker.prototype.terminate = function (this: Worker) {
+ const exit = originalTerminate.call(this);
+ terminated.push(exit);
+ return exit;
+ };
+ const messagePorts = () =>
+ process.getActiveResourcesInfo().filter((resource) => resource === "MessagePort").length;
+ const portsBefore = messagePorts();
+ const pool = new CompressionWorkerPool({ size: 1, idleMs: 50 });
+ try {
+ await pool.run(body, "stacked", { config });
+ await new Promise((resolve) => setTimeout(resolve, 300));
+ assert.equal(spawned.size, 1);
+ assert.equal(terminated.length, 1, "idle eviction must terminate the worker thread");
+ await Promise.all(terminated);
+ assert.ok(messagePorts() <= portsBefore, "idle eviction must not retain the worker's port");
+ } finally {
+ Worker.prototype.postMessage = originalPostMessage;
+ Worker.prototype.terminate = originalTerminate;
+ await pool.close();
+ // Reap anything the pool forgot so a regression fails instead of hanging the runner.
+ await Promise.all([...spawned].map((worker) => worker.terminate().catch(() => undefined)));
+ }
+ });
+
it("keeps the parent event loop responsive while two workers overlap", async () => {
const largeBody = {
messages: Array.from({ length: 400 }, (_, index) => ({
From 374bbe3ee7aaa8052d8ebd6829b31a72bac50312 Mon Sep 17 00:00:00 2001
From: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Date: Fri, 11 Sep 2026 23:09:58 +0200
Subject: [PATCH 19/20] fix(i18n): translate the home Recent Requests panel and
topology legend (#12551)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The diagnosis is the valuable part here: a verbatim English copy is invisible to every i18n gate — `check-ui-keys-coverage` counts it as covered, `sync-ui-keys` only backfills absent keys, and `check-ui-value-drift` only reacts to English values that change. That is exactly how five keys shipped in #10900 stayed English in 39 catalogs without anything noticing, and a static test asserting "not equal to the English value" is the right instrument for it.
Two things needed reconciling before merge, both pure drift from the time this sat open:
**Nine locales did not exist when you cut this branch** — el, et, ga, hr, lt, lv, mt, sl, sr. They arrived with the Recent Requests keys but not the topology legend ones, so your own first assertion failed on them. I filled the three keys from each catalog's existing approved translations of the same words (`common.active`, `common.recent`, `analytics.modelStatusError`) rather than a fresh translation pass, so the legend reads the same as the rest of that language's dashboard.
**Two cognates were being failed for being correct** — `hr.recentRequestsModel` and `sl.recentRequestsModel` are "Model", which is the right word in Croatian and Slovenian. Your `COGNATES` set already existed for exactly this (`es.topologyLegendError`), but the third assertion swept every locale without consulting it. It does now.
5/5 on the suite afterwards, and the diff stayed at the nine locale files plus the test — no collateral sync.
---
Validated in the consolidated worktree for this batch. `typecheck:core` clean, `check:dashboard-typecheck` OK, complexity and cognitive-complexity under baseline.
⚠️ base-red inherited: #12732 — and separately, `npm run i18n:check` reports 75 doc-translation drift entries across 35 files on the pure tip (40 of them `docs/reference/ENVIRONMENT.md`). That is the docs pipeline, untouched by this PR.
Thanks @pacocartones — 17 more of yours merged today.
---
...2551-i18n-home-recent-requests-topology.md | 1 +
.../dashboard/HomeProviderTopologySection.tsx | 9 +-
src/i18n/messages/ar.json | 13 +-
src/i18n/messages/az.json | 13 +-
src/i18n/messages/bg.json | 13 +-
src/i18n/messages/bn.json | 13 +-
src/i18n/messages/cs.json | 13 +-
src/i18n/messages/da.json | 13 +-
src/i18n/messages/de.json | 13 +-
src/i18n/messages/el.json | 3 +
src/i18n/messages/en.json | 3 +
src/i18n/messages/es.json | 13 +-
src/i18n/messages/et.json | 3 +
src/i18n/messages/fa.json | 13 +-
src/i18n/messages/fi.json | 13 +-
src/i18n/messages/fr.json | 13 +-
src/i18n/messages/ga.json | 3 +
src/i18n/messages/gu.json | 13 +-
src/i18n/messages/he.json | 13 +-
src/i18n/messages/hi.json | 13 +-
src/i18n/messages/hr.json | 3 +
src/i18n/messages/hu.json | 13 +-
src/i18n/messages/id.json | 13 +-
src/i18n/messages/it.json | 13 +-
src/i18n/messages/ja.json | 13 +-
src/i18n/messages/ko.json | 13 +-
src/i18n/messages/lt.json | 3 +
src/i18n/messages/lv.json | 3 +
src/i18n/messages/mr.json | 13 +-
src/i18n/messages/ms.json | 13 +-
src/i18n/messages/mt.json | 3 +
src/i18n/messages/nl.json | 13 +-
src/i18n/messages/no.json | 13 +-
src/i18n/messages/phi.json | 13 +-
src/i18n/messages/pl.json | 13 +-
src/i18n/messages/pt-BR.json | 3 +
src/i18n/messages/pt.json | 13 +-
src/i18n/messages/ro.json | 13 +-
src/i18n/messages/ru.json | 13 +-
src/i18n/messages/sk.json | 13 +-
src/i18n/messages/sl.json | 3 +
src/i18n/messages/sr.json | 3 +
src/i18n/messages/sv.json | 13 +-
src/i18n/messages/sw.json | 13 +-
src/i18n/messages/ta.json | 13 +-
src/i18n/messages/te.json | 13 +-
src/i18n/messages/th.json | 13 +-
src/i18n/messages/tr.json | 13 +-
src/i18n/messages/uk-UA.json | 13 +-
src/i18n/messages/ur.json | 13 +-
src/i18n/messages/vi.json | 3 +
src/i18n/messages/zh-CN.json | 13 +-
src/i18n/messages/zh-TW.json | 13 +-
...me-recent-requests-topology-legend.test.ts | 134 ++++++++++++++++++
54 files changed, 486 insertions(+), 201 deletions(-)
create mode 100644 changelog.d/fixes/12551-i18n-home-recent-requests-topology.md
create mode 100644 tests/unit/i18n-home-recent-requests-topology-legend.test.ts
diff --git a/changelog.d/fixes/12551-i18n-home-recent-requests-topology.md b/changelog.d/fixes/12551-i18n-home-recent-requests-topology.md
new file mode 100644
index 0000000000..87dbbcf0b7
--- /dev/null
+++ b/changelog.d/fixes/12551-i18n-home-recent-requests-topology.md
@@ -0,0 +1 @@
+- **fix(i18n):** the home "Recent Requests" panel and the Provider Topology legend are now translated instead of rendering English copies on non-English dashboards; the legend reads its own `home.topologyLegend*` labels with consistent casing rather than borrowing the memory-settings "Recent" and analytics "Error" strings (#12551 — thanks @pacocartones).
diff --git a/src/app/(dashboard)/dashboard/HomeProviderTopologySection.tsx b/src/app/(dashboard)/dashboard/HomeProviderTopologySection.tsx
index 034088e7b8..172cb5a1dc 100644
--- a/src/app/(dashboard)/dashboard/HomeProviderTopologySection.tsx
+++ b/src/app/(dashboard)/dashboard/HomeProviderTopologySection.tsx
@@ -29,9 +29,6 @@ export function HomeProviderTopologySection({
enabled?: boolean;
}) {
const t = useTranslations("home");
- const tCommon = useTranslations("common");
- const tSettings = useTranslations("settings");
- const tAnalytics = useTranslations("analytics");
// #4596: gate the live-WS connection so it only opens while the topology
// section is actually shown on the home page.
const { activeRequests: liveActiveRequests } = useLiveRequests({ enabled });
@@ -50,15 +47,15 @@ export function HomeProviderTopologySection({
- {tCommon("active")}
+ {t("topologyLegendActive")}
- {tSettings("recent")}
+ {t("topologyLegendRecent")}
- {tAnalytics("modelStatusError")}
+ {t("topologyLegendError")}