From 8d371d4e86f3c7223b52f3ddefa09111d82b2127 Mon Sep 17 00:00:00 2001 From: anhtahaylove <37265396+anhtahaylove@users.noreply.github.com> Date: Fri, 11 Sep 2026 12:29:40 +0700 Subject: [PATCH] test: expect the jina alias prefix in the custom-model catalog case The custom-model assertions expected ids prefixed `jina-ai/`, but the catalog prefixes model ids with the provider alias, which is `jina`. The synced-model test directly above asserts `jina/` and passes, so the two cases contradicted each other within the same file. The expectation predates the alias: the test was written in v3.7.9 (2026-05-04) and `alias: "jina"` was added in v3.8.36 (2026-06-25). Aligns the two assertions with the sibling test and with the product. The file now passes 44/44 (was 43 with 1 failure). Confirmed the assertions still bite: renaming the alias to `jina-XX` fails exactly these two cases. --- tests/unit/models-catalog-route.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/models-catalog-route.test.ts b/tests/unit/models-catalog-route.test.ts index cfecc23c96..c80c00e61e 100644 --- a/tests/unit/models-catalog-route.test.ts +++ b/tests/unit/models-catalog-route.test.ts @@ -1092,9 +1092,9 @@ test("v1 models catalog does not duplicate custom Jina specialty models", async assert.equal(response.status, 200); assert.equal(visibleJinaEmbeddingRows.length, 1); - assert.equal(visibleJinaEmbeddingRows[0].id, "jina-ai/jina-embeddings-v5-text-small"); + assert.equal(visibleJinaEmbeddingRows[0].id, "jina/jina-embeddings-v5-text-small"); assert.equal(visibleJinaRerankRows.length, 1); - assert.equal(visibleJinaRerankRows[0].id, "jina-ai/jina-reranker-v3"); + assert.equal(visibleJinaRerankRows[0].id, "jina/jina-reranker-v3"); }); test("v1 models catalog exposes image model input and output modalities for advanced image providers", async () => {