From b18fa2719500e3ff0986ebce38aff80c9a40ac4f Mon Sep 17 00:00:00 2001 From: Probe Test Date: Thu, 23 Jul 2026 03:58:39 -0300 Subject: [PATCH] test(nvidia): read PROVIDER_BREAKER_FAILURE_STATUSES from chatPredicates.ts Same root cause as the chat.ts import fix in this PR: the const was extracted out of chat.ts into chatPredicates.ts, so the nvidia-quota Phase-1 guard (which greps the source for the `= new Set([...])` declaration to prove 429 was not added to the breaker classification) must read chatPredicates.ts, not chat.ts. Now 13/0. --- tests/unit/nvidia-quota-phase1.test.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/unit/nvidia-quota-phase1.test.ts b/tests/unit/nvidia-quota-phase1.test.ts index ef09091d01..8dabaaea5f 100644 --- a/tests/unit/nvidia-quota-phase1.test.ts +++ b/tests/unit/nvidia-quota-phase1.test.ts @@ -189,7 +189,11 @@ test("getProviderConcurrencyCap resolves override -> static default -> fallback" ); setProviderQuotaOverrides({ nvidia: { concurrency: 3 } }); try { - assert.equal(getProviderConcurrencyCap("nvidia", 99), 3, "override wins over the static default"); + assert.equal( + getProviderConcurrencyCap("nvidia", 99), + 3, + "override wins over the static default" + ); } finally { setProviderQuotaOverrides(null); } @@ -218,13 +222,9 @@ test("nvidia 429 does not trip the provider circuit breaker (unchanged 408/500/5 // is a documentation-alignment guard proving Phase 1 didn't accidentally widen // PROVIDER_BREAKER_FAILURE_STATUSES to include 429 (which would collapse the // per-model lockout this PR adds into a whole-connection/provider outage). - const chatHandlerPath = path.join( - process.cwd(), - "src", - "sse", - "handlers", - "chat.ts" - ); + // The PROVIDER_BREAKER_FAILURE_STATUSES declaration was extracted from chat.ts into + // the sibling chatPredicates.ts (chat.ts now imports it); read it from its home. + const chatHandlerPath = path.join(process.cwd(), "src", "sse", "handlers", "chatPredicates.ts"); const source = fs.readFileSync(chatHandlerPath, "utf8"); const match = source.match(/PROVIDER_BREAKER_FAILURE_STATUSES\s*=\s*new Set\(\[([^\]]+)\]\)/); assert.ok(match, "PROVIDER_BREAKER_FAILURE_STATUSES declaration found");