From b250e08d77447ee64349f930f06c668bc120a35f Mon Sep 17 00:00:00 2001
From: Randi <55005611+rdself@users.noreply.github.com>
Date: Mon, 15 Jun 2026 20:03:26 -0400
Subject: [PATCH] fix in-flight request payload sync (#3940)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Integrated into release/v3.8.26 — keep pendingById in sync with the queue detail (Object.assign in place). Validated alongside #3937: typecheck:core clean, 42/42 request-logger + lifecycle tests, eslint 0 errors, file-size OK.
---
 src/lib/usage/usageHistory.ts               |  2 +-
 tests/unit/request-logger-endpoints.test.ts | 34 +++++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletion(-)

diff --git a/src/lib/usage/usageHistory.ts b/src/lib/usage/usageHistory.ts
index 3a30df601d..d194fe03fe 100644
--- a/src/lib/usage/usageHistory.ts
+++ b/src/lib/usage/usageHistory.ts
@@ -305,7 +305,7 @@ export function updatePendingRequest(
   const details = pendingRequests.details[connectionId]?.[modelKey];
   if (!details?.length) return;
   const lastIdx = details.length - 1;
-  details[lastIdx] = { ...details[lastIdx], ...normalizePendingMetadata(metadata) };
+  Object.assign(details[lastIdx], normalizePendingMetadata(metadata));
 }
 
 /**
diff --git a/tests/unit/request-logger-endpoints.test.ts b/tests/unit/request-logger-endpoints.test.ts
index fda95337e0..e504523591 100644
--- a/tests/unit/request-logger-endpoints.test.ts
+++ b/tests/unit/request-logger-endpoints.test.ts
@@ -87,6 +87,40 @@ test("updatePendingRequestStreamChunks stores stream chunks in the detail", () =
   assert.equal(detail.streamChunks.provider[0], 'data: {"a":1}');
 });
 
+test("updatePendingRequest keeps pending detail API view in sync", () => {
+  usageHistory.clearPendingRequests();
+  const requestId = usageHistory.trackPendingRequest(
+    "claude-sonnet-4-6",
+    "cc-test",
+    "conn-1",
+    true,
+    {
+      clientRequest: { model: "cc-test/claude-sonnet-4-6", reasoning_effort: "xhigh" },
+      providerRequest: { model: "claude-sonnet-4-6", reasoning_effort: "xhigh" },
+    }
+  );
+  assert.ok(requestId, "trackPendingRequest should return an id");
+
+  usageHistory.updatePendingRequest("claude-sonnet-4-6", "cc-test", "conn-1", {
+    providerRequest: { model: "claude-sonnet-4-6", reasoning_effort: "high" },
+    stage: "provider_response_started",
+  });
+
+  const modelKey = "claude-sonnet-4-6 (cc-test)";
+  const detailFromQueue = usageHistory.getPendingRequests().details["conn-1"]?.[modelKey]?.[0];
+  const detailFromId = usageHistory.getPendingById().get(requestId);
+
+  assert.equal(detailFromId, detailFromQueue);
+  assert.deepEqual(detailFromId?.providerRequest, {
+    model: "claude-sonnet-4-6",
+    reasoning_effort: "high",
+  });
+  assert.deepEqual(detailFromId?.clientRequest, {
+    model: "cc-test/claude-sonnet-4-6",
+    reasoning_effort: "xhigh",
+  });
+});
+
 test("updatePendingRequestStreamChunks stores empty streamChunks object (not null)", () => {
   usageHistory.clearPendingRequests();
   usageHistory.trackPendingRequest("gpt-4", "openai", "conn-1", true);