mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 04:12:17 +03:00
test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
This commit is contained in:
@@ -38,7 +38,7 @@ function withStubQoderCli(fn: () => void | Promise<void>) {
|
||||
const restore = () => {
|
||||
if (prevBin === undefined) delete process.env.CLI_QODER_BIN;
|
||||
else process.env.CLI_QODER_BIN = prevBin;
|
||||
fs.rmSync(dir, { recursive: true, force: true });
|
||||
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
||||
};
|
||||
return Promise.resolve().then(fn).finally(restore);
|
||||
}
|
||||
@@ -489,7 +489,7 @@ test("runQoderCli survives qodercli exiting before it reads a large stdin (async
|
||||
} finally {
|
||||
if (prevBin === undefined) delete process.env.CLI_QODER_BIN;
|
||||
else process.env.CLI_QODER_BIN = prevBin;
|
||||
fs.rmSync(dir, { recursive: true, force: true });
|
||||
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
||||
}
|
||||
});
|
||||
|
||||
@@ -516,7 +516,7 @@ test("runQoderCli preserves multi-byte UTF-8 output (Chinese) via stream setEnco
|
||||
} finally {
|
||||
if (prevBin === undefined) delete process.env.CLI_QODER_BIN;
|
||||
else process.env.CLI_QODER_BIN = prevBin;
|
||||
fs.rmSync(dir, { recursive: true, force: true });
|
||||
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
||||
}
|
||||
});
|
||||
|
||||
@@ -581,6 +581,6 @@ test("runQoderCli resolves the request against live --list-models and passes the
|
||||
qoderCli.__clearQoderModelNamesCache();
|
||||
if (prevBin === undefined) delete process.env.CLI_QODER_BIN;
|
||||
else process.env.CLI_QODER_BIN = prevBin;
|
||||
fs.rmSync(dir, { recursive: true, force: true });
|
||||
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
||||
}
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user