From c2a322b1d405ccbcadaf3119e2254cfb18b72ce6 Mon Sep 17 00:00:00 2001 From: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Date: Wed, 5 Aug 2026 02:29:13 -0300 Subject: [PATCH] fix(tests): drop a third unsuppressed any (gemini-web validation test) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A full-repo lint on this branch surfaced one more file in the same class: tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts:50 casts (executor as any).testConnection. The file entered the release at f1ea77fd04 (23:28), newer than the frozen eslint-suppressions.json, so the cast is not covered — and it alone kept 'No new ESLint warnings' red on this very PR. testConnection is a declared public method on GeminiWebExecutor (open-sse/executors/gemini-web.ts:359), so the cast was redundant rather than load-bearing; removed outright. eslint exit 0, typecheck:core exit 0, 15/15 across the three touched tests. --- changelog.d/maintenance/base-reds-v3850-golden-and-any.md | 2 +- .../issue-9407-gemini-web-validation-false-positive.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changelog.d/maintenance/base-reds-v3850-golden-and-any.md b/changelog.d/maintenance/base-reds-v3850-golden-and-any.md index 6ae7b19762..447d392ae2 100644 --- a/changelog.d/maintenance/base-reds-v3850-golden-and-any.md +++ b/changelog.d/maintenance/base-reds-v3850-golden-and-any.md @@ -1 +1 @@ -- **chore(tests):** cleared two base-reds sitting on `release/v3.8.50` itself, both of which turned every open PR red the moment it merged the release. `tests/snapshots/provider/translate-path.json` was stale: #9064 added the `code-execution-2025-08-25` and `skills-2025-10-02` beta flags to the Anthropic header without regenerating the golden, so `provider-translate-path-golden` failed on the bare release tip (2 pass / 1 fail with zero PRs boarded). And `tests/unit/v1-models-auth-leak-9320.test.ts:83` shipped a `(k: any)` in a file new enough that `config/quality/eslint-suppressions.json` does not cover it — with `@typescript-eslint/no-explicit-any` set to `error` under `tests/`, that single cast failed the `No new ESLint warnings` gate repo-wide. Regenerating the snapshot and dropping the redundant cast (the callback parameter infers correctly) restores both gates. +- **chore(tests):** cleared two base-reds sitting on `release/v3.8.50` itself, both of which turned every open PR red the moment it merged the release. `tests/snapshots/provider/translate-path.json` was stale: #9064 added the `code-execution-2025-08-25` and `skills-2025-10-02` beta flags to the Anthropic header without regenerating the golden, so `provider-translate-path-golden` failed on the bare release tip (2 pass / 1 fail with zero PRs boarded). And `tests/unit/v1-models-auth-leak-9320.test.ts:83` shipped a `(k: any)` in a file new enough that `config/quality/eslint-suppressions.json` does not cover it — with `@typescript-eslint/no-explicit-any` set to `error` under `tests/`, that single cast failed the `No new ESLint warnings` gate repo-wide. Same class in `tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts:50` (`(executor as any).testConnection`), which entered at `f1ea77fd04` — `testConnection` is a declared public method on `GeminiWebExecutor`, so that cast was redundant too. Regenerating the snapshot and dropping both casts restores the gates. diff --git a/tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts b/tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts index 3ef47b16b5..371295b02b 100644 --- a/tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts +++ b/tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts @@ -47,7 +47,7 @@ describe("GeminiWebExecutor — testConnection", () => { "@omniroute/open-sse/executors/gemini-web.ts" ); const executor = new GeminiWebExecutor(); - assert.equal(typeof (executor as any).testConnection, "function"); + assert.equal(typeof executor.testConnection, "function"); }); it("returns false for empty credentials", async () => {