pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-07-26 09:52:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): bare omniroute (default serve) must provision STORAGE_ENCRYPTION_KEY

Browse Source 
My #3129 gate wrongly skipped provisioning for a bare `omniroute` invocation —
but `serve` is isDefault:true, so bare runs the server, which needs the key.
Only --version/--help/help/completion skip now. Realigns with #1622: its bootstrap
test invoked `--help` (now correctly skipped), so it's switched to `config list
--json` (a real, fast, offline command) to exercise the provisioning path.
This commit is contained in:
diegosouzapw
2026-06-03 21:08:01 -03:00
parent f1c42359a2
commit e1007acb7e
3 changed files with 24 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
bin/cli/utils/storageKeyProvision.mjs
View File

@@ -5,13 +5,15 @@
* Purely informational invocations must NOT create `~/.omniroute/.env` or write
* a key — they never touch encrypted storage. Generating a 32-byte key and a
* `.env` file just to print `omniroute --version` (or `--help`) is a surprising
* side effect: running a read-only command should not mutate the data dir.
* side effect: a read-only command should not mutate the data dir.
*
* Returns false for: no command at all (bare `omniroute` → Commander prints
* help), `--version`/`-V` or `--help`/`-h` anywhere in the args, and the
* `help`/`completion` subcommands. Returns true for every real command
* (`serve`, `keys`, `providers`, …) so the encryption key is still provisioned
* before encrypted storage is accessed (preserves the #1622 persistence fix).
* Returns FALSE only for: `--version`/`-V` or `--help`/`-h` anywhere in the args,
* and the `help`/`completion` subcommands.
*
* Returns TRUE for everything else, INCLUDING a bare `omniroute` (no args) — the
* `serve` command is `isDefault: true`, so a bare invocation starts the server,
* which needs the encryption key. This preserves the #1622 persistence fix
* (key generated on first real run and reused across restarts).
*
* @param {string[]} argv - process.argv (node + script + args).
* @returns {boolean}
@@ -21,7 +23,8 @@ const INFO_COMMANDS = new Set(["help", "completion"]);
export function shouldProvisionStorageKey(argv) {
const args = Array.isArray(argv) ? argv.slice(2) : [];
if (args.length === 0) return false;
// Bare `omniroute` runs the default `serve` command → must provision.
if (args.length === 0) return true;
if (args.some((a) => INFO_FLAGS.has(a))) return false;
if (INFO_COMMANDS.has(args[0])) return false;
return true;