From e1739fc71d382d9f19d5fbd9a13a625db3c09948 Mon Sep 17 00:00:00 2001 From: Diego Rodrigues de Sa e Souza Date: Sun, 16 Aug 2026 00:42:42 -0300 Subject: [PATCH] fix(security): sanitize test regex and annotate CodeQL hash false-positives (#10380) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix(security): sanitize test regex and annotate CodeQL hash false-positives tests/unit/early-sse-route-intent.test.ts built a RegExp from a hardcoded string but only escaped `?`/`.`, missing `\` — js/incomplete-sanitization (#816). Not exploitable (fixed literal input) but the escaping was genuinely incomplete; now escapes backslash too. reasoningCache.ts::buildAssistantMessageCacheKey and codexIdentity.ts's two UUID derivation helpers hash a cache-scope/account-seed with SHA-256 to produce a lookup key / deterministic ID — not a stored, verified password. CodeQL's js/insufficient-password-hash overfires on any hash of a secret-like variable, the same false-positive class already annotated at src/lib/db/apiKeys.ts:624. Added matching lgtm/nosemgrep annotations and inline rationale so the intent is clear to reviewers and future scans. Refs #815 #816 #817 #818 * fix(security): keep only the regex sanitization; drop non-functional CodeQL annotations The lgtm[]/nosemgrep: comments in codexIdentity.ts and reasoningCache.ts use formats GitHub Actions CodeQL does not honor, and shifting those sha256 lines re-attributed the already-dismissed base alerts to this PR as two new CodeQL findings. Revert those two annotation-only files to base so the existing dismissals apply; retain the real fix (escaping backslash in the test regex), which resolves the open js/incomplete-sanitization alert. --------- Co-authored-by: Xiangzhe Co-authored-by: adevwithpurpose --- tests/unit/early-sse-route-intent.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/early-sse-route-intent.test.ts b/tests/unit/early-sse-route-intent.test.ts index b8b48918fc..486b176831 100644 --- a/tests/unit/early-sse-route-intent.test.ts +++ b/tests/unit/early-sse-route-intent.test.ts @@ -22,7 +22,7 @@ const ROUTES = [ for (const route of ROUTES) { test(`${route.name} early-heartbeat gate uses the real stream resolver`, () => { - const escapedBodyExpression = route.bodyExpression.replace(/[?.]/g, "\\$&"); + const escapedBodyExpression = route.bodyExpression.replace(/[.?\\]/g, "\\$&"); assert.match( route.source, new RegExp(