From e4e3c57147e8fe88a30203d3ea6c7ebe1cdb4172 Mon Sep 17 00:00:00 2001
From: diegosouzapw <diegosouzapw@users.noreply.github.com>
Date: Sat, 8 Aug 2026 13:46:52 -0300
Subject: [PATCH] test(combo): guard auto/best-free never leaks the combo name
 as a model (#7754)

---
 changelog.d/fixes/7754-best-free-fallback.md |  1 +
 tests/unit/repro-7754.test.ts                | 57 ++++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 changelog.d/fixes/7754-best-free-fallback.md
 create mode 100644 tests/unit/repro-7754.test.ts

diff --git a/changelog.d/fixes/7754-best-free-fallback.md b/changelog.d/fixes/7754-best-free-fallback.md
new file mode 100644
index 0000000000..0d1598538d
--- /dev/null
+++ b/changelog.d/fixes/7754-best-free-fallback.md
@@ -0,0 +1 @@
+- test(combo): guard auto/best-free never leaks the combo name as a model (#7754)
diff --git a/tests/unit/repro-7754.test.ts b/tests/unit/repro-7754.test.ts
new file mode 100644
index 0000000000..11bbe559ca
--- /dev/null
+++ b/tests/unit/repro-7754.test.ts
@@ -0,0 +1,57 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { createBuiltinAutoCombo } from "@omniroute/open-sse/services/autoCombo/builtinCatalog.ts";
+
+// #7754: `auto/best-free` combo name must never leak downstream as the model id.
+// When the free-tier candidate pool resolves non-empty, every model in the combo
+// must carry a concrete `<provider>/<model>` id — never the literal combo name.
+
+test("#7754 auto/best-free never leaks the combo name as a model", async () => {
+  const combo = await createBuiltinAutoCombo("auto/best-free", "best-free");
+  const models = combo.models || [];
+
+  // The combo id is the modelStr by design (routing resolves it back), but the
+  // models array must never contain it as a target model.
+  const leak = models.filter(
+    (m: any) =>
+      (m.id || "") === "auto/best-free" ||
+      (m.model || "") === "auto/best-free" ||
+      (m.modelStr || "") === "auto/best-free"
+  );
+  assert.equal(
+    leak.length,
+    0,
+    `combo name leaked as a target model: ${JSON.stringify(leak)}`
+  );
+});
+
+test("#7754 every auto/best-free model carries a concrete provider/model", async () => {
+  const combo = await createBuiltinAutoCombo("auto/best-free", "best-free");
+  const models = combo.models || [];
+  for (const m of models as any[]) {
+    assert.ok(
+      m.model && m.model !== "auto/best-free",
+      `model missing concrete id: ${JSON.stringify(m)}`
+    );
+    assert.ok(
+      m.providerId && m.providerId !== "auto",
+      `model missing concrete provider: ${JSON.stringify(m)}`
+    );
+  }
+});
+
+test("#7754 empty free-tier pool degrades with a clear 503, not a name leak", async () => {
+  // When NO free-tier candidate exists, createBuiltinAutoCombo must either
+  // return an empty models[] (which the #6458 route check converts to a clear
+  // 503) or throw — never synthesize a target whose model is the combo name.
+  const combo = await createBuiltinAutoCombo("auto/best-free", "best-free");
+  const models = combo.models || [];
+  if (models.length === 0) {
+    // Empty pool is fine — the route layer (#6458) converts it to a clear 503.
+    assert.equal(combo.candidatePool?.length || 0, 0);
+  } else {
+    // Non-empty pool must not leak.
+    const leak = models.filter((m: any) => (m.model || "") === "auto/best-free");
+    assert.equal(leak.length, 0);
+  }
+});