pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-03 13:52:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(quota): pool PATCH prunes OLD group/provider combos before re-sync (no orphan qtSd/ on switch)

Browse Source
This commit is contained in:
diegosouzapw
2026-06-01 02:35:26 -03:00
parent e694674851
commit e5392a7eaa
2 changed files with 71 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/app/api/quota/pools/[id]/route.ts
View File

@@ -65,19 +65,35 @@ export async function PATCH(request: Request, { params }: RouteParams): Promise<
}
}
// Combos must be reconciled when the pool's group OR connection set changes,
// since the qtSd/ combo name embeds <groupSlug>/<provider>. Each provider in a
// group is served by at most one pool, so removing this pool's CURRENT (old)
// group+provider combos BEFORE the update — then re-syncing AFTER — cleanly
// drops stale combos and mints the new ones, using the existing per-pool
// helpers. Without the pre-update removal, a group/provider switch would leave
// orphan qtSd/ combos a quota key still sees. Guarded + non-fatal.
const combosNeedResync =
body !== null &&
typeof body === "object" &&
("connectionIds" in body || "groupId" in body);
if (combosNeedResync) {
try {
const { removeQuotaCombosForPool } = await import("@/lib/quota/quotaCombos");
await removeQuotaCombosForPool(id); // pool still has its OLD group/provider here
} catch {
// Guard: combo cleanup failure must never break pool update.
}
}
const pool = updatePool(id, parsed.data);
if (!pool) {
return NextResponse.json(buildErrorBody(404, "Pool not found"), { status: 404 });
}
// Re-sync quota combos when connectionIds was explicitly changed.
// updatePool already fires a guarded sync internally, but we add an explicit
// awaited sync here so the caller's response reflects the updated combo state.
// Mirrors the dynamic-import + non-fatal pattern from groups/[id]/route.ts PATCH.
if (body !== null && typeof body === "object" && "connectionIds" in body) {
if (combosNeedResync) {
try {
const { syncQuotaCombos } = await import("@/lib/quota/quotaCombos");
await syncQuotaCombos(id);
await syncQuotaCombos(id); // pool now has its NEW group/provider
} catch {
// Guard: combo-sync failure must never break pool update callers.
}