fix(auto): address PR #2131 review issues

- Fix OAuth expiry handling for ISO strings in virtualFactory.ts
- Move AutoRoutingBanner test from src/ to tests/unit/shared/components/
- Remove mock metrics from analytics endpoint, return only real data
- Fix error handling for bare 'auto' prefix in chat.ts (check isAutoRouting)
- Update vitest.config.ts to include tests/unit/**/*.test.tsx pattern

src/app/api/analytics/auto-routing/route.ts

@@ -59,22 +59,14 @@ export async function GET(request: Request) {
         GROUP BY provider
         ORDER BY count DESC
         LIMIT 10
-      `
+        `
       )
       .all() as Array<{ provider: string; count: number }>;
 
-    // Mock metrics (would need actual scoring data from auto-combo engine)
-    const mockMetrics = {
-      avgSelectionScore: 0.85,
-      explorationRate: 0.05,
-      lkgpHitRate: 0.72,
-    };
-
     return NextResponse.json({
       totalRequests: totalRequests.count,
       variantBreakdown,
       topProviders,
-      ...mockMetrics,
     });
   } catch (error) {
     console.error("Auto-routing analytics error:", error);
@@ -82,9 +74,6 @@ export async function GET(request: Request) {
       totalRequests: 0,
       variantBreakdown: {},
       topProviders: [],
-      avgSelectionScore: 0,
-      explorationRate: 0.05,
-      lkgpHitRate: 0,
     });
   }
 }

src/shared/components/AutoRoutingBanner.test.tsx

@@ -1,96 +0,0 @@
-// @vitest-environment jsdom
-import React from "react";
-import { act } from "react";
-import { createRoot } from "react-dom/client";
-import { afterEach, beforeEach, describe, expect, it } from "vitest";
-
-const cleanupCallbacks: Array<() => void> = [];
-
-function makeContainer(): HTMLElement {
-  const container = document.createElement("div");
-  document.body.appendChild(container);
-  cleanupCallbacks.push(() => {
-    container.remove();
-  });
-  return container;
-}
-
-describe("AutoRoutingBanner", () => {
-  beforeEach(() => {
-    (
-      globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT?: boolean }
-    ).IS_REACT_ACT_ENVIRONMENT = true;
-    localStorage.clear();
-  });
-
-  afterEach(() => {
-    while (cleanupCallbacks.length > 0) {
-      cleanupCallbacks.pop()?.();
-    }
-    document.body.innerHTML = "";
-    localStorage.clear();
-  });
-
-  it("renders banner on first mount", async () => {
-    const { default: AutoRoutingBanner } = await import("./AutoRoutingBanner");
-    const container = makeContainer();
-    const root = createRoot(container);
-    await act(async () => {
-      root.render(<AutoRoutingBanner />);
-    });
-    expect(container.querySelector('[role="banner"]')).toBeTruthy();
-    expect(container.textContent).toContain("Auto-Routing Active");
-  });
-
-  it("includes link to Combos page", async () => {
-    const { default: AutoRoutingBanner } = await import("./AutoRoutingBanner");
-    const container = makeContainer();
-    const root = createRoot(container);
-    await act(async () => {
-      root.render(<AutoRoutingBanner />);
-    });
-    const link = container.querySelector('a[href="/dashboard/combos"]');
-    expect(link).toBeTruthy();
-  });
-
-  it("can be dismissed by clicking close button", async () => {
-    const { default: AutoRoutingBanner } = await import("./AutoRoutingBanner");
-    const container = makeContainer();
-    const root = createRoot(container);
-    await act(async () => {
-      root.render(<AutoRoutingBanner />);
-    });
-    expect(container.querySelector('[role="banner"]')).toBeTruthy();
-    const closeButton = container.querySelector('button[aria-label="Dismiss auto-routing banner"]');
-    expect(closeButton).toBeTruthy();
-    await act(async () => {
-      closeButton?.click();
-    });
-    expect(container.querySelector('[role="banner"]')).toBeFalsy();
-  });
-
-  it("persists dismissal to localStorage", async () => {
-    const { default: AutoRoutingBanner } = await import("./AutoRoutingBanner");
-    const container = makeContainer();
-    const root = createRoot(container);
-    await act(async () => {
-      root.render(<AutoRoutingBanner />);
-    });
-    const closeButton = container.querySelector('button[aria-label="Dismiss auto-routing banner"]');
-    await act(async () => {
-      closeButton?.click();
-    });
-    expect(localStorage.getItem("auto-routing-banner-dismissed")).toBe("true");
-  });
-
-  it("remains hidden after dismissal on remount", async () => {
-    localStorage.setItem("auto-routing-banner-dismissed", "true");
-    const { default: AutoRoutingBanner } = await import("./AutoRoutingBanner");
-    const container = makeContainer();
-    const root = createRoot(container);
-    await act(async () => {
-      root.render(<AutoRoutingBanner />);
-    });
-    expect(container.querySelector('[role="banner"]')).toBeFalsy();
-  });
-});

src/sse/handlers/chat.ts

@@ -352,7 +352,7 @@ export async function handleChat(request: any, clientRawRequest: any = null) {
   }
 
   // Auto-prefix short-circuit: if auto/ prefix was detected, replace combo with virtual one
-  if (autoVariant !== undefined && combo === null) {
+  if (isAutoRouting && combo === null) {
     try {
       const { createVirtualAutoCombo } =
         await import("@omniroute/open-sse/services/autoCombo/virtualFactory.ts");