Commit Graph

2 Commits

Author SHA1 Message Date
oyi77
819c0762b9 fix(compression): address PR review — multi-part msg safety, preservation $& fix, rule name sync, no-op rule removal
4 fixes from Gemini Code Assist PR #1689 review:

1. HIGH: Multi-part message content duplication — skip array-content
   messages instead of joining+replacing all text parts with compressed
   result, which caused content duplication (e.g., [A,B] → [comp(A+B), comp(A+B)])

2. HIGH: String.prototype.replace $& vulnerability — use arrow function
   callback instead of string arg in restorePreservedBlocks() to prevent
   special replacement patterns ($&, , etc.) from corrupting restored
   content containing code, URLs, or file paths

3. HIGH: UI/backend rule name mismatch — ALL_CAVEMAN_RULES in
   CompressionSettingsTab.tsx now uses actual backend rule names
   (polite_framing, hedging, verbose_instructions, etc.) instead of
   fabricated names (hedging_disclaimer, redundant_please, etc.)
   that would break the skip-rules feature

4. MEDIUM: Remove no-op turn_marker rule — pattern /^$/g matches only
   empty strings and replaces with empty string, achieving nothing.
   Removed from CAVEMAN_RULES; total count now 29 (was 30).

Tests: 72/72 pass, typecheck: 0 errors, lint: 0 errors
2026-04-28 04:20:46 +07:00
oyi77
b5f6bea880 feat(compression): implement caveman compression engine — Wave 1 complete
- CavemanConfig types and interfaces (types.ts)
- 30 compression rules across 4 categories (cavemanRules.ts)
- Core 5-step compression pipeline (caveman.ts)
- Code block / URL / path preservation (preservation.ts)
- Strategy selector with caveman dispatch (strategySelector.ts)
- Stats tracking module (stats.ts)
- DB settings module (compression.ts)
- Unit tests: 36 tests, 0 failures
- Typecheck: 0 errors, Lint: 0 errors

Implements: GitHub issue #1587 (Phase 2)
2026-04-27 18:31:46 +07:00