Addresses 3 critical + 4 high + 4 medium findings from the cross-agent
review of the v3.8.4 release branch.
CRITICAL
- combo: honour skipProviderBreaker in combo.ts:2452 so embedded service
supervisor outages signalled via X-Omni-Fallback-Hint=connection_cooldown
no longer trip the whole-provider circuit breaker. The G-02 contract was
added to accountFallback but never honoured by its consumer.
- combo: per-model timeout now creates an AbortController, propagates its
signal via target.modelAbortSignal, and aborts the inner request when
the timeout wins the race. Chat.ts wraps the request via AbortSignal.any
so downstream cooldown/breaker/usage mutations stop instead of running
behind the routing decision's back.
- apiKey: getOrCreateApiKey now throws ServiceApiKeyDecryptError on
decrypt failure instead of silently regenerating. Mutating embedded
service auth without operator awareness made every subsequent request
401 with no log trail.
HIGH
- base.ts proactive refresh: classify isUnrecoverableRefreshError before
spreading the result so the executor doesn't send an
unrecoverable_refresh_error sentinel object as the access token. Mark
the connection expired via onCredentialsRefreshed and elevate the catch
log from warn to error per the documented onPersist contract.
- kimi-coding: persist deviceId/deviceName/deviceModel/osVersion in
providerSpecificData at login. tokenRefresh's fallback pbkdf2(refresh_token)
rotates per refresh since Kimi rotates refresh tokens, contradicting the
"stable deviceId" comment and tripping anti-bot detection mid-session.
- inner-ai: resolveModels throws InnerAiModelsError on non-OK (with 401/403
invalidating the credential cache) instead of silently returning [].
collectContent now propagates missing_credits / reached_limit /
rate_limit_reached events via InnerAiStreamError so non-streaming
callers get a 429 instead of HTTP 200 with an empty body.
MEDIUM
- chatCore.ts retry-after-refresh: capture and log the error at error
level with sanitizeErrorMessage instead of a bare catch{}.
- gemini-cli.ts refreshCredentials: capture body on !response.ok and map
invalid_grant to unrecoverable_refresh_error for parity with
refreshGoogleToken in tokenRefresh.ts.
- usage.ts antigravity: introduce fractionReported sentinel so an
upstream schema drift (Antigravity not reporting remainingFraction) no
longer masquerades as "every model is exhausted".
- proxyFetch.ts vercel relay: sanitize the missing-relayAuth throw
message (no internal [ProxyFetch] label) and pass host through
proxyUrlForLogs for consistent redaction.
Backlog for follow-up: Inner.ai behavioural tests, tokenRefresh.ts
@ts-nocheck removal + RefreshResult discriminated union, tokenHealthCheck
tests, structural-vs-behavioural tests in token-refresh-race-comprehensive.
Tracked in #2743.
