* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff
The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
Eleven PRs landed on release/v3.8.51 while the branch carried fifteen base reds, and
nine more red tests hid among them. None is a defect in the shipped code; each test
still encoded the contract that the merged PR deliberately replaced:
- openai-to-claude finish deferral (dd35750e5f, #11933): a finish chunk that carries no
usage is now held until the end-of-stream flush that production performs
(open-sse/utils/stream.ts flush -> translateResponse(..., null, state)). The drivers in
stream-markdown-token-boundary, translator-tool-call-shim and
gemini-malformed-function-call-finish-reason-2462 fed the finish chunk and asserted
the terminal events immediately; they now mirror the flush. Assertions unchanged.
- authoritative live catalog (3d2832b836, #11919fixes#11829): a synced catalog replaces
the static registry, so model-lifecycle-integration no longer expects the static-only
gpt-5.6-sol row to survive a sync. The #8627 contract the file guards (stale chat rows
suppressed, typed media retained) is untouched.
- provider asset provenance (#11876): the unit shards check out with depth 1. The fixture
pinned a historical commit as auditedCommit (absent on a shallow clone), the
"binds auditedCommit" case relied on the repository root commit (the grafted HEAD on
a shallow clone, which matches the physical snapshot), and the real-manifest case
needs the audited commit fetched. The fixture now audits HEAD, the mismatch case
builds a dangling empty-tree commit (no ref written), and the real-manifest case
skips only on a shallow checkout that lacks the commit - the gate itself keeps
running on both fetch-depth-0 rails, which the next test asserts.
All five files pass locally (30, 11, 38, 3 and 18 tests); lint with the frozen
suppressions is clean.
