Files
OmniRoute/tests/unit/cc-discovery-aliases-gate.test.ts
Diego Rodrigues de Sa e Souza cd9a631464 feat: Claude Code discovery aliases (surface non-Claude models in the /model picker) (#8666)
* feat(db): cc discovery alias gate storage + EXPOSE_CC_DISCOVERY_ALIASES flag

Adds the gate for claude/<provider>/<model> discovery-alias mirror ids on
the /v1/models catalog: a new runtime feature flag (env forces on and wins
over the dashboard DB override), per-provider and per-model "on"/"off"/null
overrides stored in key_value under the ccDiscoveryAliases namespace, and a
pure precedence resolver (model > provider > global). Catalog wiring is a
separate follow-up task; this only lands the gate + storage.

* feat(sse): synthesize claude/ discovery aliases for the model catalog

* feat(api): advertise cc discovery aliases on /v1/models behind the 3-level gate

* feat(sse): resolve claude/ discovery aliases on the request path

* fix(sse): import getComboByName from db/combos, not the localDb barrel

* fix(sse): cover custom-node prefixes and the Codex WS bridge in cc discovery alias resolution

* feat(dashboard): cc discovery alias toggles + flag-screen env warning

Adds the operator-facing UI/API layer for the Claude Code discovery-alias
gate (claude/<provider>/<model> mirror ids on /v1/models): REST endpoint
for provider/model overrides, a provider-detail card with 3-state
(inherit/on/off) toggles, an info button on the Claude Code tool card
linking to Feature Flags, and an env-source warning on the
EXPOSE_CC_DISCOVERY_ALIASES flag card when it's forced on via env.

* feat(api): cc discovery usage metrics

* fix(api): record cc alias metric in the production wrapper + atomic counter upsert

* docs: document cc discovery aliases (Claude Code guide + feature flag catalog)

* fix(sse): don't mirror built-in auto/* combos as discovery aliases (advertised-but-unroutable)

* i18n(vi): translate the discovery-alias strings instead of shipping placeholders

vi is the one locale with a strict "no internal missing markers" test, so the 17
__MISSING__ entries this branch added (the provider ccAlias panel, the info
button, the feature-flag description and the env warning) would have turned that
test red the moment the base itself was repaired. Translated, keeping every ICU
placeholder ({modelId}, {error}) and the literal claude/<provider>/<model> id
shape intact.

* chore(quality): raise the frozen caps this feature legitimately grows

catalog.ts 1615 -> 1639: the alias synthesis is wired into the catalog builder,
which is where the per-key-filtered list is assembled — the only place the mirror
entries can be appended after model hiding has been applied.

localDb.ts 808 -> 810: two re-export lines for the new ccDiscoveryAliases db
module, which is exactly what the "Adding a New DB Module" recipe prescribes.

* refactor(dashboard,api): keep the complexity ratchets flat

The feature added four cyclomatic violations and one cognitive one, which the
ratchets reject — the baseline only moves when a metric improves. Split the new
code instead:

- appendCcDiscoveryAliases: the four skip-guards become isMirrorableId().
- resolveCcDiscoveryAliasStripWith: alias parsing and gate resolution become
  parseCcAliasTarget() and resolveGateFor(), replacing a chain of ternaries that
  each re-tested isComboAlias.
- FeatureFlagCard: the env-precedence warning becomes its own component instead
  of a conditional branch inside an already-large render.
- ProviderCcAliasSection: the loader moves to useCcAliasData(), and the override
  list and add-row become ModelOverrideList / AddOverrideRow, bringing both
  oversized functions back under the 80-line rule.

Behavior unchanged — the 74 discovery-alias tests pass untouched. Both ratchets
now sit exactly at baseline (2188 / 971).
2026-07-26 17:19:19 -03:00

210 lines
8.7 KiB
TypeScript

import { describe, it, beforeEach, after } from "node:test";
import assert from "node:assert/strict";
import os from "node:os";
import path from "node:path";
import fs from "node:fs";
// Set DATA_DIR to a temp dir before any imports that touch the DB.
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-cc-alias-"));
process.env.DATA_DIR = tmpDir;
const core = await import("../../src/lib/db/core.ts");
const { FEATURE_FLAG_DEFINITIONS } =
await import("../../src/shared/constants/featureFlagDefinitions.ts");
const {
resolveCcAliasEnabled,
getCcAliasProviderSetting,
setCcAliasProviderSetting,
getCcAliasModelSetting,
setCcAliasModelSetting,
getCcAliasSettingsBulk,
isCcAliasGlobalEnabled,
getCcAliasGlobalState,
} = await import("../../src/lib/db/ccDiscoveryAliases.ts");
function resetDb() {
core.resetDbInstance();
fs.rmSync(tmpDir, { recursive: true, force: true });
fs.mkdirSync(tmpDir, { recursive: true });
}
// ──────────────────────────────────────────────────────
// Group 1 — flag definition registry
// ──────────────────────────────────────────────────────
describe("EXPOSE_CC_DISCOVERY_ALIASES flag definition", () => {
it("is registered as a runtime boolean flag, default off", () => {
const def = FEATURE_FLAG_DEFINITIONS.find((d) => d.key === "EXPOSE_CC_DISCOVERY_ALIASES");
assert.ok(def, "EXPOSE_CC_DISCOVERY_ALIASES should exist");
assert.strictEqual(def.category, "runtime");
assert.strictEqual(def.type, "boolean");
assert.strictEqual(def.defaultValue, "false");
assert.strictEqual(def.requiresRestart, false);
assert.strictEqual(def.descriptionI18nKey, "featureFlagExposeCcDiscoveryAliasesDescription");
});
});
// ──────────────────────────────────────────────────────
// Group 2 — resolveCcAliasEnabled precedence (pure function)
// ──────────────────────────────────────────────────────
describe("resolveCcAliasEnabled precedence", () => {
it("model 'on' wins over provider 'off' and global false", () => {
assert.strictEqual(
resolveCcAliasEnabled({ model: "on", provider: "off", global: false }),
true
);
});
it("model 'off' wins over provider 'on' and global true", () => {
assert.strictEqual(
resolveCcAliasEnabled({ model: "off", provider: "on", global: true }),
false
);
});
it("model null + provider 'on' -> true", () => {
assert.strictEqual(resolveCcAliasEnabled({ model: null, provider: "on", global: false }), true);
});
it("model null + provider 'off' -> false even if global true", () => {
assert.strictEqual(
resolveCcAliasEnabled({ model: null, provider: "off", global: true }),
false
);
});
it("everything null/undefined + global true -> true", () => {
assert.strictEqual(resolveCcAliasEnabled({ global: true }), true);
});
it("everything null/undefined + global false -> false", () => {
assert.strictEqual(resolveCcAliasEnabled({ global: false }), false);
});
it("explicit nulls + global true -> true", () => {
assert.strictEqual(resolveCcAliasEnabled({ model: null, provider: null, global: true }), true);
});
});
// ──────────────────────────────────────────────────────
// Group 3 — storage round-trip
// ──────────────────────────────────────────────────────
describe("ccDiscoveryAliases storage", () => {
beforeEach(() => {
resetDb();
});
after(() => {
core.resetDbInstance();
fs.rmSync(tmpDir, { recursive: true, force: true });
});
it("getCcAliasProviderSetting returns null when unset", () => {
assert.strictEqual(getCcAliasProviderSetting("openai"), null);
});
it("setCcAliasProviderSetting('on') round-trips", () => {
setCcAliasProviderSetting("openai", "on");
assert.strictEqual(getCcAliasProviderSetting("openai"), "on");
});
it("setCcAliasProviderSetting('off') round-trips", () => {
setCcAliasProviderSetting("openai", "off");
assert.strictEqual(getCcAliasProviderSetting("openai"), "off");
});
it("setCcAliasProviderSetting(null) removes the key (back to inherit)", () => {
setCcAliasProviderSetting("openai", "on");
setCcAliasProviderSetting("openai", null);
assert.strictEqual(getCcAliasProviderSetting("openai"), null);
});
it("getCcAliasModelSetting returns null when unset", () => {
assert.strictEqual(getCcAliasModelSetting("openai", "gpt-5"), null);
});
it("setCcAliasModelSetting round-trips independently per model", () => {
setCcAliasModelSetting("openai", "gpt-5", "on");
assert.strictEqual(getCcAliasModelSetting("openai", "gpt-5"), "on");
assert.strictEqual(getCcAliasModelSetting("openai", "gpt-5-mini"), null);
});
it("setCcAliasModelSetting(null) removes the key", () => {
setCcAliasModelSetting("openai", "gpt-5", "off");
setCcAliasModelSetting("openai", "gpt-5", null);
assert.strictEqual(getCcAliasModelSetting("openai", "gpt-5"), null);
});
it("provider and model settings do not collide across provider ids", () => {
setCcAliasProviderSetting("openai", "on");
setCcAliasProviderSetting("anthropic", "off");
assert.strictEqual(getCcAliasProviderSetting("openai"), "on");
assert.strictEqual(getCcAliasProviderSetting("anthropic"), "off");
});
it("getCcAliasSettingsBulk returns both maps in one call", () => {
setCcAliasProviderSetting("openai", "on");
setCcAliasProviderSetting("anthropic", "off");
setCcAliasModelSetting("openai", "gpt-5", "off");
const { providers, models } = getCcAliasSettingsBulk();
assert.strictEqual(providers.get("openai"), "on");
assert.strictEqual(providers.get("anthropic"), "off");
assert.strictEqual(models.get("openai/gpt-5"), "off");
assert.strictEqual(models.has("openai/gpt-5-mini"), false);
});
it("getCcAliasSettingsBulk returns empty maps when nothing set", () => {
const { providers, models } = getCcAliasSettingsBulk();
assert.strictEqual(providers.size, 0);
assert.strictEqual(models.size, 0);
});
});
// ──────────────────────────────────────────────────────
// Group 4 — global state resolver (env vs DB vs default)
// ──────────────────────────────────────────────────────
describe("global CC alias state (env / DB / default)", () => {
beforeEach(() => {
resetDb();
delete process.env.EXPOSE_CC_DISCOVERY_ALIASES;
});
after(() => {
core.resetDbInstance();
fs.rmSync(tmpDir, { recursive: true, force: true });
delete process.env.EXPOSE_CC_DISCOVERY_ALIASES;
});
it("defaults to disabled with source 'default'", () => {
assert.strictEqual(isCcAliasGlobalEnabled(), false);
assert.deepStrictEqual(getCcAliasGlobalState(), { enabled: false, source: "default" });
});
it("DB override enables it with source 'db'", async () => {
const { setFeatureFlagOverride } = await import("../../src/lib/db/featureFlags.ts");
setFeatureFlagOverride("EXPOSE_CC_DISCOVERY_ALIASES", "true");
assert.strictEqual(isCcAliasGlobalEnabled(), true);
assert.deepStrictEqual(getCcAliasGlobalState(), { enabled: true, source: "db" });
});
it("env=1 forces global on with source 'env', winning over a DB 'false' override", async () => {
const { setFeatureFlagOverride } = await import("../../src/lib/db/featureFlags.ts");
setFeatureFlagOverride("EXPOSE_CC_DISCOVERY_ALIASES", "false");
process.env.EXPOSE_CC_DISCOVERY_ALIASES = "1";
assert.strictEqual(isCcAliasGlobalEnabled(), true);
assert.deepStrictEqual(getCcAliasGlobalState(), { enabled: true, source: "env" });
});
it("env='true' also forces global on", () => {
process.env.EXPOSE_CC_DISCOVERY_ALIASES = "true";
assert.strictEqual(isCcAliasGlobalEnabled(), true);
assert.strictEqual(getCcAliasGlobalState().source, "env");
});
it("env='0' does not force on — falls through to DB/default", () => {
process.env.EXPOSE_CC_DISCOVERY_ALIASES = "0";
assert.strictEqual(isCcAliasGlobalEnabled(), false);
assert.strictEqual(getCcAliasGlobalState().source, "default");
});
});