Files
OmniRoute/tests/unit/provider-scoped-models-route.test.ts
Erick Kinnee 62d46ba37c fix(api): resolve local provider models via dashboard catalog fallback (#7927)
The /api/v1/providers/{id}/models endpoint returns invalid_provider for
local self-hosted providers (Ollama, LM Studio, vLLM, etc.) because it
only resolves providers via getRegistryEntry() from the open-sse
registry, which does not include LOCAL_PROVIDERS.

After getRegistryEntry() misses, fall back to the dashboard-facing
provider catalog (getProviderById / getProviderByAlias from
@/shared/constants/providers), which covers LOCAL_PROVIDERS and all
other dashboard provider categories. Registry hits retain existing
precedence.

Closes #7910

Co-authored-by: Erick Kinnee <erick@ekinnee.dev>
2026-07-21 11:49:46 -03:00

239 lines
7.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-provider-models-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const serviceModelsDb = await import("../../src/lib/db/serviceModels.ts");
const providerModelsRoute =
await import("../../src/app/api/v1/providers/[provider]/models/route.ts");
interface SeedConnectionOverrides {
authType?: string;
name?: string;
apiKey?: string | null;
accessToken?: string | null;
isActive?: boolean;
testStatus?: string;
providerSpecificData?: Record<string, unknown>;
}
type ProviderModelsResponse = {
data: Array<Record<string, unknown>>;
object?: string;
error?: {
message?: string;
code?: string;
type?: string;
};
};
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
async function seedConnection(provider: string, overrides: SeedConnectionOverrides = {}) {
return providersDb.createProviderConnection({
provider,
authType: overrides.authType || "apikey",
name: overrides.name || `${provider}-${Math.random().toString(16).slice(2, 8)}`,
apiKey: overrides.apiKey || "sk-test",
accessToken: overrides.accessToken,
isActive: overrides.isActive ?? true,
testStatus: overrides.testStatus || "active",
providerSpecificData: overrides.providerSpecificData || {},
});
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
});
test("provider models route returns only selected provider models with unprefixed ids", async () => {
await seedConnection("openai", { name: "openai-main" });
await seedConnection("claude", {
authType: "oauth",
name: "claude-main",
apiKey: null,
accessToken: "claude-access",
});
await combosDb.createCombo({
name: "team-router",
strategy: "priority",
models: ["openai/gpt-4o"],
});
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/openai/models"),
{
params: Promise.resolve({ provider: "openai" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.length > 0);
assert.equal(
ids.some((id: string) => id.includes("/")),
false
);
assert.equal(
body.data.some((model) => String(model.owned_by) !== "openai"),
false
);
assert.equal(ids.includes("team-router"), false);
});
test("provider models route accepts provider alias in path", async () => {
await seedConnection("claude", {
authType: "oauth",
name: "claude-main",
apiKey: null,
accessToken: "claude-access",
});
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/cc/models"),
{
params: Promise.resolve({ provider: "cc" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.includes("claude-sonnet-4-6"));
assert.equal(
ids.some((id: string) => id.startsWith("cc/") || id.startsWith("claude/")),
false
);
});
test("provider models route supports service provider 9router", async () => {
serviceModelsDb.saveServiceModels("9router", [
{ id: "gpt-4o-mini", name: "Local9R Test", available: true },
]);
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/9router/models"),
{
params: Promise.resolve({ provider: "9router" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.includes("gpt-4o-mini"));
assert.equal(
ids.some((id: string) => id.includes("/")),
false
);
});
test("provider models route supports service provider cliproxyapi", async () => {
serviceModelsDb.saveServiceModels("cliproxyapi", [
{ id: "llama-3", name: "Clip Test", available: true },
]);
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/cliproxyapi/models"),
{
params: Promise.resolve({ provider: "cliproxyapi" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
const ids = body.data.map((model) => String(model.id));
assert.equal(response.status, 200);
assert.ok(ids.includes("llama-3"));
assert.equal(
ids.some((id: string) => id.includes("/")),
false
);
});
test("provider models route returns 400 for unknown provider", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/nope/models"),
{
params: Promise.resolve({ provider: "nope" }),
}
);
const body = (await response.json()) as ProviderModelsResponse;
assert.equal(response.status, 400);
assert.equal(body.error.code, "invalid_provider");
});
test("provider models route resolves local provider by canonical ID (ollama-local)", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/ollama-local/models"),
{
params: Promise.resolve({ provider: "ollama-local" }),
}
);
// Must NOT return 400 invalid_provider — should resolve via catalog fallback
assert.notEqual(response.status, 400, "ollama-local must not return 400");
const body = (await response.json()) as ProviderModelsResponse;
assert.notEqual(
body.error?.code,
"invalid_provider",
"ollama-local must not be rejected as unknown provider"
);
});
test("provider models route resolves local provider by alias (ollama)", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/ollama/models"),
{
params: Promise.resolve({ provider: "ollama" }),
}
);
assert.notEqual(response.status, 400, "ollama (alias) must not return 400");
const body = (await response.json()) as ProviderModelsResponse;
assert.notEqual(
body.error?.code,
"invalid_provider",
"ollama (alias) must not be rejected as unknown provider"
);
});
test("provider models route resolves another local provider by ID (lm-studio)", async () => {
const response = await providerModelsRoute.GET(
new Request("http://localhost/api/v1/providers/lm-studio/models"),
{
params: Promise.resolve({ provider: "lm-studio" }),
}
);
assert.notEqual(response.status, 400, "lm-studio must not return 400");
const body = (await response.json()) as ProviderModelsResponse;
assert.notEqual(
body.error?.code,
"invalid_provider",
"lm-studio must not be rejected as unknown provider"
);
});