Files
OmniRoute/tests/integration/codex-account-pool-restart-http.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

50 lines
1.7 KiB
TypeScript

import assert from "node:assert/strict";
import test from "node:test";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { spawnSync } from "node:child_process";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-codex-pool-http-"));
const PHASE_SCRIPT = path.join(
process.cwd(),
"tests/integration/fixtures/codex-account-pool-restart-phase.ts"
);
type PhaseResult = {
phase: "before" | "after";
connectionId: string;
upstreamModels: string[];
};
function runPhase(phase: PhaseResult["phase"], connectionId?: string): PhaseResult {
const result = spawnSync(process.execPath, ["--import", "tsx/esm", PHASE_SCRIPT], {
cwd: process.cwd(),
encoding: "utf8",
env: {
...process.env,
DATA_DIR: TEST_DATA_DIR,
CODEX_RESTART_PHASE: phase,
...(connectionId ? { CODEX_EXPECTED_CONNECTION_ID: connectionId } : {}),
},
maxBuffer: 50 * 1024 * 1024,
});
assert.equal(result.status, 0, `${result.stdout}\n${result.stderr}`);
const line = result.stdout.split("\n").find((entry) => entry.startsWith("CODEX_RESTART_RESULT="));
assert.ok(line, result.stdout);
return JSON.parse(line.slice("CODEX_RESTART_RESULT=".length)) as PhaseResult;
}
test("Codex Spark cooldown survives a fresh process without creating child connections", () => {
try {
const before = runPhase("before");
assert.ok(before.upstreamModels.length > 0);
const after = runPhase("after", before.connectionId);
assert.equal(after.connectionId, before.connectionId);
assert.deepEqual(after.upstreamModels, ["gpt-5.5"]);
} finally {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});