mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-18 12:52:25 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
93 lines
3.5 KiB
TypeScript
93 lines
3.5 KiB
TypeScript
// combo's fallback-compression trigger must estimate tokens from the request OBJECT (#7847).
|
|
//
|
|
// It used to call `estimateTokens(JSON.stringify(attemptBody))`, which takes the string branch of
|
|
// estimateTokens — `ceil(length / CHARS_PER_TOKEN)` over the raw JSON. An inline base64 image is
|
|
// then charged as if every character of the data URL were prose, the same over-count #8368/#8401
|
|
// fixed on the request path. On a 200 KB inline image that read ~50k tokens instead of ~1.2k,
|
|
// tripping fallback compression on a request nowhere near the context window.
|
|
//
|
|
// Passing the object instead routes through extractImageTokens, which charges images structurally.
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-token-estimate-"));
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { estimateTokens } = await import("../../open-sse/services/contextManager.ts");
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (ORIGINAL_DATA_DIR === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
});
|
|
|
|
const imageBody = (base64Chars: number) => ({
|
|
model: "claude-opus-5",
|
|
messages: [
|
|
{
|
|
role: "user",
|
|
content: [
|
|
{ type: "text", text: "describe this screenshot" },
|
|
{
|
|
type: "image_url",
|
|
image_url: { url: `data:image/png;base64,${"A".repeat(base64Chars)}` },
|
|
},
|
|
],
|
|
},
|
|
],
|
|
});
|
|
|
|
const textBody = () => ({
|
|
model: "claude-opus-5",
|
|
max_tokens: 100,
|
|
messages: [{ role: "user", content: "hello world ".repeat(500) }],
|
|
tools: [{ type: "function", function: { name: "t", description: "does a thing" } }],
|
|
});
|
|
|
|
test("an inline image is charged structurally, not as raw data-URL text", () => {
|
|
const small = estimateTokens(imageBody(10_000));
|
|
const large = estimateTokens(imageBody(200_000));
|
|
|
|
// A 20x larger base64 payload must not cost 20x the tokens — the image is charged as an image.
|
|
assert.ok(
|
|
large < small * 2,
|
|
`estimate scaled with the base64 length (${small} -> ${large}); the data URL is being counted as text`
|
|
);
|
|
assert.ok(large < 10_000, `expected a bounded image charge, got ${large} tokens`);
|
|
});
|
|
|
|
test("the string path is what over-counts — this is why the call site must pass the object", () => {
|
|
const body = imageBody(200_000);
|
|
const viaObject = estimateTokens(body);
|
|
const viaString = estimateTokens(JSON.stringify(body));
|
|
|
|
assert.ok(
|
|
viaString > viaObject * 10,
|
|
`expected the string path to over-count heavily (object=${viaObject}, string=${viaString}) — ` +
|
|
"if this ever stops being true, the regression guard below is measuring nothing"
|
|
);
|
|
});
|
|
|
|
test("text-only bodies are unaffected: object and string paths agree", () => {
|
|
const body = textBody();
|
|
assert.equal(
|
|
estimateTokens(body),
|
|
estimateTokens(JSON.stringify(body)),
|
|
"the switch to the object path must be a no-op for the common text-only request"
|
|
);
|
|
});
|
|
|
|
test("estimateTokens still handles the plain shapes", () => {
|
|
assert.equal(estimateTokens(null), 0);
|
|
assert.equal(estimateTokens(undefined), 0);
|
|
assert.equal(estimateTokens(""), 0);
|
|
assert.equal(estimateTokens("abcd"), 1);
|
|
assert.ok(estimateTokens({ a: "x".repeat(400) }) > 0);
|
|
});
|