mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 12:22:34 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
100 lines
3.7 KiB
TypeScript
100 lines
3.7 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
|
|
import { setLocalCorpusRoot } from "../../src/lib/db/localCorpus";
|
|
import {
|
|
getConfiguredLocalCorpusStatus,
|
|
readConfiguredLocalCorpus,
|
|
resetLocalCorpusIndex,
|
|
searchConfiguredLocalCorpus,
|
|
} from "../../src/lib/localCorpus/configured";
|
|
|
|
test.beforeEach(() => {
|
|
resetLocalCorpusIndex();
|
|
});
|
|
|
|
test("dynamic root path traversal outside bounding box throws error", async () => {
|
|
const tmpBase = fs.mkdtempSync(path.join(os.tmpdir(), "omni-corpus-base-"));
|
|
const subFolder = path.join(tmpBase, "allowed-sub");
|
|
fs.mkdirSync(subFolder, { recursive: true });
|
|
|
|
setLocalCorpusRoot(subFolder);
|
|
|
|
const outsideFolder = fs.mkdtempSync(path.join(os.tmpdir(), "omni-corpus-outside-"));
|
|
|
|
assert.throws(() => getConfiguredLocalCorpusStatus(outsideFolder), /Path traversal forbidden/);
|
|
|
|
fs.rmSync(tmpBase, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.rmSync(outsideFolder, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("path traversal check rejects sibling directory with matching string prefix", async () => {
|
|
const tmpBase = fs.mkdtempSync(path.join(os.tmpdir(), "omni-corpus-prefix"));
|
|
const siblingFolder = tmpBase + "-sibling";
|
|
fs.mkdirSync(siblingFolder, { recursive: true });
|
|
|
|
setLocalCorpusRoot(tmpBase);
|
|
|
|
assert.throws(() => getConfiguredLocalCorpusStatus(siblingFolder), /Path traversal forbidden/);
|
|
|
|
fs.rmSync(tmpBase, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.rmSync(siblingFolder, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("search and read configured local corpus support dynamic root within bounds", async () => {
|
|
const tmpBase = fs.mkdtempSync(path.join(os.tmpdir(), "omni-corpus-valid-"));
|
|
const sampleFile = path.join(tmpBase, "test.txt");
|
|
fs.writeFileSync(sampleFile, "Line 1: searchable text\nLine 2: content");
|
|
|
|
setLocalCorpusRoot(tmpBase);
|
|
|
|
const status = getConfiguredLocalCorpusStatus(tmpBase);
|
|
assert.equal(typeof status.indexedBytes, "number");
|
|
|
|
const searchResults = await searchConfiguredLocalCorpus("searchable", {
|
|
absoluteRootPath: tmpBase,
|
|
});
|
|
assert.ok(Array.isArray(searchResults.results));
|
|
|
|
const readResult = await readConfiguredLocalCorpus("test.txt", {
|
|
absoluteRootPath: tmpBase,
|
|
});
|
|
assert.ok(readResult.content.includes("searchable"));
|
|
|
|
fs.rmSync(tmpBase, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("LRU cache respects access order and OMNIROUTE_CORPUS_CACHE_SIZE", async () => {
|
|
const tmpRoot = fs.mkdtempSync(path.join(os.tmpdir(), "omni-corpus-lru-root-"));
|
|
setLocalCorpusRoot(tmpRoot);
|
|
|
|
process.env.OMNIROUTE_CORPUS_CACHE_SIZE = "2";
|
|
|
|
const dir1 = path.join(tmpRoot, "dir1");
|
|
const dir2 = path.join(tmpRoot, "dir2");
|
|
const dir3 = path.join(tmpRoot, "dir3");
|
|
|
|
fs.mkdirSync(dir1, { recursive: true });
|
|
fs.mkdirSync(dir2, { recursive: true });
|
|
fs.mkdirSync(dir3, { recursive: true });
|
|
|
|
const idx1 = getConfiguredLocalCorpusStatus(dir1);
|
|
getConfiguredLocalCorpusStatus(dir2);
|
|
|
|
// Access dir1 again so its access order is updated (making dir2 the least recently used)
|
|
getConfiguredLocalCorpusStatus(dir1);
|
|
|
|
// Add dir3, which causes cache capacity (2) to be exceeded -> evicts dir2
|
|
getConfiguredLocalCorpusStatus(dir3);
|
|
|
|
// Accessing dir1 again should return the existing cached index instance
|
|
const idx1Again = getConfiguredLocalCorpusStatus(dir1);
|
|
assert.equal(idx1.indexedBytes, idx1Again.indexedBytes);
|
|
|
|
delete process.env.OMNIROUTE_CORPUS_CACHE_SIZE;
|
|
fs.rmSync(tmpRoot, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|