mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-26 09:52:11 +03:00
246b87f739
* fix(mitm): gate Agent Bridge DNS and Trust Cert on sudo password (#7938) Extend the #7865 sudo gate to setup wizard DNS, Start DNS, and Trust Cert. Start server still runs without a password but skips privileged cert/DNS steps instead of spawning sudo -S with an empty string. Add a shared sudo password modal on the Agent Bridge page for DNS and trust-cert actions. Fixes #7938 * fix(mitm): use .tsx extension for MitmSudoPasswordModal hook JSX in a .ts file broke dashboard typecheck and ESLint on CI. * fix(mitm): skip DNS teardown on stop when sudo password missing (#7938) stopMitm() no longer invokes removeDNSEntry with an empty password when the server was started in skip mode. The MITM process is still killed. * refactor(mitm): extract privileged step helpers to satisfy file-size cap manager.ts exceeded the 800-line cap after #7938 gates. Move DNS teardown and the shared sudo skip runner into dedicated modules; behavior unchanged.
47 lines
1.7 KiB
TypeScript
47 lines
1.7 KiB
TypeScript
/**
|
|
* #7938 — Agent Bridge DNS toggle must not spawn `sudo -S` with an empty password.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { isSudoPasswordRequired } from "../../src/mitm/dns/dnsConfig.ts";
|
|
|
|
const dnsRoute = await import(
|
|
"../../src/app/api/tools/agent-bridge/agents/[id]/dns/route.ts"
|
|
);
|
|
|
|
function makeDnsRequest(body: Record<string, unknown> = { enabled: true }) {
|
|
return new Request("http://127.0.0.1/api/tools/agent-bridge/agents/cursor/dns", {
|
|
method: "POST",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
test("POST .../[id]/dns returns 400 Missing sudoPassword when sudo is required and none supplied", async () => {
|
|
if (process.platform === "win32") return;
|
|
if (!isSudoPasswordRequired()) return;
|
|
const isRootUser = !!(process.getuid && process.getuid() === 0);
|
|
if (isRootUser) return;
|
|
|
|
const res = await dnsRoute.POST(makeDnsRequest({ enabled: true }), {
|
|
params: { id: "cursor" },
|
|
});
|
|
assert.equal(res.status, 400);
|
|
const body = (await res.json()) as { error?: { message?: string } };
|
|
assert.match(body.error?.message ?? "", /Missing sudoPassword/);
|
|
});
|
|
|
|
test("POST .../[id]/dns returns 400 for whitespace-only sudoPassword", async () => {
|
|
if (process.platform === "win32") return;
|
|
if (!isSudoPasswordRequired()) return;
|
|
const isRootUser = !!(process.getuid && process.getuid() === 0);
|
|
if (isRootUser) return;
|
|
|
|
const res = await dnsRoute.POST(makeDnsRequest({ enabled: true, sudoPassword: " " }), {
|
|
params: { id: "cursor" },
|
|
});
|
|
assert.equal(res.status, 400);
|
|
const body = (await res.json()) as { error?: { message?: string } };
|
|
assert.match(body.error?.message ?? "", /Missing sudoPassword/);
|
|
});
|