Files
OmniRoute/tests/unit/db/quota-pools.test.ts
Paijo 4b06761ad5 feat(api): add pagination params to 8 DB modules + recharts code-split (#7046)
* perf: extract recharts into dynamic import wrappers

Bundle recharts behind next/dynamic boundaries to prevent its
large module graph from being included in the initial JS payload.

- CostOverviewTab.tsx → dynamic(() => import('./components/CostCharts'))
- ProviderUtilizationTab.tsx → dynamic(() => import('./components/ProviderCharts'))
- BurnRateChart.tsx → dynamic(() => import('./components/BurnRateChartInner'))
- Created 3 wrapper files with 'use client' and all recharts imports

Reduces initial bundle by ~35 kB (recharts + dependencies).

* perf: add pagination (limit/offset) to apiKeys, combos, providers, provider-nodes

Add optional limit/offset parameters to DB list functions and their
API route handlers. All list functions now return { items, total } when
called with parameters; backward compatible when called without args.

Affected modules:
- lib/db/apiKeys.ts      - listApiKeys, getApiKeysByGroup
- lib/db/combos.ts       - listCombos
- lib/db/providers.ts    - listProviders, getProvidersByGroup
- lib/db/providers/nodes.ts - listProviderNodes, getProviderNodesByGroup
- Corresponding API routes pass through query params

Reduces memory pressure on large datasets by returning one page at a time.

* perf: add pagination (limit/offset) to webhooks, proxies, modelComboMappings, playgroundPresets

Add optional limit/offset parameters to DB list functions and their
API route handlers for the remaining data modules.

Affected modules:
- lib/db/webhooks.ts         - getWebhooks returns { webhooks, total }
- lib/db/proxies.ts          - listProxies
- lib/db/modelComboMappings.ts - listMappings
- lib/db/playgroundPresets.ts - listPresets
- Corresponding API routes pass through query params
- Re-exports updated: lib/localDb.ts, models/index.ts

Backward compatible: calling without args returns all rows.

* perf: batch pool building and add pagination to quotaPools

Replace per-pool N+1 queries with batch-loading pattern.

- Added batchBuildPools(rows) — collects all pool IDs, does 2 batch
  queries (allocations + connections) instead of 2N individual queries
- getPoolsByGroup and listPools now use batchBuildPools
- Added optional limit/offset pagination params
- Fixed SQLite OFFSET-syntax bug: only emit OFFSET when LIMIT also present
- Added quota-pools.test.ts with 10 tests covering pagination edge cases,
  batch loading, and the offset-without-limit guard

Reduces pool-page query count from 2N+1 to 3 (constant).

* perf: replace manual offset/limit parsing with Zod paginationSchema in combos GET handler

* fix: replace manual Number()/parseInt pagination with paginationSchema

Endpoints: model-combo-mappings, playground/presets, provider-nodes.
Uses existing Zod schema with z.coerce.number() for proper validation.

* chore: bump proxies.ts frozen baseline 1177->1208 for perf/api-pagination

PR #7046 backward-compatible pagination refactor grew proxies.ts
by +31 lines (1177->1208). Entries return plain array when no
pagination params provided, {items,total} when pagination requested.

* fix(db): finish listProxies()/getWebhooks() pagination shape migration

The pagination refactor changed listProxies(), listPools(),
getModelComboMappings(), listPlaygroundPresets() and getWebhooks() to
return a paginated envelope ({ items, total } / { webhooks, total })
instead of a bare array, but left three real production callers and
several tests on the old array-shaped API:

- src/lib/proxyEgress.ts (validateProxyPool default listProxies impl)
  iterated the envelope directly -> "is not iterable" at runtime, hit
  by /api/settings/proxies/egress (no injected deps).
- src/lib/proxyHealth/scheduler.ts (sweep()) read proxies.length on the
  envelope (undefined), so the health-check sweep silently processed
  zero proxies every run.
- open-sse/utils/proxyFallback.ts (getProxyCandidates()) iterated the
  envelope inside a try/catch that swallowed the resulting TypeError,
  so every user-configured proxy silently vanished from the fallback
  candidate list.

Also fixes two TS2558/TS2339 typecheck errors in proxies.ts/webhooks.ts
(db.prepare<T>() generic not supported by this DB wrapper — cast the
query result instead, matching the existing pattern in both files) and
trims one blank re-export separator line in localDb.ts to stay within
the frozen file-size ratchet after 4 new *Count() exports.

Updates the pre-existing unit tests that called the changed functions
directly (db-quota-pools, quota-groups-migration, quota-pool-connections,
quota-pool-delete-prune, db-webhooks, model-combo-mappings-db,
db-playground-presets, db-proxies-crud, proxy-batch-routes-5918,
proxy-registry, error-message-sanitization) to destructure the new
envelope shape instead of treating the result as an array.

Implements the small, well-scoped performance-mark/measure
instrumentation ("omni-pipeline-start"/"omni-pipeline-end"/"omni-pipeline")
that tests/unit/chatcore-streaming-pipeline.test.ts already asserted for
assembleStreamingPipeline() but that had no corresponding source change.

Adds three new regression tests (TDD: each reproduces its bug against
the pre-fix code before the corresponding fix, then passes) covering
the three real production callers above:
tests/unit/proxy-egress-validate-pool-default.test.ts,
tests/unit/proxy-health-scheduler-listproxies-shape.test.ts,
tests/unit/proxy-fallback-candidates-listproxies-shape.test.ts.

Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>

* fix: resolve rebase conflict in proxies.ts — keep hasBlockingProxyAssignment but drop duplicate extraction leftovers

- Removed duplicate resolveScopePoolInternal, resolveProxyForConnectionFromRegistry,
  resolveProxyForScopeFromRegistry already extracted to proxies/rotation.ts
- Removed duplicate hasBlockingProxyAssignment function body already re-exported from proxies/guards.ts
- Removed duplicate PROXY_ALIVE_PREDICATE import
- All typechecks and 45 affected tests pass

* fix(test): account for _reorderConnections in pagination test expectedOrder

createProviderConnection calls _reorderConnections after every insert
which reassigns priorities sequentially. The test was assuming creation
order determines priority order, leading to incorrect expected results.

Fix: query the DB after all inserts and use the actual priority order.

Also removes debug console.log from getRawProviderConnections.

* chore: remove debug tmp-*.mjs files left in PR branch

* test(proxy): migrate the dedup test to the paginated listProxies() shape

#7046 changed listProxies() to return { items, total }, and updated every
production caller plus three of the four test files — tests/unit/proxy-bulk-import-dedup-7594.test.ts
was missed, so its four `listed.length` assertions read `undefined` and the
file went red on the merge train (it passes on the pure release tip).

Test-only: destructure `{ items: listed }` at the four callsites. Verified
proxyEgress.ts needs no change — its local deps shim already unwraps .items,
and tests/unit/proxy-egress-validate-pool-default.test.ts guards exactly that.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

---------

Co-authored-by: oyi77 <oyi77@users.noreply.github.com>
Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
2026-07-20 10:07:49 -03:00

150 lines
6.0 KiB
TypeScript

/**
* Unit tests for src/lib/db/quotaPools.ts — pagination and batchBuildPools.
*
* Uses isolated DATA_DIR per run; each test gets a fresh DB.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-quota-pools-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.NODE_ENV = "test";
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
const core = await import("../../../src/lib/db/core.ts");
const qp = await import("../../../src/lib/db/quotaPools.ts");
const { getDbInstance } = await import("../../../src/lib/db/core.ts");
function resetDb() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
// Insert a pool + optional connection row directly (bypass create for speed).
function insertPool(
id: string,
name: string,
connectionId: string,
createdAt = new Date().toISOString()
) {
const db = getDbInstance();
db.prepare(
"INSERT INTO quota_pools (id, name, group_id, connection_id, created_at) VALUES (?, ?, ?, ?, ?)"
).run(id, name, "default", connectionId, createdAt);
}
test.beforeEach(() => {
resetDb();
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
});
// ─────────────────────────────────────────────────────────────────────────────
// listPools — pagination
// ─────────────────────────────────────────────────────────────────────────────
test("listPools without limit/offset returns all pools", () => {
insertPool("p1", "Alpha", "c1");
insertPool("p2", "Beta", "c2");
const result = qp.listPools();
assert.equal(result.total, 2);
assert.equal(result.items.length, 2);
});
test("listPools with limit returns ≤ limit items, total unchanged", () => {
insertPool("p1", "Alpha", "c1");
insertPool("p2", "Beta", "c2");
insertPool("p3", "Gamma", "c3");
const result = qp.listPools({ limit: 2 });
assert.equal(result.total, 3);
assert.equal(result.items.length, 2);
});
test("listPools with limit+offset returns correct slice", () => {
insertPool("p1", "Alpha", "c1", "2024-01-01T00:00:00Z");
insertPool("p2", "Beta", "c2", "2024-01-02T00:00:00Z");
insertPool("p3", "Gamma", "c3", "2024-01-03T00:00:00Z");
const result = qp.listPools({ limit: 1, offset: 1 });
assert.equal(result.total, 3);
assert.equal(result.items.length, 1);
assert.equal(result.items[0].name, "Beta");
});
test("listPools with only offset (no limit) ignores offset", () => {
insertPool("p1", "Alpha", "c1");
insertPool("p2", "Beta", "c2");
// offset without limit — should not add OFFSET clause (was a bug)
const result = qp.listPools({ offset: 1 });
assert.equal(result.total, 2);
assert.equal(result.items.length, 2);
});
test("listPools with zero limit treated as no limit", () => {
insertPool("p1", "Alpha", "c1");
// limit=0 is invalid in SQL — code treats it as "no limit"
const result = qp.listPools({ limit: 0 });
assert.equal(result.total, 1);
assert.equal(result.items.length, 1);
});
// ─────────────────────────────────────────────────────────────────────────────
// getPoolsByGroup — pagination
// ─────────────────────────────────────────────────────────────────────────────
test("getPoolsByGroup with limit returns correct count", () => {
insertPool("p1", "A", "c1");
insertPool("p2", "B", "c2");
const items = qp.getPoolsByGroup("default", 1);
assert.equal(items.length, 1);
});
test("getPoolsByGroup with limit+offset returns correct slice", () => {
insertPool("p1", "Alpha", "c1", "2024-01-01T00:00:00Z");
insertPool("p2", "Beta", "c2", "2024-01-02T00:00:00Z");
insertPool("p3", "Gamma", "c3", "2024-01-03T00:00:00Z");
const items = qp.getPoolsByGroup("default", 1, 2);
assert.equal(items.length, 1);
assert.equal(items[0].name, "Gamma");
});
test("getPoolsByGroup with only offset ignores offset", () => {
insertPool("p1", "Alpha", "c1");
insertPool("p2", "Beta", "c2");
const items = qp.getPoolsByGroup("default", undefined, 1);
assert.equal(items.length, 2);
});
test("getPoolsByGroup with empty group returns []", () => {
const items = qp.getPoolsByGroup("nonexistent");
assert.deepEqual(items, []);
});
// ─────────────────────────────────────────────────────────────────────────────
// batchBuildPools — allocations loaded in batch
// ─────────────────────────────────────────────────────────────────────────────
test("batchBuildPools loads allocations in single query", () => {
const db = getDbInstance();
db.prepare(
"INSERT INTO quota_pools (id, name, group_id, connection_id, created_at) VALUES (?, ?, ?, ?, ?)"
).run("p1", "PoolA", "default", "c1", new Date().toISOString());
db.prepare(
"INSERT INTO quota_allocations (pool_id, api_key_id, weight, cap_value) VALUES (?, ?, ?, ?)"
).run("p1", "ak_test", 1, 100);
const result = qp.listPools();
assert.equal(result.items.length, 1);
assert.equal(result.total, 1);
const pool = result.items[0];
assert.equal(pool.name, "PoolA");
assert.ok(pool.allocations !== undefined);
});