Files
OmniRoute/tests/unit/ui/conversation-tab-separators.test.tsx
Diego Rodrigues de Sa e Souza a5cad5ab2a fix(tests): vitest UI suite back to green (69 fails triaged — WS6.1) (#7127)
test:vitest:ui was advisory/parked with 70 failing tests across 30 files (of
159 total). Triaged by grouping failures by root cause instead of fixing
one-by-one:

- 15 files (use-virtual-list, use-traffic-stream, use-system-proxy-exit-guard,
  use-session-recorder, use-resizable-panels, traffic-inspector-page,
  timing-i18n, stats-tab, session-recorder-bar, same-context-filter,
  historic-session-banner, conversation-tab, conversation-tab-separators,
  cli-tools-no-mitm-tab, agent-bridge-server-card-a11y) were authored against
  node:test but live under tests/unit/ui/*.test.tsx, which vitest.config.ts
  collects but test:unit's glob (only *.test.ts) never does — orphaned. Fixed
  by switching their describe/it/beforeEach imports to "vitest".
- jsdom does not implement window.matchMedia, and several dashboard
  components read it via useTheme() (directly, or transitively through
  ProviderIcon). Added tests/_setup/vitestUiPolyfills.ts (wired into
  vitest.config.ts) with a minimal MediaQueryList polyfill — fixed
  providerCascadeNode, ProviderIcon-icon-url, CliAgentsPage, playground-studio,
  comboLiveStudio, memories-tab, home-topology-hidden, ProxyRegistryManager-tdz.
- playground-build-tab.test.tsx (9 tests) and compressionHub*.test.tsx (2
  tests) asserted against pre-redesign UI: BuildTab now sits behind a 3-step
  BuildWizard (mode picker -> configure -> run), and CompressionHub is a
  Phase-2 thin overview without the old master toggle/mode selector/pipeline
  list. Rewrote the build-tab test to drive the wizard, and removed the two
  compressionHub.test.tsx assertions already superseded by
  compressionHub-active-selector.test.tsx. compressionHub-context-editing.test.tsx
  asserted stale Portuguese copy against a component that deliberately uses
  literal English strings (documented hydration workaround) — aligned to the
  real text.
- search-tools-compare-tab.test.tsx: the D22 4-provider cap documented in
  docs/frameworks/SEARCH_TOOLS_STUDIO.md was never implemented in CompareTab —
  fixed the component (disable extra toggles + cap selectAll + warning
  message) since the test was correct and the component was the bug. Also
  fixed an assertion looking for a <table> that never existed (the results
  panel is a div-based side-by-side layout).
- CliAgentsPage.test.tsx: the agent-tool catalog grew from 6 to 8 (omp, letta
  added) since the test was written — updated the fixture and expected count.
- memories-tab.test.tsx: a call-order-dependent fetch mock
  (mockResolvedValueOnce + fallback) broke once MemoriesTab started firing an
  immediate health check that raced its 300ms-debounced list fetch — switched
  to a URL-keyed mock like the rest of the file.
- home-topology-hidden-4596.test.tsx: useLiveDashboard now runs an async
  handshake fetch before opening the WebSocket — stubbed fetch and awaited it.
- same-context-filter.test.tsx: the filter branch moved from
  useTrafficStream.applyFilter into the extracted, reusable
  matchesTrafficFilter() helper — updated the source-grep target.
- tests/unit/ui/provider-plan-config.test.tsx deleted: it tested
  ProviderPlanConfigClient, which tests/unit/quota-plans-route-retired.test.ts
  proves was deliberately retired (Plans screen removed).

Result: test:vitest:ui 158/158 files, 870/870 tests passing (was 30 failed /
159, 70 failed / 743). test:vitest (MCP/autoCombo) still green at 28/28,
253/253. Not promoted to blocking in this PR per the task — the owner
promotes after reviewing the green suite.
2026-07-14 16:24:19 -03:00

152 lines
5.6 KiB
TypeScript

/**
* Tests for ConversationTab separators — CONTEXT HISTORY / MODEL RESPONSE
* Validates the rendering logic: both sections appear when both request/response have turns;
* only CONTEXT HISTORY appears when response is empty.
*/
import { describe, it } from "vitest";
import assert from "node:assert/strict";
import { normalizeConversation } from "../../../src/mitm/inspector/conversationNormalizer.ts";
import type { InterceptedRequest } from "../../../src/mitm/inspector/types.ts";
function makeRequest(overrides: Partial<InterceptedRequest> = {}): InterceptedRequest {
return {
id: "test-id",
source: "agent-bridge",
timestamp: new Date().toISOString(),
method: "POST",
host: "api.openai.com",
path: "/v1/chat/completions",
requestHeaders: { "content-type": "application/json" },
requestBody: null,
requestSize: 0,
responseHeaders: {},
responseBody: null,
responseSize: 0,
status: 200,
detectedKind: "llm",
...overrides,
};
}
describe("ConversationTab separators rendering logic", () => {
it("shows CONTEXT HISTORY section when request has turns", () => {
const reqBody = JSON.stringify({
model: "gpt-4o",
messages: [
{ role: "system", content: "You are helpful." },
{ role: "user", content: "Hello!" },
],
});
const req = makeRequest({ requestBody: reqBody, responseBody: null });
const result = normalizeConversation(req);
if (result !== null) {
assert.ok(result.request.length > 0, "request section should have turns");
// Context History separator should be rendered (guarded by request.length > 0)
const shouldRenderContextHistory = result.request.length > 0;
assert.equal(shouldRenderContextHistory, true);
}
});
it("shows MODEL RESPONSE section when response has turns", () => {
const reqBody = JSON.stringify({
model: "gpt-4o",
messages: [{ role: "user", content: "Hi" }],
});
const resBody = JSON.stringify({
choices: [
{
message: { role: "assistant", content: "Hello! How can I help?" },
finish_reason: "stop",
},
],
usage: { prompt_tokens: 5, completion_tokens: 8 },
});
const req = makeRequest({ requestBody: reqBody, responseBody: resBody });
const result = normalizeConversation(req);
if (result !== null) {
// Model Response separator should be rendered (guarded by response.length > 0)
const shouldRenderModelResponse = result.response.length > 0;
assert.equal(shouldRenderModelResponse, true);
}
});
it("does NOT render MODEL RESPONSE when response is empty", () => {
const reqBody = JSON.stringify({
model: "gpt-4o",
messages: [{ role: "user", content: "Hi" }],
});
// No response body
const req = makeRequest({ requestBody: reqBody, responseBody: null });
const result = normalizeConversation(req);
if (result !== null) {
// Response section should be empty, so MODEL RESPONSE separator should NOT render
const shouldRenderModelResponse = result.response.length > 0;
assert.equal(shouldRenderModelResponse, false);
// But context history should still render
const shouldRenderContextHistory = result.request.length > 0;
assert.equal(shouldRenderContextHistory, true);
}
});
it("renders both separators when both request and response have turns", () => {
const reqBody = JSON.stringify({
model: "gpt-4o",
messages: [{ role: "user", content: "Hi" }],
});
const resBody = JSON.stringify({
choices: [
{
message: { role: "assistant", content: "Hello!" },
finish_reason: "stop",
},
],
});
const req = makeRequest({ requestBody: reqBody, responseBody: resBody });
const result = normalizeConversation(req);
if (result !== null) {
const contextHistoryVisible = result.request.length > 0;
const modelResponseVisible = result.response.length > 0;
assert.equal(contextHistoryVisible, true, "CONTEXT HISTORY should be visible");
assert.equal(modelResponseVisible, true, "MODEL RESPONSE should be visible");
}
});
it("request and response turns are keyed separately (req-N vs res-N)", () => {
// Keys used: `req-${i}` for request turns, `res-${i}` for response turns
const reqKeys = ["req-0", "req-1", "req-2"];
const resKeys = ["res-0", "res-1"];
// Verify no overlap
const allKeys = [...reqKeys, ...resKeys];
const uniqueKeys = new Set(allKeys);
assert.equal(uniqueKeys.size, allKeys.length, "all keys should be unique");
});
it("allTurns still accounts for correct total across both sections", () => {
const request = [
{ role: "user" as const, content: "Hi", contentType: "text" as const },
];
const response = [
{ role: "assistant" as const, content: "Hello!", contentType: "text" as const },
];
// Before: allTurns = [...request, ...response]
// After: both rendered in separate sections
const totalTurns = request.length + response.length;
assert.equal(totalTurns, 2);
});
it("conversationNotAvailable key resolves when body is null (normalizeConversation returns null)", () => {
// When requestBody is null and responseBody is null, normalizeConversation returns null.
// The ConversationTab renders t("conversationNotAvailable") in that case.
const req = makeRequest({ requestBody: null, responseBody: null });
const result = normalizeConversation(req);
// Must return null so the component falls through to the conversationNotAvailable branch.
assert.equal(result, null, "normalizeConversation must return null for non-LLM / null body");
});
});