Files
OmniRoute/tests/unit/ui/use-system-proxy-exit-guard.test.tsx
Diego Rodrigues de Sa e Souza a5cad5ab2a fix(tests): vitest UI suite back to green (69 fails triaged — WS6.1) (#7127)
test:vitest:ui was advisory/parked with 70 failing tests across 30 files (of
159 total). Triaged by grouping failures by root cause instead of fixing
one-by-one:

- 15 files (use-virtual-list, use-traffic-stream, use-system-proxy-exit-guard,
  use-session-recorder, use-resizable-panels, traffic-inspector-page,
  timing-i18n, stats-tab, session-recorder-bar, same-context-filter,
  historic-session-banner, conversation-tab, conversation-tab-separators,
  cli-tools-no-mitm-tab, agent-bridge-server-card-a11y) were authored against
  node:test but live under tests/unit/ui/*.test.tsx, which vitest.config.ts
  collects but test:unit's glob (only *.test.ts) never does — orphaned. Fixed
  by switching their describe/it/beforeEach imports to "vitest".
- jsdom does not implement window.matchMedia, and several dashboard
  components read it via useTheme() (directly, or transitively through
  ProviderIcon). Added tests/_setup/vitestUiPolyfills.ts (wired into
  vitest.config.ts) with a minimal MediaQueryList polyfill — fixed
  providerCascadeNode, ProviderIcon-icon-url, CliAgentsPage, playground-studio,
  comboLiveStudio, memories-tab, home-topology-hidden, ProxyRegistryManager-tdz.
- playground-build-tab.test.tsx (9 tests) and compressionHub*.test.tsx (2
  tests) asserted against pre-redesign UI: BuildTab now sits behind a 3-step
  BuildWizard (mode picker -> configure -> run), and CompressionHub is a
  Phase-2 thin overview without the old master toggle/mode selector/pipeline
  list. Rewrote the build-tab test to drive the wizard, and removed the two
  compressionHub.test.tsx assertions already superseded by
  compressionHub-active-selector.test.tsx. compressionHub-context-editing.test.tsx
  asserted stale Portuguese copy against a component that deliberately uses
  literal English strings (documented hydration workaround) — aligned to the
  real text.
- search-tools-compare-tab.test.tsx: the D22 4-provider cap documented in
  docs/frameworks/SEARCH_TOOLS_STUDIO.md was never implemented in CompareTab —
  fixed the component (disable extra toggles + cap selectAll + warning
  message) since the test was correct and the component was the bug. Also
  fixed an assertion looking for a <table> that never existed (the results
  panel is a div-based side-by-side layout).
- CliAgentsPage.test.tsx: the agent-tool catalog grew from 6 to 8 (omp, letta
  added) since the test was written — updated the fixture and expected count.
- memories-tab.test.tsx: a call-order-dependent fetch mock
  (mockResolvedValueOnce + fallback) broke once MemoriesTab started firing an
  immediate health check that raced its 300ms-debounced list fetch — switched
  to a URL-keyed mock like the rest of the file.
- home-topology-hidden-4596.test.tsx: useLiveDashboard now runs an async
  handshake fetch before opening the WebSocket — stubbed fetch and awaited it.
- same-context-filter.test.tsx: the filter branch moved from
  useTrafficStream.applyFilter into the extracted, reusable
  matchesTrafficFilter() helper — updated the source-grep target.
- tests/unit/ui/provider-plan-config.test.tsx deleted: it tested
  ProviderPlanConfigClient, which tests/unit/quota-plans-route-retired.test.ts
  proves was deliberately retired (Plans screen removed).

Result: test:vitest:ui 158/158 files, 870/870 tests passing (was 30 failed /
159, 70 failed / 743). test:vitest (MCP/autoCombo) still green at 28/28,
253/253. Not promoted to blocking in this PR per the task — the owner
promotes after reviewing the green suite.
2026-07-14 16:24:19 -03:00

168 lines
5.6 KiB
TypeScript

/**
* Tests for useSystemProxyExitGuard — beforeunload listener + keepalive fetch revert.
*
* Strategy: test the hook logic directly without React — we exercise the same
* branches as the hook by simulating mount/unmount via the cleanup pattern.
* This matches how use-traffic-stream.test.tsx tests hook logic (pure logic,
* no React renderer needed).
*/
import { describe, it, beforeEach } from "vitest";
import assert from "node:assert/strict";
// ---------------------------------------------------------------------------
// Minimal beforeunload event simulation
// ---------------------------------------------------------------------------
type BeforeUnloadListener = (e: { preventDefault: () => void; returnValue: string }) => void;
let registeredListeners: Array<{ type: string; fn: BeforeUnloadListener }> = [];
let fetchCalls: Array<{ url: string; init: RequestInit }> = [];
const mockWindow = {
addEventListener(type: string, fn: BeforeUnloadListener) {
registeredListeners.push({ type, fn });
},
removeEventListener(type: string, fn: BeforeUnloadListener) {
registeredListeners = registeredListeners.filter((l) => l.type !== type || l.fn !== fn);
},
};
const mockFetch = (url: string, init: RequestInit) => {
fetchCalls.push({ url, init });
return Promise.resolve(new Response("{}"));
};
// ---------------------------------------------------------------------------
// Simulate the hook logic (mirrors useSystemProxyExitGuard implementation)
// to make it testable without jsdom / React.
// ---------------------------------------------------------------------------
interface GuardOpts {
applied: boolean;
endpoint?: string;
}
function mountGuard(opts: GuardOpts): () => void {
let appliedRef = opts.applied;
const endpoint = opts.endpoint ?? "/api/tools/traffic-inspector/capture-modes/system-proxy";
const body = JSON.stringify({ action: "revert" });
const revertSystemProxy = () => {
void mockFetch(endpoint, {
method: "POST",
headers: { "Content-Type": "application/json" },
body,
keepalive: true,
}).catch(() => {});
};
const beforeUnload: BeforeUnloadListener = (e) => {
if (!appliedRef) return;
revertSystemProxy();
e.preventDefault();
e.returnValue = "System-wide proxy still active — leave page anyway?";
};
mockWindow.addEventListener("beforeunload", beforeUnload);
// Return cleanup (simulates useEffect cleanup / unmount)
const cleanup = () => {
mockWindow.removeEventListener("beforeunload", beforeUnload);
if (appliedRef) {
revertSystemProxy();
}
};
// Expose a way to update appliedRef (simulates re-render with new prop)
(cleanup as unknown as { setApplied: (v: boolean) => void }).setApplied = (v: boolean) => {
appliedRef = v;
};
return cleanup;
}
// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------
describe("useSystemProxyExitGuard hook logic", () => {
beforeEach(() => {
registeredListeners = [];
fetchCalls = [];
});
it("adds beforeunload listener on mount", () => {
const cleanup = mountGuard({ applied: false });
assert.equal(registeredListeners.length, 1);
assert.equal(registeredListeners[0].type, "beforeunload");
cleanup();
});
it("fires keepalive fetch with correct endpoint and body when applied=true on beforeunload", () => {
const endpoint = "/api/tools/traffic-inspector/capture-modes/system-proxy";
const cleanup = mountGuard({ applied: true, endpoint });
// Simulate browser firing beforeunload
const fakeEvent = { preventDefault: () => {}, returnValue: "" };
registeredListeners[0].fn(fakeEvent);
assert.equal(fetchCalls.length, 1);
assert.equal(fetchCalls[0].url, endpoint);
assert.equal(fetchCalls[0].init.method, "POST");
assert.equal(fetchCalls[0].init.body, JSON.stringify({ action: "revert" }));
assert.equal(fetchCalls[0].init.keepalive, true);
cleanup();
});
it("does NOT fire keepalive fetch on beforeunload when applied=false", () => {
const cleanup = mountGuard({ applied: false });
const fakeEvent = { preventDefault: () => {}, returnValue: "" };
registeredListeners[0].fn(fakeEvent);
assert.equal(fetchCalls.length, 0);
cleanup();
});
it("removes beforeunload listener on unmount", () => {
const cleanup = mountGuard({ applied: false });
assert.equal(registeredListeners.length, 1);
cleanup();
assert.equal(registeredListeners.length, 0);
});
it("fires keepalive fetch on unmount when applied=true (SPA navigation revert)", () => {
const cleanup = mountGuard({ applied: true });
// No beforeunload triggered — just unmount (SPA navigation)
cleanup();
assert.equal(fetchCalls.length, 1);
assert.equal(fetchCalls[0].url, "/api/tools/traffic-inspector/capture-modes/system-proxy");
});
it("does NOT fire keepalive fetch on unmount when applied=false", () => {
const cleanup = mountGuard({ applied: false });
cleanup();
assert.equal(fetchCalls.length, 0);
});
it("uses custom endpoint when provided", () => {
const customEndpoint = "/api/custom/system-proxy";
const cleanup = mountGuard({ applied: true, endpoint: customEndpoint });
cleanup();
assert.equal(fetchCalls[0].url, customEndpoint);
});
it("sets returnValue on beforeunload event when applied=true", () => {
const cleanup = mountGuard({ applied: true });
const fakeEvent = { preventDefault: () => {}, returnValue: "" };
registeredListeners[0].fn(fakeEvent);
assert.equal(fakeEvent.returnValue, "System-wide proxy still active — leave page anyway?");
cleanup();
});
});