mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-03 05:45:04 +03:00
test:vitest:ui was advisory/parked with 70 failing tests across 30 files (of 159 total). Triaged by grouping failures by root cause instead of fixing one-by-one: - 15 files (use-virtual-list, use-traffic-stream, use-system-proxy-exit-guard, use-session-recorder, use-resizable-panels, traffic-inspector-page, timing-i18n, stats-tab, session-recorder-bar, same-context-filter, historic-session-banner, conversation-tab, conversation-tab-separators, cli-tools-no-mitm-tab, agent-bridge-server-card-a11y) were authored against node:test but live under tests/unit/ui/*.test.tsx, which vitest.config.ts collects but test:unit's glob (only *.test.ts) never does — orphaned. Fixed by switching their describe/it/beforeEach imports to "vitest". - jsdom does not implement window.matchMedia, and several dashboard components read it via useTheme() (directly, or transitively through ProviderIcon). Added tests/_setup/vitestUiPolyfills.ts (wired into vitest.config.ts) with a minimal MediaQueryList polyfill — fixed providerCascadeNode, ProviderIcon-icon-url, CliAgentsPage, playground-studio, comboLiveStudio, memories-tab, home-topology-hidden, ProxyRegistryManager-tdz. - playground-build-tab.test.tsx (9 tests) and compressionHub*.test.tsx (2 tests) asserted against pre-redesign UI: BuildTab now sits behind a 3-step BuildWizard (mode picker -> configure -> run), and CompressionHub is a Phase-2 thin overview without the old master toggle/mode selector/pipeline list. Rewrote the build-tab test to drive the wizard, and removed the two compressionHub.test.tsx assertions already superseded by compressionHub-active-selector.test.tsx. compressionHub-context-editing.test.tsx asserted stale Portuguese copy against a component that deliberately uses literal English strings (documented hydration workaround) — aligned to the real text. - search-tools-compare-tab.test.tsx: the D22 4-provider cap documented in docs/frameworks/SEARCH_TOOLS_STUDIO.md was never implemented in CompareTab — fixed the component (disable extra toggles + cap selectAll + warning message) since the test was correct and the component was the bug. Also fixed an assertion looking for a <table> that never existed (the results panel is a div-based side-by-side layout). - CliAgentsPage.test.tsx: the agent-tool catalog grew from 6 to 8 (omp, letta added) since the test was written — updated the fixture and expected count. - memories-tab.test.tsx: a call-order-dependent fetch mock (mockResolvedValueOnce + fallback) broke once MemoriesTab started firing an immediate health check that raced its 300ms-debounced list fetch — switched to a URL-keyed mock like the rest of the file. - home-topology-hidden-4596.test.tsx: useLiveDashboard now runs an async handshake fetch before opening the WebSocket — stubbed fetch and awaited it. - same-context-filter.test.tsx: the filter branch moved from useTrafficStream.applyFilter into the extracted, reusable matchesTrafficFilter() helper — updated the source-grep target. - tests/unit/ui/provider-plan-config.test.tsx deleted: it tested ProviderPlanConfigClient, which tests/unit/quota-plans-route-retired.test.ts proves was deliberately retired (Plans screen removed). Result: test:vitest:ui 158/158 files, 870/870 tests passing (was 30 failed / 159, 70 failed / 743). test:vitest (MCP/autoCombo) still green at 28/28, 253/253. Not promoted to blocking in this PR per the task — the owner promotes after reviewing the green suite.
126 lines
4.0 KiB
TypeScript
126 lines
4.0 KiB
TypeScript
/**
|
|
* Tests for useVirtualList — virtualizes 1000+ items without rendering all
|
|
*/
|
|
import { describe, it } from "vitest";
|
|
import assert from "node:assert/strict";
|
|
|
|
const ESTIMATED_ROW_HEIGHT = 48;
|
|
const OVERSCAN = 5;
|
|
|
|
function computeVirtualItems(
|
|
items: string[],
|
|
heights: Map<number, number>,
|
|
scrollTop: number,
|
|
containerHeight: number
|
|
) {
|
|
// Compute cumulative offsets
|
|
const offsets: number[] = [];
|
|
let total = 0;
|
|
for (let i = 0; i < items.length; i++) {
|
|
offsets.push(total);
|
|
total += heights.get(i) ?? ESTIMATED_ROW_HEIGHT;
|
|
}
|
|
|
|
// Find visible range
|
|
let startIdx = 0;
|
|
let endIdx = items.length - 1;
|
|
|
|
for (let i = 0; i < offsets.length; i++) {
|
|
if (offsets[i] + (heights.get(i) ?? ESTIMATED_ROW_HEIGHT) < scrollTop) {
|
|
startIdx = i + 1;
|
|
} else {
|
|
break;
|
|
}
|
|
}
|
|
for (let i = startIdx; i < offsets.length; i++) {
|
|
if (offsets[i] > scrollTop + containerHeight) {
|
|
endIdx = i - 1;
|
|
break;
|
|
}
|
|
}
|
|
|
|
startIdx = Math.max(0, startIdx - OVERSCAN);
|
|
endIdx = Math.min(items.length - 1, endIdx + OVERSCAN);
|
|
|
|
const virtualItems = [];
|
|
for (let i = startIdx; i <= endIdx; i++) {
|
|
virtualItems.push({ index: i, item: items[i], top: offsets[i] ?? 0 });
|
|
}
|
|
|
|
return { virtualItems, totalHeight: total };
|
|
}
|
|
|
|
describe("useVirtualList logic", () => {
|
|
it("renders only visible + overscan items from 1000-item list", () => {
|
|
const items = Array.from({ length: 1000 }, (_, i) => `req-${i}`);
|
|
const heights = new Map<number, number>();
|
|
const scrollTop = 0;
|
|
const containerHeight = 600;
|
|
|
|
const { virtualItems, totalHeight } = computeVirtualItems(
|
|
items,
|
|
heights,
|
|
scrollTop,
|
|
containerHeight
|
|
);
|
|
|
|
// Total height is all items at estimated height
|
|
assert.equal(totalHeight, 1000 * ESTIMATED_ROW_HEIGHT);
|
|
|
|
// Should render far fewer than 1000 items
|
|
const expectedVisible = Math.ceil(containerHeight / ESTIMATED_ROW_HEIGHT) + OVERSCAN;
|
|
assert.ok(
|
|
virtualItems.length <= expectedVisible + OVERSCAN + 2,
|
|
`Expected ~${expectedVisible} visible items, got ${virtualItems.length}`
|
|
);
|
|
assert.ok(virtualItems.length < 100, `Should not render all 1000 items, got ${virtualItems.length}`);
|
|
});
|
|
|
|
it("renders items starting from correct offset when scrolled", () => {
|
|
const items = Array.from({ length: 1000 }, (_, i) => `req-${i}`);
|
|
const heights = new Map<number, number>();
|
|
const scrollTop = 1000; // scrolled 1000px
|
|
const containerHeight = 600;
|
|
|
|
const { virtualItems } = computeVirtualItems(items, heights, scrollTop, containerHeight);
|
|
|
|
// At 48px per row, scrollTop=1000 means first visible is around row 20
|
|
const firstIndex = virtualItems[0]?.index ?? 0;
|
|
const expectedFirstVisible = Math.floor(scrollTop / ESTIMATED_ROW_HEIGHT) - OVERSCAN;
|
|
assert.ok(
|
|
firstIndex >= Math.max(0, expectedFirstVisible),
|
|
`Expected first index >= ${Math.max(0, expectedFirstVisible)}, got ${firstIndex}`
|
|
);
|
|
assert.ok(firstIndex < 30, `Expected first index < 30 (scrolled to row ~20), got ${firstIndex}`);
|
|
});
|
|
|
|
it("uses custom heights when provided", () => {
|
|
const items = Array.from({ length: 10 }, (_, i) => `req-${i}`);
|
|
const heights = new Map<number, number>([[0, 100], [1, 100], [2, 100]]);
|
|
const scrollTop = 0;
|
|
const containerHeight = 150;
|
|
|
|
const { virtualItems, totalHeight } = computeVirtualItems(
|
|
items,
|
|
heights,
|
|
scrollTop,
|
|
containerHeight
|
|
);
|
|
|
|
// First 3 rows have height 100 each, rest default 48
|
|
const expected = 100 + 100 + 100 + 7 * ESTIMATED_ROW_HEIGHT;
|
|
assert.equal(totalHeight, expected);
|
|
|
|
// Should only render what's visible in 150px (2 full custom rows + overscan)
|
|
assert.ok(virtualItems.length <= 10);
|
|
});
|
|
|
|
it("totalHeight equals sum of all item heights", () => {
|
|
const N = 500;
|
|
const items = Array.from({ length: N }, (_, i) => `req-${i}`);
|
|
const heights = new Map<number, number>();
|
|
const { totalHeight } = computeVirtualItems(items, heights, 0, 600);
|
|
assert.equal(totalHeight, N * ESTIMATED_ROW_HEIGHT);
|
|
});
|
|
});
|