mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 11:22:15 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
88 lines
3.5 KiB
TypeScript
88 lines
3.5 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-bare-routing-fallback-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const { getModelInfoCore } = await import("../../open-sse/services/model.ts");
|
|
|
|
// #FIX: end-to-end precedence checks for bare model routing. These guard
|
|
// the contract that:
|
|
// - Bare Codex-default model ids (gpt-5.6-sol, gpt-5.5, etc.) route to
|
|
// `codex` ahead of any other provider that also catalogs them — bounded by
|
|
// #9447 to installs where a codex connection is actually ACTIVE, so an
|
|
// OpenAI-only install is not handed a provider it has no credentials for.
|
|
// Ids that only codex catalogs (the tier variants) need no connection:
|
|
// there is no alternative provider to preempt.
|
|
// - Bare model ids shared between providers (e.g. claude-opus-5 across
|
|
// anthropic/claude/github/agentrouter/etc.) never silently route to a
|
|
// provider whose static registry does NOT actually catalog them (the
|
|
// kiro-synced-catalog bug).
|
|
// - Explicit `provider/model` prefixes always win over the bare inference.
|
|
|
|
test.before(async () => {
|
|
await providersDb.createProviderConnection({
|
|
provider: "codex",
|
|
authType: "oauth",
|
|
email: "codex@example.com",
|
|
providerSpecificData: { workspaceId: "ws-routing-fallback" },
|
|
});
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
|
});
|
|
|
|
test("bare gpt-5.6-sol routes to codex (precedence via CODEX_NATIVE_UNPREFIXED_MODELS)", async () => {
|
|
const info = await getModelInfoCore("gpt-5.6-sol", null);
|
|
assert.equal(
|
|
info.provider,
|
|
"codex",
|
|
"bare gpt-5.6-sol must route to codex — the Codex CLI default"
|
|
);
|
|
});
|
|
|
|
test("bare gpt-5.5 routes to codex", async () => {
|
|
const info = await getModelInfoCore("gpt-5.5", null);
|
|
assert.equal(info.provider, "codex");
|
|
});
|
|
|
|
test("bare gpt-5.6-sol-xhigh (a tier id) routes to codex", async () => {
|
|
const info = await getModelInfoCore("gpt-5.6-sol-xhigh", null);
|
|
assert.equal(info.provider, "codex");
|
|
});
|
|
|
|
test("explicit prefix overrides bare precedence (agentrouter/gpt-5.6-sol)", async () => {
|
|
const info = await getModelInfoCore("agentrouter/gpt-5.6-sol", null);
|
|
assert.equal(info.provider, "agentrouter");
|
|
});
|
|
|
|
test("explicit prefix overrides bare precedence (openai/gpt-5.6-sol)", async () => {
|
|
const info = await getModelInfoCore("openai/gpt-5.6-sol", null);
|
|
assert.equal(info.provider, "openai");
|
|
});
|
|
|
|
test("bare claude-opus-5 never resolves to kiro (synced-catalog validation)", async () => {
|
|
// The bug: a kiro connection had claude-opus-5 in its synced /v1/models
|
|
// cache (likely from a brief upstream quirk). The bare-routing path
|
|
// accepted it as a candidate and routed traffic there, which then 404'd
|
|
// because kiro's static registry never cataloged claude-opus-5.
|
|
// The fix: validated synced candidates against the static registry.
|
|
const info = await getModelInfoCore("claude-opus-5", null);
|
|
assert.notEqual(
|
|
info.provider,
|
|
"kiro",
|
|
`kiro must NOT win bare claude-opus-5 routing — it does not catalog the model`
|
|
);
|
|
});
|
|
|
|
test("bare claude-opus-4-8 also never resolves to kiro (same fix must apply to all shared models)", async () => {
|
|
const info = await getModelInfoCore("claude-opus-4-8", null);
|
|
assert.notEqual(info.provider, "kiro");
|
|
}); |