Files
OmniRoute/tests/unit/lib/warmupScheduler/circuitBreakerFactory.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

121 lines
4.4 KiB
TypeScript

/**
* Tests for getCircuitBreakerStore() factory routing:
* - REDIS_URL set + reachable → RedisCircuitBreakerStore
* - REDIS_URL set + unreachable → SqliteCircuitBreakerStore (fallback)
* - REDIS_URL unset → SqliteCircuitBreakerStore
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import net from "node:net";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-warmup-factory-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.NODE_ENV = "test";
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
const core = await import("../../../../src/lib/db/core.ts");
async function resetDb() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetDb();
delete process.env.REDIS_URL;
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
});
test("REDIS_URL unset → SqliteCircuitBreakerStore", async () => {
const { getCircuitBreakerStore, __resetCircuitBreakerFactory } =
await import("../../../../src/lib/warmupScheduler/circuitBreakerFactory.ts");
__resetCircuitBreakerFactory();
delete process.env.REDIS_URL;
const store = await getCircuitBreakerStore();
assert.ok(store.constructor.name.includes("Sqlite"), `got ${store.constructor.name}`);
});
/**
* A Redis that answers the handshake and then dies on the first real command.
* Enough RESP to get ioredis to `connected`, which is the state the factory
* caches -- an unreachable port only exercises the connect-time fallback, not
* the far more likely case of Redis going away after we already cached it.
*/
function startFlakyRedis(): Promise<{ port: number; close: () => void }> {
return new Promise((resolve) => {
const server = net.createServer((socket) => {
socket.on("data", (buf) => {
const cmd = buf.toString().toLowerCase();
if (cmd.includes("hgetall") || cmd.includes("hset") || cmd.includes("hget")) {
socket.destroy(); // the outage: connection drops mid-command
return;
}
if (cmd.includes("info")) {
const body = "redis_version:7.0.0\r\n";
socket.write(`$${body.length}\r\n${body}\r\n`);
return;
}
socket.write("+PONG\r\n");
});
socket.on("error", () => {});
});
server.listen(0, "127.0.0.1", () => {
const { port } = server.address() as { port: number };
resolve({ port, close: () => server.close() });
});
});
}
test("a Redis failure after caching drops the cached store instead of serving it forever", async () => {
const { getCircuitBreakerStore, __resetCircuitBreakerFactory } =
await import("../../../../src/lib/warmupScheduler/circuitBreakerFactory.ts");
const redis = await startFlakyRedis();
try {
__resetCircuitBreakerFactory();
process.env.REDIS_URL = `redis://127.0.0.1:${redis.port}`;
const first = await getCircuitBreakerStore();
assert.ok(
first.constructor.name.includes("Redis"),
`handshake should yield a Redis-backed store, got ${first.constructor.name}`
);
// The outage. The call that hits it still fails -- that run is lost.
await assert.rejects(() => first.get("conn-1"));
// The point of the fix: the next call must NOT hand back the dead client.
process.env.REDIS_URL = "redis://127.0.0.1:1"; // Redis is gone now
const second = await getCircuitBreakerStore();
assert.ok(
second.constructor.name.includes("Sqlite"),
`expected re-probe to fall back to Sqlite, got ${second.constructor.name}`
);
} finally {
delete process.env.REDIS_URL;
redis.close();
__resetCircuitBreakerFactory();
}
});
test("REDIS_URL set + unreachable → falls back to SqliteCircuitBreakerStore", async () => {
const { getCircuitBreakerStore, __resetCircuitBreakerFactory } =
await import("../../../../src/lib/warmupScheduler/circuitBreakerFactory.ts");
__resetCircuitBreakerFactory();
process.env.REDIS_URL = "redis://127.0.0.1:1"; // non-listening port → connect timeout
const store = await getCircuitBreakerStore();
assert.ok(
store.constructor.name.includes("Sqlite"),
`expected Sqlite fallback, got ${store.constructor.name}`
);
delete process.env.REDIS_URL;
});