mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-18 04:42:30 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
59 lines
2.9 KiB
TypeScript
59 lines
2.9 KiB
TypeScript
// #5420 — "Import Models" must be hidden for tool-only (search/fetch) providers,
|
|
// including ones whose id does NOT end in "-search" (e.g. firecrawl → webFetch),
|
|
// while staying visible for LLM and media providers that DO list models.
|
|
import { strict as assert } from "node:assert";
|
|
import { describe, it } from "node:test";
|
|
import {
|
|
providerLacksModelListing,
|
|
providerUsesCuratedModelsOnly,
|
|
providerUsesExclusiveSyncedListing,
|
|
} from "@/lib/providers/modelListingCapability";
|
|
|
|
describe("providerLacksModelListing (#5420)", () => {
|
|
it("hides model listing for -search suffixed providers regardless of kinds", () => {
|
|
assert.equal(providerLacksModelListing("brave-search", []), true);
|
|
assert.equal(providerLacksModelListing("brave-search", ["webSearch"]), true);
|
|
assert.equal(providerLacksModelListing("brave-search", ["llm"]), true);
|
|
});
|
|
|
|
it("hides model listing for tool-only providers without the -search suffix", () => {
|
|
assert.equal(providerLacksModelListing("firecrawl", ["webFetch"]), true);
|
|
assert.equal(providerLacksModelListing("x", ["webSearch"]), true);
|
|
assert.equal(providerLacksModelListing("y", ["webSearch", "webFetch"]), true);
|
|
});
|
|
|
|
it("keeps model listing for LLM and media providers", () => {
|
|
assert.equal(providerLacksModelListing("openai", []), false);
|
|
assert.equal(providerLacksModelListing("openai", ["llm"]), false);
|
|
assert.equal(providerLacksModelListing("falai", ["image"]), false);
|
|
assert.equal(providerLacksModelListing("x", ["webSearch", "llm"]), false);
|
|
assert.equal(providerLacksModelListing("z", ["embedding"]), false);
|
|
});
|
|
|
|
it("keeps curated web providers visible while disabling remote model import", () => {
|
|
assert.equal(providerLacksModelListing("kimi-web", ["llm"]), false);
|
|
assert.equal(providerLacksModelListing("zai-web", ["llm"]), false);
|
|
assert.equal(providerLacksModelListing("chatgpt-web", ["llm"]), false);
|
|
assert.equal(providerUsesCuratedModelsOnly("kimi-web"), true);
|
|
assert.equal(providerUsesCuratedModelsOnly("zai-web"), true);
|
|
assert.equal(providerUsesCuratedModelsOnly("chatgpt-web"), true);
|
|
assert.equal(providerUsesCuratedModelsOnly("qwen-cloud"), false);
|
|
assert.equal(providerUsesCuratedModelsOnly("kimi-coding"), false);
|
|
});
|
|
});
|
|
|
|
describe("providerUsesExclusiveSyncedListing", () => {
|
|
it("is true only for Cursor (id or alias)", () => {
|
|
assert.equal(providerUsesExclusiveSyncedListing("cursor"), true);
|
|
assert.equal(providerUsesExclusiveSyncedListing("cu"), true);
|
|
assert.equal(providerUsesExclusiveSyncedListing("Cursor"), true);
|
|
});
|
|
|
|
it("is false for other providers including authoritative live-catalog ones", () => {
|
|
assert.equal(providerUsesExclusiveSyncedListing("github"), false);
|
|
assert.equal(providerUsesExclusiveSyncedListing("command-code"), false);
|
|
assert.equal(providerUsesExclusiveSyncedListing("openai"), false);
|
|
assert.equal(providerUsesExclusiveSyncedListing(""), false);
|
|
});
|
|
});
|